Test Setup Failed
Push — master ( 88ad80...dd7f24 )
by Mohamed
13:08 queued 06:21
created
app/Http/Controllers/BulkPromotion.php 1 patch
Spacing   +18 added lines, -18 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
                 if (!empty($isAvailableforPromotion)) {
65 65
                     $this->process($institutionGrade, $nextGrade, $params);
66 66
                     DB::commit();
67
-                } else {
67
+                }else {
68 68
                     DB::rollBack();
69 69
                 }
70 70
                 //leave school levers
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
                 //     $this->process($institutionGrade, $nextGrade, $params);
73 73
                 // }
74 74
             }
75
-        } catch (\Exception $e) {
75
+        }catch (\Exception $e) {
76 76
             DB::rollBack();
77 77
         }
78 78
     }
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
105 105
 
106 106
             $output = new \Symfony\Component\Console\Output\ConsoleOutput();
107 107
             $output->writeln('##########################################################################################################################');
108
-            $output->writeln('Promoting from ' . $institutionGrade['name'] . ' IN ' . $institution->name . ' No of Students: ' . count($studentListToPromote));
108
+            $output->writeln('Promoting from '.$institutionGrade['name'].' IN '.$institution->name.' No of Students: '.count($studentListToPromote));
109 109
 
110 110
 
111 111
             if (!empty($parallelClasses)) {
@@ -120,7 +120,7 @@  discard block
 block discarded – undo
120 120
                 array_walk($parallelClasses, array($this, 'updateStudentCount'));
121 121
                 DB::commit();
122 122
             }
123
-        } catch (\Exception $e) {
123
+        }catch (\Exception $e) {
124 124
             DB::rollBack();
125 125
             Log::error($e->getMessage());
126 126
         }
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
155 155
         $previousAcademicPeriod = $params['previousAcademicPeriod'];
156 156
         $nextGradeObj = null;
157 157
         $currentGradeObj = $this->instituion_grade->getParallelClasses($institutionGrade['id'], $institutionGrade['institution_id'], $institutionGrade['education_grade_id'], $previousAcademicPeriod->id);
158
-        if ($nextGrade !== []  && !is_null($nextGrade)) {
158
+        if ($nextGrade !== [] && !is_null($nextGrade)) {
159 159
             $nextGradeObj = $this->instituion_grade->getParallelClasses($institutionGrade['id'], $institutionGrade['institution_id'], $nextGrade->id, $academicPeriod->id);
160 160
         }
161 161
 
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
                 // promote parallel classes
165 165
                 $this->promotion($institutionGrade, $nextGrade, $previousAcademicPeriod, $academicPeriod, $nextGradeObj->toArray(), 1);
166 166
                 return 1;
167
-            } elseif (($nextGradeObj->count() > 1) && ($nextGradeObj->count() !==  $currentGradeObj->count())) {
167
+            } elseif (($nextGradeObj->count() > 1) && ($nextGradeObj->count() !== $currentGradeObj->count())) {
168 168
                 // promote pool promotion
169 169
                 $this->promotion($institutionGrade, $nextGrade, $previousAcademicPeriod, $academicPeriod, [], 1);
170 170
                 return 2;
@@ -172,12 +172,12 @@  discard block
 block discarded – undo
172 172
                 // Promote matching class name with previous class
173 173
                 $this->promotion($institutionGrade, $nextGrade, $previousAcademicPeriod, $academicPeriod, $nextGradeObj->toArray(), 1);
174 174
                 return 1;
175
-            } else {
175
+            }else {
176 176
                 // default pool promotion
177 177
                 $this->promotion($institutionGrade, $nextGrade, $previousAcademicPeriod, $academicPeriod, [], 1);
178 178
                 return 2;
179 179
             }
180
-        } else {
180
+        }else {
181 181
             // default pool promotion
182 182
             $this->promotion($institutionGrade, $nextGrade, $previousAcademicPeriod, $academicPeriod, [], 3);
183 183
             return 2;
@@ -213,10 +213,10 @@  discard block
 block discarded – undo
213 213
         ];
214 214
 
215 215
         try {
216
-            Institution_student::where('id', (string)$student['id'])->update($studentData);
216
+            Institution_student::where('id', (string) $student['id'])->update($studentData);
217 217
             $output = new \Symfony\Component\Console\Output\ConsoleOutput();
218
-            $output->writeln('----------------- ' . $student['admission_id'] . ' to ' . $studentData['education_grade_id']);
219
-        } catch (\Exception $e) {
218
+            $output->writeln('----------------- '.$student['admission_id'].' to '.$studentData['education_grade_id']);
219
+        }catch (\Exception $e) {
220 220
             Log::error($e->getMessage());
221 221
         }
222 222
     }
@@ -236,7 +236,7 @@  discard block
 block discarded – undo
236 236
         $studentClass = $this->institution_class_students->getStudentNewClass($student);
237 237
         if (!is_null($studentClass)) {
238 238
             return  array_search(str_replace($educationGrade['name'], $nextGrade->name, $studentClass->name), array_column($classes, 'name'));
239
-        } else {
239
+        }else {
240 240
             return false;
241 241
         }
242 242
     }
@@ -258,7 +258,7 @@  discard block
 block discarded – undo
258 258
         $class = null;
259 259
         if (count($classes) == 1) {
260 260
             $class = $classes[0];
261
-        } else {
261
+        }else {
262 262
             $class = $this->getStudentClass($student, $educationGrade, $nextGrade, $classes);
263 263
             if (is_numeric($class)) {
264 264
                 $class = $classes[$class];
@@ -290,13 +290,13 @@  discard block
 block discarded – undo
290 290
                     //     array_walk($allInsSubjects,array($this,'updateSubjectCount'));
291 291
                     // }
292 292
                     $output = new \Symfony\Component\Console\Output\ConsoleOutput();
293
-                    $output->writeln('----------------- ' . $student['student_id'] . 'to ' . $class['name']);
294
-                } else {
295
-                    $this->institution_class_students->where('id', (string)$student['id'])->update($studentObj);
293
+                    $output->writeln('----------------- '.$student['student_id'].'to '.$class['name']);
294
+                }else {
295
+                    $this->institution_class_students->where('id', (string) $student['id'])->update($studentObj);
296 296
                     $output = new \Symfony\Component\Console\Output\ConsoleOutput();
297
-                    $output->writeln('----------------- ' . $student['student_id'] . 'to ' . $class['name']);
297
+                    $output->writeln('----------------- '.$student['student_id'].'to '.$class['name']);
298 298
                 }
299
-            } catch (\Exception $e) {
299
+            }catch (\Exception $e) {
300 300
                 Log::error($e->getMessage());
301 301
             }
302 302
         }
Please login to merge, or discard this patch.
app/Models/Institution_grade.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -70,10 +70,10 @@  discard block
 block discarded – undo
70 70
     public function getParallelClasses($id, $institutionId, $educationGradeId, $academicPeriodId)
71 71
     {
72 72
         $data = self::find($id)->select('institution_grades.id as insGrade', 'institution_classes.id', 'institution_classes.name', 'institution_grades.education_grade_id')
73
-            ->join('institution_classes', function ($join) use ($educationGradeId, $academicPeriodId) {
73
+            ->join('institution_classes', function($join) use ($educationGradeId, $academicPeriodId) {
74 74
                 $join->on('institution_classes.institution_id', '=', 'institution_grades.institution_id')
75 75
                     ->where('institution_classes.academic_period_id', $academicPeriodId)
76
-                    ->join('institution_class_grades', function ($join) use ($educationGradeId) {
76
+                    ->join('institution_class_grades', function($join) use ($educationGradeId) {
77 77
                         $join->on('institution_class_grades.institution_class_id', '=', 'institution_classes.id')
78 78
                             ->where('institution_class_grades.education_grade_id', $educationGradeId);
79 79
                     })
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
             ->select('education_grades.name', 'institutions.code', 'institutions.name as institution_name', 'institution_grades.id', 'institution_grades.institution_id', 'institution_grades.education_grade_id')
124 124
             ->where('promoted', '=', $year)
125 125
             ->join('education_grades', 'institution_grades.education_grade_id', '=', 'education_grades.id')
126
-            ->join('institutions', function ($join) use ($year, $institution) {
126
+            ->join('institutions', function($join) use ($year, $institution) {
127 127
                 $join->on('institutions.id', '=', 'institution_grades.institution_id')
128 128
                     ->where('institutions.code', '=', $institution);
129 129
             })
@@ -151,21 +151,21 @@  discard block
 block discarded – undo
151 151
      * @param $year
152 152
      * @return mixed
153 153
      */
154
-    public function getInstitutionGradeList($year, $limit,$mode)
154
+    public function getInstitutionGradeList($year, $limit, $mode)
155 155
     {
156 156
         $query = $this->select('education_grades.name', 'institutions.code', 'institutions.name as institution_name', 'institution_grades.id', 'institution_grades.institution_id', 'institution_grades.education_grade_id')
157 157
             ->where('promoted', '=', $year)
158 158
             ->join('education_grades', 'institution_grades.education_grade_id', '=', 'education_grades.id')
159
-            ->join('institutions', function ($join) use ($year) {
159
+            ->join('institutions', function($join) use ($year) {
160 160
                 $join->on('institutions.id', '=', 'institution_grades.institution_id');
161 161
             })
162 162
             ->join('education_programmes', 'education_grades.education_programme_id', 'education_programmes.id');
163 163
             switch ($mode) {
164 164
                 case '1-5':
165
-                    $query->where('education_programmes.education_cycle_id', [1,2]);
165
+                    $query->where('education_programmes.education_cycle_id', [1, 2]);
166 166
                     break;
167 167
                 case '6-11':
168
-                    $query->whereIn('education_programmes.education_cycle_id', [2,3,4]);
168
+                    $query->whereIn('education_programmes.education_cycle_id', [2, 3, 4]);
169 169
                     break;
170 170
                 case 'AL':
171 171
                     $query->where('education_programmes.education_cycle_id', 4);
@@ -180,13 +180,13 @@  discard block
 block discarded – undo
180 180
             return $data;
181 181
     }
182 182
 
183
-    public function getGradeSubjects($institutionId){
183
+    public function getGradeSubjects($institutionId) {
184 184
         return self::query()
185
-        ->select('institution_grades.institution_id','education_grades_subjects.education_grade_id','education_grades_subjects.education_subject_id','education_subjects.name')
186
-        ->where('institution_grades.institution_id',$institutionId)
185
+        ->select('institution_grades.institution_id', 'education_grades_subjects.education_grade_id', 'education_grades_subjects.education_subject_id', 'education_subjects.name')
186
+        ->where('institution_grades.institution_id', $institutionId)
187 187
         ->join('education_grades', 'institution_grades.education_grade_id', 'education_grades.id')
188
-        ->join('education_grades_subjects','education_grades.id','education_grades_subjects.education_grade_id')
189
-        ->join('education_subjects','education_grades_subjects.education_subject_id','education_subjects.id')
188
+        ->join('education_grades_subjects', 'education_grades.id', 'education_grades_subjects.education_grade_id')
189
+        ->join('education_subjects', 'education_grades_subjects.education_subject_id', 'education_subjects.id')
190 190
         ->groupBy('education_grades_subjects.id')
191 191
         ->get()
192 192
         ->toArray();
Please login to merge, or discard this patch.