moe-lk / bulk-upload

app/Http/Controllers/ExaminationStudentsController.php

Spacing +32 added lines, -32 removed lines

@@ -30,7 +30,7 @@ 
         $this->grade = $grade;
         $this->student = new Security_user();
         $this->examination_student = new Examination_student();
-        $this->academic_period =  Academic_period::where('code', '=', $this->year)->first();
+        $this->academic_period = Academic_period::where('code', '=', $this->year)->first();
         $this->education_grade = Education_grade::where('code', '=', $this->grade)->first();
         $this->output = new \Symfony\Component\Console\Output\ConsoleOutput();
     }
@@ -72,10 +72,10 @@ 
                     );
                     Session::flash('message', 'File upload successfully!');
                     // Redirect to index
-                } else {
+                }else {
                     Session::flash('message', 'File too large. File must be less than 20MB.');
                 }
-            } else {
+            }else {
                 Session::flash('message', 'Invalid File Extension.');
             }
         }
@@ -97,7 +97,7 @@ 
             $import->import($excelFile, 'local', \Maatwebsite\Excel\Excel::CSV);
             if ($import->failures()->count() > 0) {
                 $errors = $import->failures();
-                $columns =  [
+                $columns = [
                     'remarks',
                     'st_no',
                     'stu_no',
@@ -118,10 +118,10 @@ 
                 Storage::put($file, implode(',', $columns));
 
                 foreach ($errors as $error) {
-                    Storage::append($file, implode(':', $error->errors()) . ',' . implode(',', $error->values()));
+                    Storage::append($file, implode(':', $error->errors()).','.implode(',', $error->values()));
                 }
             }
-        } catch (\Maatwebsite\Excel\Validators\ValidationException $e) {
+        }catch (\Maatwebsite\Excel\Validators\ValidationException $e) {
         }
     }
 
@@ -135,9 +135,9 @@ 
         $students = [];
         switch ($mode) {
             case 'duplicate':
-                $students =  DB::table('examination_students as es')
+                $students = DB::table('examination_students as es')
                     ->select(DB::raw('count(*) as total'), 'e2.*')
-                    ->join('examination_students as e2', 'es.nsid','e2.nsid')
+                    ->join('examination_students as e2', 'es.nsid', 'e2.nsid')
                     ->having('total', '>', 1)
                     ->groupBy('e2.st_no')
                     ->orderBy('e2.st_no')
@@ -145,35 +145,35 @@ 
                     ->limit($limit)
                     ->get()->toArray();
                 $students = (array) json_decode(json_encode($students));
-                $this->output->writeln(count($students) . 'students remaining duplicate');
+                $this->output->writeln(count($students).'students remaining duplicate');
                 array_walk($students, array($this, 'clone'));
                 $this->output->writeln('All are generated');
                 break;
             case 'empty';
                 $students = Examination_student::whereNull('nsid')
-                    ->orWhere('nsid','')
+                    ->orWhere('nsid', '')
                     ->offset($offset)
                     ->limit($limit)
                     ->get()->toArray();
                 $students = (array) json_decode(json_encode($students));
-                $this->output->writeln(count($students) . 'students remaining empty');
+                $this->output->writeln(count($students).'students remaining empty');
                 array_walk($students, array($this, 'clone'));
                 $this->output->writeln('All are generated');
                 break;
             case 'count':
                 $count = Examination_student::select('nsid')
-                ->where('nsid','!=',)
+                ->where('nsid', '!=',)
                 ->groupeBy('nsid')
                 ->count();
                 $all = Examination_student::select('nsid')
                     ->count();
-                $this->output->writeln( $all. 'Total Unique nsid are: ' .$count);
+                $this->output->writeln($all.'Total Unique nsid are: '.$count);
             default:
                 $students = Examination_student::offset($offset)
                     ->limit($limit)
                     ->get()->toArray();
                 $students = (array) json_decode(json_encode($students));
-                $this->output->writeln(count($students) . 'students remaining empty');
+                $this->output->writeln(count($students).'students remaining empty');
                 array_walk($students, array($this, 'clone'));
                 $this->output->writeln('All are generated');
         }
@@ -219,7 +219,7 @@ 
      */
     public function clone($student)
     {
-        $student = (array)json_decode(json_encode($student));
+        $student = (array) json_decode(json_encode($student));
         //get student matching with same dob and gender
 
         $matchedStudent = $this->getMatchingStudents($student);
@@ -252,7 +252,7 @@ 
 
                 //TODO implement insert student to admission table
                 $student['id'] = $sis_student['id'];
-                $sis_student['student_id'] =  $student['id'];
+                $sis_student['student_id'] = $student['id'];
 
                 $student = $this->setIsTakingExam($student);
                 if (count($institutionClass) == 1) {
@@ -260,13 +260,13 @@ 
                     Institution_student::createExaminationData($student, $admissionInfo);
                     Institution_student_admission::createExaminationData($student, $admissionInfo);
                     Institution_class_student::createExaminationData($student, $admissionInfo);
-                } else {
+                }else {
                     Institution_student_admission::createExaminationData($student, $admissionInfo);
                     Institution_student::createExaminationData($student, $admissionInfo);
                 }
                 $this->updateStudentId($student, $sis_student);
                 // update the matched student's data    
-            } else {
+            }else {
                 $student = $this->setIsTakingExam($student);
                 $studentData = $this->student->updateExaminationStudent($student, $matchedStudent);
                 $matchedStudent = array_merge((array) $student, $matchedStudent);
@@ -274,9 +274,9 @@ 
                 Institution_student::updateExaminationData($studentData, $admissionInfo);
                 $this->updateStudentId($student, $studentData);
             }
-        } else {
+        }else {
 
-            $this->output->writeln('Student ' . $student['st_no'] . ' not imorted' . $student['f_name']);
+            $this->output->writeln('Student '.$student['st_no'].' not imorted'.$student['f_name']);
         }
     }
 
@@ -294,11 +294,11 @@ 
         $count = $this->student->getStudentCount($student);
 
         $studentData = [];
-        $sis_users  = (array) json_decode(json_encode($sis_student), true);
+        $sis_users = (array) json_decode(json_encode($sis_student), true);
         // if the same gender same DOE has more than one 
-        if($count > 1){
-            $studentData = $this->searchSimilarName($student, $sis_users,false);
-        }else{
+        if ($count > 1) {
+            $studentData = $this->searchSimilarName($student, $sis_users, false);
+        }else {
             $studentData = $this->searchSimilarName($student, $sis_users);
         }   
         return $studentData;
@@ -311,7 +311,7 @@ 
      * @param array $sis_students
      * @return array
      */
-    public function searchSimilarName($student, $sis_students,$surname_search = true)
+    public function searchSimilarName($student, $sis_students, $surname_search = true)
     {
         $highest = [];
         $minDistance = 0;
@@ -331,7 +331,7 @@ 
             }
         }
 
-        if($surname_search){
+        if ($surname_search) {
             if (empty($highest)) {
                 foreach ($sis_students as $key => $value) {
                     //search name with last name
@@ -360,7 +360,7 @@ 
     public function updateStudentId($student, $sis_student)
     {
         try {
-            $student['nsid'] =  $sis_student['openemis_no'];
+            $student['nsid'] = $sis_student['openemis_no'];
             // add new NSID to the examinations data set
             unset($student['id']);
             unset($student['taking_g5_exam']);
@@ -369,8 +369,8 @@ 
             unset($student['total']);
             $this->examination_student->where('st_no', $student['st_no'])->update($student);
             unset($student['st_no']);
-            $this->output->writeln('Updated  to NSID' . $sis_student['openemis_no']);
-        } catch (\Exception $th) {
+            $this->output->writeln('Updated  to NSID'.$sis_student['openemis_no']);
+        }catch (\Exception $th) {
             dd($th);
             $this->output->writeln('error');
             Log::error($th);
@@ -388,7 +388,7 @@ 
         try {
             (new ExaminationStudentsExport)->store('examination/student_data_with_nsid.csv');
             (new ExportReady($adminUser));
-        } catch (\Throwable $th) {
+        }catch (\Throwable $th) {
             //throw $th;
             dd($th);
         }
@@ -398,13 +398,13 @@ 
     public function downloadErrors()
     {
 
-        $file_path = storage_path() . '/app/examination/errors.csv';
+        $file_path = storage_path().'/app/examination/errors.csv';
         return Response::download($file_path);
     }
 
     public function downloadProcessedFile()
     {
-        $file_path = storage_path() . '/app/examination/student_data_with_nsid.csv';
+        $file_path = storage_path().'/app/examination/student_data_with_nsid.csv';
         return Response::download($file_path);
     }
 }

Braces +1 added lines, -1 removed lines

@@ -298,7 +298,7 @@
         // if the same gender same DOE has more than one 
         if($count > 1){
             $studentData = $this->searchSimilarName($student, $sis_users,false);
-        }else{
+        } else{
             $studentData = $this->searchSimilarName($student, $sis_users);
         }   
         return $studentData;

app/Console/Commands/ExaminationCheck.php

Spacing +9 added lines, -9 removed lines

@@ -42,16 +42,16 @@ 
     {
         $this->start_time = microtime(TRUE);
         $count = DB::table('examination_students')->select('nsid')->distinct()->count();
-        $studentsIdsWithDuplication =   DB::table('examination_students as es')
-        ->select(DB::raw('count(*) as total'),'es.*')
+        $studentsIdsWithDuplication = DB::table('examination_students as es')
+        ->select(DB::raw('count(*) as total'), 'es.*')
         ->whereNotNull('es.nsid')
-        ->orWhereNot('es.nsid','<>','')
-        ->having('total','>',1)
+        ->orWhereNot('es.nsid', '<>', '')
+        ->having('total', '>', 1)
         ->groupBy('es.nsid')
         ->orderBy('es.nsid')
-        ->chunk(10000,function($Students){
+        ->chunk(10000, function($Students) {
             foreach ($Students as $Student) {
-                Examination_student::where('nsid',$Student->nsid)->update(['nsid'=>'']);
+                Examination_student::where('nsid', $Student->nsid)->update(['nsid'=>'']);
             }
         }); 
     }
@@ -60,16 +60,16 @@ 
     {
         array_walk($array, array($this, 'deleteDuplication'));
         $this->end_time = microtime(TRUE);
-        $this->output->writeln('The cook took ' . ($this->end_time - $this->start_time) . ' seconds to complete');
+        $this->output->writeln('The cook took '.($this->end_time - $this->start_time).' seconds to complete');
         $this->output->writeln(count($array).'entries cleaned');
     }
 
     public function deleteDuplication($students)
     {
-        $count =  Examination_student::where('nsid', $students['nsid'])->count();
+        $count = Examination_student::where('nsid', $students['nsid'])->count();
         if ($count > 1) {
             $count = Examination_student::where('nsid', $students['nsid'])->update(['nsid' => '']);
-            $this->output->writeln($students['nsid'] .'same ID' . $count . ' records removed');
+            $this->output->writeln($students['nsid'].'same ID'.$count.' records removed');
         }
     }
 }