Passed
Pull Request — master (#8)
by Mohamed
03:41
created
app/Institution_staff.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -42,11 +42,11 @@
 block discarded – undo
42 42
     protected $dates = ['start_date', 'end_date', 'modified', 'created'];
43 43
 
44 44
 
45
-    public function staff_class(){
46
-        return $this->hasMany('App\Models\Institution_class','staff_id','staff_id');
45
+    public function staff_class() {
46
+        return $this->hasMany('App\Models\Institution_class', 'staff_id', 'staff_id');
47 47
     }
48 48
 
49
-    public function institution(){
50
-        return $this->belongsTo('App\Models\Institution','institution_id');
49
+    public function institution() {
50
+        return $this->belongsTo('App\Models\Institution', 'institution_id');
51 51
     }
52 52
 }
Please login to merge, or discard this patch.
app/Institution_class.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -48,22 +48,22 @@
 block discarded – undo
48 48
      */
49 49
     protected $dates = ['modified', 'created'];
50 50
 
51
-    public function class_teacher(){
52
-        return $this->belongsTo('App\Models\Security_group_user','staff_id','security_user_id');
51
+    public function class_teacher() {
52
+        return $this->belongsTo('App\Models\Security_group_user', 'staff_id', 'security_user_id');
53 53
     }
54 54
 
55
-    public function institution(){
56
-        return $this->belongsTo('App\Models\Institution','institution_id');
55
+    public function institution() {
56
+        return $this->belongsTo('App\Models\Institution', 'institution_id');
57 57
     }
58 58
 
59 59
 
60
-    public function getShiftClasses($shift){
60
+    public function getShiftClasses($shift) {
61 61
         return self::query()
62
-            ->select('institution_classes.id','institution_classes.institution_id','institution_classes.institution_shift_id',
63
-                'institution_classes.name','institution_classes.no_of_students','institution_classes.class_number','institution_class_grades.education_grade_id')
64
-            ->where('institution_shift_id',$shift)
62
+            ->select('institution_classes.id', 'institution_classes.institution_id', 'institution_classes.institution_shift_id',
63
+                'institution_classes.name', 'institution_classes.no_of_students', 'institution_classes.class_number', 'institution_class_grades.education_grade_id')
64
+            ->where('institution_shift_id', $shift)
65 65
 //            ->where('academic_period_id',$academicPeriod)
66
-            ->join('institution_class_grades','institution_classes.id','institution_class_grades.institution_class_id')
66
+            ->join('institution_class_grades', 'institution_classes.id', 'institution_class_grades.institution_class_id')
67 67
             ->groupBy('institution_classes.id')
68 68
             ->get()->toArray();
69 69
     }
Please login to merge, or discard this patch.
app/Security_role.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@
 block discarded – undo
42 42
     protected $dates = ['modified', 'created'];
43 43
 
44 44
 
45
-    public function securityUsers(){
46
-        return $this->belongsToMany(Security_group_user::class,'security_group_users','security_group_id','security_group_id');
45
+    public function securityUsers() {
46
+        return $this->belongsToMany(Security_group_user::class, 'security_group_users', 'security_group_id', 'security_group_id');
47 47
     }
48 48
 }
Please login to merge, or discard this patch.
app/Security_group_user.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -45,33 +45,33 @@
 block discarded – undo
45 45
     protected $dates = ['modified', 'created', 'created'];
46 46
 
47 47
 
48
-    public function security_user(){
49
-        return $this->belongsToMany('App\User','security_users');
48
+    public function security_user() {
49
+        return $this->belongsToMany('App\User', 'security_users');
50 50
     }
51 51
 
52
-    public function security_group(){
53
-        return $this->hasMany('App\Security_group' , 'id','security_group_id');
52
+    public function security_group() {
53
+        return $this->hasMany('App\Security_group', 'id', 'security_group_id');
54 54
     }
55 55
 
56
-    public function security_group_institution(){
57
-        return $this->belongsTo('App\Security_group_institution','security_group_id','security_group_id');
56
+    public function security_group_institution() {
57
+        return $this->belongsTo('App\Security_group_institution', 'security_group_id', 'security_group_id');
58 58
     }
59 59
 
60
-    public function staff_class(){
61
-        return $this->hasMany('App\Institution_class','staff_id','security_user_id');
60
+    public function staff_class() {
61
+        return $this->hasMany('App\Institution_class', 'staff_id', 'security_user_id');
62 62
     }
63 63
 
64
-    public function institution_staff(){
65
-        return $this->belongsTo('App\Institution_staff','security_user_id','staff_id');
64
+    public function institution_staff() {
65
+        return $this->belongsTo('App\Institution_staff', 'security_user_id', 'staff_id');
66 66
     }
67 67
 
68
-    public function institution_group(){
69
-        return $this->hasMany('App\Security_group_institution','security_group_id','security_group_id')
70
-            ->with(['institution','institution_classes']);
68
+    public function institution_group() {
69
+        return $this->hasMany('App\Security_group_institution', 'security_group_id', 'security_group_id')
70
+            ->with(['institution', 'institution_classes']);
71 71
     }
72 72
 
73 73
 
74
-    public function roles(){
75
-        return $this->belongsTo('App\Security_role','security_role_id','id');
74
+    public function roles() {
75
+        return $this->belongsTo('App\Security_role', 'security_role_id', 'id');
76 76
     }
77 77
 }
Please login to merge, or discard this patch.
app/Security_group.php 2 patches
Indentation   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -6,11 +6,11 @@
 block discarded – undo
6 6
 
7 7
 class Security_group extends Model
8 8
 {
9
-     /**
10
-     * The database table used by the model.
11
-     *
12
-     * @var string
13
-     */
9
+        /**
10
+         * The database table used by the model.
11
+         *
12
+         * @var string
13
+         */
14 14
     protected $table = 'security_groups';
15 15
 
16 16
     /**
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -45,12 +45,12 @@
 block discarded – undo
45 45
 //        return $this->hasMany( User::class);
46 46
 //    }
47 47
 
48
-    public function security_users(){
49
-        return $this->belongsTo('App\Security_group_user','security_group_id');
48
+    public function security_users() {
49
+        return $this->belongsTo('App\Security_group_user', 'security_group_id');
50 50
     }
51 51
 
52 52
 
53
-    public function security_group_institution(){
54
-        return $this->hasMany('App\Security_group_institution','security_group_id');
53
+    public function security_group_institution() {
54
+        return $this->hasMany('App\Security_group_institution', 'security_group_id');
55 55
     }
56 56
 }
Please login to merge, or discard this patch.
app/Institution.php 2 patches
Indentation   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -6,11 +6,11 @@  discard block
 block discarded – undo
6 6
 
7 7
 class Institution extends Model
8 8
 {
9
-     /**
10
-     * The database table used by the model.
11
-     *
12
-     * @var string
13
-     */
9
+        /**
10
+         * The database table used by the model.
11
+         *
12
+         * @var string
13
+         */
14 14
     protected $table = 'institutions';
15 15
 
16 16
     /**
@@ -42,6 +42,6 @@  discard block
 block discarded – undo
42 42
     protected $dates = ['date_opened', 'date_closed', 'modified', 'created'];
43 43
 
44 44
     public function isActive($id){
45
-       return  self::query()->find($id)->get()->first()->institution_status_id == 1;
45
+        return  self::query()->find($id)->get()->first()->institution_status_id == 1;
46 46
     }
47 47
 }
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@
 block discarded – undo
41 41
      */
42 42
     protected $dates = ['date_opened', 'date_closed', 'modified', 'created'];
43 43
 
44
-    public function isActive($id){
44
+    public function isActive($id) {
45 45
        return  self::query()->find($id)->get()->first()->institution_status_id == 1;
46 46
     }
47 47
 }
Please login to merge, or discard this patch.
app/Security_group_institution.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -43,15 +43,15 @@
 block discarded – undo
43 43
 
44 44
 
45 45
 
46
-    public function institution(){
47
-        return $this->belongsTo('App\Institution','institution_id');
46
+    public function institution() {
47
+        return $this->belongsTo('App\Institution', 'institution_id');
48 48
     }
49 49
 
50
-    public function institution_classes(){
51
-        return $this->hasMany('App\Institution_class','institution_id','institution_id');
50
+    public function institution_classes() {
51
+        return $this->hasMany('App\Institution_class', 'institution_id', 'institution_id');
52 52
     }
53 53
 
54
-    public function security_group(){
55
-        return $this->belongsTo('App\Security_group','security_group_id');
54
+    public function security_group() {
55
+        return $this->belongsTo('App\Security_group', 'security_group_id');
56 56
     }
57 57
 }
Please login to merge, or discard this patch.
app/Providers/AppServiceProvider.php 2 patches
Indentation   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -16,11 +16,11 @@
 block discarded – undo
16 16
         //
17 17
     }
18 18
 
19
-     /**
20
-     * Bootstrap any application services.
21
-     *
22
-     * @return void
23
-     */
19
+        /**
20
+         * Bootstrap any application services.
21
+         *
22
+         * @return void
23
+         */
24 24
     public function boot()
25 25
     {
26 26
         //
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
     public function boot()
25 25
     {
26 26
         //
27
-        if((\App::environment('dev')) |  (\App::environment('stage')) | (\App::environment('prod'))) {
27
+        if ((\App::environment('dev')) | (\App::environment('stage')) | (\App::environment('prod'))) {
28 28
             URL::forceScheme('https');
29 29
         }
30 30
     }
Please login to merge, or discard this patch.
app/Http/Middleware/Authenticate.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -15,7 +15,7 @@
 block discarded – undo
15 15
     protected function redirectTo($request)
16 16
     {
17 17
 
18
-        if (! ($request->expectsJson() || collect($request->route()->middleware())->contains('api'))) {
18
+        if (!($request->expectsJson() || collect($request->route()->middleware())->contains('api'))) {
19 19
             return route('login');
20 20
         }
21 21
 
Please login to merge, or discard this patch.