modera / ModeraBackendSecurityBundle

Controller/PermissionsController.php

Spacing +1 added lines, -1 removed lines

@@ -29,7 +29,7 @@
             ),
             'hydration' => array(
                 'groups' => array(
-                    'list' => function (Permission $permission) {
+                    'list' => function(Permission $permission) {
                         $groups = array();
                         foreach ($permission->getGroups() as $group) {
                             $groups[] = $group->getId();

Tests/Functional/Controller/GroupsControllerTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -293,7 +293,7 @@
     }
 
     /**
-     * @return array
+     * @return string[]
      */
     private static function getTablesClasses()
     {

Tests/Functional/Controller/UsersControllerTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -293,7 +293,7 @@
     }
 
     /**
-     * @return array
+     * @return string[]
      */
     private static function getTablesClasses()
     {

DataMapper/UserDataMapper.php

Spacing +1 added lines, -1 removed lines

@@ -28,7 +28,7 @@
 
         return array_filter(
             parent::getAllowedFields($entityClass),
-            function ($fieldName) use ($me) {
+            function($fieldName) use ($me) {
                 if (array_search($fieldName, $me->excludedFields) !== false) {
                     return false;
                 }

Controller/GroupsController.php

Spacing +4 added lines, -4 removed lines

@@ -24,7 +24,7 @@ 
     {
         $em = $this->getDoctrine();
 
-        $groupEntityValidator = function (array $params, Group $group, DefaultEntityValidator $defaultValidator, array $config, ContainerInterface $container) use ($em) {
+        $groupEntityValidator = function(array $params, Group $group, DefaultEntityValidator $defaultValidator, array $config, ContainerInterface $container) use ($em) {
             $validationResult = $defaultValidator->validate($group, $config);
 
             if (!$group->getRefName()) {
@@ -51,7 +51,7 @@ 
             return $validationResult;
         };
 
-        $mapEntity = function (array $params, Group $group, DataMapperInterface $defaultMapper, ContainerInterface $container) {
+        $mapEntity = function(array $params, Group $group, DataMapperInterface $defaultMapper, ContainerInterface $container) {
             $defaultMapper->mapData($params, $group);
 
             /*
@@ -83,7 +83,7 @@ 
             ),
             'hydration' => array(
                 'groups' => array(
-                    'list' => function (Group $group) {
+                    'list' => function(Group $group) {
                         return array(
                             'id' => $group->getId(),
                             'name' => $group->getName(),
@@ -100,7 +100,7 @@ 
                     'edit-group' => array('main-form'),
                 ),
             ),
-            'format_new_entity_values' => function (array $params, array $config, NewValuesFactoryInterface $defaultImpl, ContainerInterface $container) {
+            'format_new_entity_values' => function(array $params, array $config, NewValuesFactoryInterface $defaultImpl, ContainerInterface $container) {
                 return array(
                     'refName' => null,
                 );

Controller/UsersController.php

Unused Use Statements -1 removed lines

@@ -20,7 +20,6 @@
 use Symfony\Component\DependencyInjection\ContainerInterface;
 use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;
 use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;
-use Modera\BackendSecurityBundle\Service\MailService;
 
 /**
  * @author    Sergei Vizel <sergei.vizel@modera.org>

Spacing +8 added lines, -8 removed lines

@@ -37,13 +37,13 @@ 
 
         return array(
             'entity' => User::clazz(),
-            'create_default_data_mapper' => function (ContainerInterface $container) {
+            'create_default_data_mapper' => function(ContainerInterface $container) {
                 return $this->container->get('modera_backend_security.data_mapper.user_data_mapper');
             },
             'security' => array(
                 'actions' => array(
                     'create' => ModeraBackendSecurityBundle::ROLE_MANAGE_USER_PROFILES,
-                    'update' => function (AuthorizationCheckerInterface $ac, array $params) use ($self) {
+                    'update' => function(AuthorizationCheckerInterface $ac, array $params) use ($self) {
                         /* @var TokenStorageInterface $ts */
                         $ts = $self->get('security.token_storage');
                         /* @var User $user */
@@ -91,7 +91,7 @@ 
             'hydration' => array(
                 'groups' => array(
                     'main-form' => ['id', 'username', 'email', 'firstName', 'lastName', 'middleName', 'meta'],
-                    'list' => function (User $user) {
+                    'list' => function(User $user) {
                         $groups = array();
                         foreach ($user->getGroups() as $group) {
                             $groups[] = $group->getName();
@@ -110,7 +110,7 @@ 
                             'meta' => $user->getMeta(),
                         );
                     },
-                    'compact-list' => function (User $user) {
+                    'compact-list' => function(User $user) {
                         $groups = array();
                         foreach ($user->getGroups() as $group) {
                             $groups[] = $group->getName();
@@ -134,7 +134,7 @@ 
                     'modera-backend-security-group-groupusers' => HydrationProfile::create(false)->useGroups(array('compact-list')),
                 ),
             ),
-            'map_data_on_create' => function (array $params, User $user, DataMapperInterface $defaultMapper, ContainerInterface $container) use ($self) {
+            'map_data_on_create' => function(array $params, User $user, DataMapperInterface $defaultMapper, ContainerInterface $container) use ($self) {
                 $defaultMapper->mapData($params, $user);
 
                 if (isset($params['plainPassword']) && $params['plainPassword']) {
@@ -153,7 +153,7 @@ 
                     throw new BadPasswordException($e->getErrors()[0], null, $e);
                 }
             },
-            'map_data_on_update' => function (array $params, User $user, DataMapperInterface $defaultMapper, ContainerInterface $container) use ($self) {
+            'map_data_on_update' => function(array $params, User $user, DataMapperInterface $defaultMapper, ContainerInterface $container) use ($self) {
                 $defaultMapper->mapData($params, $user);
 
                 /* @var LoggerInterface $activityMgr */
@@ -196,7 +196,7 @@ 
                     $activityMgr->info($activityMsg, $activityContext);
                 }
             },
-            'updated_entity_validator' => function (array $params, User $user, EntityValidatorInterface $validator, array $config) {
+            'updated_entity_validator' => function(array $params, User $user, EntityValidatorInterface $validator, array $config) {
                 $isBatchUpdatedBeingPerformed = !isset($params['record']);
                 if ($isBatchUpdatedBeingPerformed) {
                     // Because of bug in AbstractCrudController (see MF-UPGRADE3.0 and search for "$recordParams" keyword)
@@ -224,7 +224,7 @@ 
 
                 return $result;
             },
-            'remove_entities_handler' => function ($entities, $params, $defaultHandler, ContainerInterface $container) {
+            'remove_entities_handler' => function($entities, $params, $defaultHandler, ContainerInterface $container) {
                 /* @var UserService $userService */
                 $userService = $container->get('modera_security.service.user_service');
 

Service/MailService.php

Doc Comments +1 added lines, -1 removed lines

@@ -52,7 +52,7 @@
 
     /**
      * @param User $user
-     * @param $plainPassword
+     * @param string $plainPassword
      *
      * @return array|bool
      */

Tests/Unit/Controller/UsersControllerTest.php

Unused Use Statements -1 removed lines

@@ -6,7 +6,6 @@
 use Modera\BackendSecurityBundle\Controller\UsersController;
 use Modera\BackendSecurityBundle\ModeraBackendSecurityBundle;
 use Modera\SecurityBundle\Entity\User;
-use Modera\SecurityBundle\PasswordStrength\PasswordGenerator;
 use Modera\SecurityBundle\PasswordStrength\PasswordManager;
 use Symfony\Bridge\Doctrine\RegistryInterface;
 use Symfony\Component\DependencyInjection\ContainerInterface;