mmucklo / DtcQueueBundle

Tests/StaticJobManager.php

Spacing +1 added lines, -1 removed lines

@@ -33,7 +33,7 @@
             $total += count($this->jobs[$jobWorkerName]);
         }
 
-        return array_sum(array_map(function ($jobs) { return count($jobs); }, $this->jobs));
+        return array_sum(array_map(function($jobs) { return count($jobs); }, $this->jobs));
     }
 
     public function getStatus()

DependencyInjection/Configuration.php

Spacing +3 added lines, -3 removed lines

@@ -89,7 +89,7 @@ 
         $rootNode
             ->prototype('variable')->end()
             ->validate()
-                ->ifTrue(function ($node) {
+                ->ifTrue(function($node) {
                     if (!is_array($node)) {
                         return true;
                     }
@@ -166,7 +166,7 @@ 
             ->append($this->addRabbitMqSslOptions())
             ->append($this->addRabbitMqArgs())
             ->append($this->addRabbitMqExchange())
-            ->validate()->always(function ($node) {
+            ->validate()->always(function($node) {
                 if (empty($node['ssl_options'])) {
                     unset($node['ssl_options']);
                 }
@@ -176,7 +176,7 @@ 
 
                 return $node;
             })->end()
-            ->validate()->ifTrue(function ($node) {
+            ->validate()->ifTrue(function($node) {
                 if (isset($node['ssl_options']) && !$node['ssl']) {
                     return true;
                 }

ORM/JobManager.php

Doc Comments +8 added lines, -3 removed lines

@@ -239,6 +239,7 @@ 
      * @param string $workerName
      * @param string $methodName
      * @param bool   $prioritize
+     * @param integer $runId
      *
      * @return Job|null
      */
@@ -255,8 +256,8 @@ 
     }
 
     /**
-     * @param null $workerName
-     * @param null $methodName
+     * @param string|null $workerName
+     * @param string|null $methodName
      * @param bool $prioritize
      *
      * @return QueryBuilder
@@ -332,7 +333,7 @@ 
      *
      * @param \Dtc\QueueBundle\Model\Job $job
      *
-     * @return mixed|null
+     * @return null|Job
      */
     public function updateNearestBatch(\Dtc\QueueBundle\Model\Job $job)
     {
@@ -361,6 +362,10 @@ 
         return $existingJob;
     }
 
+    /**
+     * @param integer $newPriority
+     * @param null|\DateTime $newWhenAt
+     */
     protected function updateBatchJob(Job $existingJob, $newPriority, $newWhenAt)
     {
         $existingPriority = $existingJob->getPriority();

ORM/LiveJobGridSource.php

Indentation +1 added lines, -1 removed lines

@@ -37,7 +37,7 @@
         $queryBuilder = $this->jobManager->getJobQueryBuilder();
         $queryBuilder->add('select', 'j');
         $queryBuilder->setFirstResult($this->offset)
-                     ->setMaxResults($this->limit);
+                        ->setMaxResults($this->limit);
 
         return $queryBuilder;
     }

Controller/QueueController.php

Spacing +1 added lines, -1 removed lines

@@ -244,7 +244,7 @@
             $timingsDates = array_unique(array_merge(array_keys($timingsData), $timingsDates));
         }
 
-        usort($timingsDates, function ($date1str, $date2str) {
+        usort($timingsDates, function($date1str, $date2str) {
             $date1 = \DateTime::createFromFormat('Y-m-d H', $date1str);
             $date2 = \DateTime::createFromFormat('Y-m-d H', $date2str);
             if (!$date2) {

Doc Comments +7 added lines, -1 removed lines

@@ -74,6 +74,9 @@ 
         return $params;
     }
 
+    /**
+     * @param string $type
+     */
     protected function validateManagerType($type)
     {
         $managerType = $this->container->getParameter($type);
@@ -201,7 +204,6 @@ 
     /**
      * @Route("/timings", name="dtc_queue_timings")
      *
-     * @param Request $request
      */
     public function getTimingsAction()
     {
@@ -221,6 +223,10 @@ 
         return new JsonResponse($params);
     }
 
+    /**
+     * @param \DateTime|null $beginDate
+     * @param \DateTime $endDate
+     */
     protected function calculateTimings($type, $beginDate, $endDate)
     {
         $params = [];

DependencyInjection/Compiler/WorkerCompilerPass.php

Doc Comments +8 added lines, -1 removed lines

@@ -48,6 +48,9 @@ 
         $this->setupDoctrineManagers($container);
     }
 
+    /**
+     * @param string $type
+     */
     protected function setupAlias(ContainerBuilder $container, $defaultManagerType, $type)
     {
         $definitionName = 'dtc_queue.'.$type.'.'.$defaultManagerType;
@@ -78,7 +81,6 @@ 
 
     /**
      * @param ContainerBuilder $container
-     * @param Reference[]      $jobManagerRef
      * @param string           $jobClass
      */
     protected function setupTaggedServices(ContainerBuilder $container, Definition $definition, $jobClass)
@@ -189,6 +191,11 @@ 
         return $managerType;
     }
 
+    /**
+     * @param string $managerType
+     * @param string $type
+     * @param string $className
+     */
     protected function getClass(ContainerBuilder $container, $managerType, $type, $className, $baseClass)
     {
         $runClass = $container->hasParameter('dtc_queue.class_'.$type) ? $container->getParameter('dtc_queue.class_'.$type) : null;

Doctrine/BaseJobManager.php

Doc Comments +16 added lines, -5 removed lines

@@ -34,10 +34,7 @@ 
     protected $jobArchiveClass;
 
     /**
-     * @param string $objectName
-     * @param string $archiveObjectName
-     * @param string $runClass
-     * @param string $runArchiveClass
+     * @param string $jobArchiveClass
      */
     public function __construct(RunManager $runManager, JobTimingManager $jobTimingManager, ObjectManager $objectManager,
         $jobClass,
@@ -113,6 +110,10 @@ 
         }
     }
 
+    /**
+     * @param string $workerName
+     * @param string $method
+     */
     public function pruneExpiredJobs($workerName = null, $method = null)
     {
         $count = $this->updateExpired($workerName, $method);
@@ -248,6 +249,10 @@ 
         return false;
     }
 
+    /**
+     * @param integer $i
+     * @param integer $count
+     */
     protected function runStalledLoop($i, $count, array $stalledJobs, &$countProcessed)
     {
         $objectManager = $this->getObjectManager();
@@ -361,6 +366,9 @@ 
      */
     abstract protected function stopIdGenerator($objectName);
 
+    /**
+     * @param string $objectName
+     */
     abstract protected function restoreIdGenerator($objectName);
 
     /**
@@ -397,6 +405,9 @@ 
         return $countProcessed;
     }
 
+    /**
+     * @param string $function
+     */
     protected function resetSaveOk($function)
     {
     }
@@ -410,7 +421,7 @@ 
 
     /**
      * @param RetryableJob $jobArchive
-     * @param $className
+     * @param string $className
      * @param $countProcessed
      */
     protected function resetJob(RetryableJob $jobArchive, $className, &$countProcessed)

ODM/JobManager.php

Doc Comments +2 added lines, -2 removed lines

@@ -241,8 +241,8 @@
     }
 
     /**
-     * @param null $workerName
-     * @param null $methodName
+     * @param string|null $workerName
+     * @param string|null $methodName
      * @param bool $prioritize
      *
      * @return Builder