mmucklo / DtcQueueBundle

Controller/TrendsController.php

Doc Comments +5 added lines, -2 removed lines

@@ -36,7 +36,6 @@ 
     /**
      * @Route("/timings", name="dtc_queue_timings")
      *
-     * @param Request $request
      */
     public function getTimingsAction()
     {
@@ -56,6 +55,10 @@ 
         return new JsonResponse($params);
     }
 
+    /**
+     * @param \DateTime|null $beginDate
+     * @param \DateTime $endDate
+     */
     protected function calculateTimings($type, $beginDate, $endDate)
     {
         $params = [];
@@ -105,7 +108,7 @@ 
      * Timings offset by timezone if necessary.
      *
      * @param array $timingsDates
-     * @param $format
+     * @param string $format
      *
      * @return array
      */

DependencyInjection/Compiler/WorkerCompilerPass.php

Doc Comments +8 added lines, -1 removed lines

@@ -54,6 +54,9 @@ 
         $this->addLiveJobs($container);
     }
 
+    /**
+     * @param string $type
+     */
     protected function setupAlias(ContainerBuilder $container, $defaultManagerType, $type)
     {
         $definitionName = 'dtc_queue.'.$type.'.'.$defaultManagerType;
@@ -84,7 +87,6 @@ 
 
     /**
      * @param ContainerBuilder $container
-     * @param Reference[]      $jobManagerRef
      * @param string           $jobClass
      */
     protected function setupTaggedServices(ContainerBuilder $container, Definition $definition, $jobClass)
@@ -212,6 +214,11 @@ 
         return $managerType;
     }
 
+    /**
+     * @param string $managerType
+     * @param string $type
+     * @param string $className
+     */
     protected function getClass(ContainerBuilder $container, $managerType, $type, $className, $baseClass)
     {
         $runClass = $container->hasParameter('dtc_queue.class_'.$type) ? $container->getParameter('dtc_queue.class_'.$type) : null;

ODM/JobManager.php

Doc Comments +9 added lines

@@ -365,6 +365,10 @@ 
         return $workersMethods;
     }
 
+    /**
+     * @param string $workerName
+     * @param string $methodName
+     */
     public function countLiveJobs($workerName = null, $methodName = null)
     {
         /** @var DocumentManager $objectManager */
@@ -378,6 +382,11 @@ 
         return $builder->getQuery()->count();
     }
 
+    /**
+     * @param string $workerName
+     * @param string $methodName
+     * @param \Closure $progressCallback
+     */
     public function archiveAllJobs($workerName = null, $methodName = null, $progressCallback)
     {
         /** @var DocumentManager $documentManager */

ORM/JobManager.php

Doc Comments +17 added lines, -3 removed lines

@@ -242,6 +242,7 @@ 
      * @param string $workerName
      * @param string $methodName
      * @param bool   $prioritize
+     * @param integer $runId
      *
      * @return Job|null
      */
@@ -268,8 +269,8 @@ 
     }
 
     /**
-     * @param null $workerName
-     * @param null $methodName
+     * @param string|null $workerName
+     * @param string|null $methodName
      * @param bool $prioritize
      *
      * @return QueryBuilder
@@ -346,7 +347,7 @@ 
      *
      * @param \Dtc\QueueBundle\Model\Job $job
      *
-     * @return mixed|null
+     * @return null|Job
      */
     public function updateNearestBatch(\Dtc\QueueBundle\Model\Job $job)
     {
@@ -375,6 +376,10 @@ 
         return $existingJob;
     }
 
+    /**
+     * @param integer $newPriority
+     * @param null|\DateTime $newWhenAt
+     */
     protected function updateBatchJob(Job $existingJob, $newPriority, $newWhenAt)
     {
         $existingPriority = $existingJob->getPriority();
@@ -426,6 +431,10 @@ 
         return $workerMethods;
     }
 
+    /**
+     * @param string $workerName
+     * @param string $methodName
+     */
     public function countLiveJobs($workerName = null, $methodName = null)
     {
         /** @var EntityRepository $repository */
@@ -438,6 +447,11 @@ 
         return $queryBuilder->getQuery()->getSingleScalarResult();
     }
 
+    /**
+     * @param string $workerName
+     * @param string $methodName
+     * @param \Closure $progressCallback
+     */
     public function archiveAllJobs($workerName = null, $methodName = null, $progressCallback)
     {
         // First mark all Live non-running jobs as Archive

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use Doctrine\ORM\EntityManager;
 use Doctrine\ORM\EntityRepository;
-use Doctrine\ORM\Query;
 use Doctrine\ORM\QueryBuilder;
 use Dtc\QueueBundle\Doctrine\BaseJobManager;
 use Dtc\QueueBundle\Entity\Job;

ORM/LiveJobsGridSource.php

Doc Comments +3 added lines

@@ -35,6 +35,9 @@
         return parent::getColumns();
     }
 
+    /**
+     * @param boolean $flag
+     */
     public function setRunning($flag)
     {
         $this->running = $flag;

Indentation +2 added lines, -2 removed lines

@@ -54,7 +54,7 @@ 
         $queryBuilder->where('j.status = :status')->setParameter(':status', BaseJob::STATUS_RUNNING);
         $queryBuilder->orderBy('j.startedAt', 'DESC');
         $queryBuilder->setFirstResult($this->offset)
-                     ->setMaxResults($this->limit);
+                        ->setMaxResults($this->limit);
 
         return $queryBuilder;
     }
@@ -68,7 +68,7 @@ 
         $queryBuilder = $this->jobManager->getJobQueryBuilder();
         $queryBuilder->add('select', 'j');
         $queryBuilder->setFirstResult($this->offset)
-                     ->setMaxResults($this->limit);
+                        ->setMaxResults($this->limit);
 
         return $queryBuilder;
     }

Controller/QueueController.php

Spacing +2 added lines, -2 removed lines

@@ -60,13 +60,13 @@
         $methodName = $request->get('method');
 
         $jobManager = $this->get('dtc_queue.job_manager');
-        $callback = function ($count) {
+        $callback = function($count) {
             echo json_encode(['count' => $count]);
             echo "\n";
             flush();
         };
 
-        return new StreamedResponse(function () use ($jobManager, $callback, $workerName, $methodName) {
+        return new StreamedResponse(function() use ($jobManager, $callback, $workerName, $methodName) {
             $total = $jobManager->countLiveJobs($workerName, $methodName);
             echo json_encode(['total' => $total]);
             echo "\n";

Tests/StaticJobManager.php

Spacing +1 added lines, -1 removed lines

@@ -36,7 +36,7 @@
             $total += count($this->jobs[$jobWorkerName]);
         }
 
-        return array_sum(array_map(function ($jobs) {
+        return array_sum(array_map(function($jobs) {
             return count($jobs);
         }, $this->jobs));
     }

Tests/Doctrine/BaseJobManagerTest.php

Spacing +1 added lines, -1 removed lines

@@ -286,7 +286,7 @@
         self::assertEquals(1, $count);
         $allCount = $this->runCountQuery($jobManager->getJobClass());
         $counter = 0;
-        $countJobs = function ($count) use (&$counter) {
+        $countJobs = function($count) use (&$counter) {
             $counter += $count;
         };
         $jobManager->archiveAllJobs(null, null, $countJobs);