LiveJobsGridSource::autoDiscoverColumns() - Code Metrics - Inspection of "fix a bug in LiveJobsGridSource, added more tests" - mmucklo/DtcQueueBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5fe2ea...bba9f0 )

by Matthew

created 2017-12-17 23:52 UTC

LiveJobsGridSource::autoDiscoverColumns() A

↳ Parent: LiveJobsGridSource

Complexity

Conditions	4
Paths	4

Size

Total Lines	11
Code Lines	6

Duplication

Lines	11
Ratio	100 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes

Metric	Value
dl	11
loc	11
ccs	0
cts	11
cp	0
rs	9.2
c	0
b	0
f	0
cc	4
eloc	6
nc	4
nop	0
crap	20

<?php

namespace Dtc\QueueBundle\ORM;

use Doctrine\ORM\EntityManager;
use Dtc\GridBundle\Grid\Column\GridColumn;
use Dtc\GridBundle\Grid\Source\EntityGridSource;
use Dtc\QueueBundle\Model\BaseJob;

class LiveJobsGridSource extends EntityGridSource
{
    protected $jobManager;
    protected $running = false;

    public function getId()
    {
        return 'dtc_queue.grid_source.jobs_'.($this->isRunning() ? 'running' : 'waiting').'.orm';
    }

    public function __construct(JobManager $jobManager)
    {
        $this->jobManager = $jobManager;
        /** @var EntityManager $entityManager */
        $entityManager = $jobManager->getObjectManager();
        parent::__construct($entityManager, $jobManager->getJobClass());
    }

    public function getColumns()
    {
        if ($columns = parent::getColumns()) {
            return $columns;
        }
        $this->autoDiscoverColumns();

        return parent::getColumns();
    }

    public function setRunning($flag)
    {
        $this->running = $flag;
    }

    public function isRunning()
    {
        return $this->running;
    }

    protected function getRunningQueryBuilder()
    {
        /** @var EntityManager $entityManager */
        $entityManager = $this->jobManager->getObjectManager();
        $queryBuilder = $entityManager->createQueryBuilder()->add('select', 'j');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $queryBuilder->from($this->jobManager->getJobClass(), 'j');
        $queryBuilder->where('j.status = :status')->setParameter(':status', BaseJob::STATUS_RUNNING);
        $queryBuilder->orderBy('j.startedAt', 'DESC');
        $queryBuilder->setFirstResult($this->offset)
                     ->setMaxResults($this->limit);

        return $queryBuilder;
    }

    protected function getQueryBuilder()

    {
        if ($this->isRunning()) {
            return $this->getRunningQueryBuilder();
        }

        $queryBuilder = $this->jobManager->getJobQueryBuilder();
        $queryBuilder->add('select', 'j');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $queryBuilder->setFirstResult($this->offset)
                     ->setMaxResults($this->limit);

        return $queryBuilder;
    }

    public function autoDiscoverColumns()

    {
        parent::autoDiscoverColumns();
        if ($this->columns) {

            foreach ($this->columns as $column) {
                if ($column instanceof GridColumn) {
                    $column->setOption('sortable', false);
                }
            }
        }
    }

    public function getDefaultSort()
    {
        return null;
    }

    public function getCount()
    {
        $qb = $this->getQueryBuilder();
        $qb->add('select', 'count(j)')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ->setFirstResult(null)
            ->setMaxResults(null);

        return $qb->getQuery()
            ->getSingleScalarResult();
    }
}


1		<?php
2
3		namespace Dtc\QueueBundle\ORM;
4
5		use Doctrine\ORM\EntityManager;
6		use Dtc\GridBundle\Grid\Column\GridColumn;
7		use Dtc\GridBundle\Grid\Source\EntityGridSource;
8		use Dtc\QueueBundle\Model\BaseJob;
9
10		class LiveJobsGridSource extends EntityGridSource
11		{
12		protected $jobManager;
13		protected $running = false;
14
15		public function getId()
16		{
17		return 'dtc_queue.grid_source.jobs_'.($this->isRunning() ? 'running' : 'waiting').'.orm';
18		}
19
20		public function __construct(JobManager $jobManager)
21		{
22		$this->jobManager = $jobManager;
23		/** @var EntityManager $entityManager */
24		$entityManager = $jobManager->getObjectManager();
25		parent::__construct($entityManager, $jobManager->getJobClass());
26		}
27
28		public function getColumns()
29		{
30		if ($columns = parent::getColumns()) {
31		return $columns;
32		}
33		$this->autoDiscoverColumns();
34
35		return parent::getColumns();
36		}
37
38		public function setRunning($flag)
39		{
40		$this->running = $flag;
41		}
42
43		public function isRunning()
44		{
45		return $this->running;
46		}
47
48		protected function getRunningQueryBuilder()
49		{
50		/** @var EntityManager $entityManager */
51		$entityManager = $this->jobManager->getObjectManager();
52		$queryBuilder = $entityManager->createQueryBuilder()->add('select', 'j');
		0 ignored issues – show Documentation introduced 2017-12-18 00:05 UTC by Report Bug Copy Issue Report `'j'` is of type `string`, but the function expects a `object<Doctrine\ORM\Query\Expr\Base>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
53		$queryBuilder->from($this->jobManager->getJobClass(), 'j');
54		$queryBuilder->where('j.status = :status')->setParameter(':status', BaseJob::STATUS_RUNNING);
55		$queryBuilder->orderBy('j.startedAt', 'DESC');
56		$queryBuilder->setFirstResult($this->offset)
57		->setMaxResults($this->limit);
58
59		return $queryBuilder;
60		}
61
62	View Code Duplication	protected function getQueryBuilder()
		0 ignored issues – show Duplication introduced 2017-12-18 00:05 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
63		{
64		if ($this->isRunning()) {
65		return $this->getRunningQueryBuilder();
66		}
67
68		$queryBuilder = $this->jobManager->getJobQueryBuilder();
69		$queryBuilder->add('select', 'j');
		0 ignored issues – show Documentation introduced 2017-12-06 08:28 UTC by Report Bug Copy Issue Report `'j'` is of type `string`, but the function expects a `object<Doctrine\ORM\Query\Expr\Base>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
70		$queryBuilder->setFirstResult($this->offset)
71		->setMaxResults($this->limit);
72
73		return $queryBuilder;
74		}
75
76	View Code Duplication	public function autoDiscoverColumns()
		0 ignored issues – show Duplication introduced 2017-12-18 00:05 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
77		{
78		parent::autoDiscoverColumns();
79		if ($this->columns) {
		0 ignored issues – show Bug Best Practice introduced 2017-12-18 00:05 UTC by Report Bug Copy Issue Report The expression `$this->columns` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
80		foreach ($this->columns as $column) {
81		if ($column instanceof GridColumn) {
82		$column->setOption('sortable', false);
83		}
84		}
85		}
86		}
87
88		public function getDefaultSort()
89		{
90		return null;
91		}
92
93		public function getCount()
94		{
95		$qb = $this->getQueryBuilder();
96		$qb->add('select', 'count(j)')
		0 ignored issues – show Documentation introduced 2017-12-05 17:25 UTC by Report Bug Copy Issue Report `'count(j)'` is of type `string`, but the function expects a `object<Doctrine\ORM\Query\Expr\Base>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
97		->setFirstResult(null)
98		->setMaxResults(null);
99
100		return $qb->getQuery()
101		->getSingleScalarResult();
102		}
103		}
104

mmucklo / DtcQueueBundle

Push — master ( 5fe2ea...bba9f0 )

LiveJobsGridSource::autoDiscoverColumns() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like