mmucklo / DtcQueueBundle

Command/CreateJobCommand.php

Unused Use Statements -2 removed lines

@@ -2,11 +2,9 @@
 namespace Dtc\QueueBundle\Command;
 
 use Dtc\QueueBundle\Documents\Job;
-
 use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
-use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
 
 class CreateJobCommand

Command/PruneCommand.php

Unused Use Statements -2 removed lines

@@ -2,9 +2,7 @@
 namespace Dtc\QueueBundle\Command;
 
 use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
-use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
-use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
 
 class PruneCommand

Controller/QueueController.php

Unused Use Statements -3 removed lines

@@ -3,10 +3,7 @@
 
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
-
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
-use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\HttpFoundation\Request;
 
 class QueueController
     extends Controller

Documents/JobManager.php

Doc Comments +3 added lines

@@ -11,6 +11,9 @@
     protected $dm;
     protected $documentName;
 
+    /**
+     * @param string $documentName
+     */
     public function __construct(DocumentManager $dm, $documentName)
     {
         $this->dm = $dm;

Braces +1 added lines, -2 removed lines

@@ -179,8 +179,7 @@
 
         if ($prioritize) {
             $qb->sort('priority', 'asc');
-        }
-        else {
+        } else {
             $qb->sort('when', 'asc');
         }
 

RabbitMQ/JobManager.php

Doc Comments +3 added lines

@@ -33,6 +33,9 @@
         return $job;
     }
 
+    /**
+     * @param string $workerName
+     */
     public function getJob($workerName = null, $methodName = null, $prioritize = true)
     {
         if ($methodName) {

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 
 use Dtc\QueueBundle\Model\Job as BaseJob;
 use Dtc\QueueBundle\Model\JobManagerInterface;
-
 use PhpAmqpLib\Connection\AMQPConnection;
 use PhpAmqpLib\Message\AMQPMessage;
 

Spacing +2 added lines, -2 removed lines

@@ -15,12 +15,12 @@
 
     public function __construct(AMQPConnection $connection) {
         $this->connection = $connection;
-        $this->channel = $connection->channel();;
+        $this->channel = $connection->channel(); ;
     }
 
     public function save($job) {
         $queue = $job->getWorkerName();
-        $exchange = null; 	// User default exchange
+        $exchange = null; // User default exchange
 
         $this->channel->queue_declare($queue, false, true, false, false);
         $this->channel->exchange_declare($exchange, 'direct', false, true, false);

Braces +1 added lines, -2 removed lines

@@ -57,8 +57,7 @@
         if ($job->getStatus() === BaseJob::STATUS_SUCCESS) {
             $this->beanstalkd
                 ->delete($job);
-        }
-        else {
+        } else {
             $this->beanstalkd
                 ->bury($job);
         }

Tests/Model/BaseJobManagerTest.php

Unused Use Statements -3 removed lines

@@ -2,9 +2,6 @@
 namespace Dtc\QueueBundle\Tests\Model;
 
 use Dtc\QueueBundle\Model\Job;
-use Dtc\QueueBundle\Tests\FibonacciWorker;
-use Dtc\QueueBundle\Tests\StaticJobManager;
-use Dtc\QueueBundle\Model\WorkerManager;
 
 class BaseJobManagerTest
     extends \PHPUnit_Framework_TestCase

Spacing +1 added lines, -1 removed lines

@@ -83,7 +83,7 @@
     public function testPerformance() {
         $start = microtime(true);
         $jobsTotal = 1000;
-        self::$jobManager->enableSorting = false;	// Ignore priority
+        self::$jobManager->enableSorting = false; // Ignore priority
 
         for ($i = 0; $i < $jobsTotal; $i++) {
             self::$worker->later()->fibonacci(1);

Tests/Model/JobTest.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 use Dtc\QueueBundle\Model\Job;
 use Dtc\QueueBundle\Tests\FibonacciWorker;
 use Dtc\QueueBundle\Tests\StaticJobManager;
-use Dtc\QueueBundle\Model\WorkerManager;
 
 class JobTest
     extends \PHPUnit_Framework_TestCase

Spacing +1 added lines, -1 removed lines

@@ -13,7 +13,7 @@
         $worker = new FibonacciWorker();
         $job = new Job($worker, false, null);
         $job->setArgs(array(1));
-        $job->setArgs(array(1, array(1,2)));
+        $job->setArgs(array(1, array(1, 2)));
 
         try {
             $job->setArgs(array($job));

Tests/Model/WorkerTest.php

Doc Comments +5 added lines

@@ -104,6 +104,11 @@
         }
     }
 
+    /**
+     * @param integer|null $time
+     * @param string $method
+     * @param integer $priority
+     */
     protected function assertJob(Job $job, $time, $method, $priority = null) {
         $this->assertNotEmpty($job->getId(), "Job should have an id");
 

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 use Dtc\QueueBundle\Model\Job;
 use Dtc\QueueBundle\Tests\FibonacciWorker;
 use Dtc\QueueBundle\Tests\StaticJobManager;
-use Dtc\QueueBundle\Model\WorkerManager;
 
 class WorkerTest
     extends \PHPUnit_Framework_TestCase

Braces +1 added lines, -2 removed lines

@@ -115,8 +115,7 @@
         if ($priority) {
             $this->assertEquals($priority, $job->getPriority(),
                     "Priority should be the same.");
-        }
-        else {
+        } else {
             $this->assertNull($job->getPriority(), "Priority should be null");
         }
 

Tests/RabbitMQ/JobManager.php

Unused Use Statements -5 removed lines

@@ -3,14 +3,9 @@
 
 use Dtc\QueueBundle\RabbitMQ\JobManager;
 use Dtc\QueueBundle\Model\Job;
-use Dtc\QueueBundle\Model\WorkerManager;
-
 use Dtc\QueueBundle\Tests\FibonacciWorker;
-use Dtc\QueueBundle\Tests\StaticJobManager;
 use Dtc\QueueBundle\Tests\Model\BaseJobManagerTest;
-
 use PhpAmqpLib\Connection\AMQPConnection;
-use PhpAmqpLib\Message\AMQPMessage;
 
 /**
  * @author David