mmikkel\cpfieldinspect\controllers\DefaultController::actionGetRedirectHash()

Complexity

Conditions	4
Paths	5

Size

Total Lines	21
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function actionGetRedirectHash(): Response
    {
        $this->requireCpRequest();
        $this->requirePostRequest();
        $url = Craft::$app->getRequest()->getRequiredBodyParam('url');
        $path = \parse_url($url, PHP_URL_PATH);

It seems like $url can also be of type array and array; however, parameter $url of parse_url() does only seem to accept string, maybe add an additional type check?

        if (!$path) {
            throw new BadRequestHttpException('Invalid URL');
        }
        $segments = \array_values(\array_filter(\explode('/', $path)));
        $cpTrigger = Craft::$app->getConfig()->getGeneral()->cpTrigger;
        if ($segments[0] === $cpTrigger) {
            \array_shift($segments);
        }
        $redirectTo = \implode('/', $segments);
        $queryString = \parse_url($url, PHP_URL_QUERY);
        if ($queryString) {
            $redirectTo .= "?{$queryString}";
        }
        return $this->asJson([

The expression return $this->asJson(array('data' => Craft::app->getSecurity()->hashData($redirectTo))) returns the type yii\web\Response which includes types incompatible with the type-hinted return craft\web\Response.

            'data' => Craft::$app->getSecurity()->hashData($redirectTo),
        ]);