mmikkel\cpfieldinspect\controllers\DefaultController

Complexity

Total Complexity

4

Size/Duplication

Total Lines	29
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	actionGetRedirectHash()	0	21	4

<?php

namespace mmikkel\cpfieldinspect\controllers;

use Craft;
use craft\web\Controller;
use craft\web\Response;

use yii\web\BadRequestHttpException;

class DefaultController extends Controller
{

    /**
     * @return string
     * @throws \yii\base\Exception
     * @throws \yii\base\InvalidConfigException
     */
    public function actionGetRedirectHash(): Response
    {
        $this->requireCpRequest();
        $this->requirePostRequest();
        $url = Craft::$app->getRequest()->getRequiredBodyParam('url');
        $path = \parse_url($url, PHP_URL_PATH);

It seems like $url can also be of type array and array; however, parameter $url of parse_url() does only seem to accept string, maybe add an additional type check?

        if (!$path) {
            throw new BadRequestHttpException('Invalid URL');
        }
        $segments = \array_values(\array_filter(\explode('/', $path)));
        $cpTrigger = Craft::$app->getConfig()->getGeneral()->cpTrigger;
        if ($segments[0] === $cpTrigger) {
            \array_shift($segments);
        }
        $redirectTo = \implode('/', $segments);
        $queryString = \parse_url($url, PHP_URL_QUERY);
        if ($queryString) {
            $redirectTo .= "?{$queryString}";
        }
        return $this->asJson([

The expression return $this->asJson(array('data' => Craft::app->getSecurity()->hashData($redirectTo))) returns the type yii\web\Response which includes types incompatible with the type-hinted return craft\web\Response.

            'data' => Craft::$app->getSecurity()->hashData($redirectTo),
        ]);
    }

}