AframeVR\Core\Assets\Mixin

Complexity

Total Complexity

13

Size/Duplication

Total Lines	167
Duplicated Lines	14.37 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	component()	14	14	3
A	__call()	10	11	2
A	color()	0	7	1
A	metalness()	0	7	1
A	roughness()	0	7	1
A	src()	0	7	1
A	translate()	0	5	1
A	shader()	0	5	1
A	opacity()	0	5	1
A	transparent()	0	5	1

<?php
/** @formatter:off
 * ******************************************************************
 * Created by   Marko Kungla on Jun 20, 2016 - 9:12:11 PM
 * Contact      marko@okramlabs.com
 * @copyright   2016 Marko Kungla - https://github.com/mkungla
 * @license     The MIT License (MIT)
 * 
 * @category       AframeVR
 * @package        aframe-php
 * 
 * Lang         PHP (php version >= 7)
 * Encoding     UTF-8
 * File         Mixin.php
 * Code format  PSR-2 and 12
 * @link        https://github.com/mkungla/aframe-php
 * @issues      https://github.com/mkungla/aframe-php/issues
 * ********************************************************************
 * Contributors:
 * @author Marko Kungla <marko@okramlabs.com>
 * ********************************************************************
 * Comments:
 * @formatter:on */
namespace AframeVR\Core\Assets;

use \AframeVR\Core\Exceptions\BadComponentCallException;
use \AframeVR\Interfaces\Core\Assets\MixinInterface;
use \AframeVR\Core\Helpers\AssetsAbstract;
use \Closure;

final class Mixin extends AssetsAbstract implements MixinInterface
{

    /**
     * DOM tag name of asset item
     *
     * @var string
     */
    protected $element_tag = 'a-mixin';
    
    /**
     * Array of mocked components
     *
     * @var array
     */
    protected $components = array();

    /**
     * Load component for this entity
     *
     * @param string $component_name            
     * @throws \AframeVR\Core\Exceptions\BadComponentCallException
     * @return object|null
     */
    public function component(string $component_name)

This method seems to be duplicated in your project.

    {
        if (! array_key_exists($component_name, $this->components)) {
            $component = sprintf('\AframeVR\Core\Components\%s\%sComponent', ucfirst($component_name), 
                ucfirst($component_name));
            if (class_exists($component)) {
                $this->components[$component_name] = new $component();
            } else {
                throw new BadComponentCallException($component_name);
            }
        }
        
        return $this->components[$component_name] ?? null;
    }
    
    /**
     * Handle entity components
     *
     * Since we might need to customize these to have
     * custom components loaded as $this->methosd aswell therefore
     * we have these placeholder magic methods here
     *
     * @param string $component_name            
     * @param array $args            
     */
    public function __call(string $component_name, array $args)

This method seems to be duplicated in your project.

    {
        if (! method_exists($this, $component_name)) {
            $this->{$component_name} = Closure::bind(
                function () use ($component_name) {
                    return $this->component($component_name);
                }, $this, get_class());
        }
        
        return call_user_func($this->{$component_name}, $args);
    }
    
    /**
     * material.color
     *
     * @param string $color
     * @return EntityInterface

Should the return type not be Mixin?

     */
    public function color(string $color = 'gray')
    {
        $this->component('Material')
        ->shader()
        ->color($color);
        return $this;
    }
    
    /**
     * material.metalness
     *
     * @param int|float $metalness
     * @return EntityInterface

Should the return type not be Mixin?

     */
    public function metalness(float $metalness = 0)
    {
        $this->component('Material')
        ->shader()
        ->metalness($metalness);
        return $this;
    }
    
    /**
     * material.roughness
     *
     * @param float $roughness
     * @return EntityInterface

Should the return type not be Mixin?

     */
    public function roughness(float $roughness = 0.5)
    {
        $this->component('Material')
        ->shader()
        ->roughness($roughness);
        return $this;
    }
    
    /**
     * material.src
     *
     * @param null|string $src
     * @return EntityInterface

Should the return type not be Mixin?

     */
    public function src(string $src = null)
    {
        $this->component('Material')
        ->shader()
        ->src($src);
        return $this;
    }
    
    /**
     * geometry.translate
     *
     * @param int|float $x
     * @param int|float $y
     * @param int|float $z
     * @return EntityInterface

Should the return type not be Mixin?

     */
    public function translate(float $x = 0, float $y = 0, float $z = 0)
    {
        $this->component('Geometry')->translate($x, $y, $z);
        return $this;
    }
    
    /**
     * material.shader
     *
     * @param string $shader
     * @return EntityInterface

Should the return type not be Mixin?

     */
    public function shader($shader = 'standard')
    {
        $this->component('Material')->shader($shader);
        return $this;
    }
    
    /**
     * material.opacity
     *
     * @param float $opacity
     * @return EntityInterface

Should the return type not be Mixin?

     */
    public function opacity(float $opacity = 1.0)
    {
        $this->component('Material')->opacity($opacity);
        return $this;
    }
    
    /**
     * material.transparent
     *
     * @param bool $transparent
     * @return EntityInterface

Should the return type not be Mixin?

     */
    public function transparent(bool $transparent = false)
    {
        $this->component('Material')->transparent($transparent);
        return $this;
    }
}