mikekamornikov / UpgradeSpec

src/Cache/Cache.php

Doc Comments +3 added lines, -3 removed lines

@@ -23,7 +23,7 @@ 
     }
 
     /**
-     * @param $key
+     * @param string $key
      *
      * @return bool
      */
@@ -37,7 +37,7 @@ 
     }
 
     /**
-     * @param $key
+     * @param string $key
      * @param null $default
      *
      * @return mixed
@@ -56,7 +56,7 @@ 
     }
 
     /**
-     * @param $key
+     * @param string $key
      * @param $value
      * @param null $ttl
      *

src/Data/Manager.php

Doc Comments +3 added lines, -3 removed lines

@@ -43,7 +43,7 @@ 
      *
      * Examples: 7.6.1 -> 7.6.1.0, 7.7 -> 7.7.1, 7.8 -> 7.8.0.0
      *
-     * @param $flav
+     * @param string $flav
      * @param null $baseVersion
      *
      * @return mixed
@@ -99,7 +99,7 @@ 
     /**
      * Gets all required information to perform health check.
      *
-     * @param $version
+     * @param string $version
      *
      * @return mixed
      */
@@ -111,7 +111,7 @@ 
     /**
      * Gets all required information to perform upgrade.
      *
-     * @param $version
+     * @param string $version
      *
      * @return mixed
      */

Spacing +1 added lines, -1 removed lines

@@ -71,7 +71,7 @@
          * all versions with $baseVersion base
          * for example: 7.6.1 -> [7.6.1.0, 7.6.1.1], 7.6 -> [7.6.1.0, 7.6.1.1, 7.6.2].
          */
-        $minors = array_filter($versions, function ($minor) use ($baseVersion) {
+        $minors = array_filter($versions, function($minor) use ($baseVersion) {
             return implode('.', array_slice(explode('.', $minor), 0, count(explode('.', $baseVersion)))) === $baseVersion;
         });
 

src/Data/Provider/Memory.php

Doc Comments +1 added lines, -1 removed lines

@@ -68,7 +68,7 @@
     /**
      * Gets data from memory by key.
      *
-     * @param $key
+     * @param string $key
      * @param null $default
      *
      * @return mixed|null

Spacing +1 added lines, -1 removed lines

@@ -36,7 +36,7 @@
      */
     public function getReleaseNotes($flav, array $versions)
     {
-        return array_map(function ($version) use ($flav) {
+        return array_map(function($version) use ($flav) {
             return $this->get(sprintf('%s_%s_release_notes', $flav, $version), '');
         }, $versions);
     }

src/Element/Section/UpgradeChanges.php

Doc Comments +5 added lines, -6 removed lines

@@ -54,8 +54,7 @@ 
     /**
      * Get all available SugarCRM versions (sorted ASC).
      *
-     * @param mixed $flav
-     * @param mixed $pathToUpgradePackage
+     * @param Context $pathToUpgradePackage
      *
      * @return mixed
      */
@@ -75,7 +74,7 @@ 
      *
      * @param string $pathToUpgradePackage
      *
-     * @return mixed
+     * @return string
      */
     public function getListOfDeletedFiles($pathToUpgradePackage)
     {
@@ -87,7 +86,7 @@ 
      *
      * @param string $pathToUpgradePackage
      *
-     * @return mixed
+     * @return string
      */
     public function getListOfModifiedFiles($pathToUpgradePackage)
     {
@@ -99,7 +98,7 @@ 
      *
      * @param string $pathToUpgradePackage
      *
-     * @return mixed
+     * @return string
      */
     public function getListOfScripts($pathToUpgradePackage)
     {
@@ -111,7 +110,7 @@ 
      *
      * @param string $pathToUpgradePackage
      *
-     * @return mixed
+     * @return string
      */
     public function getListOfSQLScripts($pathToUpgradePackage)
     {

src/Purifier/Html.php

Spacing +3 added lines, -3 removed lines

@@ -84,7 +84,7 @@ 
         $path = parse_url($base, PHP_URL_PATH);
         $scheme = parse_url($base, PHP_URL_SCHEME);
 
-        return preg_replace_callback($pattern, function ($matches) use ($base, $scheme, $host, $path) {
+        return preg_replace_callback($pattern, function($matches) use ($base, $scheme, $host, $path) {
             $hrefValue = $matches[0];
 
             if (mb_strpos($hrefValue, '//') === 0) {
@@ -149,7 +149,7 @@ 
     private function convertCode($content)
     {
         // strpos with array support
-        $strposa = function ($haystack, $needles = []) {
+        $strposa = function($haystack, $needles = []) {
             $chr = [];
             foreach ($needles as $needle) {
                 $res = mb_strpos($haystack, $needle);
@@ -167,7 +167,7 @@ 
 
         $content = str_replace(['<pre>', '<pre ', '</pre>'], ['<code>', '<code ', '</code>'], $content);
 
-        return preg_replace_callback('/<code(.*?)>(.*?)<\/code>/s', function ($matches) use ($strposa) {
+        return preg_replace_callback('/<code(.*?)>(.*?)<\/code>/s', function($matches) use ($strposa) {
             $noLineBreaks = str_replace(["\r\n", "\r", "\n"], '<br />', $matches[0]);
             $code = str_replace(['<br></br>', '<br>', '<br/>', '<br />'], PHP_EOL, $noLineBreaks);
 

src/Spec/Generator.php

Spacing +1 added lines, -1 removed lines

@@ -56,7 +56,7 @@
             $title = $this->formatter->asTitle(sprintf('SugarCRM upgrade: %s', $context)) . $delimiter;
 
             return $title . implode($delimiter, array_map(
-                function ($element) use ($context) {
+                function($element) use ($context) {
                     return $this->elementGenerator->generate($element, $context);
                 },
                 $elements

src/Data/Provider/SupportSugarcrm.php

Spacing +8 added lines, -8 removed lines

@@ -73,7 +73,7 @@ 
         }
 
         // sort versions (ASC)
-        usort($versions, function ($v1, $v2) {
+        usort($versions, function($v1, $v2) {
             return version_compare($v1, $v2, '<') ? -1 : (version_compare($v1, $v2, '>') ? 1 : 0);
         });
 
@@ -90,13 +90,13 @@ 
      */
     public function getReleaseNotes($flav, array $versions)
     {
-        $newVersions = array_filter($versions, function ($version) use ($flav) {
+        $newVersions = array_filter($versions, function($version) use ($flav) {
             return !$this->cache->has($this->getCacheKey([$flav, 'release_notes', $version]));
         });
 
-        $requests = function () use ($flav, $newVersions) {
+        $requests = function() use ($flav, $newVersions) {
             foreach ($newVersions as $version) {
-                yield $version => function () use ($flav, $version) {
+                yield $version => function() use ($flav, $version) {
                     return $this->httpClient->getAsync($this->getReleaseNotesUri($flav, $version));
                 };
             }
@@ -104,7 +104,7 @@ 
 
         if ($newVersions) {
             $this->processRequestPool($requests, [
-                'fulfilled' => function (ResponseInterface $response, $version) use ($flav) {
+                'fulfilled' => function(ResponseInterface $response, $version) use ($flav) {
                     $html = $response->getBody()->getContents();
                     $crawler = new Crawler($this->purifyHtml($html, $this->getReleaseNotesUri($flav, $version)));
 
@@ -134,7 +134,7 @@ 
 
                     $this->cache->set($this->getCacheKey([$flav, 'release_notes', $version]), $releaseNote);
                 },
-                'rejected' => function ($reason, $version) {
+                'rejected' => function($reason, $version) {
                     throw new \RuntimeException(
                         sprintf('Can\'t get release notes for version: %s (reason: %s)', $version, $reason)
                     );
@@ -150,7 +150,7 @@ 
             }
         }
 
-        uksort($releaseNotes, function ($v1, $v2) {
+        uksort($releaseNotes, function($v1, $v2) {
             return version_compare($v1, $v2, '<') ? -1 : (version_compare($v1, $v2, '>') ? 1 : 0);
         });
 
@@ -319,7 +319,7 @@ 
     {
         $delimiter = '___';
 
-        return implode($delimiter, array_map(function ($key) {
+        return implode($delimiter, array_map(function($key) {
             return preg_replace('/[^a-zA-Z0-9_\.]+/', '', mb_strtolower($key));
         }, $keyParts));
     }

Doc Comments +5 added lines, -5 removed lines

@@ -223,7 +223,7 @@ 
     /**
      * Returns the result (response body) of GET request.
      *
-     * @param $url
+     * @param string $url
      *
      * @return string
      */
@@ -235,7 +235,7 @@ 
     }
 
     /**
-     * @param $version
+     * @param string $version
      *
      * @return string
      */
@@ -245,7 +245,7 @@ 
     }
 
     /**
-     * @param $version
+     * @param string $version
      *
      * @return string
      */
@@ -315,7 +315,7 @@ 
      *
      * @param $keyParts
      *
-     * @return mixed
+     * @return string
      */
     private function getCacheKey(array $keyParts)
     {
@@ -329,7 +329,7 @@ 
     /**
      * Lightweight HTML purifier.
      *
-     * @param $html
+     * @param string $html
      * @param string $url
      * @param array  $options
      *

src/autoload.php

Spacing +2 added lines, -2 removed lines

@@ -3,8 +3,8 @@
 // application or vendor context
 $autoload = [
     __DIR__ . '/../vendor/autoload.php', // application bin or phar
-    __DIR__ . '/../autoload.php',        // vendor bin
-    __DIR__ . '/../../../autoload.php',  // vendor
+    __DIR__ . '/../autoload.php', // vendor bin
+    __DIR__ . '/../../../autoload.php', // vendor
 ];
 
 foreach ($autoload as $file) {

src/Template/RendererAwareInterface.php

Doc Comments +3 added lines

@@ -4,5 +4,8 @@
 
 interface RendererAwareInterface
 {
+    /**
+     * @return void
+     */
     public function setRenderer(RendererInterface $renderer);
 }