mikekamornikov / UpgradeSpec

src/Context/Upgrade.php

Doc Comments +2 added lines, -2 removed lines

@@ -29,7 +29,7 @@ 
     }
 
     /**
-     * @return Version
+     * @return string
      */
     public function getBuildVersion()
     {
@@ -53,7 +53,7 @@ 
     }
 
     /**
-     * @return Version
+     * @return string
      */
     public function getTargetVersion()
     {

src/Data/Manager.php

Doc Comments +1 added lines, -1 removed lines

@@ -126,7 +126,7 @@
      *
      * @param Upgrade $context
      *
-     * @return mixed
+     * @return Upgrade
      */
     public function getPotentiallyBrokenCustomizations(Upgrade $context)
     {

Spacing +2 added lines, -2 removed lines

@@ -72,7 +72,7 @@ 
          * all versions with $baseVersion base
          * for example: 7.6.1 -> [7.6.1, 7.6.1.0, 7.6.1.1], 7.6 -> [7.6.1.0, 7.6.1.1, 7.6.2].
          */
-        $minors = $versions->filter(function (Version $version) use ($baseVersion) {
+        $minors = $versions->filter(function(Version $version) use ($baseVersion) {
             return $version->isChildOf($baseVersion) || $version->isEqualTo($baseVersion);
         });
 
@@ -157,7 +157,7 @@ 
         $from = (string) $context->getBuildVersion()->getFull();
         $to = (string) $context->getTargetVersion()->getFull();
 
-        return $this->getVersions($context->getBuildFlav())->filter(function (Version $version) use ($from, $to) {
+        return $this->getVersions($context->getBuildFlav())->filter(function(Version $version) use ($from, $to) {
             return version_compare((string) $version, $from, '>')
                 && version_compare((string) $version, $to, '<=');
         });

src/Data/Provider/Doc/SupportSugarcrm.php

Doc Comments +1 added lines, -1 removed lines

@@ -315,7 +315,7 @@
     /**
      * Lightweight HTML purifier.
      *
-     * @param $html
+     * @param string $html
      * @param string $url
      * @param array  $options
      *

Spacing +6 added lines, -6 removed lines

@@ -88,13 +88,13 @@ 
      */
     public function getReleaseNotes($flav, OrderedList $versions)
     {
-        $newVersions = $versions->filter(function (Version $version) use ($flav) {
+        $newVersions = $versions->filter(function(Version $version) use ($flav) {
             return !$this->cache->has($this->getCacheKey([$flav, 'release_notes', (string) $version]));
         });
 
-        $requests = function () use ($flav, $newVersions) {
+        $requests = function() use ($flav, $newVersions) {
             foreach ($newVersions as $version) {
-                yield (string) $version => function () use ($flav, $version) {
+                yield (string) $version => function() use ($flav, $version) {
                     return $this->httpClient->getAsync($this->getReleaseNotesUri($flav, $version));
                 };
             }
@@ -102,7 +102,7 @@ 
 
         if (count($newVersions)) {
             $this->processRequestPool($requests, [
-                'fulfilled' => function (ResponseInterface $response, $version) use ($flav) {
+                'fulfilled' => function(ResponseInterface $response, $version) use ($flav) {
                     $html = $response->getBody()->getContents();
                     $crawler = new Crawler($this->purifyHtml($html, $this->getReleaseNotesUri($flav, new Version($version))));
 
@@ -132,7 +132,7 @@ 
 
                     $this->cache->set($this->getCacheKey([$flav, 'release_notes', $version]), $releaseNote);
                 },
-                'rejected' => function ($reason, $version) {
+                'rejected' => function($reason, $version) {
                     throw new \RuntimeException(
                         sprintf('Can\'t get release notes for version: %s (reason: %s)', $version, $reason)
                     );
@@ -307,7 +307,7 @@ 
     {
         $delimiter = '___';
 
-        return implode($delimiter, array_map(function ($key) {
+        return implode($delimiter, array_map(function($key) {
             return preg_replace('/[^a-zA-Z0-9_\.]+/', '', mb_strtolower($key));
         }, $keyParts));
     }

src/Data/Provider/SourceCode/LocalUpgradePackages.php

Doc Comments +3 added lines, -3 removed lines

@@ -49,7 +49,7 @@ 
     }
 
     /**
-     * @param $buildPath
+     * @param string $buildPath
      * @param $packages
      *
      * @return array
@@ -140,8 +140,8 @@ 
     /**
      * Gets flav specific packages
      *
-     * @param $flav
-     * @param $packagesPath
+     * @param string $flav
+     * @param string $packagesPath
      *
      * @return array
      */

Spacing +4 added lines, -4 removed lines

@@ -81,7 +81,7 @@ 
             $deletedFiles = array_diff(array_merge($deletedFiles, $packageDeletedFiles), $packageModifiedFiles);
         }
 
-        $modifiedFiles = array_keys(array_filter($modifiedFiles, function ($package, $changedFile) use ($buildPath, $packageZips) {
+        $modifiedFiles = array_keys(array_filter($modifiedFiles, function($package, $changedFile) use ($buildPath, $packageZips) {
             if (($buildFile = @file_get_contents($buildPath . DS . $changedFile)) === false) {
                 return false;
             }
@@ -96,11 +96,11 @@ 
             $zip->close();
         }
 
-        $modifiedFiles = array_values(array_filter($modifiedFiles, function ($file) use ($buildPath) {
+        $modifiedFiles = array_values(array_filter($modifiedFiles, function($file) use ($buildPath) {
             return file_exists($buildPath . '/custom/' . $file);
         }));
 
-        $deletedFiles = array_values(array_filter($deletedFiles, function ($file) use ($buildPath) {
+        $deletedFiles = array_values(array_filter($deletedFiles, function($file) use ($buildPath) {
             return file_exists($buildPath . '/custom/' . $file);
         }));
 
@@ -124,7 +124,7 @@ 
         $packages = $this->getFlavPackages($context->getBuildFlav(), $context->getTargetPath());
         $graph = new Graph(new AdjacencyList($packages));
 
-        $this->suitablePackages = array_map(function (array $hop) use ($packages) {
+        $this->suitablePackages = array_map(function(array $hop) use ($packages) {
             foreach ($packages as $path => $pair) {
                 if ((new OrderedList($hop))->isEqualTo(new OrderedList($pair))) {
                     return $path;

src/Version/Graph/Graph.php

Doc Comments +2 added lines, -2 removed lines

@@ -134,7 +134,7 @@ 
     /**
      * @param Version $from
      *
-     * @return OrderedList
+     * @return \Sugarcrm\UpgradeSpec\Version\OrderedList
      */
     private function getOriginVertexes(Version $from)
     {
@@ -152,7 +152,7 @@ 
     /**
      * @param Version $to
      *
-     * @return OrderedList
+     * @return \Sugarcrm\UpgradeSpec\Version\OrderedList
      */
     private function getDestinationVertexes(Version $to)
     {

Spacing +2 added lines, -2 removed lines

@@ -144,7 +144,7 @@ 
             $aliases = $aliases->merge($from->getAliases());
         }
 
-        return $aliases->filter(function (Version $version) {
+        return $aliases->filter(function(Version $version) {
             return isset($this->graph[$version]);
         });
     }
@@ -156,7 +156,7 @@ 
      */
     private function getDestinationVertexes(Version $to)
     {
-        return $to->getAliases()->filter(function (Version $version) {
+        return $to->getAliases()->filter(function(Version $version) {
             return isset($this->graph[$version]);
         });
     }

src/Version/Graph/AdjacencyList.php

Spacing +1 added lines, -1 removed lines

@@ -33,7 +33,7 @@
 
         // add parent edges
         foreach ($versions as $version) {
-            $minorVersions = $versions->filter(function (Version $minorVersion) use ($version) {
+            $minorVersions = $versions->filter(function(Version $minorVersion) use ($version) {
                 return $minorVersion->isChildOf($version);
             });
 

src/Version/OrderedList.php

Spacing +4 added lines, -4 removed lines

@@ -21,7 +21,7 @@ 
         }
 
         // sort versions (jASC)
-        usort($this->versions, function (Version $v1, Version $v2) {
+        usort($this->versions, function(Version $v1, Version $v2) {
             $v1 = (string) $v1->getFull();
             $v2 = (string) $v2->getFull();
 
@@ -48,7 +48,7 @@ 
      */
     public function merge(OrderedList $range, $checkAliases = false)
     {
-        $filtered = $range->filter(function (Version $version) use ($checkAliases) {
+        $filtered = $range->filter(function(Version $version) use ($checkAliases) {
             return !$this->contains($version, $checkAliases);
         });
 
@@ -64,7 +64,7 @@ 
     public function contains(Version $version, $checkAliases = false)
     {
         if ($checkAliases) {
-            return in_array($version->getFull(), $this->map(function (Version $version) {
+            return in_array($version->getFull(), $this->map(function(Version $version) {
                 return $version->getFull();
             }));
         }
@@ -107,7 +107,7 @@ 
     public function isEqualTo(OrderedList $range, $checkAliases = false)
     {
         if ($checkAliases) {
-            $getFull = function (Version $version) {
+            $getFull = function(Version $version) {
                 return $version->getFull();
             };