mikekamornikov / UpgradeSpec

src/Data/Manager.php

Doc Comments +4 added lines, -4 removed lines

@@ -43,7 +43,7 @@ 
      *
      * Examples: 7.6.1 -> 7.6.1.0, 7.7 -> 7.7.1, 7.8 -> 7.8.0.0
      *
-     * @param $flav
+     * @param string $flav
      * @param null $baseVersion
      *
      * @return mixed
@@ -99,7 +99,7 @@ 
     /**
      * Gets all required information to perform health check.
      *
-     * @param $version
+     * @param string $version
      *
      * @return mixed
      */
@@ -111,7 +111,7 @@ 
     /**
      * Gets all required information to perform upgrade.
      *
-     * @param $version
+     * @param string $version
      *
      * @return mixed
      */
@@ -125,7 +125,7 @@ 
      *
      * @param Upgrade $context
      *
-     * @return mixed
+     * @return Upgrade
      */
     public function getPotentiallyBrokenCustomizations(Upgrade $context)
     {

src/Data/Provider/SourceCode/LocalUpgradePackages.php

Doc Comments +5 added lines, -5 removed lines

@@ -45,7 +45,7 @@ 
     }
 
     /**
-     * @param $buildPath
+     * @param string $buildPath
      * @param $packages
      *
      * @return array
@@ -141,8 +141,8 @@ 
     /**
      * Gets flav specific packages
      *
-     * @param $flav
-     * @param $packagesPath
+     * @param string $flav
+     * @param string $packagesPath
      *
      * @return array
      */
@@ -196,8 +196,8 @@ 
      * Calculates an array of possible upgrade chains
      *
      * @param $packages
-     * @param $buildVersion
-     * @param $upgradeTo
+     * @param string $buildVersion
+     * @param string $upgradeTo
      *
      * @return array
      */

Spacing +11 added lines, -11 removed lines

@@ -77,7 +77,7 @@ 
             $deletedFiles = array_diff(array_merge($deletedFiles, $packageDeletedFiles), $packageModifiedFiles);
         }
 
-        $modifiedFiles = array_keys(array_filter($modifiedFiles, function ($package, $changedFile) use ($buildPath, $packageZips) {
+        $modifiedFiles = array_keys(array_filter($modifiedFiles, function($package, $changedFile) use ($buildPath, $packageZips) {
             if (($buildFile = @file_get_contents($buildPath . DS . $changedFile)) === false) {
                 return false;
             }
@@ -92,11 +92,11 @@ 
             $zip->close();
         }
 
-        $modifiedFiles = array_values(array_filter($modifiedFiles, function ($file) use ($buildPath) {
+        $modifiedFiles = array_values(array_filter($modifiedFiles, function($file) use ($buildPath) {
             return file_exists($buildPath . '/custom/' . $file);
         }));
 
-        $deletedFiles = array_values(array_filter($deletedFiles, function ($file) use ($buildPath) {
+        $deletedFiles = array_values(array_filter($deletedFiles, function($file) use ($buildPath) {
             return file_exists($buildPath . '/custom/' . $file);
         }));
 
@@ -129,7 +129,7 @@ 
             return $this->suitablePackages;
         }
 
-        usort($upgradeChains, function ($a1, $a2) {
+        usort($upgradeChains, function($a1, $a2) {
             return count($a1) < count($a2) ? -1 : (count($a1) > count($a2) ? 1 : 0);
         });
 
@@ -211,7 +211,7 @@ 
         $versionMatrix = $this->getVersionMatrix($packages);
         $allVersions = array_keys($versionMatrix);
 
-        $getExistingSubversions = function ($version) use ($allVersions) {
+        $getExistingSubversions = function($version) use ($allVersions) {
             $existingVersions = [];
 
             $fromParts = explode('.', $version);
@@ -226,7 +226,7 @@ 
         };
 
         // init chains with starting versions
-        $chains = array_map(function ($version) use ($buildVersion) {
+        $chains = array_map(function($version) use ($buildVersion) {
             return [$version => $buildVersion];
         }, $getExistingSubversions($buildVersion));
 
@@ -236,7 +236,7 @@ 
         }
 
         // gets last key of assoc array
-        $getLastKey = function ($array) {
+        $getLastKey = function($array) {
             end($array);
 
             return key($array);
@@ -285,7 +285,7 @@ 
             $chains = $fullChains;
         }
 
-        $chains = array_map(function ($chain) use ($versionMatrix) {
+        $chains = array_map(function($chain) use ($versionMatrix) {
             $keys = array_keys($chain);
             $values = array_values($chain);
 
@@ -315,17 +315,17 @@ 
      */
     private function getVersionMatrix($packages)
     {
-        $allVersions = array_unique(call_user_func_array('array_merge', array_map(function ($package) {
+        $allVersions = array_unique(call_user_func_array('array_merge', array_map(function($package) {
             return [$package['from'], $package['to']];
         }, $packages)));
 
         // sort versions (ASC)
-        usort($allVersions, function ($v1, $v2) {
+        usort($allVersions, function($v1, $v2) {
             return version_compare($v1, $v2, '<') ? -1 : (version_compare($v1, $v2, '>') ? 1 : 0);
         });
 
         // create matrix and fill it with zeros
-        $versionMatrix = call_user_func_array('array_merge',array_map(function ($version) use ($allVersions) {
+        $versionMatrix = call_user_func_array('array_merge', array_map(function($version) use ($allVersions) {
             return [$version => array_combine($allVersions, array_fill(0, count($allVersions), 0))];
         }, $allVersions));
 

src/Element/Section/UpgradeChanges.php

Doc Comments +1 added lines, -1 removed lines

@@ -33,7 +33,7 @@
     /**
      * @param Upgrade $context
      *
-     * @return bool
+     * @return string
      */
     public function isRelevantTo(Upgrade $context)
     {

src/Element/Provider.php

Spacing +2 added lines, -2 removed lines

@@ -50,7 +50,7 @@ 
      */
     public function getSuitableElements(Upgrade $context)
     {
-        $elements = array_filter($this->specElements, function (ElementInterface $element) use ($context) {
+        $elements = array_filter($this->specElements, function(ElementInterface $element) use ($context) {
             return $element->isRelevantTo($context);
         });
 
@@ -63,7 +63,7 @@ 
         }
 
         // sort elements (ASC)
-        usort($elements, function (ElementInterface $a, ElementInterface $b) {
+        usort($elements, function(ElementInterface $a, ElementInterface $b) {
             return $a->getOrder() > $b->getOrder() ? 1 : ($a->getOrder() < $b->getOrder() ? -1 : 0);
         });