Issues in UniqueJobIdentifierGenerator.php (master) - Issues in master - mikaelkael/GearmanBundle - Measure and Improve Code Quality continuously with Scrutinizer

Issues (57)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Generator/UniqueJobIdentifierGenerator.php (2 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * Gearman Bundle for Symfony2 / Symfony3
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * Feel free to edit as you please, and have fun.
 *
 * @author Marc Morera <[email protected]>
 */

namespace Mkk\GearmanBundle\Generator;

use Mkk\GearmanBundle\Exceptions\WorkerNameTooLongException;

/**
 * Job Unique Key generator
 *
 * @see https://github.com/mmoreram/GearmanBundle/issues/66
 */
class UniqueJobIdentifierGenerator
{
    /**
     * @var string
     *
     * Generate unique key
     */
    protected $generateUniqueKey;

    /**
     * Construct method
     *
     * @param string $generateUniqueKey Generate unique key
     */
    public function __construct($generateUniqueKey)
    {
        $this->generateUniqueKey = $generateUniqueKey;
    }

    /**
     * Generate unique key if generateUniqueKey is enabled
     *
     * Even some parameters are not used, are passed to allow user overwrite
     * method
     *
     * Also, if name and unique value exceeds 114 bytes, an exception is thrown
     *
     * @param string $name   A GermanBundle registered function to be executed
     * @param string $params Parameters to send to task as string
     * @param string $unique unique ID used to identify a particular task
     * @param string $method Method to perform
     *
     * @return string Generated Unique Key
     *
     * @throws WorkerNameTooLongException If name is too large
     *
     * @api
     */
    public function generateUniqueKey($name, $params, $unique, $method)

    {
        $unique = !$unique && $this->generateUniqueKey

            ? md5($name . $params)
            : $unique;

        if (strlen($name . $unique) > 114) {

            throw new WorkerNameTooLongException;
        }

        return $unique;
    }
}


1		<?php
2
3		/**
4		* Gearman Bundle for Symfony2 / Symfony3
5		*
6		* For the full copyright and license information, please view the LICENSE
7		* file that was distributed with this source code.
8		*
9		* Feel free to edit as you please, and have fun.
10		*
11		* @author Marc Morera <[email protected]>
12		*/
13
14		namespace Mkk\GearmanBundle\Generator;
15
16		use Mkk\GearmanBundle\Exceptions\WorkerNameTooLongException;
17
18		/**
19		* Job Unique Key generator
20		*
21		* @see https://github.com/mmoreram/GearmanBundle/issues/66
22		*/
23		class UniqueJobIdentifierGenerator
24		{
25		/**
26		* @var string
27		*
28		* Generate unique key
29		*/
30		protected $generateUniqueKey;
31
32		/**
33		* Construct method
34		*
35		* @param string $generateUniqueKey Generate unique key
36		*/
37	5	public function __construct($generateUniqueKey)
38		{
39	5	$this->generateUniqueKey = $generateUniqueKey;
40	5	}
41
42		/**
43		* Generate unique key if generateUniqueKey is enabled
44		*
45		* Even some parameters are not used, are passed to allow user overwrite
46		* method
47		*
48		* Also, if name and unique value exceeds 114 bytes, an exception is thrown
49		*
50		* @param string $name A GermanBundle registered function to be executed
51		* @param string $params Parameters to send to task as string
52		* @param string $unique unique ID used to identify a particular task
53		* @param string $method Method to perform
54		*
55		* @return string Generated Unique Key
56		*
57		* @throws WorkerNameTooLongException If name is too large
58		*
59		* @api
60		*/
61	2	public function generateUniqueKey($name, $params, $unique, $method)
		0 ignored issues – show Unused Code introduced 2018-04-29 15:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$method` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
62		{
63	2	$unique = !$unique && $this->generateUniqueKey
		0 ignored issues – show Coding Style introduced 2016-11-11 12:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider using a different name than the parameter `$unique`. This often makes code more readable. Loading history...
64	1	? md5($name . $params)
65	2	: $unique;
66
67	2	if (strlen($name . $unique) > 114) {
68
69		throw new WorkerNameTooLongException;
70		}
71
72	2	return $unique;
73		}
74		}
75

mikaelkael / GearmanBundle

Issues (57)

Security Analysis no request data

Generator/UniqueJobIdentifierGenerator.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like