Mkk\GearmanBundle\Generator\UniqueJobIdentifierGenerator

Complexity

Total Complexity

5

Size/Duplication

Total Lines	52
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

90%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	generateUniqueKey()	0	13	4

<?php

/**
 * Gearman Bundle for Symfony2 / Symfony3
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * Feel free to edit as you please, and have fun.
 *
 * @author Marc Morera <yuhu@mmoreram.com>
 */

namespace Mkk\GearmanBundle\Generator;

use Mkk\GearmanBundle\Exceptions\WorkerNameTooLongException;

/**
 * Job Unique Key generator
 *
 * @see https://github.com/mmoreram/GearmanBundle/issues/66
 */
class UniqueJobIdentifierGenerator
{
    /**
     * @var string
     *
     * Generate unique key
     */
    protected $generateUniqueKey;

    /**
     * Construct method
     *
     * @param string $generateUniqueKey Generate unique key
     */
    public function __construct($generateUniqueKey)
    {
        $this->generateUniqueKey = $generateUniqueKey;
    }

    /**
     * Generate unique key if generateUniqueKey is enabled
     *
     * Even some parameters are not used, are passed to allow user overwrite
     * method
     *
     * Also, if name and unique value exceeds 114 bytes, an exception is thrown
     *
     * @param string $name   A GermanBundle registered function to be executed
     * @param string $params Parameters to send to task as string
     * @param string $unique unique ID used to identify a particular task
     * @param string $method Method to perform
     *
     * @return string Generated Unique Key
     *
     * @throws WorkerNameTooLongException If name is too large
     *
     * @api
     */
    public function generateUniqueKey($name, $params, $unique, $method)

The parameter $method is not used and could be removed.

    {
        $unique = !$unique && $this->generateUniqueKey

Consider using a different name than the parameter $unique. This often makes code more readable.

            ? md5($name . $params)
            : $unique;

        if (strlen($name . $unique) > 114) {

            throw new WorkerNameTooLongException;
        }

        return $unique;
    }
}