Completed
Branch dev (594ce5)
by
unknown
11:01 queued 06:39
created
development/factory/admin_page/AdminPageFramework_View_Form.php 1 patch
Spacing   +19 added lines, -19 removed lines patch added patch discarded remove patch
@@ -27,17 +27,17 @@  discard block
 block discarded – undo
27 27
      */
28 28
     public function _replyToGetSectionName( /* $sAttribute, $aSectionset */ ) {
29 29
 
30
-        $_aParams            = func_get_args() + array( null, null, );
30
+        $_aParams            = func_get_args() + array( null, null,);
31 31
         $sNameAttribute      = $_aParams[ 0 ];
32 32
         $aSectionset         = $_aParams[ 1 ];        
33 33
         $_aSectionPath       = $aSectionset[ '_section_path_array' ];
34 34
         $_aDimensionalKeys   = array( $this->oProp->sOptionKey );   
35
-        foreach( $_aSectionPath as $_sDimension ) {
36
-            $_aDimensionalKeys[] = '[' . $_sDimension . ']';
35
+        foreach ( $_aSectionPath as $_sDimension ) {
36
+            $_aDimensionalKeys[ ] = '['.$_sDimension.']';
37 37
         }
38 38
         
39 39
         if ( isset( $aSectionset[ '_index' ] ) ) {
40
-            $_aDimensionalKeys[] = '[' . $aSectionset[ '_index' ] . ']';
40
+            $_aDimensionalKeys[ ] = '['.$aSectionset[ '_index' ].']';
41 41
         }
42 42
         
43 43
         return implode( '', $_aDimensionalKeys );
@@ -50,25 +50,25 @@  discard block
 block discarded – undo
50 50
      */
51 51
     public function _replyToGetFieldNameAttribute( /* $sAttribute, $aFieldset */ ) {
52 52
         
53
-        $_aParams           = func_get_args() + array( null, null,  );
53
+        $_aParams           = func_get_args() + array( null, null,);
54 54
         $sNameAttribute     = $_aParams[ 0 ];
55 55
         $aFieldset          = $_aParams[ 1 ];
56 56
         $_aDimensionalKeys  = array( 
57 57
             $this->oProp->sOptionKey    // Use `$this->oProp->sOptionKey` instead of `$aFieldset[ 'option_key' ]` which is not set for nested items.
58 58
         );        
59 59
         if ( $this->isSectionSet( $aFieldset ) ) {
60
-            $_aSectionPath       = $aFieldset[ '_section_path_array' ];
61
-            foreach( $_aSectionPath as $_sDimension ) {
62
-                $_aDimensionalKeys[] = '[' . $_sDimension . ']';
60
+            $_aSectionPath = $aFieldset[ '_section_path_array' ];
61
+            foreach ( $_aSectionPath as $_sDimension ) {
62
+                $_aDimensionalKeys[ ] = '['.$_sDimension.']';
63 63
             }
64 64
             if ( isset( $aFieldset[ '_section_index' ] ) ) {
65
-                $_aDimensionalKeys[] = '[' . $aFieldset[ '_section_index' ] . ']';
65
+                $_aDimensionalKeys[ ] = '['.$aFieldset[ '_section_index' ].']';
66 66
             }
67 67
         }
68 68
         
69 69
         // 3.8.0+ Support for nested fields.
70
-        foreach( $aFieldset[ '_field_path_array' ] as $_sPathPart ) {
71
-            $_aDimensionalKeys[] = '[' . $_sPathPart . ']';
70
+        foreach ( $aFieldset[ '_field_path_array' ] as $_sPathPart ) {
71
+            $_aDimensionalKeys[ ] = '['.$_sPathPart.']';
72 72
         }
73 73
 
74 74
         return implode( '', $_aDimensionalKeys );
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
      */
82 82
     public function _replyToGetFlatFieldName( /* $sAttribute, $aFieldset */ ) {
83 83
 
84
-        $_aParams           = func_get_args() + array( null, null,  );
84
+        $_aParams           = func_get_args() + array( null, null,);
85 85
         $sNameAttribute     = $_aParams[ 0 ];
86 86
         $aFieldset          = $_aParams[ 1 ];        
87 87
         
@@ -89,11 +89,11 @@  discard block
 block discarded – undo
89 89
             $this->oProp->sOptionKey    // Use `$this->oProp->sOptionKey` instead of `$aFieldset[ 'option_key' ]` which is not set for nested items.
90 90
         );
91 91
         if ( $this->isSectionSet( $aFieldset ) ) {
92
-            foreach( $aFieldset[ '_section_path_array' ] as $_sDimension ) {
93
-                $_aDimensionalKeys[] = $_sDimension; // $aFieldset[ 'section_id' ];
92
+            foreach ( $aFieldset[ '_section_path_array' ] as $_sDimension ) {
93
+                $_aDimensionalKeys[ ] = $_sDimension; // $aFieldset[ 'section_id' ];
94 94
             }
95 95
             if ( isset( $aFieldset[ '_section_index' ] ) ) {
96
-                $_aDimensionalKeys[] = $aFieldset[ '_section_index' ];    
96
+                $_aDimensionalKeys[ ] = $aFieldset[ '_section_index' ];    
97 97
             }
98 98
         }
99 99
 
@@ -122,8 +122,8 @@  discard block
 block discarded – undo
122 122
             "[{$sKey}]"
123 123
         );   
124 124
 
125
-        $_sNamePrefix   = $this->_replyToGetFieldNameAttribute( '', $aField );
126
-        return $_sNamePrefix . $sKey;
125
+        $_sNamePrefix = $this->_replyToGetFieldNameAttribute( '', $aField );
126
+        return $_sNamePrefix.$sKey;
127 127
         
128 128
     }
129 129
     /**
@@ -141,10 +141,10 @@  discard block
 block discarded – undo
141 141
         $_sKey              = $this->oUtil->getAOrB(
142 142
             '0' !== $_sKey && empty( $_sKey ),
143 143
             '',
144
-            "|" . $_sKey
144
+            "|".$_sKey
145 145
         );        
146 146
         
147
-        return $this->_replyToGetFlatFieldName( '', $aField ) . $_sKey;
147
+        return $this->_replyToGetFlatFieldName( '', $aField ).$_sKey;
148 148
 
149 149
     }
150 150
             
Please login to merge, or discard this patch.
development/factory/widget/AdminPageFramework_Widget_Factory.php 1 patch
Spacing   +29 added lines, -29 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
26 26
      * @since       3.2.0
27 27
      * @return      void
28 28
      */
29
-	public function __construct( $oCaller, $sWidgetTitle, array $aArguments=array() ) {
29
+	public function __construct( $oCaller, $sWidgetTitle, array $aArguments = array() ) {
30 30
 		
31 31
         $aArguments = $aArguments 
32 32
             + array( 
@@ -35,8 +35,8 @@  discard block
 block discarded – undo
35 35
             );
36 36
             
37 37
 		parent::__construct( 
38
-            $oCaller->oProp->sClassName,  // base id 
39
-            $sWidgetTitle,      // widget title
38
+            $oCaller->oProp->sClassName, // base id 
39
+            $sWidgetTitle, // widget title
40 40
             $aArguments         // widget arguments
41 41
         );
42 42
         $this->oCaller = $oCaller;
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
         
58 58
         $this->oCaller->oUtil->addAndDoActions( 
59 59
             $this->oCaller, 
60
-            'do_' . $this->oCaller->oProp->sClassName, 
60
+            'do_'.$this->oCaller->oProp->sClassName, 
61 61
             $this->oCaller
62 62
         );
63 63
        
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
          */
89 89
         private function _getTitle( array $aArguments, array $aFormData ) {
90 90
                 
91
-            if ( ! $this->oCaller->oProp->bShowWidgetTitle ) {
91
+            if ( !$this->oCaller->oProp->bShowWidgetTitle ) {
92 92
                 return '';
93 93
             }
94 94
             
@@ -102,12 +102,12 @@  discard block
 block discarded – undo
102 102
                 $aFormData,
103 103
                 $this->id_base 
104 104
             );
105
-            if ( ! $_sTitle ) {
105
+            if ( !$_sTitle ) {
106 106
                 return '';
107 107
             }
108
-           return $aArguments['before_title'] 
108
+           return $aArguments[ 'before_title' ] 
109 109
                 . $_sTitle 
110
-            . $aArguments['after_title'];           
110
+            . $aArguments[ 'after_title' ];           
111 111
             
112 112
         }
113 113
             
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
             $this->oCaller, 
124 124
             "validation_{$this->oCaller->oProp->sClassName}", 
125 125
             call_user_func_array( 
126
-                array( $this->oCaller, 'validate' ),    // triggers __call()
126
+                array( $this->oCaller, 'validate' ), // triggers __call()
127 127
                 array( $aSubmittedFormData, $aSavedFormData, $this->oCaller ) // parameters
128 128
             ), // 3.5.3+                        
129 129
             $aSavedFormData,
@@ -172,8 +172,8 @@  discard block
 block discarded – undo
172 172
         $this->oCaller->oForm   = new AdminPageFramework_Form_widget(
173 173
             array(
174 174
                 'register_if_action_already_done' => false, // do not register fields right away
175
-            ) + $this->oCaller->oProp->aFormArguments,  // form arguments  
176
-            $this->oCaller->oForm->aCallbacks,  // callbacks 
175
+            ) + $this->oCaller->oProp->aFormArguments, // form arguments  
176
+            $this->oCaller->oForm->aCallbacks, // callbacks 
177 177
             $this->oCaller->oMsg
178 178
         );
179 179
         // Reuse the data of the previous widget instance.
@@ -199,7 +199,7 @@  discard block
 block discarded – undo
199 199
              * Call the load method only once per class. Also the added field registrations in the class also done once.
200 200
              * @since       3.7.9
201 201
              */ 
202
-            if ( $this->oCaller->oUtil->hasBeenCalled( '_widget_load_' . $this->oCaller->oProp->sClassName ) ) {
202
+            if ( $this->oCaller->oUtil->hasBeenCalled( '_widget_load_'.$this->oCaller->oProp->sClassName ) ) {
203 203
 
204 204
                 /**
205 205
                  * The saved option callback is done with the below load_... callback so for widget form instances called from the second time
@@ -217,7 +217,7 @@  discard block
 block discarded – undo
217 217
             $this->oCaller->oUtil->addAndDoActions( 
218 218
                 $this->oCaller, 
219 219
                 array(
220
-                    'load_' . $this->oCaller->oProp->sClassName, 
220
+                    'load_'.$this->oCaller->oProp->sClassName, 
221 221
                 ),
222 222
                 $this->oCaller 
223 223
             );            
@@ -231,9 +231,9 @@  discard block
 block discarded – undo
231 231
          */
232 232
         private function _getFormCallbacks() {
233 233
             return array( 
234
-                'hfID'          => array( $this, 'get_field_id' ),    // defined in the WP_Widget class.  
235
-                'hfTagID'       => array( $this, 'get_field_id' ),    // defined in the WP_Widget class.  
236
-                'hfName'        => array( $this, '_replyToGetFieldName' ),  // defined in the WP_Widget class.  
234
+                'hfID'          => array( $this, 'get_field_id' ), // defined in the WP_Widget class.  
235
+                'hfTagID'       => array( $this, 'get_field_id' ), // defined in the WP_Widget class.  
236
+                'hfName'        => array( $this, '_replyToGetFieldName' ), // defined in the WP_Widget class.  
237 237
                 'hfInputName'   => array( $this, '_replyToGetFieldInputName' ),
238 238
                 
239 239
                 'saved_data'    => array( $this, '_replyToGetSavedFormData' ),
@@ -249,8 +249,8 @@  discard block
 block discarded – undo
249 249
     public function  _replyToGetSavedFormData() {
250 250
         return $this->oCaller->oUtil->addAndApplyFilter(
251 251
             $this->oCaller, // the caller factory object
252
-            'options_' . $this->oCaller->oProp->sClassName,
253
-            $this->oCaller->oProp->aOptions,      // subject value to be filtered
252
+            'options_'.$this->oCaller->oProp->sClassName,
253
+            $this->oCaller->oProp->aOptions, // subject value to be filtered
254 254
             $this->id   // 3.7.9+
255 255
         );        
256 256
     }    
@@ -280,25 +280,25 @@  discard block
 block discarded – undo
280 280
          */
281 281
         private function _getNameAttributeDimensions( $aFieldset ) {
282 282
 
283
-            $_sNamePrefix   = 'widget-' . $this->id_base . '[' . $this->number . ']';
283
+            $_sNamePrefix = 'widget-'.$this->id_base.'['.$this->number.']';
284 284
 
285 285
             $_sDimensions = '';
286 286
             if ( $this->oCaller->isSectionSet( $aFieldset ) ) {
287
-                $_aSectionPath       = $aFieldset[ '_section_path_array' ];
288
-                foreach( $_aSectionPath as $_sDimension ) {
289
-                    $_sDimensions .= '[' . $_sDimension . ']';
287
+                $_aSectionPath = $aFieldset[ '_section_path_array' ];
288
+                foreach ( $_aSectionPath as $_sDimension ) {
289
+                    $_sDimensions .= '['.$_sDimension.']';
290 290
                 }
291 291
                 if ( isset( $aFieldset[ '_section_index' ] ) ) {
292
-                    $_sDimensions .= '[' . $aFieldset[ '_section_index' ] . ']';
292
+                    $_sDimensions .= '['.$aFieldset[ '_section_index' ].']';
293 293
                 }
294 294
             }
295 295
 
296 296
             // 3.8.18+ Support for nested fields. @see  https://github.com/michaeluno/admin-page-framework/issues/274
297
-            foreach( $aFieldset[ '_field_path_array' ] as $_sPathPart ) {
298
-                $_sDimensions .= '[' . $_sPathPart . ']';
297
+            foreach ( $aFieldset[ '_field_path_array' ] as $_sPathPart ) {
298
+                $_sDimensions .= '['.$_sPathPart.']';
299 299
             }
300 300
 
301
-            return $_sNamePrefix . $_sDimensions;
301
+            return $_sNamePrefix.$_sDimensions;
302 302
         }        
303 303
     
304 304
     /**
@@ -315,10 +315,10 @@  discard block
 block discarded – undo
315 315
         $_sIndex        = $this->oCaller->oUtil->getAOrB(
316 316
             '0' !== $sIndex && empty( $sIndex ),
317 317
             '',
318
-            "[" . $sIndex . "]"
318
+            "[".$sIndex."]"
319 319
         );
320
-        $_sNamePrefix   = $this->_replyToGetFieldName( '', $aFieldset );
321
-        return $_sNamePrefix . $_sIndex;
320
+        $_sNamePrefix = $this->_replyToGetFieldName( '', $aFieldset );
321
+        return $_sNamePrefix.$_sIndex;
322 322
 
323 323
     }
324 324
   
Please login to merge, or discard this patch.
admin-page-framework-loader.php 1 patch
Spacing   +22 added lines, -22 removed lines patch added patch discarded remove patch
@@ -16,9 +16,9 @@  discard block
 block discarded – undo
16 16
  */
17 17
 class AdminPageFrameworkLoader_Registry_Base {
18 18
 
19
-    const VERSION        = '3.8.18b01';    // <--- DON'T FORGET TO CHANGE THIS AS WELL!!
19
+    const VERSION        = '3.8.18b01'; // <--- DON'T FORGET TO CHANGE THIS AS WELL!!
20 20
     const NAME           = 'Admin Page Framework - Loader'; // the name is not 'Admin Page Framework' because warning messages gets confusing.
21
-    const SHORTNAME      = 'Admin Page Framework';  // used for a menu title etc.
21
+    const SHORTNAME      = 'Admin Page Framework'; // used for a menu title etc.
22 22
     const DESCRIPTION    = 'Loads Admin Page Framework which facilitates WordPress plugin and theme development.';
23 23
     const URI            = 'http://admin-page-framework.michaeluno.jp/';
24 24
     const AUTHOR         = 'miunosoft (Michael Uno)';
@@ -55,14 +55,14 @@  discard block
 block discarded – undo
55 55
      * @remark      This is also accessed from `uninstall.php` so do not remove.
56 56
      * @remark      Do not exceed 8 characters as a transient name allows 45 characters or less ( 40 for site transients ) so that md5 (32 characters) can be added.
57 57
      */
58
-    const TRANSIENT_PREFIX         = 'APFL_';
58
+    const TRANSIENT_PREFIX = 'APFL_';
59 59
 
60 60
     /**
61 61
      * The hook slug used for the prefix of action and filter hook names.
62 62
      * 
63 63
      * @remark      The ending underscore is not necessary.
64 64
      */
65
-    const HOOK_SLUG                = 'admin_page_framework_loader';
65
+    const HOOK_SLUG = 'admin_page_framework_loader';
66 66
 
67 67
     /**
68 68
      * The text domain slug and its path.
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
      */
117 117
     static public $aAdminPages = array(
118 118
         // key => 'page slug'
119
-        'about'     => 'apfl_about',        // the welcome page
119
+        'about'     => 'apfl_about', // the welcome page
120 120
         'addon'     => 'apfl_addons',
121 121
         'tool'      => 'apfl_tools',
122 122
         'help'      => 'apfl_contact',
@@ -154,12 +154,12 @@  discard block
 block discarded – undo
154 154
      * @since       3.5.0
155 155
      * @return      string
156 156
      */
157
-    public static function getPluginURL( $sRelativePath='' ) {
157
+    public static function getPluginURL( $sRelativePath = '' ) {
158 158
         if ( isset( self::$_sPluginURLCache ) ) {
159
-            return self::$_sPluginURLCache . $sRelativePath;
159
+            return self::$_sPluginURLCache.$sRelativePath;
160 160
         }
161 161
         self::$_sPluginURLCache = trailingslashit( plugins_url( '', self::$sFilePath ) );
162
-        return self::$_sPluginURLCache . $sRelativePath;
162
+        return self::$_sPluginURLCache.$sRelativePath;
163 163
     }
164 164
         /**
165 165
          * @since       3.7.9
@@ -189,13 +189,13 @@  discard block
 block discarded – undo
189 189
      * @since       3.5.0
190 190
      * @return      void
191 191
      */ 
192
-    static public function setAdminNotice( $sMessage, $sClassAttribute='error' ) {
193
-        if ( ! is_admin() ) {  
192
+    static public function setAdminNotice( $sMessage, $sClassAttribute = 'error' ) {
193
+        if ( !is_admin() ) {  
194 194
             return; 
195 195
         }
196
-        self::$_aAdminNotices[] = array(
196
+        self::$_aAdminNotices[ ] = array(
197 197
             'message'           => $sMessage,
198
-            'class_attribute'   => trim( $sClassAttribute ) . ' notice is-dismissible',
198
+            'class_attribute'   => trim( $sClassAttribute ).' notice is-dismissible',
199 199
         );
200 200
         add_action( 'admin_notices', array( __CLASS__, '_replyToSetAdminNotice' ) );
201 201
     }
@@ -205,12 +205,12 @@  discard block
 block discarded – undo
205 205
          * @return      void
206 206
          */
207 207
         static public function _replyToSetAdminNotice() {
208
-            foreach( self::$_aAdminNotices as $_aAdminNotice ) {
209
-                echo "<div class='" . esc_attr( $_aAdminNotice['class_attribute'] ) . " notice is-dismissible'>"
208
+            foreach ( self::$_aAdminNotices as $_aAdminNotice ) {
209
+                echo "<div class='".esc_attr( $_aAdminNotice[ 'class_attribute' ] )." notice is-dismissible'>"
210 210
                         ."<p>"
211 211
                             . sprintf(
212
-                                '<strong>%1$s</strong>: ' . $_aAdminNotice['message'],
213
-                                self::NAME . ' ' . self::VERSION
212
+                                '<strong>%1$s</strong>: '.$_aAdminNotice[ 'message' ],
213
+                                self::NAME.' '.self::VERSION
214 214
                             )
215 215
                         . "</p>"
216 216
                     . "</div>";
@@ -222,7 +222,7 @@  discard block
 block discarded – undo
222 222
 AdminPageFrameworkLoader_Registry::setUp( __FILE__ );
223 223
 
224 224
 // Initial checks. - Do no load if accessed directly, not exiting because the 'uninstall.php' and inclusion list generator will load this file.
225
-if ( ! defined( 'ABSPATH' ) ) {
225
+if ( !defined( 'ABSPATH' ) ) {
226 226
     return;
227 227
 }
228 228
 if ( defined( 'DOING_UNINSTALL' ) && DOING_UNINSTALL ) {
@@ -234,8 +234,8 @@  discard block
 block discarded – undo
234 234
 
235 235
     $_bFrameworkLoaded = class_exists( 'AdminPageFramework_Registry', false );
236 236
     if (
237
-        ! $_bFrameworkLoaded
238
-        || ! defined( 'AdminPageFramework_Registry::VERSION' ) // backward compatibility
237
+        !$_bFrameworkLoaded
238
+        || !defined( 'AdminPageFramework_Registry::VERSION' ) // backward compatibility
239 239
         || version_compare( AdminPageFramework_Registry::VERSION, AdminPageFrameworkLoader_Registry::VERSION, '<' )
240 240
     ) {
241 241
         AdminPageFrameworkLoader_Registry::setAdminNotice(
@@ -253,18 +253,18 @@  discard block
 block discarded – undo
253 253
 add_action( 'admin_init', 'AdminPageFrameworkLoader_Warning' );
254 254
 
255 255
 // Include the library file - the development version will be available if you cloned the GitHub repository.
256
-$_sDevelopmentVersionPath = AdminPageFrameworkLoader_Registry::$sDirPath . '/development/admin-page-framework.php';
256
+$_sDevelopmentVersionPath = AdminPageFrameworkLoader_Registry::$sDirPath.'/development/admin-page-framework.php';
257 257
 $_bDebugMode              = defined( 'WP_DEBUG' ) && WP_DEBUG;
258 258
 $_bLoadDevelopmentVersion = $_bDebugMode && file_exists( $_sDevelopmentVersionPath );
259 259
 include(
260 260
     $_bLoadDevelopmentVersion
261 261
         ? $_sDevelopmentVersionPath
262
-        : AdminPageFrameworkLoader_Registry::$sDirPath . '/library/apf/admin-page-framework.php'
262
+        : AdminPageFrameworkLoader_Registry::$sDirPath.'/library/apf/admin-page-framework.php'
263 263
 );
264 264
 
265 265
 // Include the framework loader plugin components.
266 266
 include( AdminPageFramework_Registry::$aClassFiles[ 'AdminPageFramework_PluginBootstrap' ] );
267
-include( AdminPageFrameworkLoader_Registry::$sDirPath . '/include/class/AdminPageFrameworkLoader_Bootstrap.php' );
267
+include( AdminPageFrameworkLoader_Registry::$sDirPath.'/include/class/AdminPageFrameworkLoader_Bootstrap.php' );
268 268
 new AdminPageFrameworkLoader_Bootstrap(
269 269
     AdminPageFrameworkLoader_Registry::$sFilePath,
270 270
     AdminPageFrameworkLoader_Registry::HOOK_SLUG    // hook prefix
Please login to merge, or discard this patch.