Issues in AbstractMethodNumberOf.php (master) - Issues in master - mi-schi/phpmd-symfony2 - Measure and Improve Code Quality continuously with Scrutinizer

Issues (38)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Rule/Test/AbstractMethodNumberOf.php (1 issue)

Labels

Compatibility 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace MS\PHPMD\Rule\Test;

use PHPMD\Node\ClassNode;
use PHPMD\Node\MethodNode;
use PHPMD\AbstractNode;

/**
 * Class AbstractMethodNumberOf
 *
 * @package MS\PHPMD\Rule\Test
 */
abstract class AbstractMethodNumberOf extends AbstractTestRule
{
    /**
     * @var array
     */
    private $names;

    /**
     * @var bool
     */
    private $match;

    /**
     * @param AbstractNode|ClassNode $node
     */
    public function apply(AbstractNode $node)
    {
        if (false === $this->isTest($node)) {

            return;
        }

        $this->names = explode($this->getStringProperty('delimiter'), $this->getStringProperty('names'));
        $this->match = $this->getBooleanProperty('match');
        $number = $this->getIntProperty('number');

        foreach ($node->getMethods() as $method) {
            $count = $this->count($method);

            if ($number < $count) {
                $this->addViolation($method, [$count, $number]);
            }
        }
    }

    /**
     * @param MethodNode $node
     *
     * @return int
     */
    private function count(MethodNode $node)
    {
        $count = 0;
        $methodPostfixes = $node->findChildrenOfType('MethodPostfix');

        foreach ($methodPostfixes as $methodPostfix) {
            if (true === $this->isMethodPostfixInNames($methodPostfix)) {
                $count++;
            }
        }

        return $count;
    }

    /**
     * @param AbstractNode $methodPostfix
     *
     * @return bool
     */
    private function isMethodPostfixInNames(AbstractNode $methodPostfix)
    {
        if (true === $this->match) {
            return in_array($methodPostfix->getImage(), $this->names);
        }

        return $this->isMethodPostfixContainsNames($methodPostfix);
    }

    /**
     * @param AbstractNode $methodPostfix
     *
     * @return bool
     */
    private function isMethodPostfixContainsNames(AbstractNode $methodPostfix)
    {
        foreach ($this->names as $name) {
            if (false !== strpos($methodPostfix->getImage(), $name)) {
                return true;
            }
        }

        return false;
    }
}


1		<?php
2
3		namespace MS\PHPMD\Rule\Test;
4
5		use PHPMD\Node\ClassNode;
6		use PHPMD\Node\MethodNode;
7		use PHPMD\AbstractNode;
8
9		/**
10		* Class AbstractMethodNumberOf
11		*
12		* @package MS\PHPMD\Rule\Test
13		*/
14		abstract class AbstractMethodNumberOf extends AbstractTestRule
15		{
16		/**
17		* @var array
18		*/
19		private $names;
20
21		/**
22		* @var bool
23		*/
24		private $match;
25
26		/**
27		* @param AbstractNode\|ClassNode $node
28		*/
29	5	public function apply(AbstractNode $node)
30		{
31	5	if (false === $this->isTest($node)) {
		0 ignored issues – show Compatibility introduced 2015-12-01 14:20 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$node` of type `object<PHPMD\AbstractNode>` is not a sub-type of `object<PHPMD\Node\ClassNode>`. It seems like you assume a child class of the class `PHPMD\AbstractNode` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
32	2	return;
33		}
34
35	3	$this->names = explode($this->getStringProperty('delimiter'), $this->getStringProperty('names'));
36	3	$this->match = $this->getBooleanProperty('match');
37	3	$number = $this->getIntProperty('number');
38
39	3	foreach ($node->getMethods() as $method) {
40	3	$count = $this->count($method);
41
42	3	if ($number < $count) {
43	2	$this->addViolation($method, [$count, $number]);
44	2	}
45	3	}
46	3	}
47
48		/**
49		* @param MethodNode $node
50		*
51		* @return int
52		*/
53	3	private function count(MethodNode $node)
54		{
55	3	$count = 0;
56	3	$methodPostfixes = $node->findChildrenOfType('MethodPostfix');
57
58	3	foreach ($methodPostfixes as $methodPostfix) {
59	3	if (true === $this->isMethodPostfixInNames($methodPostfix)) {
60	3	$count++;
61	3	}
62	3	}
63
64	3	return $count;
65		}
66
67		/**
68		* @param AbstractNode $methodPostfix
69		*
70		* @return bool
71		*/
72	3	private function isMethodPostfixInNames(AbstractNode $methodPostfix)
73		{
74	3	if (true === $this->match) {
75	1	return in_array($methodPostfix->getImage(), $this->names);
76		}
77
78	2	return $this->isMethodPostfixContainsNames($methodPostfix);
79		}
80
81		/**
82		* @param AbstractNode $methodPostfix
83		*
84		* @return bool
85		*/
86	2	private function isMethodPostfixContainsNames(AbstractNode $methodPostfix)
87		{
88	2	foreach ($this->names as $name) {
89	2	if (false !== strpos($methodPostfix->getImage(), $name)) {
90	2	return true;
91		}
92	1	}
93
94	1	return false;
95		}
96		}
97

mi-schi / phpmd-symfony2

Issues (38)

Security Analysis no request data

Rule/Test/AbstractMethodNumberOf.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like