MS\PHPMD\Rule\Test\AbstractMethodNumberOf

Complexity

Total Complexity

12

Size/Duplication

Total Lines	83
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

100%

Importance

Changes	4
Bugs	1	Features	2

4 Methods

Rating	Name	Duplication	Size	Complexity
A	apply()	0	18	4
A	count()	0	13	3
A	isMethodPostfixInNames()	0	8	2
A	isMethodPostfixContainsNames()	0	10	3

<?php

namespace MS\PHPMD\Rule\Test;

use PHPMD\Node\ClassNode;
use PHPMD\Node\MethodNode;
use PHPMD\AbstractNode;

/**
 * Class AbstractMethodNumberOf
 *
 * @package MS\PHPMD\Rule\Test
 */
abstract class AbstractMethodNumberOf extends AbstractTestRule
{
    /**
     * @var array
     */
    private $names;

    /**
     * @var bool
     */
    private $match;

    /**
     * @param AbstractNode|ClassNode $node
     */
    public function apply(AbstractNode $node)
    {
        if (false === $this->isTest($node)) {

$node of type object<PHPMD\AbstractNode> is not a sub-type of object<PHPMD\Node\ClassNode>. It seems like you assume a child class of the class PHPMD\AbstractNode to be always present.

            return;
        }

        $this->names = explode($this->getStringProperty('delimiter'), $this->getStringProperty('names'));
        $this->match = $this->getBooleanProperty('match');
        $number = $this->getIntProperty('number');

        foreach ($node->getMethods() as $method) {
            $count = $this->count($method);

            if ($number < $count) {
                $this->addViolation($method, [$count, $number]);
            }
        }
    }

    /**
     * @param MethodNode $node
     *
     * @return int
     */
    private function count(MethodNode $node)
    {
        $count = 0;
        $methodPostfixes = $node->findChildrenOfType('MethodPostfix');

        foreach ($methodPostfixes as $methodPostfix) {
            if (true === $this->isMethodPostfixInNames($methodPostfix)) {
                $count++;
            }
        }

        return $count;
    }

    /**
     * @param AbstractNode $methodPostfix
     *
     * @return bool
     */
    private function isMethodPostfixInNames(AbstractNode $methodPostfix)
    {
        if (true === $this->match) {
            return in_array($methodPostfix->getImage(), $this->names);
        }

        return $this->isMethodPostfixContainsNames($methodPostfix);
    }

    /**
     * @param AbstractNode $methodPostfix
     *
     * @return bool
     */
    private function isMethodPostfixContainsNames(AbstractNode $methodPostfix)
    {
        foreach ($this->names as $name) {
            if (false !== strpos($methodPostfix->getImage(), $name)) {
                return true;
            }
        }

        return false;
    }
}