mi-schi / phpmd-symfony2

Rule/CleanCode/SuperfluousComment.php

Doc Comments +1 added lines, -1 removed lines

@@ -56,7 +56,7 @@
     }
 
     /**
-     * @param AbstractNode|ASTClass $node
+     * @param AbstractNode $node
      */
     private function checkProperties(AbstractNode $node)
     {

Spacing +1 added lines, -1 removed lines

@@ -63,7 +63,7 @@
         foreach ($node->getProperties() as $property) {
             $this->checkNode(
                 $node,
-                'property ' . $property->getName(),
+                'property '.$property->getName(),
                 $this->calculateNameToCommentSimilarityInPercent($property)
             );
         }

Rule/Symfony2/ControllerMethodName.php

Doc Comments +1 added lines, -1 removed lines

@@ -36,7 +36,7 @@
     }
 
     /**
-     * @param ClassNode|ASTClass $node
+     * @param ClassNode $node
      *
      * @return bool
      */

Indentation +1 added lines, -1 removed lines

@@ -33,7 +33,7 @@
         foreach ($node->getMethods() as $method) {
             // Check if method is whitelisted
             if (in_array($method->getImage(), $allowedMethodNames)) {
-              continue;
+                continue;
             }
 
             if ('Action' !== substr($method->getImage(), -6, 6)) {

Rule/Symfony2/EntityConstants.php

Doc Comments +1 added lines, -1 removed lines

@@ -16,7 +16,7 @@
 class EntityConstants extends AbstractEntityRule
 {
     /**
-     * @param AbstractNode|ClassNode|ASTClass $node
+     * @param AbstractNode $node
      */
     public function apply(AbstractNode $node)
     {

Rule/Symfony2/EntitySimpleGetterSetter.php

Doc Comments +2 added lines, -2 removed lines

@@ -64,7 +64,7 @@ 
     }
 
     /**
-     * @param MethodNode|ASTMethod $node
+     * @param MethodNode $node
      *
      * @return bool
      */
@@ -80,7 +80,7 @@ 
     }
 
     /**
-     * @param MethodNode|ASTMethod $node
+     * @param MethodNode $node
      *
      * @return bool
      */

Tests/Unit/AbstractApplyTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
     /**
      * @param int $violationNumber
      *
-     * @return \Mockery\MockInterface|Report
+     * @return \Mockery\MockInterface
      */
     protected function getReport($violationNumber)
     {

Tests/Unit/CleanCode/SuperfluousCommentTest.php

Doc Comments +3 added lines, -3 removed lines

@@ -71,10 +71,10 @@
 
     /**
      * @param string $docComment
-     * @param array  $properties
-     * @param array  $methods
+     * @param \Mockery\MockInterface[]  $properties
+     * @param \Mockery\MockInterface[]  $methods
      *
-     * @return \Mockery\MockInterface|AbstractNode
+     * @return \Mockery\MockInterface
      */
     private function getClassNode($docComment = '', $properties = [], $methods = [])
     {

Spacing +1 added lines, -1 removed lines

@@ -60,7 +60,7 @@
      */
     protected function getRule()
     {
-        $rule =  new SuperfluousComment();
+        $rule = new SuperfluousComment();
         $rule->addProperty('percent', '60');
         $rule->addProperty('checkClass', '1');
         $rule->addProperty('checkProperties', '1');

Tests/Unit/CleanCode/TraitPublicMethodTest.php

Doc Comments +2 added lines, -2 removed lines

@@ -62,7 +62,7 @@ 
     }
 
     /**
-     * @param mixed $parentType
+     * @param \Mockery\MockInterface $parentType
      *
      * @return \Mockery\MockInterface
      */
@@ -76,7 +76,7 @@ 
     }
 
     /**
-     * @param mixed $parentType
+     * @param \Mockery\MockInterface $parentType
      *
      * @return \Mockery\MockInterface
      */

Tests/Unit/Symfony2/EntitySimpleGetterSetterTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -163,7 +163,7 @@
     }
 
     /**
-     * @param array $methodNodes
+     * @param \Mockery\MockInterface[] $methodNodes
      *
      * @return \Mockery\MockInterface
      */

Rule/CleanCode/MethodOneTryCatch.php

Spacing +1 added lines, -1 removed lines

@@ -27,7 +27,7 @@
             $this->addViolation($node);
         }
 
-        if (1 === $countTry &&  true === $this->hasNotAllowedChildren($node)) {
+        if (1 === $countTry && true === $this->hasNotAllowedChildren($node)) {
             $this->addViolation($node);
         }
     }