Code Quality Summary - merodiro/settings - Measure and Improve Code Quality continuously with Scrutinizer

2018-04-10 19:23 UTC

Inspected merge default config

	1 issue (critical) was introduced.
A	↘	B	SettingsServiceProvider::boot() got worse

2018-04-01 13:25 UTC

Inspected clean repeated code

2 added classes/operations
	A	Setting::getCacheKeyAttribute() added
	A	SettingObserver::saved() added

2018-03-14 16:22 UTC

Inspected make commands code cleaner

2 issues (2 informational) were introduced.
2 issues were fixed.

2018-03-14 16:04 UTC

Inspected cache user settings

	2 issues (2 informational) were introduced. 2 issues were fixed.
	2 added classes/operations
		A	HasSettings::settingsCacheKey() added
		A	SettingsManger::cacheKey() added
A	↘	B	SettingsCache::handle() got worse
A	↘	B	SettingsClear::handle() got worse

2018-03-14 15:02 UTC

Inspected cache on set instead of on get

1 issue (informational) was introduced.
1 issue was fixed.

2018-03-13 20:32 UTC

Inspected remove duplication and add abs...

Good job, 8 issues were fixed.
1 added class/operation
	A	SettingObserver::deleteCache() added

2018-03-13 20:19 UTC

Inspected use getKey instead of id in us...

6 issues (6 minor) were introduced.
1 issue was fixed.

2018-03-13 20:00 UTC

Inspected add user settings

6 issues (1 major, 1 minor, 4 informational) were introduced.
9 added classes/operations
	A	HasSettings added
	A	AddOwnerIdToSettingsTable added
	A	HasSettings::allSettings() added
	A	HasSettings::setSettings() added
	A	HasSettings::getSettings() added
	A	HasSettings::forgetSettings() added
	A	HasSettings::flushSettings() added
	A	AddOwnerIdToSettingsTable::up() added
	A	AddOwnerIdToSettingsTable::down() added