meemalabs / laravel-media-converter

src/Jobs/CreateVideoConversion.php

<?php

namespace Meema\MediaConverter\Jobs;

use Illuminate\Bus\Queueable;
use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Foundation\Bus\Dispatchable;
use Illuminate\Queue\InteractsWithQueue;
use Illuminate\Queue\SerializesModels;
use Meema\MediaConverter\Facades\MediaConvert;

class CreateVideoConversion implements ShouldQueue
{
    use Dispatchable, InteractsWithQueue, Queueable, SerializesModels;

The trait Illuminate\Queue\SerializesModels requires some properties which are not provided by Meema\MediaConverter\Jobs\CreateVideoConversion: $id, $relations, $class, $keyBy

    /**
     * @var array
     */
    private array $jobSettings;

    /**
     * @var int
     */
    private int $mediaId;

    /**
     * @var array
     */
    private array $tags;

    /**
     * Create a new job instance.
     *
     * @param  array  $jobSettings
     * @param  array  $tags
     * @param  int  $mediaId
     */
    public function __construct($jobSettings, $tags = [], $mediaId = null)
    {
        $this->jobSettings = $jobSettings;
        $this->tags = $tags;

        if ($mediaId) {

The expression $mediaId of type integer|null is loosely compared to true; this is ambiguous if the integer can be 0. You might want to explicitly use !== null instead.

            $this->mediaId = $mediaId;
        }
    }

    /**
     * Execute the job.
     *
     * @return void
     */
    public function handle()
    {
        $metaData = [];
        $tags = $this->tags;

        if ($this->mediaId) {
            $metaData = ['model_id' => $this->mediaId];
        }

        MediaConvert::createJob($this->jobSettings, $metaData, $tags);
    }
}