CreateVideoConversion::__construct() - Code Metrics - meemalabs/laravel-media-converter - Measure and Improve Code Quality continuously with Scrutinizer

CreateVideoConversion::__construct() A
last analyzed 2022-04-28 06:43 UTC

↳ Parent: CreateVideoConversion

Complexity

Conditions	2
Paths	2

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	2	Features	2

Metric	Value
cc	2
eloc	4
c	3
b	2
f	2
nc	2
nop	3
dl	0
loc	7
rs	10

<?php

namespace Meema\MediaConverter\Jobs;

use Illuminate\Bus\Queueable;
use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Foundation\Bus\Dispatchable;
use Illuminate\Queue\InteractsWithQueue;
use Illuminate\Queue\SerializesModels;
use Meema\MediaConverter\Facades\MediaConvert;

class CreateVideoConversion implements ShouldQueue
{
    use Dispatchable, InteractsWithQueue, Queueable, SerializesModels;


    /**
     * @var array
     */
    private array $jobSettings;

    /**
     * @var int
     */
    private int $mediaId;

    /**
     * @var array
     */
    private array $tags;

    /**
     * Create a new job instance.
     *
     * @param  array  $jobSettings
     * @param  array  $tags
     * @param  int  $mediaId
     */
    public function __construct($jobSettings, $tags = [], $mediaId = null)
    {
        $this->jobSettings = $jobSettings;
        $this->tags = $tags;

        if ($mediaId) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
            $this->mediaId = $mediaId;
        }
    }

    /**
     * Execute the job.
     *
     * @return void
     */
    public function handle()
    {
        $metaData = [];
        $tags = $this->tags;

        if ($this->mediaId) {
            $metaData = ['model_id' => $this->mediaId];
        }

        MediaConvert::createJob($this->jobSettings, $metaData, $tags);
    }
}


1			<?php
2
3			namespace Meema\MediaConverter\Jobs;
4
5			use Illuminate\Bus\Queueable;
6			use Illuminate\Contracts\Queue\ShouldQueue;
7			use Illuminate\Foundation\Bus\Dispatchable;
8			use Illuminate\Queue\InteractsWithQueue;
9			use Illuminate\Queue\SerializesModels;
10			use Meema\MediaConverter\Facades\MediaConvert;
11
12			class CreateVideoConversion implements ShouldQueue
13			{
14			use Dispatchable, InteractsWithQueue, Queueable, SerializesModels;
			0 ignored issues – show introduced 2021-03-13 21:44 UTC by Report Bug Copy Issue Report The trait `Illuminate\Queue\SerializesModels` requires some properties which are not provided by `Meema\MediaConverter\Jobs\CreateVideoConversion`: `$id`, `$relations`, `$class`, `$keyBy` Loading history...
15
16			/**
17			* @var array
18			*/
19			private array $jobSettings;
20
21			/**
22			* @var int
23			*/
24			private int $mediaId;
25
26			/**
27			* @var array
28			*/
29			private array $tags;
30
31			/**
32			* Create a new job instance.
33			*
34			* @param array $jobSettings
35			* @param array $tags
36			* @param int $mediaId
37			*/
38			public function __construct($jobSettings, $tags = [], $mediaId = null)
39			{
40			$this->jobSettings = $jobSettings;
41			$this->tags = $tags;
42
43			if ($mediaId) {
			0 ignored issues – show Bug Best Practice introduced 2021-05-21 02:44 UTC by Report Bug Copy Issue Report The expression `$mediaId` of type `integer\|null` is loosely compared to `true`; this is ambiguous if the integer can be 0. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `integer` values, zero is a special case, in particular the following results might be unexpected: 0 == false // true 0 == null // true 123 == false // false 123 == null // false // It is often better to use strict comparison 0 === false // false 0 === null // false Loading history...
44			$this->mediaId = $mediaId;
45			}
46			}
47
48			/**
49			* Execute the job.
50			*
51			* @return void
52			*/
53			public function handle()
54			{
55			$metaData = [];
56			$tags = $this->tags;
57
58			if ($this->mediaId) {
59			$metaData = ['model_id' => $this->mediaId];
60			}
61
62			MediaConvert::createJob($this->jobSettings, $metaData, $tags);
63			}
64			}
65

meemalabs / laravel-media-converter

CreateVideoConversion::__construct() A last analyzed 2022-04-28 06:43 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

CreateVideoConversion::__construct() A
last analyzed 2022-04-28 06:43 UTC