meadsteve / DiceApi

src/RequestHandler/DiceRequestHandler.php

Spacing +4 added lines, -4 removed lines

@@ -42,10 +42,10 @@ 
             $this->diceCounter->count($dice);
         } catch (UncreatableDiceException $creationError) {
             $diceResponse = $diceResponse->withStatus(400)
-                ->write("Unable to roll dice: " . $creationError->getMessage());
+                ->write("Unable to roll dice: ".$creationError->getMessage());
         } catch (UnrenderableDiceException $renderError) {
             $diceResponse = $diceResponse->withStatus(400)
-                ->write("Unable to render request: " . $renderError->getMessage());
+                ->write("Unable to render request: ".$renderError->getMessage());
         }
         return $diceResponse;
     }
@@ -60,7 +60,7 @@ 
                 ->withHeader("Content-Type", $renderer->contentType());
         } catch (UnknownRendererException $error) {
             $responseWithOutput = $response->withStatus(406);
-            $responseWithOutput->write("Not sure how to respond with: " . $requestedContentType);
+            $responseWithOutput->write("Not sure how to respond with: ".$requestedContentType);
         }
         return $responseWithOutput;
     }
@@ -69,7 +69,7 @@ 
     {
         $rolledValue = $request->getHeader('totally-legit')[0];
         return array_map(
-            function (Dice $dice) use ($rolledValue) {
+            function(Dice $dice) use ($rolledValue) {
                 return new TotallyLegit($dice, (int) $rolledValue);
             },
             $dice

Doc Comments +7 added lines

@@ -77,10 +77,17 @@
         return $responseWithOutput;
     }
 
+    /**
+     * @param Dice[] $dice
+     */
     private function makeDiceTotallyLegit($dice, Request $request)
     {
         $rolledValue = $request->getHeader('totally-legit')[0];
         return array_map(
+
+            /**
+             * @param Dice[] $dice
+             */
             function (Dice $dice) use ($rolledValue) {
                 return new TotallyLegit($dice, (int) $rolledValue);
             },

src/Dice/BasicDice.php

Spacing +1 added lines, -1 removed lines

@@ -20,7 +20,7 @@
 
     public function roll()
     {
-        if (! function_exists('random_int')) {
+        if (!function_exists('random_int')) {
             return mt_rand(1, $this->size);
         }
 

www/index.php

Spacing +2 added lines, -2 removed lines

@@ -14,7 +14,7 @@ 
 use MeadSteve\DiceApi\RequestHandler\DiceRequestHandler;
 use Predis\Client;
 
-require __DIR__ . "/../vendor/autoload.php";
+require __DIR__."/../vendor/autoload.php";
 
 $diceGenerator = new UrlDiceGenerator(
     new DiceFactoryCollection([
@@ -25,7 +25,7 @@ 
 
 $rendererCollection = new RendererCollection([
     new Json(),
-    new Html('http://' . $_SERVER['HTTP_HOST']),
+    new Html('http://'.$_SERVER['HTTP_HOST']),
     new Plain()
 ]);
 

src/DiceApp.php

Spacing +5 added lines, -5 removed lines

@@ -27,11 +27,11 @@ 
 
     public function index(Request $request, Response $response)
     {
-        $indexFilePath = __DIR__ . "/generated-index.html";
+        $indexFilePath = __DIR__."/generated-index.html";
         if (!file_exists($indexFilePath)) {
             $converter = new CommonMarkConverter();
-            $indexBody = $converter->convertToHtml(file_get_contents(__DIR__ . "/../README.md"));
-            $indexContent = file_get_contents(__DIR__ . "/../www/templates/index.html");
+            $indexBody = $converter->convertToHtml(file_get_contents(__DIR__."/../README.md"));
+            $indexContent = file_get_contents(__DIR__."/../www/templates/index.html");
             $indexContent = str_replace("{{body}}", $indexBody, $indexContent);
             file_put_contents($indexFilePath, $indexContent);
             $response->write($indexContent);
@@ -66,8 +66,8 @@ 
     {
         $diceRequestHandler = $this->diceRequestHandler;
         $this->get(
-            "/{$path}" . self::DICE_PATH_REGEX,
-            function (Request $request, $response, $args) use ($diceRequestHandler, $contentType) {
+            "/{$path}".self::DICE_PATH_REGEX,
+            function(Request $request, $response, $args) use ($diceRequestHandler, $contentType) {
                 return $diceRequestHandler->getDice(
                     $request->withHeader('accept', $contentType),
                     $response,

src/Renderer/Html.php

Spacing +1 added lines, -1 removed lines

@@ -40,6 +40,6 @@
         }
         $roll = $dice->roll();
         $url = "{$this->urlRoot}/images/poorly-drawn/{$name}/{$roll}.png";
-        return '<img src="' . $url . '" />';
+        return '<img src="'.$url.'" />';
     }
 }

src/Renderer/Json.php

Spacing +1 added lines, -1 removed lines

@@ -31,7 +31,7 @@
 
     private function diceAsAssocArrays(array $diceCollection)
     {
-        return array_map(function (Dice $dice) {
+        return array_map(function(Dice $dice) {
             return [
                 "value" => $dice->roll(),
                 "type"  => $dice->name()

src/Dice/Factories/SpecialDiceFactory.php

Spacing +2 added lines, -2 removed lines

@@ -14,10 +14,10 @@
     public function __construct()
     {
         $this->diceTypeMappings = [
-            'steve' => function () {
+            'steve' => function() {
                 return new Dice\SteveDice();
             },
-            'fate'  => function () {
+            'fate'  => function() {
                 return new Dice\FateDice();
             },
         ];

src/UrlDiceGenerator.php

Spacing +1 added lines, -1 removed lines

@@ -63,7 +63,7 @@
         $data = [];
         $valid = preg_match("/(?P<count>[0-9]+)?d(?P<type>[^\/]+)/i", $part, $data);
         if (!$valid) {
-            throw new UncreatableDiceException("Problem creating dice from incorrectly formatted data: " . $part);
+            throw new UncreatableDiceException("Problem creating dice from incorrectly formatted data: ".$part);
         }
         if (!$data["count"]) {
             $data["count"] = 1;