Passed
Branch master (847752)
by Misbahul D
05:16
created
components/AccessControl.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -77,7 +77,7 @@
 block discarded – undo
77 77
      * Denies the access of the user.
78 78
      * The default implementation will redirect the user to the login page if he is a guest;
79 79
      * if the user is already logged, a 403 HTTP exception will be thrown.
80
-     * @param  yii\web\User $user the current user
80
+     * @param  User $user the current user
81 81
      * @throws yii\web\ForbiddenHttpException if the user is already logged in.
82 82
      */
83 83
     protected function denyAccess($user)
Please login to merge, or discard this patch.
components/ItemController.php 1 patch
Doc Comments   +3 added lines, -4 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
 
43 43
     /**
44 44
      * Lists all AuthItem models.
45
-     * @return mixed
45
+     * @return string
46 46
      */
47 47
     public function actionIndex()
48 48
     {
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
     /**
59 59
      * Displays a single AuthItem model.
60 60
      * @param  string $id
61
-     * @return mixed
61
+     * @return string
62 62
      */
63 63
     public function actionView($id)
64 64
     {
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
      * Deletes an existing AuthItem model.
104 104
      * If deletion is successful, the browser will be redirected to the 'index' page.
105 105
      * @param  string $id
106
-     * @return mixed
106
+     * @return \yii\web\Response
107 107
      */
108 108
     public function actionDelete($id)
109 109
     {
@@ -131,7 +131,6 @@  discard block
 block discarded – undo
131 131
     /**
132 132
      * Assign or remove items
133 133
      * @param string $id
134
-     * @param string $action
135 134
      * @return array
136 135
      */
137 136
     public function actionRemove($id)
Please login to merge, or discard this patch.
components/MenuHelper.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -186,7 +186,7 @@
 block discarded – undo
186 186
      * Normalize menu
187 187
      * @param  array $assigned
188 188
      * @param  array $menus
189
-     * @param  Closure $callback
189
+     * @param  \Closure|null $callback
190 190
      * @param  integer $parent
191 191
      * @return array
192 192
      */
Please login to merge, or discard this patch.
controllers/AssignmentController.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
 
56 56
     /**
57 57
      * Lists all Assignment models.
58
-     * @return mixed
58
+     * @return string
59 59
      */
60 60
     public function actionIndex()
61 61
     {
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
     /**
82 82
      * Displays a single Assignment model.
83 83
      * @param  integer $id
84
-     * @return mixed
84
+     * @return string
85 85
      */
86 86
     public function actionView($id)
87 87
     {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@
 block discarded – undo
32 32
         parent::init();
33 33
         if ($this->userClassName === null) {
34 34
             $this->userClassName = Yii::$app->getUser()->identityClass;
35
-            $this->userClassName = $this->userClassName ? : 'mdm\admin\models\User';
35
+            $this->userClassName = $this->userClassName ?: 'mdm\admin\models\User';
36 36
         }
37 37
     }
38 38
 
Please login to merge, or discard this patch.
controllers/MenuController.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
 
37 37
     /**
38 38
      * Lists all Menu models.
39
-     * @return mixed
39
+     * @return string
40 40
      */
41 41
     public function actionIndex()
42 42
     {
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
     /**
53 53
      * Displays a single Menu model.
54 54
      * @param  integer $id
55
-     * @return mixed
55
+     * @return string
56 56
      */
57 57
     public function actionView($id)
58 58
     {
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
106 106
      * Deletes an existing Menu model.
107 107
      * If deletion is successful, the browser will be redirected to the 'index' page.
108 108
      * @param  integer $id
109
-     * @return mixed
109
+     * @return \yii\web\Response
110 110
      */
111 111
     public function actionDelete($id)
112 112
     {
Please login to merge, or discard this patch.
controllers/RuleController.php 2 patches
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
 
37 37
     /**
38 38
      * Lists all AuthItem models.
39
-     * @return mixed
39
+     * @return string
40 40
      */
41 41
     public function actionIndex()
42 42
     {
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
     /**
53 53
      * Displays a single AuthItem model.
54 54
      * @param  string $id
55
-     * @return mixed
55
+     * @return string
56 56
      */
57 57
     public function actionView($id)
58 58
     {
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
      * Deletes an existing AuthItem model.
101 101
      * If deletion is successful, the browser will be redirected to the 'index' page.
102 102
      * @param  string $id
103
-     * @return mixed
103
+     * @return \yii\web\Response
104 104
      */
105 105
     public function actionDelete($id)
106 106
     {
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
      * Finds the AuthItem model based on its primary key value.
116 116
      * If the model is not found, a 404 HTTP exception will be thrown.
117 117
      * @param  string        $id
118
-     * @return AuthItem      the loaded model
118
+     * @return BizRule      the loaded model
119 119
      * @throws HttpException if the model cannot be found
120 120
      */
121 121
     protected function findModel($id)
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
 
75 75
             return $this->redirect(['view', 'id' => $model->name]);
76 76
         } else {
77
-            return $this->render('create', ['model' => $model,]);
77
+            return $this->render('create', ['model' => $model, ]);
78 78
         }
79 79
     }
80 80
 
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
93 93
             return $this->redirect(['view', 'id' => $model->name]);
94 94
         }
95 95
 
96
-        return $this->render('update', ['model' => $model,]);
96
+        return $this->render('update', ['model' => $model, ]);
97 97
     }
98 98
 
99 99
     /**
Please login to merge, or discard this patch.
controllers/UserController.php 2 patches
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
 
88 88
     /**
89 89
      * Lists all User models.
90
-     * @return mixed
90
+     * @return string
91 91
      */
92 92
     public function actionIndex()
93 93
     {
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
     /**
104 104
      * Displays a single User model.
105 105
      * @param integer $id
106
-     * @return mixed
106
+     * @return string
107 107
      */
108 108
     public function actionView($id)
109 109
     {
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
      * Deletes an existing User model.
117 117
      * If deletion is successful, the browser will be redirected to the 'index' page.
118 118
      * @param integer $id
119
-     * @return mixed
119
+     * @return \yii\web\Response
120 120
      */
121 121
     public function actionDelete($id)
122 122
     {
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
147 147
 
148 148
     /**
149 149
      * Logout
150
-     * @return string
150
+     * @return \yii\web\Response
151 151
      */
152 152
     public function actionLogout()
153 153
     {
@@ -238,7 +238,7 @@  discard block
 block discarded – undo
238 238
     /**
239 239
      * Activate new user
240 240
      * @param integer $id
241
-     * @return type
241
+     * @return \yii\web\Response
242 242
      * @throws UserException
243 243
      * @throws NotFoundHttpException
244 244
      */
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -14,7 +14,6 @@
 block discarded – undo
14 14
 use yii\web\BadRequestHttpException;
15 15
 use yii\web\Controller;
16 16
 use yii\filters\VerbFilter;
17
-use yii\filters\AccessControl;
18 17
 use yii\web\NotFoundHttpException;
19 18
 use yii\base\UserException;
20 19
 use yii\mail\BaseMailer;
Please login to merge, or discard this patch.
models/AuthItem.php 1 patch
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
     /**
112 112
      * Find role
113 113
      * @param string $id
114
-     * @return null|\self
114
+     * @return AuthItem|null
115 115
      */
116 116
     public static function find($id)
117 117
     {
@@ -218,7 +218,6 @@  discard block
 block discarded – undo
218 218
 
219 219
     /**
220 220
      *
221
-     * @param string $id
222 221
      * @return array
223 222
      */
224 223
     public function getItems()
Please login to merge, or discard this patch.
models/BizRule.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -149,7 +149,7 @@
 block discarded – undo
149 149
 
150 150
     /**
151 151
      * Get item
152
-     * @return Item
152
+     * @return Rule
153 153
      */
154 154
     public function getItem()
155 155
     {
Please login to merge, or discard this patch.