mcustiel / php-simple-request

src/ParserGenerator.php

Unused Use Statements -7 removed lines

@@ -18,13 +18,6 @@
 namespace Mcustiel\SimpleRequest;
 
 use Doctrine\Common\Annotations\AnnotationReader;
-use Mcustiel\SimpleRequest\Util\ValidatorBuilder;
-use Mcustiel\SimpleRequest\Annotation\RequestAnnotation;
-use Mcustiel\SimpleRequest\Annotation\ValidatorAnnotation;
-use Mcustiel\SimpleRequest\Annotation\FilterAnnotation;
-use Mcustiel\SimpleRequest\Util\FilterBuilder;
-use Mcustiel\SimpleRequest\Annotation\ParseAs;
-use Mcustiel\SimpleRequest\Annotation\AnnotationWithAssociatedClass;
 use Mcustiel\SimpleRequest\Strategies\AnnotationParserFactory;
 use Mcustiel\SimpleRequest\Strategies\PropertyParserBuilder;
 use Mcustiel\SimpleRequest\Strategies\Properties\PropertyParser;

src/RequestBuilder.php

Doc Comments +4 added lines, -4 removed lines

@@ -41,9 +41,6 @@ 
     /**
      * Class constructor.
      *
-     * @param \stdClass        $cacheConfig
-     *      Config parameters for cache. By default cache is activated and saves files
-     *      under system's temp dir. This parameter is used to set alternative options.
      *
      */
     public function __construct(
@@ -60,7 +57,6 @@ 
      *
      * @param array|\stdClass  $request   The request to convert to an object.
      * @param string           $className The class of the object to which the request must be converted.
-     * @param string           $behaviour The behaviour of the parser.
      */
     public function parseRequest(
         $request,
@@ -71,6 +67,10 @@ 
             ->parse($this->sanitizeRequestOrThrowExceptionIfInvalid($request));
     }
 
+    /**
+     * @param string $className
+     * @param RequestParser $parser
+     */
     private function generateRequestParserObject($className, $parser)
     {
         $cacheKey = str_replace('\\', '', $className . get_class($parser));

Unused Use Statements -1 removed lines

@@ -19,7 +19,6 @@
 
 use Mcustiel\SimpleRequest\Exception\InvalidRequestException;
 use Psr\Cache\CacheItemPoolInterface as PsrCache;
-use Symfony\Component\Cache\CacheItem;
 
 /**
  * Builds a request by parsing all the resulting object's annotations and running

Spacing +1 added lines, -1 removed lines

@@ -73,7 +73,7 @@
 
     private function generateRequestParserObject($className, $parser)
     {
-        $cacheKey = str_replace('\\', '', $className . get_class($parser));
+        $cacheKey = str_replace('\\', '', $className.get_class($parser));
         $cacheItem = $this->cache->getItem($cacheKey);
         $return = $cacheItem->get();
         if ($return === null) {

src/Strategies/Properties/SimplePropertyParser.php

Doc Comments -1 removed lines

@@ -48,7 +48,6 @@
      * Filters and validates a value. And return the filtered value.
      * It throws an exception if the value is not valid.
      *
-     * @param mixed $value
      * @return mixed
      *
      * @throws \Mcustiel\SimpleRequest\Exception\InvalidValueException

Spacing +1 added lines, -1 removed lines

@@ -88,7 +88,7 @@
         foreach ($this->validators as $validator) {
             if (!$validator->validate($value)) {
                 throw new InvalidValueException(
-                    "Field {$this->name}, was set with invalid value: " . var_export($value, true)
+                    "Field {$this->name}, was set with invalid value: ".var_export($value, true)
                 );
             }
         }

src/Strategies/AnnotationParserFactory.php

Spacing +1 added lines, -1 removed lines

@@ -29,6 +29,6 @@
                 return new $val;
             }
         }
-        throw new \Exception('Unsupported annotation: ' . get_class($annotation));
+        throw new \Exception('Unsupported annotation: '.get_class($annotation));
     }
 }

src/RequestParser.php

Spacing +1 added lines, -1 removed lines

@@ -78,7 +78,7 @@
         $value = $propertyParser->parse(
             $this->getFromRequest($request, $propertyName)
         );
-        $method = 'set' . ucfirst($propertyName);
+        $method = 'set'.ucfirst($propertyName);
         $object->$method($value);
     }
 

src/FirstErrorRequestParser.php

Spacing +1 added lines, -1 removed lines

@@ -42,7 +42,7 @@
             try {
                 $this->setProperty($request, $object, $propertyName, $propertyParser);
             } catch (InvalidValueException $e) {
-                $exception = new InvalidRequestException($propertyName . ': ' . $e->getMessage());
+                $exception = new InvalidRequestException($propertyName.': '.$e->getMessage());
                 $exception->setErrors([$propertyName => $e->getMessage()]);
                 throw $exception;
             }