Inspection of "Update README.md" - mberatsanli/multilangPHP - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — master (02ef0c)

by Melih Berat

created 2019-04-21 13:04 UTC

Spacing +22 added lines, -22 removed lines patch added patch discarded remove patch

@@ -29,16 +29,16 @@  discard block
 block discarded – undo
  * @license http://www.gnu.org/copyleft/lesser.html GNU Lesser General Public License
 */
 
-class multilang{
-	private static $lang ="tr"; // Predefined language
+class multilang {
+	private static $lang = "tr"; // Predefined language
 	private static $dir = "system/lang/"; // Predefined directory
 	private static $log = array(); // Please don't touch
 
-	public static function get($req, $return = 0){
+	public static function get($req, $return = 0) {
 		global $_SESSION;
-		switch ($req){
+		switch ($req) {
 			case 'lang':
-				if($_SESSION['multilang']){
+				if ($_SESSION['multilang']) {
 					if ($return) return $_SESSION['multilang'];
 					echo $_SESSION['multilang'];
 					break;
@@ -47,8 +47,8 @@  discard block
 block discarded – undo
 				echo multilang::$lang;
 				break;
 			case 'dir&lang':
-				if ($return) return multilang::get("dir", 1).multilang::get("lang",1).".php";
-				echo multilang::get("dir",1).multilang::get("lang",1).".php";
+				if ($return) return multilang::get("dir", 1).multilang::get("lang", 1).".php";
+				echo multilang::get("dir", 1).multilang::get("lang", 1).".php";
 				break;
 			case 'dir':
 				if ($return) return multilang::$dir;
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
 		}
 	}
 
-	public static function set($type, $set){
+	public static function set($type, $set) {
 		global $_SESSION;
 		switch ($type) {
 			case 'lang':
@@ -83,17 +83,17 @@  discard block
 block discarded – undo
 		}
 	}
 
-	public static function ctrl($fileLang){
+	public static function ctrl($fileLang) {
 		return file_exists(multilang::$dir.$fileLang.".php");
 	}
 
 	# Return Type: array, html (div>a*)
-	public static function listlang($returnType = "array"){
+	public static function listlang($returnType = "array") {
 		$langPHP_array = array();
 		$langPHP_html = '<div class="multilang">';
 		$openDir = opendir(multilang::get("dir", 1));
-		while (($file = readdir($openDir)) != FALSE ){
-			if ($file =='.' || $file == '..' || is_file($file) || substr($language, -4, 4) == '.php') continue;
+		while (($file = readdir($openDir)) != FALSE) {
+			if ($file == '.' || $file == '..' || is_file($file) || substr($language, -4, 4) == '.php') continue;
 			if ($returnType == "array") $langPHP_array[basename($file, ".php")] = $file;
 			if ($returnType == "html") $langPHP_html .= sprintf(' <a href="?lang=%s" title="language %s">%s</a> ', basename($file, ".php"), $file, $file);
 		}
@@ -102,29 +102,29 @@  discard block
 block discarded – undo
 		return $returnType == "array" ? $langPHP_array : $langPHP_html;
 	}
 
-	public static function lang($type){
+	public static function lang($type) {
 		global $LANG;
-		if(!$LANG[$type]){
+		if (!$LANG[$type]) {
 			multilang::set("log", sprintf('NOT FOUND "%s" in %s.php', $type, multilang::get("lang", 1)));
 			return sprintf('<span style="background-color: red; color: white;">NOT FOUND "%s" in %s.php</span>', $type, multilang::get("lang", 1));
 		}
 		return $LANG[$type];
 	}
 
-	public static function setup(){
+	public static function setup() {
 		global $_GET, $_SESSION, $LANG;
-		if(session_status() == PHP_SESSION_NONE) session_start();
-		if($_GET && $_GET['lang']){
-			if(multilang::ctrl($_GET['lang'])){
+		if (session_status() == PHP_SESSION_NONE) session_start();
+		if ($_GET && $_GET['lang']) {
+			if (multilang::ctrl($_GET['lang'])) {
 				multilang::set("lang", $_GET['lang']);
 				require_once(multilang::get("dir&lang", 1));
-				multilang::set("log", sprintf("Language file loading (%s.php)", multilang::get("dir&lang",1)));
-			}else{
+				multilang::set("log", sprintf("Language file loading (%s.php)", multilang::get("dir&lang", 1)));
+			}else {
 				multilang::set("log", sprintf("Language file not found (%s.php)", multilang::$dir.$_GET['lang']));
 			}
-		}else{
+		}else {
 			require_once(multilang::get("dir&lang", 1));
-			multilang::set("log", sprintf("Language file loading (%s.php)", multilang::get("dir&lang",1)));
+			multilang::set("log", sprintf("Language file loading (%s.php)", multilang::get("dir&lang", 1)));
 		}
 	}
 }

Please login to merge, or discard this patch.

Braces +32 added lines, -12 removed lines patch added patch discarded remove patch

@@ -39,27 +39,39 @@  discard block
 block discarded – undo
 		switch ($req){
 			case 'lang':
 				if($_SESSION['multilang']){
-					if ($return) return $_SESSION['multilang'];
+					if ($return) {
+						return $_SESSION['multilang'];
+					}
 					echo $_SESSION['multilang'];
 					break;
 				}
-				if ($return) return multilang::$lang;
+				if ($return) {
+					return multilang::$lang;
+				}
 				echo multilang::$lang;
 				break;
 			case 'dir&lang':
-				if ($return) return multilang::get("dir", 1).multilang::get("lang",1).".php";
+				if ($return) {
+					return multilang::get("dir", 1).multilang::get("lang",1).".php";
+				}
 				echo multilang::get("dir",1).multilang::get("lang",1).".php";
 				break;
 			case 'dir':
-				if ($return) return multilang::$dir;
+				if ($return) {
+					return multilang::$dir;
+				}
 				echo multilang::$dir;
 				break;
 			case 'log':
-				if ($return) return multilang::$log;
+				if ($return) {
+					return multilang::$log;
+				}
 				echo multilang::$log;
 				break;	
 			case 'log_last':
-				if ($return) return end(multilang::$log);
+				if ($return) {
+					return end(multilang::$log);
+				}
 				echo end(multilang::$log);
 				break;
 		}
@@ -93,9 +105,15 @@  discard block
 block discarded – undo
 		$langPHP_html = '<div class="multilang">';
 		$openDir = opendir(multilang::get("dir", 1));
 		while (($file = readdir($openDir)) != FALSE ){
-			if ($file =='.' || $file == '..' || is_file($file) || substr($language, -4, 4) == '.php') continue;
-			if ($returnType == "array") $langPHP_array[basename($file, ".php")] = $file;
-			if ($returnType == "html") $langPHP_html .= sprintf(' <a href="?lang=%s" title="language %s">%s</a> ', basename($file, ".php"), $file, $file);
+			if ($file =='.' || $file == '..' || is_file($file) || substr($language, -4, 4) == '.php') {
+				continue;
+			}
+			if ($returnType == "array") {
+				$langPHP_array[basename($file, ".php")] = $file;
+			}
+			if ($returnType == "html") {
+				$langPHP_html .= sprintf(' <a href="?lang=%s" title="language %s">%s</a> ', basename($file, ".php"), $file, $file);
+			}
 		}
 		$langPHP_html .= '</div>';
 		closedir($openDir);
@@ -113,16 +131,18 @@  discard block
 block discarded – undo
 
 	public static function setup(){
 		global $_GET, $_SESSION, $LANG;
-		if(session_status() == PHP_SESSION_NONE) session_start();
+		if(session_status() == PHP_SESSION_NONE) {
+			session_start();
+		}
 		if($_GET && $_GET['lang']){
 			if(multilang::ctrl($_GET['lang'])){
 				multilang::set("lang", $_GET['lang']);
 				require_once(multilang::get("dir&lang", 1));
 				multilang::set("log", sprintf("Language file loading (%s.php)", multilang::get("dir&lang",1)));
-			}else{
+			} else{
 				multilang::set("log", sprintf("Language file not found (%s.php)", multilang::$dir.$_GET['lang']));
 			}
-		}else{
+		} else{
 			require_once(multilang::get("dir&lang", 1));
 			multilang::set("log", sprintf("Language file loading (%s.php)", multilang::get("dir&lang",1)));
 		}

Please login to merge, or discard this patch.

		@@ -29,16 +29,16 @@ discard block
		block discarded – undo
29	29	* @license http://www.gnu.org/copyleft/lesser.html GNU Lesser General Public License
30	30	*/
31	31
32		-class multilang{
33		- private static $lang ="tr"; // Predefined language
	32	+class multilang {
	33	+ private static $lang = "tr"; // Predefined language
34	34	private static $dir = "system/lang/"; // Predefined directory
35	35	private static $log = array(); // Please don't touch
36	36
37		- public static function get($req, $return = 0){
	37	+ public static function get($req, $return = 0) {
38	38	global $_SESSION;
39		- switch ($req){
	39	+ switch ($req) {
40	40	case 'lang':
41		- if($_SESSION['multilang']){
	41	+ if ($_SESSION['multilang']) {
42	42	if ($return) return $_SESSION['multilang'];
43	43	echo $_SESSION['multilang'];
44	44	break;
		@@ -47,8 +47,8 @@ discard block
		block discarded – undo
47	47	echo multilang::$lang;
48	48	break;
49	49	case 'dir&lang':
50		- if ($return) return multilang::get("dir", 1).multilang::get("lang",1).".php";
51		- echo multilang::get("dir",1).multilang::get("lang",1).".php";
	50	+ if ($return) return multilang::get("dir", 1).multilang::get("lang", 1).".php";
	51	+ echo multilang::get("dir", 1).multilang::get("lang", 1).".php";
52	52	break;
53	53	case 'dir':
54	54	if ($return) return multilang::$dir;
		@@ -65,7 +65,7 @@ discard block
		block discarded – undo
65	65	}
66	66	}
67	67
68		- public static function set($type, $set){
	68	+ public static function set($type, $set) {
69	69	global $_SESSION;
70	70	switch ($type) {
71	71	case 'lang':
		@@ -83,17 +83,17 @@ discard block
		block discarded – undo
83	83	}
84	84	}
85	85
86		- public static function ctrl($fileLang){
	86	+ public static function ctrl($fileLang) {
87	87	return file_exists(multilang::$dir.$fileLang.".php");
88	88	}
89	89
90	90	# Return Type: array, html (div>a*)
91		- public static function listlang($returnType = "array"){
	91	+ public static function listlang($returnType = "array") {
92	92	$langPHP_array = array();
93	93	$langPHP_html = '<div class="multilang">';
94	94	$openDir = opendir(multilang::get("dir", 1));
95		- while (($file = readdir($openDir)) != FALSE ){
96		- if ($file =='.' \|\| $file == '..' \|\| is_file($file) \|\| substr($language, -4, 4) == '.php') continue;
	95	+ while (($file = readdir($openDir)) != FALSE) {
	96	+ if ($file == '.' \|\| $file == '..' \|\| is_file($file) \|\| substr($language, -4, 4) == '.php') continue;
97	97	if ($returnType == "array") $langPHP_array[basename($file, ".php")] = $file;
98	98	if ($returnType == "html") $langPHP_html .= sprintf(' <a href="?lang=%s" title="language %s">%s</a> ', basename($file, ".php"), $file, $file);
99	99	}
		@@ -102,29 +102,29 @@ discard block
		block discarded – undo
102	102	return $returnType == "array" ? $langPHP_array : $langPHP_html;
103	103	}
104	104
105		- public static function lang($type){
	105	+ public static function lang($type) {
106	106	global $LANG;
107		- if(!$LANG[$type]){
	107	+ if (!$LANG[$type]) {
108	108	multilang::set("log", sprintf('NOT FOUND "%s" in %s.php', $type, multilang::get("lang", 1)));
109	109	return sprintf('<span style="background-color: red; color: white;">NOT FOUND "%s" in %s.php</span>', $type, multilang::get("lang", 1));
110	110	}
111	111	return $LANG[$type];
112	112	}
113	113
114		- public static function setup(){
	114	+ public static function setup() {
115	115	global $_GET, $_SESSION, $LANG;
116		- if(session_status() == PHP_SESSION_NONE) session_start();
117		- if($_GET && $_GET['lang']){
118		- if(multilang::ctrl($_GET['lang'])){
	116	+ if (session_status() == PHP_SESSION_NONE) session_start();
	117	+ if ($_GET && $_GET['lang']) {
	118	+ if (multilang::ctrl($_GET['lang'])) {
119	119	multilang::set("lang", $_GET['lang']);
120	120	require_once(multilang::get("dir&lang", 1));
121		- multilang::set("log", sprintf("Language file loading (%s.php)", multilang::get("dir&lang",1)));
122		- }else{
	121	+ multilang::set("log", sprintf("Language file loading (%s.php)", multilang::get("dir&lang", 1)));
	122	+ }else {
123	123	multilang::set("log", sprintf("Language file not found (%s.php)", multilang::$dir.$_GET['lang']));
124	124	}
125		- }else{
	125	+ }else {
126	126	require_once(multilang::get("dir&lang", 1));
127		- multilang::set("log", sprintf("Language file loading (%s.php)", multilang::get("dir&lang",1)));
	127	+ multilang::set("log", sprintf("Language file loading (%s.php)", multilang::get("dir&lang", 1)));
128	128	}
129	129	}
130	130	}

		@@ -39,27 +39,39 @@ discard block
		block discarded – undo
39	39	switch ($req){
40	40	case 'lang':
41	41	if($_SESSION['multilang']){
42		- if ($return) return $_SESSION['multilang'];
	42	+ if ($return) {
	43	+ return $_SESSION['multilang'];
	44	+ }
43	45	echo $_SESSION['multilang'];
44	46	break;
45	47	}
46		- if ($return) return multilang::$lang;
	48	+ if ($return) {
	49	+ return multilang::$lang;
	50	+ }
47	51	echo multilang::$lang;
48	52	break;
49	53	case 'dir&lang':
50		- if ($return) return multilang::get("dir", 1).multilang::get("lang",1).".php";
	54	+ if ($return) {
	55	+ return multilang::get("dir", 1).multilang::get("lang",1).".php";
	56	+ }
51	57	echo multilang::get("dir",1).multilang::get("lang",1).".php";
52	58	break;
53	59	case 'dir':
54		- if ($return) return multilang::$dir;
	60	+ if ($return) {
	61	+ return multilang::$dir;
	62	+ }
55	63	echo multilang::$dir;
56	64	break;
57	65	case 'log':
58		- if ($return) return multilang::$log;
	66	+ if ($return) {
	67	+ return multilang::$log;
	68	+ }
59	69	echo multilang::$log;
60	70	break;
61	71	case 'log_last':
62		- if ($return) return end(multilang::$log);
	72	+ if ($return) {
	73	+ return end(multilang::$log);
	74	+ }
63	75	echo end(multilang::$log);
64	76	break;
65	77	}
		@@ -93,9 +105,15 @@ discard block
		block discarded – undo
93	105	$langPHP_html = '<div class="multilang">';
94	106	$openDir = opendir(multilang::get("dir", 1));
95	107	while (($file = readdir($openDir)) != FALSE ){
96		- if ($file =='.' \|\| $file == '..' \|\| is_file($file) \|\| substr($language, -4, 4) == '.php') continue;
97		- if ($returnType == "array") $langPHP_array[basename($file, ".php")] = $file;
98		- if ($returnType == "html") $langPHP_html .= sprintf(' <a href="?lang=%s" title="language %s">%s</a> ', basename($file, ".php"), $file, $file);
	108	+ if ($file =='.' \|\| $file == '..' \|\| is_file($file) \|\| substr($language, -4, 4) == '.php') {
	109	+ continue;
	110	+ }
	111	+ if ($returnType == "array") {
	112	+ $langPHP_array[basename($file, ".php")] = $file;
	113	+ }
	114	+ if ($returnType == "html") {
	115	+ $langPHP_html .= sprintf(' <a href="?lang=%s" title="language %s">%s</a> ', basename($file, ".php"), $file, $file);
	116	+ }
99	117	}
100	118	$langPHP_html .= '</div>';
101	119	closedir($openDir);
		@@ -113,16 +131,18 @@ discard block
		block discarded – undo
113	131
114	132	public static function setup(){
115	133	global $_GET, $_SESSION, $LANG;
116		- if(session_status() == PHP_SESSION_NONE) session_start();
	134	+ if(session_status() == PHP_SESSION_NONE) {
	135	+ session_start();
	136	+ }
117	137	if($_GET && $_GET['lang']){
118	138	if(multilang::ctrl($_GET['lang'])){
119	139	multilang::set("lang", $_GET['lang']);
120	140	require_once(multilang::get("dir&lang", 1));
121	141	multilang::set("log", sprintf("Language file loading (%s.php)", multilang::get("dir&lang",1)));
122		- }else{
	142	+ } else{
123	143	multilang::set("log", sprintf("Language file not found (%s.php)", multilang::$dir.$_GET['lang']));
124	144	}
125		- }else{
	145	+ } else{
126	146	require_once(multilang::get("dir&lang", 1));
127	147	multilang::set("log", sprintf("Language file loading (%s.php)", multilang::get("dir&lang",1)));
128	148	}

mberatsanli / multilangPHP

Branch — master (02ef0c)

Category

Spacing +22 added lines, -22 removed lines patch added patch discarded remove patch

Braces +32 added lines, -12 removed lines patch added patch discarded remove patch