InMemoryList\Infrastructure\Domain\Model\ListCollectionFactory::create()

Complexity

Conditions	5
Paths	5

Size

Total Lines	19
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function create(array $elements, array $headers = [], $uuid = null, $elementUuid = null)
    {
        if (empty($elements)) {
            throw new CreateListFromEmptyArrayException('Try to create a collection from an empty array.');
        }

        $listUuid = new ListCollectionUuid($uuid);
        $list = new ListCollection($listUuid);

        foreach ($elements as $element) {
            $newElementUuid = new ListElementUuid(($elementUuid) ? (string) $this->getValueFromKey($element, $elementUuid) : null);

It seems like $elementUuid ? (string)$this->getValueFromKey($element, $elementUuid) : null can also be of type string; however, parameter $uuid of InMemoryList\Domain\Model\ListElementUuid::__construct() does only seem to accept null, maybe add an additional type check?

            $list->addElement(new ListElement($newElementUuid, $element));
        }

        if ($headers) {

The expression $headers of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            $list->setHeaders($headers);
        }

        return $list;
    }