InMemoryList\Infrastructure\Domain\Model\ListCollectionFactory

Complexity

Total Complexity

15

Size/Duplication

Total Lines	67
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getValueKeyFromObject()	0	9	4
A	create()	0	19	5
A	getValueFromKey()	0	9	6

<?php
/**
 * This file is part of the InMemoryList package.
 *
 * (c) Mauro Cassani<https://github.com/mauretto78>
 *
 *  For the full copyright and license information, please view the LICENSE
 *  file that was distributed with this source code.
 */

namespace InMemoryList\Infrastructure\Domain\Model;

use InMemoryList\Domain\Model\Contracts\ListFactoryInterface as Factory;
use InMemoryList\Domain\Model\ListCollection;
use InMemoryList\Domain\Model\ListCollectionUuid;
use InMemoryList\Domain\Model\ListElement;
use InMemoryList\Domain\Model\ListElementUuid;
use InMemoryList\Infrastructure\Domain\Model\Exceptions\CreateListFromEmptyArrayException;
use InMemoryList\Infrastructure\Domain\Model\Exceptions\NotValidKeyElementInListException;

class ListCollectionFactory implements Factory
{
    /**
     * @param array $elements
     * @param array $headers
     * @param null  $uuid

Are you sure the doc-type for parameter $uuid is correct as it would always require null to be passed?

     * @param null  $elementUuid

Are you sure the doc-type for parameter $elementUuid is correct as it would always require null to be passed?

     *
     * @return ListCollection
     *
     * @throws CreateListFromEmptyArrayException
     */
    public function create(array $elements, array $headers = [], $uuid = null, $elementUuid = null)
    {
        if (empty($elements)) {
            throw new CreateListFromEmptyArrayException('Try to create a collection from an empty array.');
        }

        $listUuid = new ListCollectionUuid($uuid);
        $list = new ListCollection($listUuid);

        foreach ($elements as $element) {
            $newElementUuid = new ListElementUuid(($elementUuid) ? (string) $this->getValueFromKey($element, $elementUuid) : null);

It seems like $elementUuid ? (string)$this->getValueFromKey($element, $elementUuid) : null can also be of type string; however, parameter $uuid of InMemoryList\Domain\Model\ListElementUuid::__construct() does only seem to accept null, maybe add an additional type check?

            $list->addElement(new ListElement($newElementUuid, $element));
        }

        if ($headers) {

The expression $headers of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            $list->setHeaders($headers);
        }

        return $list;
    }

    /**
     * @param $element
     * @param $key
     *
     * @return mixed
     *
     * @throws NotValidKeyElementInListException
     */
    private function getValueFromKey($element, $key)
    {
        if ((is_object($element) && !$this->getValueKeyFromObject($element, $key)) || (is_array($element) && !isset($element[$key]))) {
            $getterName = 'get'.str_replace(' ', '', ucwords($key));

            throw new NotValidKeyElementInListException($key.' is not a valid key. If your elements are Entities class, please check if you implement '.$getterName.'() method.');
        }

        return is_object($element) ? $this->getValueKeyFromObject($element, $key) : $element[$key];
    }

    /**
     * @param $element
     * @param $key
     *
     * @return bool
     */
    private function getValueKeyFromObject($element, $key)
    {
        if (!$element instanceof \stdClass) {
            $getterName = 'get'.str_replace(' ', '', ucwords($key));

            return (method_exists($element, $getterName)) ? $element->$getterName() : false;
        }

        return (isset($element->{$key})) ? $element->{$key} : false;
    }
}