mattheworres / phpdraft

api/config/_middlewares.php

Unused Use Statements -3 removed lines

@@ -2,10 +2,7 @@
 use Silex\Application;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\HttpFoundation\ParameterBag;
 use PhpDraft\Domain\Models\PhpDraftResponse;
-use Symfony\Component\Debug\ErrorHandler;
-use Symfony\Component\Debug\ExceptionHandler;
 
 if (!$app instanceof Silex\Application) {
   throw new Exception('Invalid application setup.');

Spacing +9 added lines, -9 removed lines

@@ -11,12 +11,12 @@ 
   throw new Exception('Invalid application setup.');
 }
 
-$app->error(function (\Exception $e, $code) use($app) {
+$app->error(function(\Exception $e, $code) use($app) {
   return $app->json(array("error" => $e->getMessage()), Response::HTTP_INTERNAL_SERVER_ERROR);
 });
 
 //If we get application/json, decode the data so controllers can use it
-$app->before(function (Request $request) {
+$app->before(function(Request $request) {
   if (0 === strpos($request->headers->get('Content-Type'), 'application/json')) {
     $data = json_decode($request->getContent(), true);
     $request->request->replace(is_array($data) ? $data : array());
@@ -29,7 +29,7 @@ 
 
   $viewable = $app['phpdraft.DraftValidator']->IsDraftViewableForUser($draft_id, $request);
 
-  if(!$viewable) {
+  if (!$viewable) {
     $response = new PhpDraftResponse(false, array());
     $response->errors[] = "Draft marked as private.";
 
@@ -43,7 +43,7 @@ 
 
   $setting_up = $app['phpdraft.DraftValidator']->IsDraftSettingUpOrInProgress($draft);
 
-  if(!$setting_up->success) {
+  if (!$setting_up->success) {
     return $app->json(array($setting_up), $setting_up->responseType());
   }
 };
@@ -54,7 +54,7 @@ 
 
   $in_progress = $app['phpdraft.DraftValidator']->IsDraftInProgress($draft);
 
-  if(!$in_progress->success) {
+  if (!$in_progress->success) {
     return $app->json(array($in_progress), $in_progress->responseType());
   }
 };
@@ -65,7 +65,7 @@ 
 
   $in_progress = $app['phpdraft.DraftValidator']->IsDraftInProgressOrComplete($draft);
 
-  if(!$in_progress->success) {
+  if (!$in_progress->success) {
     return $app->json(array($in_progress), $in_progress->responseType());
   }
 };
@@ -77,7 +77,7 @@ 
 
   $grace_period = $app['phpdraft.DraftValidator']->IsDraftInProgressOrCompletedInLessThanTen($draft);
 
-  if(!$grace_period->success) {
+  if (!$grace_period->success) {
     return $app->json(array($grace_period), $grace_period->responseType());
   }
 };
@@ -88,7 +88,7 @@ 
 
   $completed = $app['phpdraft.DraftValidator']->IsDraftComplete($draft);
 
-  if(!$completed->success) {
+  if (!$completed->success) {
     return $app->json(array($completed), $completed->responseType());
   }
 };
@@ -101,7 +101,7 @@ 
 
   $editable = $app['phpdraft.DraftValidator']->IsDraftEditableForUser($draft, $current_user);
 
-  if(!$editable) {
+  if (!$editable) {
     $response = new PhpDraft\Domain\Models\PhpDraftResponse(false, array());
     $response->errors[] = "You do not have permission to this draft.";
 

api/config/_security.php

Unused Use Statements -3 removed lines

@@ -1,9 +1,6 @@
 <?php
 
-use Symfony\Component\DependencyInjection\Definition;
-use Symfony\Component\DependencyInjection\Reference;
 use PhpDraft\Config\Security\UserProvider;
-use PhpDraft\Config\Security\AuthenticationEntryPoint;
 
 if (!$app instanceof Silex\Application) {
   throw new Exception('Invalid application setup.');

Spacing +1 added lines, -1 removed lines

@@ -9,7 +9,7 @@
   throw new Exception('Invalid application setup.');
 }
 
-$app['users'] = function () use ($app) {
+$app['users'] = function() use ($app) {
   return new UserProvider($app);
 };
 

api/Controllers/Admin/DraftStatsController.php

Unused Use Statements -3 removed lines

@@ -3,10 +3,7 @@
 namespace PhpDraft\Controllers\Admin;
 
 use \Silex\Application;
-use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\HttpFoundation\Request;
-use PhpDraft\Domain\Models\PhpDraftResponse;
-use PhpDraft\Domain\Entities\Draft;
 
 class DraftStatsController
 {

api/Controllers/Admin/ProPlayerController.php

Unused Use Statements -2 removed lines

@@ -5,8 +5,6 @@
 use \Silex\Application;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\HttpFoundation\Request;
-use PhpDraft\Domain\Models\PhpDraftResponse;
-use PhpDraft\Domain\Entities\Draft;
 
 class ProPlayerController
 {

Spacing +1 added lines, -1 removed lines

@@ -22,7 +22,7 @@
 
     $validity = $app['phpdraft.ProPlayerValidator']->IsUploadSportValid($sport, $file);
 
-    if(!$validity->success) {
+    if (!$validity->success) {
       return $app->json($validity, $validity->responseType());
     }
 

api/Controllers/Admin/UserController.php

Unused Use Statements -2 removed lines

@@ -3,10 +3,8 @@
 namespace PhpDraft\Controllers\Admin;
 
 use \Silex\Application;
-use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\HttpFoundation\Request;
 use PhpDraft\Domain\Models\PhpDraftResponse;
-use PhpDraft\Domain\Entities\Draft;
 
 class UserController
 {

Spacing +2 added lines, -2 removed lines

@@ -30,7 +30,7 @@ 
 
     $validity = $app['phpdraft.LoginUserValidator']->IsAdminUserUpdateValid($user);
 
-    if(!$validity->success) {
+    if (!$validity->success) {
       return $app->json($validity, $validity->responseType());
     }
 
@@ -45,7 +45,7 @@ 
     $user_id = $request->get('user_id');
     $user = $app['phpdraft.LoginUserRepository']->LoadById($user_id);
 
-    if($app['phpdraft.LoginUserService']->CurrentUserIsAdmin($user)) {
+    if ($app['phpdraft.LoginUserService']->CurrentUserIsAdmin($user)) {
       $response = new PhpDraftResponse(false, array());
       $response->errors[] = "Unable to delete user - user is admin.";
 

api/Controllers/Commish/DraftController.php

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use \Silex\Application;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\HttpFoundation\Request;
-use PhpDraft\Domain\Models\PhpDraftResponse;
 use PhpDraft\Domain\Entities\Draft;
 
 class DraftController

Spacing +11 added lines, -11 removed lines

@@ -42,18 +42,18 @@ 
 
     $validity = $app['phpdraft.DraftValidator']->IsDraftValidForCreateAndUpdate($draft);
 
-    if(!$validity->success) {
+    if (!$validity->success) {
       return $app->json($validity, Response::HTTP_BAD_REQUEST);
     }
 
     $createPositionsModel = null;
 
-    if($draft->using_depth_charts == 1) {
+    if ($draft->using_depth_charts == 1) {
       $createPositionsModel = $this->_BuildDepthChartPositionModel($request);
 
       $positionValidity = $app['phpdraft.DepthChartPositionValidator']->AreDepthChartPositionsValid($createPositionsModel);
 
-      if(!$positionValidity->success) {
+      if (!$positionValidity->success) {
         return $app->json($positionValidity, Response::HTTP_BAD_REQUEST);
       }
     }
@@ -90,18 +90,18 @@ 
 
     $validity = $app['phpdraft.DraftValidator']->IsDraftValidForCreateAndUpdate($draft);
 
-    if(!$validity->success) {
+    if (!$validity->success) {
       return $app->json($validity, Response::HTTP_BAD_REQUEST);
     }
 
     $createPositionsModel = null;
 
-    if($draft->using_depth_charts == 1) {
+    if ($draft->using_depth_charts == 1) {
       $createPositionsModel = $this->_BuildDepthChartPositionModel($request);
 
       $positionValidity = $app['phpdraft.DepthChartPositionValidator']->AreDepthChartPositionsValid($createPositionsModel);
 
-      if(!$positionValidity->success) {
+      if (!$positionValidity->success) {
         return $app->json($positionValidity, Response::HTTP_BAD_REQUEST);
       }
     }
@@ -120,7 +120,7 @@ 
 
     $validity = $app['phpdraft.DraftValidator']->IsDraftStatusValid($draft, $oldStatus);
 
-    if(!$validity->success) {
+    if (!$validity->success) {
       return $app->json($validity, Response::HTTP_BAD_REQUEST);
     }
 
@@ -154,10 +154,10 @@ 
     $createModel = new \PhpDraft\Domain\Models\RoundTimeCreateModel();
     $createModel->isRoundTimesEnabled = (bool)$request->get('isRoundTimesEnabled');
 
-    if($createModel->isRoundTimesEnabled) {
+    if ($createModel->isRoundTimesEnabled) {
       $roundTimesJson = $request->get('roundTimes');
 
-      foreach($roundTimesJson as $roundTimeRequest) {
+      foreach ($roundTimesJson as $roundTimeRequest) {
         $newRoundTime = new \PhpDraft\Domain\Entities\RoundTime();
         $newRoundTime->draft_id = $draftId;
         $newRoundTime->is_static_time = $roundTimeRequest['is_static_time'] == "true" ? 1 : 0;
@@ -170,7 +170,7 @@ 
 
     $validity = $app['phpdraft.RoundTimeValidator']->AreRoundTimesValid($createModel);
 
-    if(!$validity->success) {
+    if (!$validity->success) {
       return $app->json($validity, Response::HTTP_BAD_REQUEST);
     }
 
@@ -187,7 +187,7 @@ 
     $depthChartPositionJson = $request->get('depthChartPositions');
     $display_order = 0;
 
-    foreach($depthChartPositionJson as $depthChartPositionRequest) {
+    foreach ($depthChartPositionJson as $depthChartPositionRequest) {
       $depthChartPosition = new \PhpDraft\Domain\Entities\DepthChartPosition();
       $depthChartPosition->draft_id = $draftId;
       $depthChartPosition->position = $depthChartPositionRequest['position'];

api/Controllers/Commish/PickController.php

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use \Silex\Application;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use PhpDraft\Domain\Entities\ProPlayer;
 use PhpDraft\Domain\Models\PhpDraftResponse;
 
 class PickController {

Spacing +6 added lines, -6 removed lines

@@ -30,7 +30,7 @@ 
       $pick->last_name = $request->get('last_name');
       $pick->team = $request->get('team');
       $pick->position = $request->get('position');
-    } catch(\Exception $e) {
+    } catch (\Exception $e) {
       $response = new PhpDraftResponse(false, array());
       $response->errors[] = "Unable to add pick #$pick_id";
 
@@ -39,7 +39,7 @@ 
 
     $validity = $app['phpdraft.PickValidator']->IsPickValidForAdd($draft, $pick);
 
-    if(!$validity->success) {
+    if (!$validity->success) {
       return $app->json($validity, $validity->responseType());
     }
 
@@ -60,7 +60,7 @@ 
       $pick->last_name = $request->get('last_name');
       $pick->team = $request->get('team');
       $pick->position = $request->get('position');
-    } catch(\Exception $e) {
+    } catch (\Exception $e) {
       $response = new PhpDraftResponse(false, array());
       $response->errors[] = "Unable to edit pick #$pick_id";
 
@@ -69,7 +69,7 @@ 
 
     $validity = $app['phpdraft.PickValidator']->IsPickValidForUpdate($draft, $pick);
 
-    if(!$validity->success) {
+    if (!$validity->success) {
       return $app->json($validity, $validity->responseType());
     }
 
@@ -99,7 +99,7 @@ 
       $response->draft_rounds = $draft->draft_rounds;
       $response->last_5_picks = $app['phpdraft.PickRepository']->LoadLastPicks($draft_id, 5);
       $response->success = true;
-    } catch(\Exception $e) {
+    } catch (\Exception $e) {
       $response->success = false;
       $response->errors[] = "Unable to load last 5 picks.";
     }
@@ -117,7 +117,7 @@ 
       $response->round = $round;
       $response->round_picks = $app['phpdraft.PickRepository']->LoadRoundPicks($draft, $round, false, true);
       $response->success = true;
-    } catch(\Exception $e) {
+    } catch (\Exception $e) {
       $response->success = false;
       $response->errors[] = "Unable to load round #$round's picks";
     }

api/Controllers/Commish/ProPlayerController.php

Unused Use Statements -2 removed lines

@@ -4,8 +4,6 @@
 
 use \Silex\Application;
 use Symfony\Component\HttpFoundation\Request;
-use Symfony\Component\HttpFoundation\Response;
-use PhpDraft\Domain\Entities\ProPlayer;
 use PhpDraft\Domain\Models\PhpDraftResponse;
 
 class ProPlayerController {

Spacing +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
 
     $response = new PhpDraftResponse();
 
-    if(count($searchTerm) > 0) {
+    if (count($searchTerm) > 0) {
       $response = $app['phpdraft.ProPlayerService']->SearchPlayers($league, $searchTerm);
     } else {
       $response = $app['phpdraft.ProPlayerService']->SearchPlayersManual($league, $first, $last, $team, $position);

api/Controllers/Commish/TradeController.php

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
 use Symfony\Component\HttpFoundation\Response;
 use PhpDraft\Domain\Entities\Trade;
 use PhpDraft\Domain\Entities\TradeAsset;
-use PhpDraft\Domain\Entities\Manager;
 use PhpDraft\Domain\Models\PhpDraftResponse;
 
 class TradeController {

Spacing +7 added lines, -7 removed lines

@@ -19,7 +19,7 @@ 
 
     try {
       $manager = $app['phpdraft.ManagerRepository']->Load($managerId);
-    } catch(\Exception $e) {
+    } catch (\Exception $e) {
       $response = new PhpDraftResponse(false, array());
       $response->errors[] = "Unable to load manager #$managerId";
       return $app->json($response, Response::HTTP_BAD_REQUEST);
@@ -27,7 +27,7 @@ 
 
     $validity = $app['phpdraft.TradeValidator']->IsManagerValidForAssetRetrieval($draft, $manager);
 
-    if(!$validity->success) {
+    if (!$validity->success) {
       return $app->json($validity, Response::HTTP_BAD_REQUEST);
     }
 
@@ -53,17 +53,17 @@ 
       $newTrade->manager1 = $app['phpdraft.ManagerRepository']->Load($newTrade->manager1_id);
       $newTrade->manager2 = $app['phpdraft.ManagerRepository']->Load($newTrade->manager2_id);
 
-      foreach($assets_json as $asset_id) {
+      foreach ($assets_json as $asset_id) {
         $newTradeAsset = new TradeAsset();
         $newTradeAsset->player = $app['phpdraft.PickRepository']->Load($asset_id);
         $newTradeAsset->was_drafted = $app['phpdraft.PickService']->PickHasBeenSelected($newTradeAsset->player);
 
-        if($newTradeAsset->player->manager_id == $newTrade->manager1_id) {
+        if ($newTradeAsset->player->manager_id == $newTrade->manager1_id) {
           $newTradeAsset->oldmanager_id = $newTrade->manager1_id;
           $newTradeAsset->newmanager_id = $newTrade->manager2_id;
           $newTradeAsset->oldmanager = $newTrade->manager1;
           $newTradeAsset->newmanager = $newTrade->manager2;
-        } else if($newTradeAsset->player->manager_id == $newTrade->manager2_id) {
+        } else if ($newTradeAsset->player->manager_id == $newTrade->manager2_id) {
           $newTradeAsset->oldmanager_id = $newTrade->manager2_id;
           $newTradeAsset->newmanager_id = $newTrade->manager1_id;
           $newTradeAsset->oldmanager = $newTrade->manager2;
@@ -74,7 +74,7 @@ 
 
         $newTrade->trade_assets[] = $newTradeAsset;
       }
-    } catch(\Exception $e) {
+    } catch (\Exception $e) {
       $response = new PhpDraftResponse(false, array());
       $message = $e->getMessage();
       $response->errors[] = "Unable to build trade: $message";
@@ -84,7 +84,7 @@ 
 
     $validity = $app['phpdraft.TradeValidator']->IsTradeValid($draft, $newTrade);
 
-    if(!$validity->success) {
+    if (!$validity->success) {
       return $app->json($validity, Response::HTTP_BAD_REQUEST);
     }