mattheworres / phpdraft

api/config/Security/UserProvider.php

Braces +6 added lines, -4 removed lines

@@ -25,11 +25,13 @@
     $user_stmt->setFetchMode(\PDO::FETCH_INTO, $user);
     $user_stmt->bindParam(1, $email);
 
-    if (!$user_stmt->execute())
-      throw new UsernameNotFoundException(sprintf('Email "%s" does not exist.', $email));
+    if (!$user_stmt->execute()) {
+          throw new UsernameNotFoundException(sprintf('Email "%s" does not exist.', $email));
+    }
 
-    if (!$user_stmt->fetch())
-      throw new UsernameNotFoundException(sprintf('Email "%s" does not exist.', $email));
+    if (!$user_stmt->fetch()) {
+          throw new UsernameNotFoundException(sprintf('Email "%s" does not exist.', $email));
+    }
 
     return new PhpDraftSecurityUser($user->email,
       $user->name,

api/Domain/Services/DraftService.php

Braces +3 added lines, -3 removed lines

@@ -34,7 +34,7 @@ 
 
       $response->success = true;
       $response->draft = $draft;
-    }catch(\Exception $e) {
+    } catch(\Exception $e) {
       $response->success = false;
       $response->errors = array($e->getMessage());
     }
@@ -55,7 +55,7 @@ 
 
       $response->success = true;
       $response->draft = $draft;
-    }catch(\Exception $e) {
+    } catch(\Exception $e) {
       $response->success = false;
       $response->errors = array($e->getMessage());
     }
@@ -85,7 +85,7 @@ 
 
       $response->success = true;
       $response->draft = $draft;
-    }catch(\Exception $e) {
+    } catch(\Exception $e) {
       $response->success = false;
       $response->errors = array($e->getMessage());
     }

api/Domain/Services/RoundTimeService.php

Braces +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
 
       $response->success = true;
       $response->roundTimes = $roundTimes;
-    }catch(\Exception $e) {
+    } catch(\Exception $e) {
       $response->success = false;
       $response->errors = array($e->getMessage());
     }

api/Domain/Services/ManagerService.php

Braces +3 added lines, -3 removed lines

@@ -21,7 +21,7 @@ 
 
       $response->success = true;
       $response->manager = $manager;
-    }catch(\Exception $e) {
+    } catch(\Exception $e) {
       $response->success = false;
       $response->errors = array($e->getMessage());
     }
@@ -37,7 +37,7 @@ 
 
       $response->success = true;
       $response->managers = $managers;
-    }catch(\Exception $e) {
+    } catch(\Exception $e) {
       $response->success = false;
       $response->errors = array($e->getMessage());
     }
@@ -52,7 +52,7 @@ 
       $this->app['phpdraft.ManagerRepository']->ReorderManagers($managersIdArray);
       
       $response->success = true;
-    }catch(\Exception $e) {
+    } catch(\Exception $e) {
       $response->success = false;
       $response->errors = array($e->getMessage());
     }

api/Domain/Services/PickService.php

Braces +5 added lines, -4 removed lines

@@ -200,10 +200,11 @@
     $pick->pick_time = $now_utc->format('Y-m-d H:i:s');
 
     //Calculate the pick duration
-    if ($pick->player_pick == 1 || $previous_pick == null)
-      $start_time = new \DateTime($draft->draft_start_time, new \DateTimeZone("UTC"));
-    else
-      $start_time = new \DateTime($previous_pick->pick_time, new \DateTimeZone("UTC"));
+    if ($pick->player_pick == 1 || $previous_pick == null) {
+          $start_time = new \DateTime($draft->draft_start_time, new \DateTimeZone("UTC"));
+    } else {
+          $start_time = new \DateTime($previous_pick->pick_time, new \DateTimeZone("UTC"));
+    }
 
     $start_time_timestamp = $start_time->getTimestamp();
 

api/Domain/Services/ProPlayerService.php

Braces +6 added lines, -4 removed lines

@@ -67,12 +67,14 @@
       return $response;
     }
 
-    if (SET_CSV_TIMEOUT)
-      set_time_limit(0);
+    if (SET_CSV_TIMEOUT) {
+          set_time_limit(0);
+    }
 
     while (($data = fgetcsv($handle, 1000, ';')) !== FALSE) {
-      if ($data[0] == "Player")
-        continue;
+      if ($data[0] == "Player") {
+              continue;
+      }
 
       $new_player = new ProPlayer();
 

api/Domain/Services/LoginUserService.php

Braces +5 added lines, -5 removed lines

@@ -44,7 +44,7 @@ 
       $email = $decoded->name;
 
       return $this->app['phpdraft.LoginUserRepository']->Load($email);
-    }catch(\Exception $ex) {
+    } catch(\Exception $ex) {
       return null;
     }
   }
@@ -128,7 +128,7 @@ 
       $this->app['phpdraft.EmailService']->SendMail($message);
 
       $response->success = true;
-    }catch(\Exception $e) {
+    } catch(\Exception $e) {
       //$this->app['db']->rollback();
 
       $response->success = false;
@@ -187,7 +187,7 @@ 
       $response->success = true;
 
       $this->app['db']->commit();
-    }catch(\Exception $e) {
+    } catch(\Exception $e) {
       $this->app['db']->rollback();
 
       $response->success = false;
@@ -212,7 +212,7 @@ 
       $response->success = true;
 
       $this->app['db']->commit();
-    }catch(\Exception $e) {
+    } catch(\Exception $e) {
       $this->app['db']->rollback();
 
       $response->success = false;
@@ -282,7 +282,7 @@ 
       $response->sendEmail = $sendEmail;
 
       $this->app['db']->commit();
-    }catch(\Exception $e) {
+    } catch(\Exception $e) {
       $this->app['db']->rollback();
 
       $response->success = false;

api/Domain/Repositories/TradeRepository.php

Braces +19 added lines, -13 removed lines

@@ -31,7 +31,7 @@ 
         $trade->manager1 = $this->app['phpdraft.ManagerRepository']->Load($trade->manager1_id);
         $trade->manager2 = $this->app['phpdraft.ManagerRepository']->Load($trade->manager2_id);
         $trade->trade_assets = $this->GetAssets($trade, $trade->manager1, $trade->manager2);
-      }catch(\Exception $e) {
+      } catch(\Exception $e) {
         throw new \Exception("Unable to load managers or trade assets: " . $e->getMessage());
       }
 
@@ -58,19 +58,22 @@ 
     while ($asset = $stmt->fetch()) {
       /* @var $asset trade_asset_object */
       //We must use the protected $newmanager_id and $oldmanager_id because we have just pulled from DB, objs aren't automatic:
-      if ($asset->newmanager_id != $manager1->manager_id && $asset->newmanager_id != $manager2->manager_id)
-        throw new \Exception('Invalid manager ID for asset: ' . $asset->newmanager_id);
+      if ($asset->newmanager_id != $manager1->manager_id && $asset->newmanager_id != $manager2->manager_id) {
+              throw new \Exception('Invalid manager ID for asset: ' . $asset->newmanager_id);
+      }
 
-      if ($asset->oldmanager_id != $manager1->manager_id && $asset->oldmanager_id != $manager2->manager_id)
-        throw new \Exception('Invalid manager ID for asset: ' . $asset->oldmanager_id);
+      if ($asset->oldmanager_id != $manager1->manager_id && $asset->oldmanager_id != $manager2->manager_id) {
+              throw new \Exception('Invalid manager ID for asset: ' . $asset->oldmanager_id);
+      }
 
       //Use passed in manager_objects to prevent unneccessary SELECTs to the db:
       $asset->player = $this->app['phpdraft.PickRepository']->Load($asset->player_id);
       $asset->newmanager = $asset->newmanager_id == $manager1->manager_id ? $manager1 : $manager2;
       $asset->oldmanager = $asset->oldmanager_id == $manager1->manager_id ? $manager1 : $manager2;
 
-      if ($asset->player == false || $asset->newmanager == false || $asset->oldmanager == false)
-        throw new \Exception('Invalid asset loaded.');
+      if ($asset->player == false || $asset->newmanager == false || $asset->oldmanager == false) {
+              throw new \Exception('Invalid asset loaded.');
+      }
 
       $assets[] = $asset;
     }
@@ -89,8 +92,9 @@ 
 
     $trades = array();
 
-    while ($trade = $draft_trade_stmt->fetch())
-      $trades[] = $trade;
+    while ($trade = $draft_trade_stmt->fetch()) {
+          $trades[] = $trade;
+    }
 
     $delete_assets_stmt = $this->app['db']->prepare("DELETE FROM trade_assets WHERE trade_id = :trade_id");
     $delete_trade_stmt = $this->app['db']->prepare("DELETE FROM trades WHERE trade_id = :trade_id");
@@ -98,13 +102,15 @@ 
     foreach ($trades as $trade) {
       $delete_assets_stmt->bindValue(":trade_id", $trade->trade_id);
 
-      if (!$delete_assets_stmt->execute())
-        throw new \Exception("Unable to delete trade assets for $draft_id.");
+      if (!$delete_assets_stmt->execute()) {
+              throw new \Exception("Unable to delete trade assets for $draft_id.");
+      }
 
       $delete_trade_stmt->bindValue(":trade_id", $trade->trade_id);
 
-      if (!$delete_trade_stmt->execute())
-        throw new \Exception("Unable to delete trade assets for $draft_id.");
+      if (!$delete_trade_stmt->execute()) {
+              throw new \Exception("Unable to delete trade assets for $draft_id.");
+      }
     }
 
     return;

api/Domain/Repositories/PickRepository.php

Braces +17 added lines, -12 removed lines

@@ -371,11 +371,13 @@ 
     $sql = "SELECT p.*, m.manager_name, MATCH (p.first_name, p.last_name) AGAINST (?) as search_score " .
             "FROM players p LEFT OUTER JOIN managers m ON m.manager_id = p.manager_id WHERE MATCH (p.first_name, p.last_name) AGAINST (?) AND p.draft_id = ? ";
 
-    if ($searchModel->hasTeam())
-      $sql .= "AND p.team = ? ";
+    if ($searchModel->hasTeam()) {
+          $sql .= "AND p.team = ? ";
+    }
 
-    if ($searchModel->hasPosition())
-      $sql .= "AND p.position = ? ";
+    if ($searchModel->hasPosition()) {
+          $sql .= "AND p.position = ? ";
+    }
 
     $sql .= "AND p.pick_time IS NOT NULL ORDER BY search_score ASC, p.player_pick $searchModel->sort";
 
@@ -421,14 +423,17 @@ 
 
     $sql = "SELECT p.*, m.manager_name FROM players p LEFT OUTER JOIN managers m ON m.manager_id = p.manager_id WHERE p.draft_id = ? ";
 
-    if ($searchModel->hasName())
-      $sql .= "AND (p.first_name LIKE ? OR p.last_name LIKE ?)";
+    if ($searchModel->hasName()) {
+          $sql .= "AND (p.first_name LIKE ? OR p.last_name LIKE ?)";
+    }
 
-    if ($searchModel->hasTeam())
-      $sql .= "AND p.team = ? ";
+    if ($searchModel->hasTeam()) {
+          $sql .= "AND p.team = ? ";
+    }
 
-    if ($searchModel->hasPosition())
-      $sql .= "AND p.position = ? ";
+    if ($searchModel->hasPosition()) {
+          $sql .= "AND p.position = ? ";
+    }
 
     $sql .= "AND p.pick_time IS NOT NULL ORDER BY p.player_pick $searchModel->sort";
 
@@ -584,9 +589,9 @@ 
           $managers = $descending_managers;
           $even = true;
         }
+      } else {
+              $managers = $ascending_managers;
       }
-      else
-        $managers = $ascending_managers;
 
       foreach ($managers as $manager) {
         $new_pick = new Pick();