GitElephant\Command\ResetCommand::reset()

Complexity

Conditions	4
Paths	4

Size

Total Lines	16
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function reset($arg = null, Array $options = array())

As per coding-style, PHP keywords should be in lowercase; expected array, but found Array.

    {
        $this->clearAll();
        $this->addCommandName(self::GIT_RESET_COMMAND);
        // if there are options add them.
        if (! is_null($options)) {
            foreach ($options as $option) {
                $this->addCommandArgument($option);
            }
        }
        if($arg!=null){

It seems like you are loosely comparing $arg of type GitElephant\Objects\TreeishInterface|string|null against null; this is ambiguous if the string can be empty. Consider using a strict comparison !== instead.

Expected 1 space after IF keyword; 0 found

            $this->addCommandSubject2($arg);

It seems like $arg defined by parameter $arg on line 43 can also be of type object<GitElephant\Objects\TreeishInterface>; however, GitElephant\Command\BaseCommand::addCommandSubject2() does only seem to accept string, maybe add an additional type check?

        }

        return $this->getCommand();
    }

}