GitElephant\Command\ResetCommand

Complexity

Total Complexity

6

Size/Duplication

Total Lines	54
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	reset()	0	16	4
A	getInstance()	0	4	1

<?php
/**
 * Created by PhpStorm.
 * User: christian
 * Date: 3/2/16
 * Time: 11:29 AM
 */

namespace GitElephant\Command;


use GitElephant\Objects\Commit;
use GitElephant\Objects\Tag;
use GitElephant\Objects\TreeishInterface;
use \GitElephant\Repository;

class ResetCommand extends BaseCommand
{
    const GIT_RESET_COMMAND = 'reset';

    const OPTION_HARD  = '--hard';
    const OPTION_MERGE = '--merge';
    const OPTION_SOFT  = '--soft';

    /**
     * constructor
     *
     * @param \GitElephant\Repository $repo The repository object this command
     *                                      will interact with
     */
    public function __construct(Repository $repo = null)
    {
        parent::__construct($repo);
    }

    /**
     * @param TreeishInterface|Commit|string $arg
     * @param array $options
     *
     * @throws \RuntimeException
     * @return string
     */
    public function reset($arg = null, Array $options = array())

As per coding-style, PHP keywords should be in lowercase; expected array, but found Array.

    {
        $this->clearAll();
        $this->addCommandName(self::GIT_RESET_COMMAND);
        // if there are options add them.
        if (! is_null($options)) {
            foreach ($options as $option) {
                $this->addCommandArgument($option);
            }
        }
        if($arg!=null){

It seems like you are loosely comparing $arg of type GitElephant\Objects\TreeishInterface|string|null against null; this is ambiguous if the string can be empty. Consider using a strict comparison !== instead.

Expected 1 space after IF keyword; 0 found

            $this->addCommandSubject2($arg);

It seems like $arg defined by parameter $arg on line 43 can also be of type object<GitElephant\Objects\TreeishInterface>; however, GitElephant\Command\BaseCommand::addCommandSubject2() does only seem to accept string, maybe add an additional type check?

        }

        return $this->getCommand();
    }

    /**
     * @return ResetCommand
     */
    public static function getInstance()
    {
        return new self();
    }



}