matiasdelellis / facerecognition

lib/BackgroundJob/BackgroundService.php

Unused Use Statements -4 removed lines

@@ -24,8 +24,6 @@ 
 namespace OCA\FaceRecognition\BackgroundJob;
 
 use OCA\FaceRecognition\AppInfo\Application;
-use OCA\FaceRecognition\Helper\Requirements;
-
 use OCA\FaceRecognition\BackgroundJob\Tasks\CheckCronTask;
 use OCA\FaceRecognition\BackgroundJob\Tasks\CheckRequirementsTask;
 use OCA\FaceRecognition\BackgroundJob\Tasks\LockTask;
@@ -35,8 +33,6 @@ 
 use OCA\FaceRecognition\BackgroundJob\Tasks\ImageProcessingTask;
 use OCA\FaceRecognition\BackgroundJob\Tasks\UnlockTask;
 
-use Symfony\Component\Console\Output\OutputInterface;
-
 /**
  * Background service. Both command and cron job are calling this service for long-running background operations.
  * Background processing for face recognition is comprised of several steps, called tasks. Each task is independent,

lib/BackgroundJob/FaceRecognitionLogger.php

Unused Use Statements -1 removed lines

@@ -24,7 +24,6 @@
 namespace OCA\FaceRecognition\BackgroundJob;
 
 use OCP\ILogger;
-
 use Symfony\Component\Console\Output\OutputInterface;
 
 /**

lib/BackgroundJob/Tasks/CreateClustersTask.php

Unused Use Statements -4 removed lines

@@ -25,17 +25,13 @@
 
 use OCP\IConfig;
 use OCP\IUser;
-
 use OCA\FaceRecognition\BackgroundJob\FaceRecognitionBackgroundTask;
 use OCA\FaceRecognition\BackgroundJob\FaceRecognitionContext;
 use OCA\FaceRecognition\BackgroundJob\Tasks\AddMissingImagesTask;
-
 use OCA\FaceRecognition\Db\FaceNewMapper;
 use OCA\FaceRecognition\Db\ImageMapper;
 use OCA\FaceRecognition\Db\PersonMapper;
-
 use OCA\FaceRecognition\Helper\Euclidean;
-
 use OCA\FaceRecognition\Migration\AddDefaultFaceModel;
 
 /**

lib/BackgroundJob/Tasks/ImageProcessingTask.php

Unused Use Statements -4 removed lines

@@ -24,13 +24,9 @@
 namespace OCA\FaceRecognition\BackgroundJob\Tasks;
 
 use OC_Image;
-
 use OCP\Files\File;
-use OCP\Files\Folder;
 use OCP\IConfig;
 use OCP\ITempManager;
-use OCP\IUser;
-
 use OCA\FaceRecognition\BackgroundJob\FaceRecognitionBackgroundTask;
 use OCA\FaceRecognition\BackgroundJob\FaceRecognitionContext;
 use OCA\FaceRecognition\Db\FaceNew;

Doc Comments +1 added lines, -1 removed lines

@@ -273,7 +273,7 @@
 	 *
 	 * @param \FaceLandmarkDetection $fld Landmark detection model
 	 * @param \FaceRecognition $fr Face recognition model
-	 * @param ImageProcessingContext Image processing context
+	 * @param ImageProcessingContext ImageProcessingContext processing context
 	 */
 	private function populateDescriptors(\FaceLandmarkDetection $fld, \FaceRecognition $fr, ImageProcessingContext $imageProcessingContext) {
 		$faces = $imageProcessingContext->getFaces();

lib/Command/Analyze.php

Doc Comments +6 added lines

@@ -274,10 +274,16 @@
 		$this->output->writeln(count($facesFound).' faces(s) found.');
 	}
 
+	/**
+	 * @param integer $progress
+	 */
 	private function updateProgress($progress) {
 		$this->config->setAppValue('facerecognition', 'queue-done', $progress);
 	}
 
+	/**
+	 * @param integer $time
+	 */
 	private function setStartTime($time) {
 		$this->config->setAppValue('facerecognition', 'starttime', $time);
 	}

Unused Use Statements -5 removed lines

@@ -26,21 +26,16 @@
 namespace OCA\FaceRecognition\Command;
 
 use OCP\Encryption\IManager;
-use OCP\Files\File;
-use OCP\Files\Folder;
-use OCP\Files\IAppData;
 use OCP\Files\IRootFolder;
 use OCP\App\IAppManager;
 use OCP\Files\NotFoundException;
 use OCP\IConfig;
-use OCP\IDateTimeFormatter;
 use OCP\IUser;
 use OCP\IUserManager;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
-
 use OCA\FaceRecognition\Db\Face;
 use OCA\FaceRecognition\Db\FaceMapper;
 use OCA\FaceRecognition\Helper\Requirements;

lib/Command/Check.php

Unused Use Statements -6 removed lines

@@ -25,15 +25,9 @@
 
 use OCP\App\IAppManager;
 use OCP\Encryption\IManager;
-
 use Symfony\Component\Console\Command\Command;
-use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
-
-use OCA\FaceRecognition\Db\Face;
-use OCA\FaceRecognition\Db\FaceMapper;
-
 use OCA\FaceRecognition\Helper\Requirements;
 
 class Check extends Command {

lib/Command/Queue.php

Unused Use Statements -2 removed lines

@@ -29,7 +29,6 @@ 
 use OCP\Files\File;
 use OCP\Files\Folder;
 use OCP\Files\IRootFolder;
-use OCP\Files\NotFoundException;
 use OCP\IConfig;
 use OCP\IUser;
 use OCP\IUserManager;
@@ -37,7 +36,6 @@ 
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
-
 use OCA\FaceRecognition\Db\Face;
 use OCA\FaceRecognition\Db\FaceMapper;
 use OCA\FaceRecognition\Helper\Requirements;

lib/Command/Update.php

Unused Use Statements -5 removed lines

@@ -26,10 +26,7 @@ 
 namespace OCA\FaceRecognition\Command;
 
 use OCP\Encryption\IManager;
-use OCP\Files\File;
-use OCP\Files\Folder;
 use OCP\Files\IRootFolder;
-use OCP\Files\NotFoundException;
 use OCP\IConfig;
 use OCP\IUser;
 use OCP\IUserManager;
@@ -37,8 +34,6 @@ 
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
-
-use OCA\FaceRecognition\Db\Face;
 use OCA\FaceRecognition\Db\FaceMapper;
 use OCA\FaceRecognition\Helper\Euclidean;
 

lib/Db/FaceMapper.php

Unused Use Statements -2 removed lines

@@ -3,8 +3,6 @@
 
 use OCP\IDBConnection;
 use OCP\AppFramework\Db\Mapper;
-use OCP\AppFramework\Db\DoesNotExistException;
-use OCP\DB\QueryBuilder\IQueryBuilder;
 
 class FaceMapper extends Mapper {
 

Doc Comments +23 added lines

@@ -22,16 +22,27 @@ 
 		return $this->findEntities($sql, [$userId]);
 	}
 
+	/**
+	 * @param string $userId
+	 * @param integer $limit
+	 * @param integer $offset
+	 */
 	public function findAllQueued($userId, $limit = null, $offset = null) {
 		$sql = 'SELECT * FROM *PREFIX*face_recognition WHERE uid = ? AND distance = -1 AND encoding IS NULL';
 		return $this->findEntities($sql, [$userId], $limit, $offset);
 	}
 
+	/**
+	 * @param string $userId
+	 */
 	public function findAllKnown($userId) {
 		$sql = 'SELECT * FROM *PREFIX*face_recognition WHERE uid = ? AND distance = 0 AND encoding IS NOT NULL';
 		return $this->findEntities($sql, [$userId]);
 	}
 
+	/**
+	 * @param string $userId
+	 */
 	public function findAllUnknown($userId) {
 		$sql = 'SELECT * FROM *PREFIX*face_recognition WHERE uid = ? AND distance > 0 AND encoding IS NOT NULL';
 		return $this->findEntities($sql, [$userId]);
@@ -42,6 +53,9 @@ 
 		return $this->findEntities($sql, [$userId]);
 	}
 
+	/**
+	 * @param integer $limit
+	 */
 	public function findAllNamed($userId, $query, $limit = null, $offset = null) {
 		$sql = 'SELECT id, name, distance FROM *PREFIX*face_recognition WHERE uid = ? AND encoding IS NOT NULL AND LOWER(name) LIKE LOWER(?)';
 		return $this->findEntities($sql, [$userId, $query], $limit, $offset);
@@ -57,11 +71,17 @@ 
 		return $this->findEntities($sql, [$userId]);
 	}
 
+	/**
+	 * @param integer $fileId
+	 */
 	public function findNewFile($userId, $fileId) {
 		$sql = 'SELECT * FROM *PREFIX*face_recognition WHERE uid = ? AND file = ? AND distance = -1 AND encoding IS NULL';
 		return $this->findEntities($sql, [$userId, $fileId]);
 	}
 
+	/**
+	 * @param integer $fileId
+	 */
 	public function findFile($userId, $fileId) {
 		$sql = 'SELECT * FROM *PREFIX*face_recognition WHERE uid = ? AND file = ?';
 		return $this->findEntities($sql, [$userId, $fileId]);
@@ -78,6 +98,9 @@ 
 		return true;
 	}
 
+	/**
+	 * @param string $userId
+	 */
 	public function countUserQueue($userId) {
 		$sql = 'SELECT count(*) AS ct FROM *PREFIX*face_recognition WHERE uid = ? AND distance = -1 AND encoding IS NULL';
 		$query = \OCP\DB::prepare($sql);