matecat / xliff-parser

src/XliffReplacer/Xliff20.php

Spacing +63 added lines, -63 removed lines

@@ -32,18 +32,18 @@ 
     /**
      * @inheritDoc
      */
-    protected function tagOpen( $parser, $name, $attr ) {
+    protected function tagOpen($parser, $name, $attr) {
 
-        $this->handleOpenUnit( $name, $attr );
+        $this->handleOpenUnit($name, $attr);
 
-        if ( 'mda:metadata' === $name ) {
+        if ('mda:metadata' === $name) {
             $this->unitContainsMda = true;
         }
 
         // check if we are entering into a <target>
-        if ( 'target' === $name ) {
+        if ('target' === $name) {
 
-            if ( $this->currentTransUnitIsTranslatable === 'no' ) {
+            if ($this->currentTransUnitIsTranslatable === 'no') {
                 $this->inTarget = false;
             } else {
                 $this->inTarget = true;
@@ -51,13 +51,13 @@ 
         }
 
         // open buffer
-        if ( in_array( $name, $this->nodesToBuffer ) ) {
+        if (in_array($name, $this->nodesToBuffer)) {
             $this->bufferIsActive = true;
         }
 
         // check if we are inside a <target>, obviously this happen only if there are targets inside the trans-unit
         // <target> must be stripped to be replaced, so this check avoids <target> reconstruction
-        if ( !$this->inTarget ) {
+        if (!$this->inTarget) {
 
             $tag = '';
 
@@ -80,31 +80,31 @@ 
             // http://docs.oasis-open.org/xliff/xliff-core/v2.0/os/xliff-core-v2.0-os.html#unit
             //
             if (
-                    ( $name === 'notes' || $name === 'originalData' || $name === 'segment' || $name === 'ignorable' ) &&
+                    ($name === 'notes' || $name === 'originalData' || $name === 'segment' || $name === 'ignorable') &&
                     $this->unitContainsMda === false &&
-                    !empty( $this->transUnits[ $this->currentTransUnitId ] ) &&
+                    !empty($this->transUnits[$this->currentTransUnitId]) &&
                     !$this->hasWrittenCounts
             ) {
                 // we need to update counts here
                 $this->updateCounts();
                 $this->hasWrittenCounts = true;
-                $tag                    .= $this->getWordCountGroupForXliffV2();
+                $tag .= $this->getWordCountGroupForXliffV2();
                 $this->unitContainsMda  = true;
             }
 
             // construct tag
             $tag .= "<$name ";
 
-            foreach ( $attr as $k => $v ) {
+            foreach ($attr as $k => $v) {
 
                 //if tag name is file, we must replace the target-language attribute
-                if ( $name === 'file' && $k === 'target-language' && !empty( $this->targetLang ) ) {
+                if ($name === 'file' && $k === 'target-language' && !empty($this->targetLang)) {
                     //replace Target language with job language provided from constructor
                     $tag .= "$k=\"$this->targetLang\" ";
                 } else {
 
                     //normal tag flux, put attributes in it but skip for translation state and set the right value for the attribute
-                    if ( $k != 'state' ) {
+                    if ($k != 'state') {
                         $tag .= "$k=\"$v\" ";
                     }
 
@@ -114,39 +114,39 @@ 
 
             $seg = $this->getCurrentSegment();
 
-            if ( $name === $this->tuTagName and !empty( $seg ) and isset( $seg[ 'sid' ] ) ) {
+            if ($name === $this->tuTagName and !empty($seg) and isset($seg['sid'])) {
 
                 // add `help-id` to xliff v.1*
                 // add `mtc:segment-id` to xliff v.2*
-                if ( strpos( $tag, 'mtc:segment-id' ) === false ) {
-                    $tag .= "mtc:segment-id=\"{$seg[ 'sid' ]}\" ";
+                if (strpos($tag, 'mtc:segment-id') === false) {
+                    $tag .= "mtc:segment-id=\"{$seg['sid']}\" ";
                 }
 
             }
 
             // replace state for xliff v2
-            if ( 'segment' === $name ) { // add state to segment in Xliff v2
-                [ $stateProp, ] = StatusToStateAttribute::getState( $seg[ 'status' ], $this->xliffVersion );
+            if ('segment' === $name) { // add state to segment in Xliff v2
+                [$stateProp, ] = StatusToStateAttribute::getState($seg['status'], $this->xliffVersion);
                 $tag .= $stateProp;
             }
 
 
             // add oasis xliff 20 namespace
-            if ( $name === 'xliff' && !array_key_exists( 'xmlns:mda', $attr ) ) {
+            if ($name === 'xliff' && !array_key_exists('xmlns:mda', $attr)) {
                 $tag .= 'xmlns:mda="urn:oasis:names:tc:xliff:metadata:2.0"';
             }
 
             // add MateCat specific namespace, we want maybe add non-XLIFF attributes
-            if ( $name === 'xliff' && !array_key_exists( 'xmlns:mtc', $attr ) ) {
+            if ($name === 'xliff' && !array_key_exists('xmlns:mtc', $attr)) {
                 $tag .= ' xmlns:mtc="https://www.matecat.com" ';
             }
 
             // trgLang
-            if ( $name === 'xliff' ) {
-                $tag = preg_replace( '/trgLang="(.*?)"/', 'trgLang="' . $this->targetLang . '"', $tag );
+            if ($name === 'xliff') {
+                $tag = preg_replace('/trgLang="(.*?)"/', 'trgLang="' . $this->targetLang . '"', $tag);
             }
 
-            $this->checkForSelfClosedTagAndFlush( $parser, $tag );
+            $this->checkForSelfClosedTagAndFlush($parser, $tag);
 
         }
 
@@ -155,7 +155,7 @@ 
     /**
      * @inheritDoc
      */
-    protected function tagClose( $parser, $name ) {
+    protected function tagClose($parser, $name) {
         $tag = '';
 
         /**
@@ -164,32 +164,32 @@ 
          *
          * self::tagOpen method
          */
-        if ( !$this->isEmpty ) {
+        if (!$this->isEmpty) {
 
-            if ( !$this->inTarget ) {
+            if (!$this->inTarget) {
                 $tag = "</$name>";
             }
 
-            if ( 'target' == $name ) {
+            if ('target' == $name) {
 
-                if ( isset( $this->transUnits[ $this->currentTransUnitId ] ) && $this->currentTransUnitIsTranslatable !== 'no' ) {
+                if (isset($this->transUnits[$this->currentTransUnitId]) && $this->currentTransUnitIsTranslatable !== 'no') {
 
                     $seg = $this->getCurrentSegment();
 
                     // update counts
-                    if ( !$this->hasWrittenCounts && !empty( $seg ) ) {
-                        $this->updateSegmentCounts( $seg );
+                    if (!$this->hasWrittenCounts && !empty($seg)) {
+                        $this->updateSegmentCounts($seg);
                     }
 
                     // delete translations so the prepareSegment
                     // will put source content in target tag
-                    if ( $this->sourceInTarget ) {
-                        $seg[ 'translation' ] = '';
+                    if ($this->sourceInTarget) {
+                        $seg['translation'] = '';
                         $this->resetCounts();
                     }
 
                     // append $translation
-                    $translation = $this->prepareTranslation( $seg );
+                    $translation = $this->prepareTranslation($seg);
 
                     //append translation
                     $tag = "<target>$translation</target>";
@@ -199,21 +199,21 @@ 
                 // signal we are leaving a target
                 $this->targetWasWritten = true;
                 $this->inTarget         = false;
-                $this->postProcAndFlush( $this->outputFP, $tag, true );
-            } elseif ( in_array( $name, $this->nodesToBuffer ) ) { // we are closing a critical CDATA section
+                $this->postProcAndFlush($this->outputFP, $tag, true);
+            } elseif (in_array($name, $this->nodesToBuffer)) { // we are closing a critical CDATA section
 
                 $this->bufferIsActive = false;
 
                 // only for Xliff 2.*
                 // write here <mda:metaGroup> and <mda:meta> if already present in the <unit>
-                if ( 'mda:metadata' === $name && $this->unitContainsMda && !$this->hasWrittenCounts ) {
+                if ('mda:metadata' === $name && $this->unitContainsMda && !$this->hasWrittenCounts) {
 
                     // we need to update counts here
                     $this->updateCounts();
                     $this->hasWrittenCounts = true;
 
                     $tag = $this->CDATABuffer;
-                    $tag .= $this->getWordCountGroupForXliffV2( false );
+                    $tag .= $this->getWordCountGroupForXliffV2(false);
                     $tag .= "    </mda:metadata>";
 
                 } else {
@@ -223,19 +223,19 @@ 
                 $this->CDATABuffer = "";
 
                 //flush to the pointer
-                $this->postProcAndFlush( $this->outputFP, $tag );
+                $this->postProcAndFlush($this->outputFP, $tag);
 
-            } elseif ( 'segment' === $name ) {
+            } elseif ('segment' === $name) {
 
                 // only for Xliff 2.*
                 // if segment has no <target> add it BEFORE </segment>
-                if ( !$this->targetWasWritten ) {
+                if (!$this->targetWasWritten) {
 
                     $seg = $this->getCurrentSegment();
 
-                    if ( isset( $seg[ 'translation' ] ) ) {
+                    if (isset($seg['translation'])) {
 
-                        $translation = $this->prepareTranslation( $seg );
+                        $translation = $this->prepareTranslation($seg);
                         // replace the tag
                         $tag = "<target>$translation</target>";
 
@@ -248,17 +248,17 @@ 
                 // update segmentPositionInTu
                 $this->segmentInUnitPosition++;
 
-                $this->postProcAndFlush( $this->outputFP, $tag );
+                $this->postProcAndFlush($this->outputFP, $tag);
 
                 // we are leaving <segment>, reset $segmentHasTarget
                 $this->targetWasWritten = false;
 
-            } elseif ( $this->bufferIsActive ) { // this is a tag ( <g | <mrk ) inside a seg or seg-source tag
+            } elseif ($this->bufferIsActive) { // this is a tag ( <g | <mrk ) inside a seg or seg-source tag
                 $this->CDATABuffer .= "</$name>";
                 // Do NOT Flush
             } else { //generic tag closure do Nothing
                 // flush to pointer
-                $this->postProcAndFlush( $this->outputFP, $tag );
+                $this->postProcAndFlush($this->outputFP, $tag);
             }
         } else {
             //ok, nothing to be done; reset flag for next coming tag
@@ -266,7 +266,7 @@ 
         }
 
         // check if we are leaving a <trans-unit> (xliff v1.*) or <unit> (xliff v2.*)
-        if ( $this->tuTagName === $name ) {
+        if ($this->tuTagName === $name) {
             $this->currentTransUnitIsTranslatable = null;
             $this->inTU                           = false;
             $this->segmentPositionInTu            = -1;
@@ -283,8 +283,8 @@ 
     private function updateCounts() {
 
         $seg = $this->getCurrentSegment();
-        if ( !empty( $seg ) ) {
-            $this->updateSegmentCounts( $seg );
+        if (!empty($seg)) {
+            $this->updateSegmentCounts($seg);
         }
 
     }
@@ -294,30 +294,30 @@ 
      *
      * @return string
      */
-    private function getWordCountGroupForXliffV2( bool $withMetadataTag = true ): string {
+    private function getWordCountGroupForXliffV2(bool $withMetadataTag = true): string {
 
         $this->mdaGroupCounter++;
-        $segments_count_array = $this->counts[ 'segments_count_array' ];
+        $segments_count_array = $this->counts['segments_count_array'];
 
         $tag = '';
 
-        if ( $withMetadataTag === true ) {
+        if ($withMetadataTag === true) {
             $tag .= '<mda:metadata>';
         }
 
         $index = 0;
-        foreach ( $segments_count_array as $segments_count_item ) {
+        foreach ($segments_count_array as $segments_count_item) {
 
             $id = 'word_count_tu[' . $this->currentTransUnitId . '][' . $index . ']';
             $index++;
 
             $tag .= "    <mda:metaGroup id=\"" . $id . "\" category=\"row_xml_attribute\">
-                                <mda:meta type=\"x-matecat-raw\">" . $segments_count_item[ 'raw_word_count' ] . "</mda:meta>
-                                <mda:meta type=\"x-matecat-weighted\">" . $segments_count_item[ 'eq_word_count' ] . "</mda:meta>
+                                <mda:meta type=\"x-matecat-raw\">" . $segments_count_item['raw_word_count'] . "</mda:meta>
+                                <mda:meta type=\"x-matecat-weighted\">" . $segments_count_item['eq_word_count'] . "</mda:meta>
                             </mda:metaGroup>";
         }
 
-        if ( $withMetadataTag === true ) {
+        if ($withMetadataTag === true) {
             $tag .= '</mda:metadata>';
         }
 
@@ -332,18 +332,18 @@ 
      *
      * @return string
      */
-    protected function prepareTranslation( array $seg ): string {
+    protected function prepareTranslation(array $seg): string {
 
-        $segment     = Strings::removeDangerousChars( $seg [ 'segment' ] );
-        $translation = Strings::removeDangerousChars( $seg [ 'translation' ] );
-        $dataRefMap  = ( isset( $seg[ 'data_ref_map' ] ) ) ? Strings::jsonToArray( $seg[ 'data_ref_map' ] ) : [];
+        $segment     = Strings::removeDangerousChars($seg ['segment']);
+        $translation = Strings::removeDangerousChars($seg ['translation']);
+        $dataRefMap  = (isset($seg['data_ref_map'])) ? Strings::jsonToArray($seg['data_ref_map']) : [];
 
-        if ( $seg [ 'translation' ] == '' ) {
+        if ($seg ['translation'] == '') {
             $translation = $segment;
         } else {
-            if ( $this->callback instanceof XliffReplacerCallbackInterface ) {
-                $error = ( !empty( $seg[ 'error' ] ) ) ? $seg[ 'error' ] : null;
-                if ( $this->callback->thereAreErrors( $seg[ 'sid' ], $segment, $translation, $dataRefMap, $error ) ) {
+            if ($this->callback instanceof XliffReplacerCallbackInterface) {
+                $error = (!empty($seg['error'])) ? $seg['error'] : null;
+                if ($this->callback->thereAreErrors($seg['sid'], $segment, $translation, $dataRefMap, $error)) {
                     $translation = '|||UNTRANSLATED_CONTENT_START|||' . $segment . '|||UNTRANSLATED_CONTENT_END|||';
                 }
             }

src/XliffReplacer/AbstractXliffReplacer.php

Spacing +106 added lines, -106 removed lines

@@ -8,27 +8,27 @@ 
 abstract class AbstractXliffReplacer {
     protected $originalFP;
 
-    protected $tuTagName;                 // <trans-unit> (forXliff v 1.*) or <unit> (forXliff v 2.*)
-    protected $inTU                = false;  // flag to check whether we are in a <trans-unit>
-    protected $inTarget            = false;  // flag to check whether we are in a <target>, to ignore everything
-    protected $isEmpty             = false;  // flag to check whether we are in an empty tag (<tag/>)
-    protected $targetWasWritten    = false;  // flag to check is <target> was written in the current unit
-    protected $segmentPositionInTu = -1;  // the current position of segment in the current <unit> (forXliff v 2.*)
-
-    protected $CDATABuffer    = "";       // buffer for special tag
-    protected $bufferIsActive = false;    // buffer for special tag
-
-    protected     $offset                = 0;         // offset for SAX pointer
-    protected     $outputFP;                  // output stream pointer
-    protected     $currentBuffer;             // the current piece of text it's been parsed
-    protected     $len;                       // length of the currentBuffer
-    protected     $segments;                  // array of translations
+    protected $tuTagName; // <trans-unit> (forXliff v 1.*) or <unit> (forXliff v 2.*)
+    protected $inTU                = false; // flag to check whether we are in a <trans-unit>
+    protected $inTarget            = false; // flag to check whether we are in a <target>, to ignore everything
+    protected $isEmpty             = false; // flag to check whether we are in an empty tag (<tag/>)
+    protected $targetWasWritten    = false; // flag to check is <target> was written in the current unit
+    protected $segmentPositionInTu = -1; // the current position of segment in the current <unit> (forXliff v 2.*)
+
+    protected $CDATABuffer    = ""; // buffer for special tag
+    protected $bufferIsActive = false; // buffer for special tag
+
+    protected     $offset = 0; // offset for SAX pointer
+    protected     $outputFP; // output stream pointer
+    protected     $currentBuffer; // the current piece of text it's been parsed
+    protected     $len; // length of the currentBuffer
+    protected     $segments; // array of translations
     protected     $lastTransUnit         = [];
     protected int $segmentInUnitPosition = 0;
-    protected     $currentTransUnitId;        // id of current <trans-unit>
+    protected     $currentTransUnitId; // id of current <trans-unit>
     protected     $currentTransUnitIsTranslatable; // 'translate' attribute of current <trans-unit>
-    protected     $unitContainsMda       = false;   // check if <unit> already contains a <mda:metadata> (forXliff v 2.*)
-    protected     $hasWrittenCounts      = false;  // check if <unit> already wrote segment counts (forXliff v 2.*)
+    protected     $unitContainsMda       = false; // check if <unit> already contains a <mda:metadata> (forXliff v 2.*)
+    protected     $hasWrittenCounts      = false; // check if <unit> already wrote segment counts (forXliff v 2.*)
 
     protected $targetLang;
 
@@ -75,8 +75,8 @@ 
             XliffReplacerCallbackInterface $callback = null
     ) {
         self::$INTERNAL_TAG_PLACEHOLDER = $this->getInternalTagPlaceholder();
-        $this->createOutputFileIfDoesNotExist( $outputFilePath );
-        $this->setFileDescriptors( $originalXliffPath, $outputFilePath );
+        $this->createOutputFileIfDoesNotExist($outputFilePath);
+        $this->setFileDescriptors($originalXliffPath, $outputFilePath);
         $this->xliffVersion = $xliffVersion;
         $this->setTuTagName();
         $this->segments       = $segments;
@@ -88,17 +88,17 @@ 
     }
 
     public function replaceTranslation() {
-        fwrite( $this->outputFP, '<?xml version="1.0" encoding="UTF-8"?>' );
+        fwrite($this->outputFP, '<?xml version="1.0" encoding="UTF-8"?>');
 
         //create Sax parser
         $xmlParser = $this->initSaxParser();
 
-        while ( $this->currentBuffer = fread( $this->originalFP, 4096 ) ) {
+        while ($this->currentBuffer = fread($this->originalFP, 4096)) {
             /*
                preprocess file
              */
             // obfuscate entities because sax automatically does html_entity_decode
-            $temporary_check_buffer = preg_replace( "/&(.*?);/", self::$INTERNAL_TAG_PLACEHOLDER . '$1' . self::$INTERNAL_TAG_PLACEHOLDER, $this->currentBuffer );
+            $temporary_check_buffer = preg_replace("/&(.*?);/", self::$INTERNAL_TAG_PLACEHOLDER . '$1' . self::$INTERNAL_TAG_PLACEHOLDER, $this->currentBuffer);
 
             //avoid cutting entities in half:
             //the last fread could have truncated an entity (say, '&lt;' in '&l'), thus invalidating the escaping
@@ -110,67 +110,67 @@ 
             // add 9 Bytes and substitute the entities, if the & is present, and it is not at the end
             //it can't be an entity, exit the loop
 
-            while ( true ) {
-                $_ampPos = strpos( $temporary_check_buffer, '&' );
+            while (true) {
+                $_ampPos = strpos($temporary_check_buffer, '&');
 
                 //check for real entity or escape it to safely exit from the loop!!!
-                if ( $_ampPos === false || strlen( substr( $temporary_check_buffer, $_ampPos ) ) > 9 ) {
+                if ($_ampPos === false || strlen(substr($temporary_check_buffer, $_ampPos)) > 9) {
                     $escape_AMP = true;
                     break;
                 }
 
                 //if an entity is still present, fetch some more and repeat the escaping
-                $this->currentBuffer    .= fread( $this->originalFP, 9 );
-                $temporary_check_buffer = preg_replace( "/&(.*?);/", self::$INTERNAL_TAG_PLACEHOLDER . '$1' . self::$INTERNAL_TAG_PLACEHOLDER, $this->currentBuffer );
+                $this->currentBuffer .= fread($this->originalFP, 9);
+                $temporary_check_buffer = preg_replace("/&(.*?);/", self::$INTERNAL_TAG_PLACEHOLDER . '$1' . self::$INTERNAL_TAG_PLACEHOLDER, $this->currentBuffer);
             }
 
             //free stuff outside the loop
-            unset( $temporary_check_buffer );
+            unset($temporary_check_buffer);
 
-            $this->currentBuffer = preg_replace( "/&(.*?);/", self::$INTERNAL_TAG_PLACEHOLDER . '$1' . self::$INTERNAL_TAG_PLACEHOLDER, $this->currentBuffer );
-            if ( $escape_AMP ) {
-                $this->currentBuffer = str_replace( "&", self::$INTERNAL_TAG_PLACEHOLDER . 'amp' . self::$INTERNAL_TAG_PLACEHOLDER, $this->currentBuffer );
+            $this->currentBuffer = preg_replace("/&(.*?);/", self::$INTERNAL_TAG_PLACEHOLDER . '$1' . self::$INTERNAL_TAG_PLACEHOLDER, $this->currentBuffer);
+            if ($escape_AMP) {
+                $this->currentBuffer = str_replace("&", self::$INTERNAL_TAG_PLACEHOLDER . 'amp' . self::$INTERNAL_TAG_PLACEHOLDER, $this->currentBuffer);
             }
 
             //get length of chunk
-            $this->len = strlen( $this->currentBuffer );
+            $this->len = strlen($this->currentBuffer);
 
             //parse chunk of text
-            if ( !xml_parse( $xmlParser, $this->currentBuffer, feof( $this->originalFP ) ) ) {
+            if (!xml_parse($xmlParser, $this->currentBuffer, feof($this->originalFP))) {
                 //if unable, raise an exception
-                throw new RuntimeException( sprintf(
+                throw new RuntimeException(sprintf(
                         "XML error: %s at line %d",
-                        xml_error_string( xml_get_error_code( $xmlParser ) ),
-                        xml_get_current_line_number( $xmlParser )
-                ) );
+                        xml_error_string(xml_get_error_code($xmlParser)),
+                        xml_get_current_line_number($xmlParser)
+                ));
             }
             //get accumulated this->offset in document: as long as SAX pointer advances, we keep track of total bytes it has seen so far; this way, we can translate its global pointer in an address local to the current buffer of text to retrieve last char of tag
             $this->offset += $this->len;
         }
 
         // close Sax parser
-        $this->closeSaxParser( $xmlParser );
+        $this->closeSaxParser($xmlParser);
 
     }
 
-    protected function getLastCharacter( $parser ) {
+    protected function getLastCharacter($parser) {
 
         //this logic helps detecting empty tags
         //get current position of SAX pointer in all the stream of data is has read so far:
         //it points at the end of current tag
-        $idx = xml_get_current_byte_index( $parser );
+        $idx = xml_get_current_byte_index($parser);
 
         //check whether the bounds of current tag are entirely in current buffer or the end of the current tag
         //is outside current buffer (in the latter case, it's in next buffer to be read by the while loop);
         //this check is necessary because we may have truncated a tag in half with current read,
         //and the other half may be encountered in the next buffer it will be passed
-        if ( isset( $this->currentBuffer[ $idx - $this->offset ] ) ) {
+        if (isset($this->currentBuffer[$idx - $this->offset])) {
             //if this tag entire lenght fitted in the buffer, the last char must be the last
             //symbol before the '>'; if it's an empty tag, it is assumed that it's a '/'
-            $lastChar = $this->currentBuffer[ $idx - $this->offset ];
+            $lastChar = $this->currentBuffer[$idx - $this->offset];
         } else {
             //if it's out, simple use the last character of the chunk
-            $lastChar = $this->currentBuffer[ $this->len - 1 ];
+            $lastChar = $this->currentBuffer[$this->len - 1];
         }
 
         return $lastChar;
@@ -184,19 +184,19 @@ 
         return "§" .
                 substr(
                         str_replace(
-                                [ '+', '/' ],
+                                ['+', '/'],
                                 '',
-                                base64_encode( openssl_random_pseudo_bytes( 10, $_crypto_strong ) )
+                                base64_encode(openssl_random_pseudo_bytes(10, $_crypto_strong))
                         ),
                         0,
                         4
                 );
     }
 
-    private function createOutputFileIfDoesNotExist( $outputFilePath ) {
+    private function createOutputFileIfDoesNotExist($outputFilePath) {
         // create output file
-        if ( !file_exists( $outputFilePath ) ) {
-            touch( $outputFilePath );
+        if (!file_exists($outputFilePath)) {
+            touch($outputFilePath);
         }
     }
 
@@ -204,13 +204,13 @@ 
      * @param $originalXliffPath
      * @param $outputFilePath
      */
-    private function setFileDescriptors( $originalXliffPath, $outputFilePath ) {
-        $this->outputFP = fopen( $outputFilePath, 'w+' );
+    private function setFileDescriptors($originalXliffPath, $outputFilePath) {
+        $this->outputFP = fopen($outputFilePath, 'w+');
 
         $streamArgs = null;
 
-        if ( !( $this->originalFP = fopen( $originalXliffPath, "r", false, stream_context_create( $streamArgs ) ) ) ) {
-            throw new RuntimeException( "could not open XML input" );
+        if (!($this->originalFP = fopen($originalXliffPath, "r", false, stream_context_create($streamArgs)))) {
+            throw new RuntimeException("could not open XML input");
         }
     }
 
@@ -219,7 +219,7 @@ 
      * <trans-unit> (xliff v1.*) || <unit> (xliff v2.*)
      */
     private function setTuTagName() {
-        $this->tuTagName = ( $this->xliffVersion === 2 ) ? 'unit' : 'trans-unit';
+        $this->tuTagName = ($this->xliffVersion === 2) ? 'unit' : 'trans-unit';
     }
 
     /**
@@ -228,8 +228,8 @@ 
     public function __destruct() {
         //this stream can be closed outside the class
         //to permit multiple concurrent downloads, so suppress warnings
-        @fclose( $this->originalFP );
-        fclose( $this->outputFP );
+        @fclose($this->originalFP);
+        fclose($this->outputFP);
     }
 
     /**
@@ -238,11 +238,11 @@ 
      * @return resource
      */
     protected function initSaxParser() {
-        $xmlSaxParser = xml_parser_create( 'UTF-8' );
-        xml_set_object( $xmlSaxParser, $this );
-        xml_parser_set_option( $xmlSaxParser, XML_OPTION_CASE_FOLDING, false );
-        xml_set_element_handler( $xmlSaxParser, 'tagOpen', 'tagClose' );
-        xml_set_character_data_handler( $xmlSaxParser, 'characterData' );
+        $xmlSaxParser = xml_parser_create('UTF-8');
+        xml_set_object($xmlSaxParser, $this);
+        xml_parser_set_option($xmlSaxParser, XML_OPTION_CASE_FOLDING, false);
+        xml_set_element_handler($xmlSaxParser, 'tagOpen', 'tagClose');
+        xml_set_character_data_handler($xmlSaxParser, 'characterData');
 
         return $xmlSaxParser;
     }
@@ -250,8 +250,8 @@ 
     /**
      * @param resource $xmlSaxParser
      */
-    protected function closeSaxParser( $xmlSaxParser ) {
-        xml_parser_free( $xmlSaxParser );
+    protected function closeSaxParser($xmlSaxParser) {
+        xml_parser_free($xmlSaxParser);
     }
 
     /**
@@ -261,7 +261,7 @@ 
      *
      * @return mixed
      */
-    abstract protected function tagOpen( $parser, $name, $attr );
+    abstract protected function tagOpen($parser, $name, $attr);
 
     /**
      * @param $parser
@@ -269,7 +269,7 @@ 
      *
      * @return mixed
      */
-    abstract protected function tagClose( $parser, $name );
+    abstract protected function tagClose($parser, $name);
 
     /**
      * @param $parser
@@ -277,11 +277,11 @@ 
      *
      * @return mixed
      */
-    protected function characterData( $parser, $data ): void {
+    protected function characterData($parser, $data): void {
         // don't write <target> data
-        if ( !$this->inTarget && !$this->bufferIsActive ) {
-            $this->postProcAndFlush( $this->outputFP, $data );
-        } elseif ( $this->bufferIsActive ) {
+        if (!$this->inTarget && !$this->bufferIsActive) {
+            $this->postProcAndFlush($this->outputFP, $data);
+        } elseif ($this->bufferIsActive) {
             $this->CDATABuffer .= $data;
         }
     }
@@ -293,34 +293,34 @@ 
      * @param string   $data
      * @param bool     $treatAsCDATA
      */
-    protected function postProcAndFlush( $fp, $data, $treatAsCDATA = false ) {
+    protected function postProcAndFlush($fp, $data, $treatAsCDATA = false) {
         //postprocess string
-        $data = preg_replace( "/" . self::$INTERNAL_TAG_PLACEHOLDER . '(.*?)' . self::$INTERNAL_TAG_PLACEHOLDER . "/", '&$1;', $data );
-        $data = str_replace( '&nbsp;', ' ', $data );
-        if ( !$treatAsCDATA ) {
+        $data = preg_replace("/" . self::$INTERNAL_TAG_PLACEHOLDER . '(.*?)' . self::$INTERNAL_TAG_PLACEHOLDER . "/", '&$1;', $data);
+        $data = str_replace('&nbsp;', ' ', $data);
+        if (!$treatAsCDATA) {
             //unix2dos
-            $data = str_replace( "\r\n", "\r", $data );
-            $data = str_replace( "\n", "\r", $data );
-            $data = str_replace( "\r", "\r\n", $data );
+            $data = str_replace("\r\n", "\r", $data);
+            $data = str_replace("\n", "\r", $data);
+            $data = str_replace("\r", "\r\n", $data);
         }
 
         //flush to disk
-        fwrite( $fp, $data );
+        fwrite($fp, $data);
     }
 
-    protected function handleOpenUnit( string $name, array $attr ) {
+    protected function handleOpenUnit(string $name, array $attr) {
 
         // check if we are entering into a <trans-unit> (xliff v1.*) or <unit> (xliff v2.*)
-        if ( $this->tuTagName === $name ) {
+        if ($this->tuTagName === $name) {
             $this->inTU = true;
 
             // get id
             // trim to first 100 characters because this is the limit on Matecat's DB
-            $this->currentTransUnitId = substr( $attr[ 'id' ], 0, 100 );
+            $this->currentTransUnitId = substr($attr['id'], 0, 100);
 
             // `translate` attribute can be only yes or no
             // current 'translate' attribute of the current trans-unit
-            $this->currentTransUnitIsTranslatable = empty( $attr[ 'translate' ] ) ? 'yes' : $attr[ 'translate' ];
+            $this->currentTransUnitIsTranslatable = empty($attr['translate']) ? 'yes' : $attr['translate'];
 
             $this->setLastTransUnitSegments();
 
@@ -330,36 +330,36 @@ 
     /**
      * @param array $seg
      */
-    protected function updateSegmentCounts( array $seg = [] ) {
+    protected function updateSegmentCounts(array $seg = []) {
 
-        $raw_word_count = $seg[ 'raw_word_count' ];
-        $eq_word_count  = ( floor( $seg[ 'eq_word_count' ] * 100 ) / 100 );
+        $raw_word_count = $seg['raw_word_count'];
+        $eq_word_count  = (floor($seg['eq_word_count'] * 100) / 100);
 
-        $this->counts[ 'segments_count_array' ][ $seg[ 'sid' ] ] = [
+        $this->counts['segments_count_array'][$seg['sid']] = [
                 'raw_word_count' => $raw_word_count,
                 'eq_word_count'  => $eq_word_count,
         ];
 
-        $this->counts[ 'raw_word_count' ] += $raw_word_count;
-        $this->counts[ 'eq_word_count' ]  += $eq_word_count;
+        $this->counts['raw_word_count'] += $raw_word_count;
+        $this->counts['eq_word_count']  += $eq_word_count;
     }
 
     protected function resetCounts() {
-        $this->counts[ 'segments_count_array' ] = [];
-        $this->counts[ 'raw_word_count' ]       = 0;
-        $this->counts[ 'eq_word_count' ]        = 0;
+        $this->counts['segments_count_array'] = [];
+        $this->counts['raw_word_count']       = 0;
+        $this->counts['eq_word_count']        = 0;
     }
 
-    protected function checkForSelfClosedTagAndFlush( $parser, $tag ) {
+    protected function checkForSelfClosedTagAndFlush($parser, $tag) {
 
-        $lastChar = $this->getLastCharacter( $parser );
+        $lastChar = $this->getLastCharacter($parser);
 
         //trim last space
-        $tag = rtrim( $tag );
+        $tag = rtrim($tag);
 
         //detect empty tag
         $this->isEmpty = $lastChar == '/';
-        if ( $this->isEmpty ) {
+        if ($this->isEmpty) {
             $tag .= $lastChar;
         }
 
@@ -367,11 +367,11 @@ 
         $tag .= ">";
 
         //set a Buffer for the segSource Source tag
-        if ( $this->bufferIsActive ) { // we are opening a critical CDATA section
+        if ($this->bufferIsActive) { // we are opening a critical CDATA section
             //these are NOT source/seg-source/value empty tags, THERE IS A CONTENT, write it in buffer
             $this->CDATABuffer .= $tag;
         } else {
-            $this->postProcAndFlush( $this->outputFP, $tag );
+            $this->postProcAndFlush($this->outputFP, $tag);
         }
 
     }
@@ -396,18 +396,18 @@ 
          */
         $this->lastTransUnit = [];
 
-        if ( !isset( $this->transUnits[ $this->currentTransUnitId ] ) ) {
+        if (!isset($this->transUnits[$this->currentTransUnitId])) {
             return;
         }
 
-        $listOfSegmentsIds = $this->transUnits[ $this->currentTransUnitId ];
+        $listOfSegmentsIds = $this->transUnits[$this->currentTransUnitId];
         $last_value        = null;
-        $segmentsCount     = count( $listOfSegmentsIds );
-        for ( $i = 0; $i < $segmentsCount; $i++ ) {
-            $id = $listOfSegmentsIds[ $i ];
-            if ( isset( $this->segments[ $id ] ) && ( $i == 0 || $last_value + 1 == $listOfSegmentsIds[ $i ] ) ) {
-                $last_value            = $listOfSegmentsIds[ $i ];
-                $this->lastTransUnit[] = $this->segments[ $id ];
+        $segmentsCount     = count($listOfSegmentsIds);
+        for ($i = 0; $i < $segmentsCount; $i++) {
+            $id = $listOfSegmentsIds[$i];
+            if (isset($this->segments[$id]) && ($i == 0 || $last_value + 1 == $listOfSegmentsIds[$i])) {
+                $last_value            = $listOfSegmentsIds[$i];
+                $this->lastTransUnit[] = $this->segments[$id];
             }
         }
 
@@ -417,8 +417,8 @@ 
      * @return array
      */
     protected function getCurrentSegment(): array {
-        if ( $this->currentTransUnitIsTranslatable !== 'no' && isset( $this->transUnits[ $this->currentTransUnitId ] ) ) {
-            return $this->segments[ $this->segmentInUnitPosition ];
+        if ($this->currentTransUnitIsTranslatable !== 'no' && isset($this->transUnits[$this->currentTransUnitId])) {
+            return $this->segments[$this->segmentInUnitPosition];
         }
 
         return [];

src/XliffReplacer/XliffReplacerFactory.php

Spacing +6 added lines, -6 removed lines

@@ -28,14 +28,14 @@
             LoggerInterface                $logger = null,
             XliffReplacerCallbackInterface $callback = null
     ) {
-        $info = XliffProprietaryDetect::getInfo( $originalXliffPath );
+        $info = XliffProprietaryDetect::getInfo($originalXliffPath);
 
-        if ( $info[ 'version' ] == 1 && $info[ 'proprietary_short_name' ] !== 'trados' ) {
-            return new Xliff12( $originalXliffPath, $info[ 'version' ], $data, $transUnits, $targetLang, $outputFilePath, $setSourceInTarget, $logger, $callback );
-        } elseif ( $info[ 'version' ] == 2 ) {
-            return new Xliff20( $originalXliffPath, $info[ 'version' ], $data, $transUnits, $targetLang, $outputFilePath, $setSourceInTarget, $logger, $callback );
+        if ($info['version'] == 1 && $info['proprietary_short_name'] !== 'trados') {
+            return new Xliff12($originalXliffPath, $info['version'], $data, $transUnits, $targetLang, $outputFilePath, $setSourceInTarget, $logger, $callback);
+        } elseif ($info['version'] == 2) {
+            return new Xliff20($originalXliffPath, $info['version'], $data, $transUnits, $targetLang, $outputFilePath, $setSourceInTarget, $logger, $callback);
         }
 
-        return new XliffSdl( $originalXliffPath, $info[ 'version' ], $data, $transUnits, $targetLang, $outputFilePath, $setSourceInTarget, $logger, $callback );
+        return new XliffSdl($originalXliffPath, $info['version'], $data, $transUnits, $targetLang, $outputFilePath, $setSourceInTarget, $logger, $callback);
     }
 }

src/XliffReplacer/Xliff12.php

Spacing +60 added lines, -60 removed lines

@@ -27,14 +27,14 @@ 
     /**
      * @inheritDoc
      */
-    protected function tagOpen( $parser, $name, $attr ) {
+    protected function tagOpen($parser, $name, $attr) {
 
-        $this->handleOpenUnit( $name, $attr );
+        $this->handleOpenUnit($name, $attr);
 
         // check if we are entering into a <target>
-        if ( 'target' === $name ) {
+        if ('target' === $name) {
 
-            if ( $this->currentTransUnitIsTranslatable === 'no' ) {
+            if ($this->currentTransUnitIsTranslatable === 'no') {
                 $this->inTarget = false;
             } else {
                 $this->inTarget = true;
@@ -42,23 +42,23 @@ 
         }
 
         // open buffer
-        if ( in_array( $name, $this->nodesToBuffer ) ) {
+        if (in_array($name, $this->nodesToBuffer)) {
             $this->bufferIsActive = true;
         }
 
         // check if we are inside a <target>, obviously this happen only if there are targets inside the trans-unit
         // <target> must be stripped to be replaced, so this check avoids <target> reconstruction
-        if ( !$this->inTarget ) {
+        if (!$this->inTarget) {
 
             $tag = '';
 
             // construct tag
             $tag .= "<$name ";
 
-            foreach ( $attr as $k => $v ) {
+            foreach ($attr as $k => $v) {
 
                 //if tag name is file, we must replace the target-language attribute
-                if ( $name === 'file' && $k === 'target-language' && !empty( $this->targetLang ) ) {
+                if ($name === 'file' && $k === 'target-language' && !empty($this->targetLang)) {
                     //replace Target language with job language provided from constructor
                     $tag .= "$k=\"$this->targetLang\" ";
                 } else {
@@ -69,11 +69,11 @@ 
 
             $seg = $this->getCurrentSegment();
 
-            if ( $name === $this->tuTagName && !empty( $seg ) and isset( $seg[ 'sid' ] ) ) {
+            if ($name === $this->tuTagName && !empty($seg) and isset($seg['sid'])) {
 
-                if ( strpos( $tag, 'help-id' ) === false ) {
-                    if ( !empty( $seg[ 'sid' ] ) ) {
-                        $tag .= "help-id=\"{$seg[ 'sid' ]}\" ";
+                if (strpos($tag, 'help-id') === false) {
+                    if (!empty($seg['sid'])) {
+                        $tag .= "help-id=\"{$seg['sid']}\" ";
                     }
                 }
 
@@ -81,14 +81,14 @@ 
 
             // Add MateCat specific namespace.
             // Add trgLang
-            if ( $name === 'xliff' ) {
-                if ( !array_key_exists( 'xmlns:mtc', $attr ) ) {
+            if ($name === 'xliff') {
+                if (!array_key_exists('xmlns:mtc', $attr)) {
                     $tag .= ' xmlns:mtc="https://www.matecat.com" ';
                 }
-                $tag = preg_replace( '/trgLang="(.*?)"/', 'trgLang="' . $this->targetLang . '"', $tag );
+                $tag = preg_replace('/trgLang="(.*?)"/', 'trgLang="' . $this->targetLang . '"', $tag);
             }
 
-            $this->checkForSelfClosedTagAndFlush( $parser, $tag );
+            $this->checkForSelfClosedTagAndFlush($parser, $tag);
 
         }
 
@@ -98,7 +98,7 @@ 
     /**
      * @inheritDoc
      */
-    protected function tagClose( $parser, $name ) {
+    protected function tagClose($parser, $name) {
         $tag = '';
 
         /**
@@ -107,15 +107,15 @@ 
          *
          * self::tagOpen method
          */
-        if ( !$this->isEmpty ) {
+        if (!$this->isEmpty) {
 
-            if ( !$this->inTarget ) {
+            if (!$this->inTarget) {
                 $tag = "</$name>";
             }
 
-            if ( 'target' == $name ) {
+            if ('target' == $name) {
 
-                if ( isset( $this->transUnits[ $this->currentTransUnitId ] ) ) {
+                if (isset($this->transUnits[$this->currentTransUnitId])) {
 
                     // get translation of current segment, by indirect indexing: id -> positional index -> segment
                     // actually there may be more than one segment to that ID if there are two mrk of the same source segment
@@ -126,42 +126,42 @@ 
                 $this->targetWasWritten = true;
                 // signal we are leaving a target
                 $this->inTarget = false;
-                $this->postProcAndFlush( $this->outputFP, $tag, true );
+                $this->postProcAndFlush($this->outputFP, $tag, true);
 
-            } elseif ( in_array( $name, $this->nodesToBuffer ) ) { // we are closing a critical CDATA section
+            } elseif (in_array($name, $this->nodesToBuffer)) { // we are closing a critical CDATA section
 
                 $this->bufferIsActive = false;
                 $tag                  = $this->CDATABuffer . "</$name>";
                 $this->CDATABuffer    = "";
 
                 //flush to the pointer
-                $this->postProcAndFlush( $this->outputFP, $tag );
+                $this->postProcAndFlush($this->outputFP, $tag);
 
-            } elseif ( $name === $this->tuTagName ) {
+            } elseif ($name === $this->tuTagName) {
 
                 $tag = "";
 
                 // handling </trans-unit> closure
-                if ( !$this->targetWasWritten ) {
+                if (!$this->targetWasWritten) {
 
-                    if ( isset( $this->transUnits[ $this->currentTransUnitId ] ) ) {
+                    if (isset($this->transUnits[$this->currentTransUnitId])) {
                         $tag = $this->rebuildTarget();
                     } else {
-                        $tag = $this->createTargetTag( "", "" );
+                        $tag = $this->createTargetTag("", "");
                     }
 
                 }
 
-                $tag                    .= "</$this->tuTagName>";
+                $tag .= "</$this->tuTagName>";
                 $this->targetWasWritten = false;
-                $this->postProcAndFlush( $this->outputFP, $tag );
+                $this->postProcAndFlush($this->outputFP, $tag);
 
-            } elseif ( $this->bufferIsActive ) { // this is a tag ( <g | <mrk ) inside a seg or seg-source tag
+            } elseif ($this->bufferIsActive) { // this is a tag ( <g | <mrk ) inside a seg or seg-source tag
                 $this->CDATABuffer .= "</$name>";
                 // Do NOT Flush
             } else { //generic tag closure do Nothing
                 // flush to pointer
-                $this->postProcAndFlush( $this->outputFP, $tag );
+                $this->postProcAndFlush($this->outputFP, $tag);
             }
 
         } else {
@@ -170,7 +170,7 @@ 
         }
 
         // check if we are leaving a <trans-unit> (xliff v1.*) or <unit> (xliff v2.*)
-        if ( $this->tuTagName === $name ) {
+        if ($this->tuTagName === $name) {
             $this->currentTransUnitIsTranslatable = null;
             $this->inTU                           = false;
             $this->hasWrittenCounts               = false;
@@ -187,35 +187,35 @@ 
      *
      * @return string
      */
-    protected function prepareTranslation( array $seg, string $transUnitTranslation = "" ): string {
+    protected function prepareTranslation(array $seg, string $transUnitTranslation = ""): string {
 
-        $segment     = Strings::removeDangerousChars( $seg [ 'segment' ] );
-        $translation = Strings::removeDangerousChars( $seg [ 'translation' ] );
+        $segment     = Strings::removeDangerousChars($seg ['segment']);
+        $translation = Strings::removeDangerousChars($seg ['translation']);
 
-        if ( $seg [ 'translation' ] == '' ) {
+        if ($seg ['translation'] == '') {
             $translation = $segment;
         } else {
-            if ( $this->callback instanceof XliffReplacerCallbackInterface ) {
-                $error = ( !empty( $seg[ 'error' ] ) ) ? $seg[ 'error' ] : null;
-                if ( $this->callback->thereAreErrors( $seg[ 'sid' ], $segment, $translation, [], $error ) ) {
+            if ($this->callback instanceof XliffReplacerCallbackInterface) {
+                $error = (!empty($seg['error'])) ? $seg['error'] : null;
+                if ($this->callback->thereAreErrors($seg['sid'], $segment, $translation, [], $error)) {
                     $translation = '|||UNTRANSLATED_CONTENT_START|||' . $segment . '|||UNTRANSLATED_CONTENT_END|||';
                 }
             }
         }
 
-        $transUnitTranslation .= $seg[ 'prev_tags' ] . $this->rebuildMarks( $seg, $translation ) . ltrim( $seg[ 'succ_tags' ] );
+        $transUnitTranslation .= $seg['prev_tags'] . $this->rebuildMarks($seg, $translation) . ltrim($seg['succ_tags']);
 
         return $transUnitTranslation;
     }
 
-    protected function rebuildMarks( array $seg, string $translation ): string {
+    protected function rebuildMarks(array $seg, string $translation): string {
 
-        if ( $seg[ 'mrk_id' ] !== null && $seg[ 'mrk_id' ] != '' ) {
-            if ( $this->targetLang === 'ja-JP' ) {
-                $seg[ 'mrk_succ_tags' ] = ltrim( $seg[ 'mrk_succ_tags' ] );
+        if ($seg['mrk_id'] !== null && $seg['mrk_id'] != '') {
+            if ($this->targetLang === 'ja-JP') {
+                $seg['mrk_succ_tags'] = ltrim($seg['mrk_succ_tags']);
             }
 
-            $translation = "<mrk mid=\"" . $seg[ 'mrk_id' ] . "\" mtype=\"seg\">" . $seg[ 'mrk_prev_tags' ] . $translation . $seg[ 'mrk_succ_tags' ] . "</mrk>";
+            $translation = "<mrk mid=\"" . $seg['mrk_id'] . "\" mtype=\"seg\">" . $seg['mrk_prev_tags'] . $translation . $seg['mrk_succ_tags'] . "</mrk>";
         }
 
         return $translation;
@@ -230,10 +230,10 @@ 
      *
      * @return string
      */
-    private function createTargetTag( string $translation, string $stateProp ): string {
+    private function createTargetTag(string $translation, string $stateProp): string {
         $targetLang = ' xml:lang="' . $this->targetLang . '"';
         $tag        = "<target $targetLang $stateProp>$translation</target>";
-        $tag        .= "\n<count-group name=\"$this->currentTransUnitId\"><count count-type=\"x-matecat-raw\">" . $this->counts[ 'raw_word_count' ] . "</count><count count-type=\"x-matecat-weighted\">" . $this->counts[ 'eq_word_count' ] . '</count></count-group>';
+        $tag .= "\n<count-group name=\"$this->currentTransUnitId\"><count count-type=\"x-matecat-raw\">" . $this->counts['raw_word_count'] . "</count><count count-type=\"x-matecat-weighted\">" . $this->counts['eq_word_count'] . '</count></count-group>';
 
         return $tag;
 
@@ -249,7 +249,7 @@ 
         // we must reset the lastMrkId found because this is a new segment.
         $lastMrkId = -1;
 
-        foreach ( $this->lastTransUnit as $pos => $seg ) {
+        foreach ($this->lastTransUnit as $pos => $seg) {
 
             /*
              * This routine works to respect the positional orders of markers.
@@ -262,8 +262,8 @@ 
              * pre-assign zero to the new mrk if this is the first one ( in this segment )
              * If it is null leave it NULL
              */
-            if ( (int)$seg[ "mrk_id" ] < 0 && $seg[ "mrk_id" ] !== null ) {
-                $seg[ "mrk_id" ] = 0;
+            if ((int)$seg["mrk_id"] < 0 && $seg["mrk_id"] !== null) {
+                $seg["mrk_id"] = 0;
             }
 
             /*
@@ -272,33 +272,33 @@ 
              * ( null <= -1 ) === true
              * so, cast to int
              */
-            if ( (int)$seg[ "mrk_id" ] <= $lastMrkId ) {
+            if ((int)$seg["mrk_id"] <= $lastMrkId) {
                 break;
             }
 
             // update counts
-            if ( !empty( $seg ) ) {
-                $this->updateSegmentCounts( $seg );
+            if (!empty($seg)) {
+                $this->updateSegmentCounts($seg);
             }
 
             // delete translations so the prepareSegment
             // will put source content in target tag
-            if ( $this->sourceInTarget ) {
-                $seg[ 'translation' ] = '';
+            if ($this->sourceInTarget) {
+                $seg['translation'] = '';
                 $this->resetCounts();
             }
 
             // append $translation
-            $translation = $this->prepareTranslation( $seg, $translation );
+            $translation = $this->prepareTranslation($seg, $translation);
 
-            $lastMrkId = $seg[ "mrk_id" ];
+            $lastMrkId = $seg["mrk_id"];
 
-            [ $stateProp, $lastMrkState ] = StatusToStateAttribute::getState( $seg[ 'status' ], $this->xliffVersion, $stateProp, $lastMrkState );
+            [$stateProp, $lastMrkState] = StatusToStateAttribute::getState($seg['status'], $this->xliffVersion, $stateProp, $lastMrkState);
 
         }
 
         //append translation
-        return $this->createTargetTag( $translation, $stateProp );
+        return $this->createTargetTag($translation, $stateProp);
 
     }
 

src/XliffReplacer/StatusToStateAttribute.php

Spacing +14 added lines, -14 removed lines

@@ -22,26 +22,26 @@ 
      *
      * @return array
      */
-    public static function getState( string $status, int $xliffVersion, ?string $state_prop = '', ?string $lastMrkState = '' ): array {
+    public static function getState(string $status, int $xliffVersion, ?string $state_prop = '', ?string $lastMrkState = ''): array {
 
-        switch ( $status ) {
+        switch ($status) {
 
             case TranslationStatus::STATUS_FIXED:
             case TranslationStatus::STATUS_APPROVED2:
-                if ( $lastMrkState == null || $lastMrkState == TranslationStatus::STATUS_APPROVED2 ) {
+                if ($lastMrkState == null || $lastMrkState == TranslationStatus::STATUS_APPROVED2) {
                     $state_prop   = "state=\"final\"";
                     $lastMrkState = TranslationStatus::STATUS_APPROVED2;
                 }
                 break;
             case TranslationStatus::STATUS_APPROVED:
-                if ( $lastMrkState == null || $lastMrkState == TranslationStatus::STATUS_APPROVED ) {
-                    $state_prop   = ( $xliffVersion === 2 ) ? "state=\"reviewed\"" : "state=\"signed-off\"";
+                if ($lastMrkState == null || $lastMrkState == TranslationStatus::STATUS_APPROVED) {
+                    $state_prop   = ($xliffVersion === 2) ? "state=\"reviewed\"" : "state=\"signed-off\"";
                     $lastMrkState = TranslationStatus::STATUS_APPROVED;
                 }
                 break;
 
             case TranslationStatus::STATUS_TRANSLATED:
-                if ( $lastMrkState == null || $lastMrkState == TranslationStatus::STATUS_TRANSLATED || $lastMrkState == TranslationStatus::STATUS_APPROVED ) {
+                if ($lastMrkState == null || $lastMrkState == TranslationStatus::STATUS_TRANSLATED || $lastMrkState == TranslationStatus::STATUS_APPROVED) {
                     $state_prop   = "state=\"translated\"";
                     $lastMrkState = TranslationStatus::STATUS_TRANSLATED;
                 }
@@ -49,22 +49,22 @@ 
 
             case TranslationStatus::STATUS_REJECTED:  // if there is a mark REJECTED and there is not a DRAFT, all the trans-unit is REJECTED. In V2 there is no way to mark
             case TranslationStatus::STATUS_REBUTTED:
-                if ( ( $lastMrkState == null ) || ( $lastMrkState != TranslationStatus::STATUS_NEW || $lastMrkState != TranslationStatus::STATUS_DRAFT ) ) {
-                    $state_prop   = ( $xliffVersion === 2 ) ? "state=\"initial\"" : "state=\"needs-review-translation\"";
+                if (($lastMrkState == null) || ($lastMrkState != TranslationStatus::STATUS_NEW || $lastMrkState != TranslationStatus::STATUS_DRAFT)) {
+                    $state_prop   = ($xliffVersion === 2) ? "state=\"initial\"" : "state=\"needs-review-translation\"";
                     $lastMrkState = TranslationStatus::STATUS_REJECTED;
                 }
                 break;
 
             case TranslationStatus::STATUS_NEW:
-                if ( ( $lastMrkState == null ) || $lastMrkState != TranslationStatus::STATUS_NEW ) {
-                    $state_prop   = ( $xliffVersion === 2 ) ? "state=\"initial\"" : "state=\"new\"";
+                if (($lastMrkState == null) || $lastMrkState != TranslationStatus::STATUS_NEW) {
+                    $state_prop   = ($xliffVersion === 2) ? "state=\"initial\"" : "state=\"new\"";
                     $lastMrkState = TranslationStatus::STATUS_NEW;
                 }
                 break;
 
             case TranslationStatus::STATUS_DRAFT:
-                if ( ( $lastMrkState == null ) || $lastMrkState != TranslationStatus::STATUS_DRAFT ) {
-                    $state_prop   = ( $xliffVersion === 2 ) ? "state=\"initial\"" : "state=\"new\"";
+                if (($lastMrkState == null) || $lastMrkState != TranslationStatus::STATUS_DRAFT) {
+                    $state_prop   = ($xliffVersion === 2) ? "state=\"initial\"" : "state=\"new\"";
                     $lastMrkState = TranslationStatus::STATUS_DRAFT;
                 }
                 break;
@@ -73,7 +73,7 @@ 
                 // this is the case when a segment is not showed in cattool, so the row in
                 // segment_translations does not exists and
                 // ---> $seg[ 'status' ] is NULL
-                if ( $lastMrkState == null ) { //this is the first MRK ID
+                if ($lastMrkState == null) { //this is the first MRK ID
                     $state_prop   = "state=\"translated\"";
                     $lastMrkState = TranslationStatus::STATUS_TRANSLATED;
                 } else {
@@ -82,7 +82,7 @@ 
                 break;
         }
 
-        return [ $state_prop, $lastMrkState ];
+        return [$state_prop, $lastMrkState];
 
     }
 

src/XliffReplacer/XliffSdl.php

Spacing +21 added lines, -21 removed lines

@@ -16,13 +16,13 @@ 
     /**
      * @inheritDoc
      */
-    protected function tagOpen( $parser, $name, $attr ) {
+    protected function tagOpen($parser, $name, $attr) {
 
-        $this->handleOpenUnit( $name, $attr );
+        $this->handleOpenUnit($name, $attr);
 
         // check if we are entering into a <target>
-        if ( 'target' == $name ) {
-            if ( $this->currentTransUnitIsTranslatable === 'no' ) {
+        if ('target' == $name) {
+            if ($this->currentTransUnitIsTranslatable === 'no') {
                 $this->inTarget = false;
             } else {
                 $this->inTarget = true;
@@ -30,18 +30,18 @@ 
         }
 
         // reset Marker positions
-        if ( 'sdl:seg-defs' == $name ) {
+        if ('sdl:seg-defs' == $name) {
             $this->segmentInUnitPosition = 0;
         }
 
         // open buffer
-        if ( in_array( $name, $this->nodesToBuffer ) ) {
+        if (in_array($name, $this->nodesToBuffer)) {
             $this->bufferIsActive = true;
         }
 
         // check if we are inside a <target>, obviously this happen only if there are targets inside the trans-unit
         // <target> must be stripped to be replaced, so this check avoids <target> reconstruction
-        if ( !$this->inTarget ) {
+        if (!$this->inTarget) {
 
             // costruct tag
             $tag = "<$name ";
@@ -51,16 +51,16 @@ 
             // so the check on it's name is not enough
             $_sdlStatus_confWritten = false;
 
-            foreach ( $attr as $k => $v ) {
+            foreach ($attr as $k => $v) {
 
                 // if tag name is file, we must replace the target-language attribute
-                if ( $name == 'file' && $k == 'target-language' && !empty( $this->targetLang ) ) {
+                if ($name == 'file' && $k == 'target-language' && !empty($this->targetLang)) {
                     //replace Target language with job language provided from constructor
                     $tag .= "$k=\"$this->targetLang\" ";
                 } else {
                     //normal tag flux, put attributes in it
                     // Warning, this is NOT an elseif
-                    if ( $k != 'conf' ) {
+                    if ($k != 'conf') {
                         //put also the current attribute in it if it is not a "conf" attribute
                         $tag .= "$k=\"$v\" ";
                     }
@@ -69,11 +69,11 @@ 
 
             $seg = $this->getCurrentSegment();
 
-            if ( 'sdl:seg' == $name && !empty( $seg ) and isset( $seg[ 'sid' ] ) ) {
-                $tag .= $this->prepareTargetStatuses( $seg );
+            if ('sdl:seg' == $name && !empty($seg) and isset($seg['sid'])) {
+                $tag .= $this->prepareTargetStatuses($seg);
             }
 
-            $this->checkForSelfClosedTagAndFlush( $parser, $tag );
+            $this->checkForSelfClosedTagAndFlush($parser, $tag);
 
         }
 
@@ -84,7 +84,7 @@ 
      *
      * @return string
      */
-    protected function prepareTargetStatuses( $segment ): string {
+    protected function prepareTargetStatuses($segment): string {
         $statusMap = [
                 'NEW'        => '',
                 'DRAFT'      => 'Draft',
@@ -93,22 +93,22 @@ 
                 'REJECTED'   => 'RejectedTranslation',
         ];
 
-        return "conf=\"{$statusMap[ $segment[ 'status' ] ]}\" ";
+        return "conf=\"{$statusMap[$segment['status']]}\" ";
     }
 
-    protected function rebuildMarks( array $seg, string $translation ): string {
+    protected function rebuildMarks(array $seg, string $translation): string {
 
         $trailingSpaces = '';
-        for ( $s = 0; $s < Strings::getTheNumberOfTrailingSpaces( $translation ); $s++ ) {
+        for ($s = 0; $s < Strings::getTheNumberOfTrailingSpaces($translation); $s++) {
             $trailingSpaces .= ' ';
         }
 
-        if ( $seg[ 'mrk_id' ] !== null && $seg[ 'mrk_id' ] != '' ) {
-            if ( $this->targetLang === 'ja-JP' ) {
-                $seg[ 'mrk_succ_tags' ] = ltrim( $seg[ 'mrk_succ_tags' ] );
+        if ($seg['mrk_id'] !== null && $seg['mrk_id'] != '') {
+            if ($this->targetLang === 'ja-JP') {
+                $seg['mrk_succ_tags'] = ltrim($seg['mrk_succ_tags']);
             }
 
-            $translation = "<mrk mid=\"" . $seg[ 'mrk_id' ] . "\" mtype=\"seg\">" . $seg[ 'mrk_prev_tags' ] . rtrim( $translation ) . $seg[ 'mrk_succ_tags' ] . "</mrk>" . $trailingSpaces;
+            $translation = "<mrk mid=\"" . $seg['mrk_id'] . "\" mtype=\"seg\">" . $seg['mrk_prev_tags'] . rtrim($translation) . $seg['mrk_succ_tags'] . "</mrk>" . $trailingSpaces;
         }
 
         return $translation;