matecat / xliff-parser

src/XliffParser/XliffParserV2.php

Spacing +141 added lines, -141 removed lines

@@ -16,30 +16,30 @@ 
      * @inheritDoc
      * @throws \Exception
      */
-    public function parse( DOMDocument $dom, $output = [] ) {
+    public function parse(DOMDocument $dom, $output = []) {
         $i = 1;
         /** @var DOMElement $file */
-        foreach ( $dom->getElementsByTagName( 'file' ) as $file ) {
+        foreach ($dom->getElementsByTagName('file') as $file) {
 
             // metadata
-            $output[ 'files' ][ $i ][ 'attr' ] = $this->extractMetadata( $dom );
+            $output['files'][$i]['attr'] = $this->extractMetadata($dom);
 
             // notes
-            $output[ 'files' ][ $i ][ 'notes' ] = $this->extractNotes( $file );
+            $output['files'][$i]['notes'] = $this->extractNotes($file);
 
             // trans-units
             $transUnitIdArrayForUniquenessCheck = [];
             $j                                  = 1;
             /** @var DOMElement $transUnit */
-            foreach ( $file->childNodes as $childNode ) {
-                $this->extractTuFromNode( $childNode, $transUnitIdArrayForUniquenessCheck, $dom, $output, $i, $j );
+            foreach ($file->childNodes as $childNode) {
+                $this->extractTuFromNode($childNode, $transUnitIdArrayForUniquenessCheck, $dom, $output, $i, $j);
             }
 
             // trans-unit re-count check
-            $totalTransUnitsId  = count( $transUnitIdArrayForUniquenessCheck );
-            $transUnitsUniqueId = count( array_unique( $transUnitIdArrayForUniquenessCheck ) );
-            if ( $totalTransUnitsId != $transUnitsUniqueId ) {
-                throw new DuplicateTransUnitIdInXliff( "Invalid trans-unit id, duplicate found.", 400 );
+            $totalTransUnitsId  = count($transUnitIdArrayForUniquenessCheck);
+            $transUnitsUniqueId = count(array_unique($transUnitIdArrayForUniquenessCheck));
+            if ($totalTransUnitsId != $transUnitsUniqueId) {
+                throw new DuplicateTransUnitIdInXliff("Invalid trans-unit id, duplicate found.", 400);
             }
 
             $i++;
@@ -53,23 +53,23 @@ 
      *
      * @return array
      */
-    private function extractMetadata( DOMDocument $dom ) {
+    private function extractMetadata(DOMDocument $dom) {
         $metadata = [];
 
-        $xliffNode = $dom->getElementsByTagName( 'xliff' )->item( 0 );
-        $fileNode  = $dom->getElementsByTagName( 'file' )->item( 0 );
+        $xliffNode = $dom->getElementsByTagName('xliff')->item(0);
+        $fileNode  = $dom->getElementsByTagName('file')->item(0);
 
         // original
-        $metadata[ 'original' ] = ( null !== $fileNode->attributes->getNamedItem( 'original' ) ) ? $fileNode->attributes->getNamedItem( 'original' )->nodeValue : 'no-name';
+        $metadata['original'] = (null !== $fileNode->attributes->getNamedItem('original')) ? $fileNode->attributes->getNamedItem('original')->nodeValue : 'no-name';
 
         // source-language
-        $metadata[ 'source-language' ] = ( null !== $xliffNode->attributes->getNamedItem( 'srcLang' ) ) ? $xliffNode->attributes->getNamedItem( 'srcLang' )->nodeValue : 'en-US';
+        $metadata['source-language'] = (null !== $xliffNode->attributes->getNamedItem('srcLang')) ? $xliffNode->attributes->getNamedItem('srcLang')->nodeValue : 'en-US';
 
         // datatype
         // @TODO to be implemented
 
         // target-language
-        $metadata[ 'target-language' ] = ( null !== $xliffNode->attributes->getNamedItem( 'trgLang' ) ) ? $xliffNode->attributes->getNamedItem( 'trgLang' )->nodeValue : 'en-US';
+        $metadata['target-language'] = (null !== $xliffNode->attributes->getNamedItem('trgLang')) ? $xliffNode->attributes->getNamedItem('trgLang')->nodeValue : 'en-US';
 
         // custom MateCat x-attribute
         // @TODO to be implemented
@@ -83,16 +83,16 @@ 
      * @return array
      * @throws \Exception
      */
-    private function extractNotes( DOMElement $file ) {
+    private function extractNotes(DOMElement $file) {
         $notes = [];
 
         // loop <notes> to get nested <note> tag
-        foreach ( $file->childNodes as $childNode ) {
-            if ( $childNode->nodeName === 'notes' ) {
-                foreach ( $childNode->childNodes as $note ) {
-                    $noteValue = trim( $note->nodeValue );
-                    if ( '' !== $noteValue ) {
-                        $notes[] = $this->JSONOrRawContentArray( $noteValue );
+        foreach ($file->childNodes as $childNode) {
+            if ($childNode->nodeName === 'notes') {
+                foreach ($childNode->childNodes as $note) {
+                    $noteValue = trim($note->nodeValue);
+                    if ('' !== $noteValue) {
+                        $notes[] = $this->JSONOrRawContentArray($noteValue);
                     }
                 }
             }
@@ -113,34 +113,34 @@ 
      *
      * @throws \Exception
      */
-    protected function extractTransUnit( $transUnit, &$transUnitIdArrayForUniquenessCheck, $dom, &$output, &$i, &$j ) {
+    protected function extractTransUnit($transUnit, &$transUnitIdArrayForUniquenessCheck, $dom, &$output, &$i, &$j) {
         // metadata
-        $output[ 'files' ][ $i ][ 'trans-units' ][ $j ][ 'attr' ] = $this->extractTransUnitMetadata( $transUnit, $transUnitIdArrayForUniquenessCheck );
+        $output['files'][$i]['trans-units'][$j]['attr'] = $this->extractTransUnitMetadata($transUnit, $transUnitIdArrayForUniquenessCheck);
 
         // notes
         // merge <notes> with key and key-note contained in metadata <mda:metaGroup>
-        $output[ 'files' ][ $i ][ 'trans-units' ][ $j ][ 'notes' ] = $this->extractTransUnitNotes( $transUnit );
+        $output['files'][$i]['trans-units'][$j]['notes'] = $this->extractTransUnitNotes($transUnit);
 
         // uuid
-        foreach ( $output[ 'files' ][ $i ][ 'trans-units' ][ $j ][ 'notes' ] as $note ) {
-            if ( isset( $note[ 'raw-content' ] ) && Strings::isAValidUuid( $note[ 'raw-content' ] ) ) {
-                $output[ 'files' ][ $i ][ 'trans-units' ][ $j ][ 'attr' ][ 'uuid' ] = $note[ 'raw-content' ];
+        foreach ($output['files'][$i]['trans-units'][$j]['notes'] as $note) {
+            if (isset($note['raw-content']) && Strings::isAValidUuid($note['raw-content'])) {
+                $output['files'][$i]['trans-units'][$j]['attr']['uuid'] = $note['raw-content'];
             }
         }
 
         // original-data (exclusive for V2)
         // http://docs.oasis-open.org/xliff/xliff-core/v2.0/xliff-core-v2.0.html#originaldata
-        $originalData = $this->extractTransUnitOriginalData( $transUnit );
+        $originalData = $this->extractTransUnitOriginalData($transUnit);
         $dataRefMap   = null;
-        if ( !empty( $originalData ) ) {
-            $output[ 'files' ][ $i ][ 'trans-units' ][ $j ][ 'original-data' ] = $originalData;
-            $dataRefMap                                                        = $this->getDataRefMap( $originalData );
+        if (!empty($originalData)) {
+            $output['files'][$i]['trans-units'][$j]['original-data'] = $originalData;
+            $dataRefMap                                                        = $this->getDataRefMap($originalData);
         }
 
         // additionalTagData (exclusive for V2)
-        $additionalTagData = $this->extractTransUnitAdditionalTagData( $transUnit );
-        if ( !empty( $additionalTagData ) ) {
-            $output[ 'files' ][ $i ][ 'trans-units' ][ $j ][ 'additional-tag-data' ] = $additionalTagData;
+        $additionalTagData = $this->extractTransUnitAdditionalTagData($transUnit);
+        if (!empty($additionalTagData)) {
+            $output['files'][$i]['trans-units'][$j]['additional-tag-data'] = $additionalTagData;
         }
 
         // content
@@ -160,64 +160,64 @@ 
 
         /** @var DOMElement $segment */
         $c = 0;
-        foreach ( $transUnit->childNodes as $segment ) {
-            if ( $segment->nodeName === 'segment' ) {
+        foreach ($transUnit->childNodes as $segment) {
+            if ($segment->nodeName === 'segment') {
 
                 // check segment id consistency
-                $attr = $output[ 'files' ][ $i ][ 'trans-units' ][ $j ][ 'attr' ];
-                $this->checkSegmentIdConsistency( $segment, $attr );
+                $attr = $output['files'][$i]['trans-units'][$j]['attr'];
+                $this->checkSegmentIdConsistency($segment, $attr);
 
                 // loop <segment> to get nested <source> and <target> tag
-                foreach ( $segment->childNodes as $childNode ) {
-                    if ( $childNode->nodeName === 'source' ) {
-                        $extractedSource               = $this->extractContent( $dom, $childNode );
-                        $source[ 'raw-content' ][ $c ] = $extractedSource[ 'raw-content' ];
+                foreach ($segment->childNodes as $childNode) {
+                    if ($childNode->nodeName === 'source') {
+                        $extractedSource               = $this->extractContent($dom, $childNode);
+                        $source['raw-content'][$c] = $extractedSource['raw-content'];
 
-                        if ( !empty( $originalData ) ) {
-                            $source[ 'replaced-content' ][ $c ] = ( new DataRefReplacer( $dataRefMap ) )->replace( $source[ 'raw-content' ][ $c ] );
+                        if (!empty($originalData)) {
+                            $source['replaced-content'][$c] = (new DataRefReplacer($dataRefMap))->replace($source['raw-content'][$c]);
                         }
 
-                        if ( !empty( $extractedSource[ 'attr' ] ) ) {
-                            $source[ 'attr' ][ $c ] = $extractedSource[ 'attr' ];
+                        if (!empty($extractedSource['attr'])) {
+                            $source['attr'][$c] = $extractedSource['attr'];
                         }
 
                         // append value to 'seg-source'
-                        if ( $this->stringContainsMarks( $extractedSource[ 'raw-content' ] ) ) {
-                            $segSource = $this->extractContentWithMarksAndExtTags( $dom, $childNode, $extractedSource[ 'raw-content' ], $originalData );
+                        if ($this->stringContainsMarks($extractedSource['raw-content'])) {
+                            $segSource = $this->extractContentWithMarksAndExtTags($dom, $childNode, $extractedSource['raw-content'], $originalData);
                         } else {
                             $segSource[] = [
-                                    'attr'             => $this->extractTagAttributes( $segment),
-                                    'mid'              => count( $segSource ) > 0 ? count( $segSource ) : 0,
+                                    'attr'             => $this->extractTagAttributes($segment),
+                                    'mid'              => count($segSource) > 0 ? count($segSource) : 0,
                                     'ext-prec-tags'    => '',
-                                    'raw-content'      => $extractedSource[ 'raw-content' ],
-                                    'replaced-content' => ( !empty( $originalData ) ) ? ( new DataRefReplacer( $dataRefMap ) )->replace( $extractedSource[ 'raw-content' ] ) : null,
+                                    'raw-content'      => $extractedSource['raw-content'],
+                                    'replaced-content' => (!empty($originalData)) ? (new DataRefReplacer($dataRefMap))->replace($extractedSource['raw-content']) : null,
                                     'ext-succ-tags'    => '',
                             ];
                         }
                     }
 
-                    if ( $childNode->nodeName === 'target' ) {
-                        $extractedTarget               = $this->extractContent( $dom, $childNode );
-                        $target[ 'raw-content' ][ $c ] = $extractedTarget[ 'raw-content' ];
+                    if ($childNode->nodeName === 'target') {
+                        $extractedTarget               = $this->extractContent($dom, $childNode);
+                        $target['raw-content'][$c] = $extractedTarget['raw-content'];
 
-                        if ( !empty( $originalData ) ) {
-                            $target[ 'replaced-content' ][ $c ] = ( new DataRefReplacer( $dataRefMap ) )->replace( $target[ 'raw-content' ][ $c ] );
+                        if (!empty($originalData)) {
+                            $target['replaced-content'][$c] = (new DataRefReplacer($dataRefMap))->replace($target['raw-content'][$c]);
                         }
 
-                        if ( !empty( $extractedTarget[ 'attr' ] ) ) {
-                            $target[ 'attr' ][ $c ] = $extractedTarget[ 'attr' ];
+                        if (!empty($extractedTarget['attr'])) {
+                            $target['attr'][$c] = $extractedTarget['attr'];
                         }
 
                         // append value to 'seg-target'
-                        if ( $this->stringContainsMarks( $extractedTarget[ 'raw-content' ] ) ) {
-                            $segTarget = $this->extractContentWithMarksAndExtTags( $dom, $childNode, $extractedTarget[ 'raw-content' ], $originalData );
+                        if ($this->stringContainsMarks($extractedTarget['raw-content'])) {
+                            $segTarget = $this->extractContentWithMarksAndExtTags($dom, $childNode, $extractedTarget['raw-content'], $originalData);
                         } else {
                             $segTarget[] = [
-                                    'attr'             => $this->extractTagAttributes( $segment),
-                                    'mid'              => count( $segTarget ) > 0 ? count( $segTarget ) : 0,
+                                    'attr'             => $this->extractTagAttributes($segment),
+                                    'mid'              => count($segTarget) > 0 ? count($segTarget) : 0,
                                     'ext-prec-tags'    => '',
-                                    'raw-content'      => $extractedTarget[ 'raw-content' ],
-                                    'replaced-content' => ( !empty( $originalData ) ) ? ( new DataRefReplacer( $dataRefMap ) )->replace( $extractedTarget[ 'raw-content' ] ) : null,
+                                    'raw-content'      => $extractedTarget['raw-content'],
+                                    'replaced-content' => (!empty($originalData)) ? (new DataRefReplacer($dataRefMap))->replace($extractedTarget['raw-content']) : null,
                                     'ext-succ-tags'    => '',
                             ];
                         }
@@ -228,10 +228,10 @@ 
             }
         }
 
-        $output[ 'files' ][ $i ][ 'trans-units' ][ $j ][ 'source' ]     = $source;
-        $output[ 'files' ][ $i ][ 'trans-units' ][ $j ][ 'target' ]     = $target;
-        $output[ 'files' ][ $i ][ 'trans-units' ][ $j ][ 'seg-source' ] = $segSource;
-        $output[ 'files' ][ $i ][ 'trans-units' ][ $j ][ 'seg-target' ] = $segTarget;
+        $output['files'][$i]['trans-units'][$j]['source']     = $source;
+        $output['files'][$i]['trans-units'][$j]['target']     = $target;
+        $output['files'][$i]['trans-units'][$j]['seg-source'] = $segSource;
+        $output['files'][$i]['trans-units'][$j]['seg-target'] = $segTarget;
 
         $j++;
     }
@@ -242,41 +242,41 @@ 
      *
      * @return array
      */
-    private function extractTransUnitMetadata( DOMElement $transUnit, &$transUnitIdArrayForUniquenessCheck ) {
+    private function extractTransUnitMetadata(DOMElement $transUnit, &$transUnitIdArrayForUniquenessCheck) {
         $metadata = [];
 
         // id
-        if ( null === $transUnit->attributes->getNamedItem( 'id' ) ) {
-            throw new NotFoundIdInTransUnit( 'Invalid trans-unit id found. EMPTY value', 400 );
+        if (null === $transUnit->attributes->getNamedItem('id')) {
+            throw new NotFoundIdInTransUnit('Invalid trans-unit id found. EMPTY value', 400);
         }
 
-        $id = $transUnit->attributes->getNamedItem( 'id' )->nodeValue;
+        $id = $transUnit->attributes->getNamedItem('id')->nodeValue;
 
-        if ( strlen( $id ) > 100 ) {
-            throw new SegmentIdTooLongException( 'Segment-id too long. Max 100 characters allowed', 400 );
+        if (strlen($id) > 100) {
+            throw new SegmentIdTooLongException('Segment-id too long. Max 100 characters allowed', 400);
         }
 
         $transUnitIdArrayForUniquenessCheck[] = $id;
-        $metadata[ 'id' ]                     = $id;
+        $metadata['id']                     = $id;
 
         // translate
-        if ( null !== $transUnit->attributes->getNamedItem( 'translate' ) ) {
-            $metadata[ 'translate' ] = $transUnit->attributes->getNamedItem( 'translate' )->nodeValue;
+        if (null !== $transUnit->attributes->getNamedItem('translate')) {
+            $metadata['translate'] = $transUnit->attributes->getNamedItem('translate')->nodeValue;
         }
 
         // tGroupBegin
-        if ( null !== $transUnit->attributes->getNamedItem( 'tGroupBegin' ) ) {
-            $metadata[ 'tGroupBegin' ] = $transUnit->attributes->getNamedItem( 'tGroupBegin' )->nodeValue;
+        if (null !== $transUnit->attributes->getNamedItem('tGroupBegin')) {
+            $metadata['tGroupBegin'] = $transUnit->attributes->getNamedItem('tGroupBegin')->nodeValue;
         }
 
         // tGroupEnd
-        if ( null !== $transUnit->attributes->getNamedItem( 'tGroupEnd' ) ) {
-            $metadata[ 'tGroupEnd' ] = $transUnit->attributes->getNamedItem( 'tGroupEnd' )->nodeValue;
+        if (null !== $transUnit->attributes->getNamedItem('tGroupEnd')) {
+            $metadata['tGroupEnd'] = $transUnit->attributes->getNamedItem('tGroupEnd')->nodeValue;
         }
 
         // sizeRestriction
-        if ( null !== $transUnit->attributes->getNamedItem( 'sizeRestriction' ) && '' !== $transUnit->attributes->getNamedItem( 'sizeRestriction' )->nodeValue ) {
-            $metadata[ 'sizeRestriction' ] = (int)$transUnit->attributes->getNamedItem( 'sizeRestriction' )->nodeValue;
+        if (null !== $transUnit->attributes->getNamedItem('sizeRestriction') && '' !== $transUnit->attributes->getNamedItem('sizeRestriction')->nodeValue) {
+            $metadata['sizeRestriction'] = (int)$transUnit->attributes->getNamedItem('sizeRestriction')->nodeValue;
         }
 
         return $metadata;
@@ -288,31 +288,31 @@ 
      * @return array
      * @throws \Exception
      */
-    private function extractTransUnitOriginalData( DOMElement $transUnit ) {
+    private function extractTransUnitOriginalData(DOMElement $transUnit) {
         $originalData = [];
 
         // loop <originalData> to get nested content
-        foreach ( $transUnit->childNodes as $childNode ) {
-            if ( $childNode->nodeName === 'originalData' ) {
-                foreach ( $childNode->childNodes as $data ) {
-                    if ( null !== $data->attributes && null !== $data->attributes->getNamedItem( 'id' ) ) {
-                        $dataId = $data->attributes->getNamedItem( 'id' )->nodeValue;
+        foreach ($transUnit->childNodes as $childNode) {
+            if ($childNode->nodeName === 'originalData') {
+                foreach ($childNode->childNodes as $data) {
+                    if (null !== $data->attributes && null !== $data->attributes->getNamedItem('id')) {
+                        $dataId = $data->attributes->getNamedItem('id')->nodeValue;
 
-                        $dataValue = str_replace( Placeholder::WHITE_SPACE_PLACEHOLDER, ' ', $data->nodeValue );
-                        $dataValue = str_replace( Placeholder::NEW_LINE_PLACEHOLDER, '\n', $dataValue );
-                        $dataValue = str_replace( Placeholder::TAB_PLACEHOLDER, '\t', $dataValue );
+                        $dataValue = str_replace(Placeholder::WHITE_SPACE_PLACEHOLDER, ' ', $data->nodeValue);
+                        $dataValue = str_replace(Placeholder::NEW_LINE_PLACEHOLDER, '\n', $dataValue);
+                        $dataValue = str_replace(Placeholder::TAB_PLACEHOLDER, '\t', $dataValue);
 
-                        if ( '' !== $dataValue ) {
+                        if ('' !== $dataValue) {
 
-                            $jsonOrRawContentArray = $this->JSONOrRawContentArray( $dataValue, false );
+                            $jsonOrRawContentArray = $this->JSONOrRawContentArray($dataValue, false);
 
                             // restore xliff tags
-                            if ( isset( $jsonOrRawContentArray[ 'json' ] ) ) {
-                                $jsonOrRawContentArray[ 'json' ] = str_replace( [ Placeholder::LT_PLACEHOLDER, Placeholder::GT_PLACEHOLDER ], [ '&lt;', '&gt;' ], $jsonOrRawContentArray[ 'json' ] );
+                            if (isset($jsonOrRawContentArray['json'])) {
+                                $jsonOrRawContentArray['json'] = str_replace([Placeholder::LT_PLACEHOLDER, Placeholder::GT_PLACEHOLDER], ['&lt;', '&gt;'], $jsonOrRawContentArray['json']);
                             }
 
-                            if ( isset( $jsonOrRawContentArray[ 'raw-content' ] ) ) {
-                                $jsonOrRawContentArray[ 'raw-content' ] = str_replace( [ Placeholder::LT_PLACEHOLDER, Placeholder::GT_PLACEHOLDER ], [ '&lt;', '&gt;' ], $jsonOrRawContentArray[ 'raw-content' ] );
+                            if (isset($jsonOrRawContentArray['raw-content'])) {
+                                $jsonOrRawContentArray['raw-content'] = str_replace([Placeholder::LT_PLACEHOLDER, Placeholder::GT_PLACEHOLDER], ['&lt;', '&gt;'], $jsonOrRawContentArray['raw-content']);
                             }
 
                             $originalData[] = array_merge(
@@ -337,41 +337,41 @@ 
      *
      * @return array
      */
-    private function extractTransUnitAdditionalTagData( DOMElement $transUnit ) {
+    private function extractTransUnitAdditionalTagData(DOMElement $transUnit) {
         $additionalTagData = [];
 
         // loop <originalData> to get nested content
-        foreach ( $transUnit->childNodes as $childNode ) {
-            if ( $childNode->nodeName === 'memsource:additionalTagData' ) {
-                foreach ( $childNode->childNodes as $data ) {
+        foreach ($transUnit->childNodes as $childNode) {
+            if ($childNode->nodeName === 'memsource:additionalTagData') {
+                foreach ($childNode->childNodes as $data) {
                     $dataArray = [];
 
                     // id
-                    if ( $data->nodeName === 'memsource:tag' ) {
-                        if ( null !== $data->attributes && null !== $data->attributes->getNamedItem( 'id' ) ) {
-                            $dataId                      = $data->attributes->getNamedItem( 'id' )->nodeValue;
-                            $dataArray[ 'attr' ][ 'id' ] = $dataId;
+                    if ($data->nodeName === 'memsource:tag') {
+                        if (null !== $data->attributes && null !== $data->attributes->getNamedItem('id')) {
+                            $dataId                      = $data->attributes->getNamedItem('id')->nodeValue;
+                            $dataArray['attr']['id'] = $dataId;
                         }
                     }
 
                     // in PHP 7.4 $data->childNodes is an empty DomNodeList, it is iterable with size 0
                     // PHP 5.6 check: in php 5.6 $data->childNodes can be null
-                    if ( $data->childNodes != null ) {
+                    if ($data->childNodes != null) {
 
                         // content
-                        foreach ( $data->childNodes as $datum ) {
-                            if ( $datum->nodeName === 'memsource:tagId' ) {
-                                $dataArray[ 'raw-content' ][ 'tagId' ] = $datum->nodeValue;
+                        foreach ($data->childNodes as $datum) {
+                            if ($datum->nodeName === 'memsource:tagId') {
+                                $dataArray['raw-content']['tagId'] = $datum->nodeValue;
                             }
 
-                            if ( $datum->nodeName === 'memsource:type' ) {
-                                $dataArray[ 'raw-content' ][ 'type' ] = $datum->nodeValue;
+                            if ($datum->nodeName === 'memsource:type') {
+                                $dataArray['raw-content']['type'] = $datum->nodeValue;
                             }
                         }
 
                     }
 
-                    if ( !empty( $dataArray ) ) {
+                    if (!empty($dataArray)) {
                         $additionalTagData[] = $dataArray;
                     }
                 }
@@ -387,15 +387,15 @@ 
      * @param DOMElement $segment
      * @param array      $attr
      */
-    private function checkSegmentIdConsistency( DOMElement $segment, array $attr ) {
-        if ( isset( $attr[ 'tGroupBegin' ] ) && isset( $attr[ 'tGroupEnd' ] ) && $segment->attributes->getNamedItem( 'id' ) ) {
-            $id  = $segment->attributes->getNamedItem( 'id' )->nodeValue;
-            $min = (int)$attr[ 'tGroupBegin' ];
-            $max = (int)$attr[ 'tGroupEnd' ];
-
-            if ( false === ( ( $min <= $id ) && ( $id <= $max ) ) ) {
-                if ( $this->logger ) {
-                    $this->logger->warning( 'Segment #' . $id . ' is not included within tGroupBegin and tGroupEnd' );
+    private function checkSegmentIdConsistency(DOMElement $segment, array $attr) {
+        if (isset($attr['tGroupBegin']) && isset($attr['tGroupEnd']) && $segment->attributes->getNamedItem('id')) {
+            $id  = $segment->attributes->getNamedItem('id')->nodeValue;
+            $min = (int)$attr['tGroupBegin'];
+            $max = (int)$attr['tGroupEnd'];
+
+            if (false === (($min <= $id) && ($id <= $max))) {
+                if ($this->logger) {
+                    $this->logger->warning('Segment #' . $id . ' is not included within tGroupBegin and tGroupEnd');
                 }
             }
         }
@@ -407,31 +407,31 @@ 
      * @return array
      * @throws \Exception
      */
-    private function extractTransUnitNotes( DOMElement $transUnit ) {
+    private function extractTransUnitNotes(DOMElement $transUnit) {
         $notes = [];
 
         // loop <notes> to get nested <note> tag
-        foreach ( $transUnit->childNodes as $childNode ) {
-            if ( $childNode->nodeName == 'notes' ) {
-                foreach ( $childNode->childNodes as $note ) {
-                    $noteValue = trim( $note->nodeValue );
-                    if ( '' !== $noteValue ) {
-                        $notes[] = $this->JSONOrRawContentArray( $noteValue );
+        foreach ($transUnit->childNodes as $childNode) {
+            if ($childNode->nodeName == 'notes') {
+                foreach ($childNode->childNodes as $note) {
+                    $noteValue = trim($note->nodeValue);
+                    if ('' !== $noteValue) {
+                        $notes[] = $this->JSONOrRawContentArray($noteValue);
                     }
                 }
             }
 
-            if ( $childNode->nodeName === 'mda:metadata' ) {
-                foreach ( $childNode->childNodes as $metadata ) {
-                    if ( $metadata->nodeName === 'mda:metaGroup' ) {
-                        foreach ( $metadata->childNodes as $meta ) {
-                            if ( null !== $meta->attributes && null !== $meta->attributes->getNamedItem( 'type' ) ) {
-                                $type      = $meta->attributes->getNamedItem( 'type' )->nodeValue;
-                                $metaValue = trim( $meta->nodeValue );
+            if ($childNode->nodeName === 'mda:metadata') {
+                foreach ($childNode->childNodes as $metadata) {
+                    if ($metadata->nodeName === 'mda:metaGroup') {
+                        foreach ($metadata->childNodes as $meta) {
+                            if (null !== $meta->attributes && null !== $meta->attributes->getNamedItem('type')) {
+                                $type      = $meta->attributes->getNamedItem('type')->nodeValue;
+                                $metaValue = trim($meta->nodeValue);
 
-                                if ( '' !== $metaValue ) {
+                                if ('' !== $metaValue) {
                                     $notes[] = array_merge(
-                                            $this->JSONOrRawContentArray( $metaValue ),
+                                            $this->JSONOrRawContentArray($metaValue),
                                             [
                                                     'attr' => [
                                                             'type' => $type