marcojanssen / silex-routing-service-provider

src/MJanssen/Provider/RoutingServiceProvider.php

Doc Comments +2 added lines, -3 removed lines

@@ -87,7 +87,6 @@ 
     /**
      * Adds a route, a given route-name (for named routes) and all of its methods
      *
-     * @param Container $app
      * @param array $route
      * @throws InvalidArgumentException
      */
@@ -150,7 +149,7 @@ 
     /**
      * @param Controller $controller
      * @param $actions
-     * @param $type
+     * @param string $type
      * @throws \InvalidArgumentException
      */
     protected function addActions(Controller $controller, $actions, $type)
@@ -232,7 +231,7 @@ 
      * Adds a before/after middleware by its configuration
      *
      * @param Controller $controller
-     * @param $type
+     * @param string $type
      * @param $value
      */
     protected function addMiddlewareFromConfig(Controller $controller, $type, $value)

Unused Use Statements +4 added lines, -6 removed lines

@@ -3,15 +3,13 @@
 
 use InvalidArgumentException;
 use MJanssen\Route\Factory;
-use MJanssen\Route\Name;
-use MJanssen\Route\Route;
-use RuntimeException;
-use Silex\Application;
-use Silex\Controller;
-use Pimple\ServiceProviderInterface;
 use Pimple\Container;
+use Pimple\ServiceProviderInterface;
+use RuntimeException;
 use Silex\Api\BootableProviderInterface;
 use Silex\Api\EventListenerProviderInterface;
+use Silex\Application;
+use Silex\Controller;
 use Symfony\Component\EventDispatcher\EventDispatcherInterface;
 
 /**

src/MJanssen/Route/Route.php

Doc Comments +8 added lines, -8 removed lines

@@ -38,12 +38,12 @@ 
     private $values = [];
 
     /**
-     * @param array $methods
-     * @param string $pattern
-     * @param string $controller
-     * @param array $asserts
-     * @param array $values
-     * @param string $name
+     * @param Methods $methods
+     * @param Pattern $pattern
+     * @param Controller $controller
+     * @param Asserts $asserts
+     * @param Values $values
+     * @param Name $name
      */
     public function __construct(
         Methods $methods,
@@ -78,7 +78,7 @@ 
     }
 
     /**
-     * @return Pattern
+     * @return string
      */
     public function getPattern()
     {
@@ -86,7 +86,7 @@ 
     }
 
     /**
-     * @return Controller
+     * @return string
      */
     public function getController()
     {

Unused Use Statements -3 removed lines

@@ -2,9 +2,6 @@
 
 namespace MJanssen\Route;
 
-use InvalidArgumentException;
-use MJanssen\Assert\Method;
-
 class Route
 {
     /**