mapado / rest-client-sdk

src/EntityRepository.php

Doc Comments -2 removed lines

@@ -37,10 +37,8 @@
 
     /**
      *
-     * @param type $client - the client to process the data with
      * @param object $sdkClient - the client to connect to the datasource with
      * @param object $restClient - cleitn to process the http requests
-     * @param type $class The entiy to work with
      */
     public function __construct($sdkClient, $restClient, $entityName)
     {

Spacing +2 added lines, -2 removed lines

@@ -178,7 +178,7 @@ 
         }
         $path .= '?' . http_build_query($this->convertQueryParameters($queryParams));
 
-        $data =  $this->restClient->get($path);
+        $data = $this->restClient->get($path);
 
 
         $hydrator = $this->sdk->getModelHydrator();
@@ -208,7 +208,7 @@ 
         $sdk = $this->sdk;
 
         return array_map(
-            function ($item) use ($sdk) {
+            function($item) use ($sdk) {
                 if (is_object($item)) {
                     $mapping = $sdk->getMapping();
                     if (method_exists($item, 'getId')) {

src/Mapping.php

Doc Comments +4 added lines, -4 removed lines

@@ -42,7 +42,7 @@ 
     /**
      * setMapping
      *
-     * @param array $mapping
+     * @param Mapping\ClassMetadata[] $mapping
      * @access public
      * @return Mapping
      */
@@ -88,7 +88,7 @@ 
      *
      * @param string $id
      * @access public
-     * @return void
+     * @return string
      */
     public function getKeyFromId($id)
     {
@@ -104,7 +104,7 @@ 
      *
      * @param string $modelName model name
      * @access public
-     * @return void
+     * @return string
      */
     public function getKeyFromModel($modelName)
     {
@@ -199,7 +199,7 @@ 
     /**
      * removePrefix
      *
-     * @param mixed $value
+     * @param string $value
      * @access private
      * @return string
      */

Spacing +1 added lines, -1 removed lines

@@ -76,7 +76,7 @@
     public function getMappingKeys()
     {
         return array_map(
-            function ($mapping) {
+            function($mapping) {
                 return $mapping->getKey();
             },
             $this->mapping

src/Mapping/Driver/AnnotationDriver.php

Doc Comments +3 added lines, -3 removed lines

@@ -191,9 +191,9 @@
     /**
      * getPropertyAnnotation
      *
-     * @param mixed $reader
-     * @param mixed $property
-     * @param mixed $classname
+     * @param FileCacheReader $reader
+     * @param \ReflectionProperty $property
+     * @param string $classname
      * @access private
      * @return void
      */

Spacing +2 added lines, -2 removed lines

@@ -76,7 +76,7 @@ 
 
         foreach ($iterator as $file) {
             $sourceFile = $file[0];
-            if (! preg_match('(^phar:)i', $sourceFile)) {
+            if (!preg_match('(^phar:)i', $sourceFile)) {
                 $sourceFile = realpath($sourceFile);
             }
 
@@ -114,7 +114,7 @@ 
     {
         $metadata = $this->getClassMetadataForClassname($classname);
 
-        return $metadata ? [$metadata,] : [];
+        return $metadata ? [$metadata, ] : [];
     }
 
     /**

src/Model/ModelHydrator.php

Doc Comments +4 added lines, -1 removed lines

@@ -79,7 +79,7 @@ 
      * @param array $data
      * @param string $modelName
      * @access public
-     * @return array
+     * @return HydraCollection
      */
     public function hydrateList($data, $modelName)
     {
@@ -92,6 +92,9 @@ 
         return new HydraCollection();
     }
 
+    /**
+     * @param string $modelName
+     */
     public function deserializeAll($data, $modelName)
     {
         $data['hydra:member'] = array_map(

Indentation +7 added lines, -7 removed lines

@@ -33,13 +33,13 @@
     }
 
     /**
-      * convertId
-      *
-      * @param string $id
-      * @param string $modelName
-      * @access public
-      * @return string
-      */
+     * convertId
+     *
+     * @param string $id
+     * @param string $modelName
+     * @access public
+     * @return string
+     */
     public function convertId($id, $modelName)
     {
         // add slash if needed to have a valid hydra id

Spacing +1 added lines, -1 removed lines

@@ -95,7 +95,7 @@
     public function deserializeAll($data, $modelName)
     {
         $data['hydra:member'] = array_map(
-            function ($member) use ($modelName) {
+            function($member) use ($modelName) {
                 return $this->deserialize($member, $modelName);
             },
             $data['hydra:member']

src/RestClient.php

Doc Comments +4 added lines, -4 removed lines

@@ -209,11 +209,11 @@
     /**
      * logRequest
      *
-     * @param mixed $startTime
-     * @param mixed $method
-     * @param mixed $url
+     * @param double|null $startTime
+     * @param string $method
+     * @param string $url
      * @param mixed $parameters
-     * @param mixed $response
+     * @param \Psr\Http\Message\ResponseInterface $response
      * @access private
      * @return void
      */

Spacing +2 added lines, -2 removed lines

@@ -53,7 +53,7 @@ 
     public function __construct(ClientInterface $httpClient, $baseUrl = null)
     {
         $this->httpClient = $httpClient;
-        $this->baseUrl      = substr($baseUrl, -1) === '/' ? substr($baseUrl, 0, -1) : $baseUrl;
+        $this->baseUrl = substr($baseUrl, -1) === '/' ? substr($baseUrl, 0, -1) : $baseUrl;
 
         $this->logHistory = false;
         $this->requestHistory = [];
@@ -188,7 +188,7 @@ 
         $headers = $response->getHeaders();
         $jsonContentTypeList = ['application/ld+json', 'application/json'];
 
-        $requestIsJson  = false;
+        $requestIsJson = false;
 
         if (isset($headers['Content-Type'])) {
             foreach ($jsonContentTypeList as $contentType) {

src/SdkClient.php

Doc Comments +2 added lines, -2 removed lines

@@ -24,7 +24,7 @@ 
 
     /**
      * Constructor
-     * @param ClientInterface $restClient
+     * @param RestClient $restClient
      */
     public function __construct(RestClient $restClient, Mapping $mapping, Serializer $serializer = null)
     {
@@ -113,7 +113,7 @@ 
      *
      * @param string $id
      * @access public
-     * @return object
+     * @return \ProxyManager\Proxy\GhostObjectInterface
      */
     public function createProxy($id)
     {

Spacing +3 added lines, -3 removed lines

@@ -125,8 +125,8 @@ 
         $sdk = $this;
 
         $factory     = new LazyLoadingGhostFactory();
-        $initializer = function (
-            LazyLoadingInterface &$proxy,
+        $initializer = function(
+            LazyLoadingInterface&$proxy,
             $method,
             array $parameters,
             & $initializer
@@ -136,7 +136,7 @@ 
             $id
         ) {
             if ($method !== 'getId' && $method !== 'setId' && $method !== 'jsonSerialize') {
-                $initializer   = null; // disable initialization
+                $initializer = null; // disable initialization
 
                 // load data and modify the object here
                 if ($id) {

Tests/Units/EntityRepository.php

Doc Comments -2 removed lines

@@ -15,7 +15,6 @@ 
     /**
      * testFind
      *
-     * @param mixed $method
      * @access public
      * @return void
      */
@@ -91,7 +90,6 @@ 
     /**
      * testFindNotFound
      *
-     * @param mixed $method
      * @access public
      * @return void
      */

Tests/Units/Mapping.php

Doc Comments +1 added lines, -1 removed lines

@@ -202,7 +202,7 @@
      * getMappingArray
      *
      * @access private
-     * @return void
+     * @return ClassMetadata[]
      */
     private function getMappingArray()
     {

Spacing +7 added lines, -7 removed lines

@@ -24,7 +24,7 @@ 
             ->given($this->newTestedInstance)
                 ->and($this->testedInstance->setMapping([new ClassMetadata('foo', null, null)]))
             ->then($testedInstance = $this->testedInstance)
-            ->exception(function () use ($testedInstance) {
+            ->exception(function() use ($testedInstance) {
                 @$testedInstance->getModelName();
             })
                 ->isInstanceOf('Mapado\RestClientSdk\Exception\MappingException')
@@ -34,7 +34,7 @@ 
             ->given($this->newTestedInstance)
                 ->and($this->testedInstance->setMapping([new ClassMetadata('foo', null, null)]))
             ->then($testedInstance = $this->testedInstance)
-            ->exception(function () use ($testedInstance) {
+            ->exception(function() use ($testedInstance) {
                 $testedInstance->getModelName('orders');
             })
                 ->isInstanceOf('Mapado\RestClientSdk\Exception\MappingException')
@@ -44,7 +44,7 @@ 
             ->given($this->newTestedInstance)
             ->and($this->testedInstance->setMapping([new ClassMetadata('orders', null, null)]))
             ->then($testedInstance = $this->testedInstance)
-            ->exception(function () use ($testedInstance) {
+            ->exception(function() use ($testedInstance) {
                 $testedInstance->getModelName('orders');
             })
                 ->isInstanceOf('Mapado\RestClientSdk\Exception\MappingException')
@@ -92,7 +92,7 @@ 
             // no mappings
             ->given($this->newTestedInstance)
             ->then($testedInstance = $this->testedInstance)
-                ->exception(function () use ($testedInstance) {
+                ->exception(function() use ($testedInstance) {
                     $testedInstance->getKeyFromId('/orders/8');
                 })
                 ->isInstanceOf('Mapado\RestClientSdk\Exception\MappingException')
@@ -141,7 +141,7 @@ 
                     ->isEqualTo('order_items')
 
             ->then($testedInstance = $this->testedInstance)
-            ->exception(function () use ($testedInstance) {
+            ->exception(function() use ($testedInstance) {
                 $testedInstance->getKeyFromModel('\Not\Viable\Classname');
             })
                 ->isInstanceOf('Mapado\RestClientSdk\Exception\MappingException')
@@ -167,7 +167,7 @@ 
                     ->isInstanceOf('Mapado\RestClientSdk\Mapping\ClassMetadata')
 
             ->then
-            ->exception(function () use ($testedInstance) {
+            ->exception(function() use ($testedInstance) {
                 $testedInstance->getClassMetadata('Foo\Bar');
             })
                     ->isInstanceOf('Mapado\RestClientSdk\Exception\MappingException')
@@ -224,6 +224,6 @@ 
             'Foo\Bar\Client\ClientClient'
         );
 
-        return [ $order, $orderItem, $client, ];
+        return [$order, $orderItem, $client, ];
     }
 }

Tests/Model/Cart.php

Spacing +1 added lines, -1 removed lines

@@ -154,7 +154,7 @@
 
     public function addCartItemList($cartItem)
     {
-        $this->cartItemList[] =  $cartItem;
+        $this->cartItemList[] = $cartItem;
     }
 
     /**