View GitHub Repository simple-router

Schedule Inspection
Subscribe
Completed
Push — master ( 67b45a...83bc69 )
by Charis
04:26
created
Status
Category
Toggle Patches
src/Design/RouteableInterface.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch 
@@ -15,7 +15,7 @@  discard block
 
 block discarded – undo
15 15 
      * @param mixed $handler
16 16 
      * @return Route
17 17 
      */
18 
-    public function get(string $pattern, $handler);
18 
+    public function get (string $pattern, $handler);
19 19
20 20 
     /**
21 21 
      * post function.
 
@@ -25,7 +25,7 @@  discard block
 
 block discarded – undo
25 25 
      * @param mixed $handler
26 26 
      * @return Route
27 27 
      */
28 
-    public function post(string $pattern, $handler);
28 
+    public function post (string $pattern, $handler);
29 29
30 30 
     /**
31 31 
      * put function.
 
@@ -35,7 +35,7 @@  discard block
 
 block discarded – undo
35 35 
      * @param mixed $handler
36 36 
      * @return Route
37 37 
      */
38 
-    public function put(string $pattern, $handler);
38 
+    public function put (string $pattern, $handler);
39 39
40 40 
     /**
41 41 
      * patch function.
 
@@ -45,7 +45,7 @@  discard block
 
 block discarded – undo
45 45 
      * @param mixed $handler
46 46 
      * @return Route
47 47 
      */
48 
-    public function patch(string $pattern, $handler);
48 
+    public function patch (string $pattern, $handler);
49 49
50 50 
     /**
51 51 
      * delete function.
 
@@ -55,7 +55,7 @@  discard block
 
 block discarded – undo
55 55 
      * @param mixed $handler
56 56 
      * @return Route
57 57 
      */
58 
-    public function delete(string $pattern, $handler);
58 
+    public function delete (string $pattern, $handler);
59 59
60 60 
     /**
61 61 
      * options function.
 
@@ -65,7 +65,7 @@  discard block
 
 block discarded – undo
65 65 
      * @param mixed $handler
66 66 
      * @return Route
67 67 
      */
68 
-    public function options(string $pattern, $handler);
68 
+    public function options (string $pattern, $handler);
69 69
70 70 
     /**
71 71 
      * any function.
 
@@ -75,7 +75,7 @@  discard block
 
 block discarded – undo
75 75 
      * @param mixed $handler
76 76 
      * @return Route
77 77 
      */
78 
-    public function any(string $pattern, $handler);
78 
+    public function any (string $pattern, $handler);
79 79
80 80 
     /**
81 81 
      * map function.
 
@@ -86,5 +86,5 @@  discard block
 
 block discarded – undo
86 86 
      * @param mixed $handler
87 87 
      * @return mixed
88 88 
      */
89 
-    public function map($methods, string $pattern, $handler);
89 
+    public function map ($methods, string $pattern, $handler);
90 90 
 }
Please login to merge, or discard this patch.
src/Route.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch 
@@ -71,7 +71,7 @@  discard block
 
 block discarded – undo
71 71 
      * @param string $group (default: '')
72 72 
      * @param string $identifier (default: '')
73 73 
      */
74 
-    public function __construct(string $method, string $pattern, $handler, $group = '', $identifier = '')
74 
+    public function __construct (string $method, string $pattern, $handler, $group = '', $identifier = '')
75 75 
     {
76 76 
         $this->method = $method;
77 77 
         $this->pattern = $pattern;
 
@@ -86,7 +86,7 @@  discard block
 
 block discarded – undo
86 86 
      * @access public
87 87 
      * @return string
88 88 
      */
89 
-    public function getMethod()
89 
+    public function getMethod ()
90 90 
     {
91 91 
         return $this->method;
92 92 
     }
 
@@ -98,7 +98,7 @@  discard block
 
 block discarded – undo
98 98 
      * @param string $method
99 99 
      * @return $this
100 100 
      */
101 
-    public function setMethod(string $method)
101 
+    public function setMethod (string $method)
102 102 
     {
103 103 
         $this->method = $method;
104 104 
         return $this;
 
@@ -110,7 +110,7 @@  discard block
 
 block discarded – undo
110 110 
      * @access public
111 111 
      * @return string
112 112 
      */
113 
-    public function getPattern()
113 
+    public function getPattern ()
114 114 
     {
115 115 
         return $this->pattern;
116 116 
     }
 
@@ -122,7 +122,7 @@  discard block
 
 block discarded – undo
122 122 
      * @param string $pattern
123 123 
      * @return $this
124 124 
      */
125 
-    public function setPattern(string $pattern)
125 
+    public function setPattern (string $pattern)
126 126 
     {
127 127 
         $this->pattern = $pattern;
128 128 
         return $this;
 
@@ -134,7 +134,7 @@  discard block
 
 block discarded – undo
134 134 
      * @access public
135 135 
      * @return callable|string
136 136 
      */
137 
-    public function getHandler()
137 
+    public function getHandler ()
138 138 
     {
139 139 
         return $this->handler;
140 140 
     }
 
@@ -147,7 +147,7 @@  discard block
 
 block discarded – undo
147 147 
      * @param string $handler
148 148 
      * @return $this
149 149 
      */
150 
-    public function setHandler(string $handler)
150 
+    public function setHandler (string $handler)
151 151 
     {
152 152 
         $this->handler = $handler;
153 153 
 
@@ -160,7 +160,7 @@  discard block
 
 block discarded – undo
160 160 
      * @access public
161 161 
      * @return array
162 162 
      */
163 
-    public function getGroup()
163 
+    public function getGroup ()
164 164 
     {
165 165 
         return $this->group;
166 166 
     }
 
@@ -172,7 +172,7 @@  discard block
 
 block discarded – undo
172 172 
      * @param string $group
173 173 
      * @return $this
174 174 
      */
175 
-    public function setGroup(string $group)
175 
+    public function setGroup (string $group)
176 176 
     {
177 177 
         $this->group = $group;
178 178 
 
@@ -185,7 +185,7 @@  discard block
 
 block discarded – undo
185 185 
      * @access public
186 186 
      * @return string
187 187 
      */
188 
-    public function getIdentifier()
188 
+    public function getIdentifier ()
189 189 
     {
190 190 
         return $this->identifier;
191 191 
     }
 
@@ -197,7 +197,7 @@  discard block
 
 block discarded – undo
197 197 
      * @param string $identifier
198 198 
      * @return $this
199 199 
      */
200 
-    public function setIdentifier(string $identifier)
200 
+    public function setIdentifier (string $identifier)
201 201 
     {
202 202 
         $this->identifier = $identifier;
203 203 
 
@@ -211,7 +211,7 @@  discard block
 
 block discarded – undo
211 211 
      * @param mixed $args
212 212 
      * @return $this
213 213 
      */
214 
-    public function setArgs($args)
214 
+    public function setArgs ($args)
215 215 
     {
216 216 
         $this->args = $args;
217 217 
 
@@ -224,7 +224,7 @@  discard block
 
 block discarded – undo
224 224 
      * @access public
225 225 
      * @return array
226 226 
      */
227 
-    public function getArgs()
227 
+    public function getArgs ()
228 228 
     {
229 229 
         return $this->args;
230 230 
     }
Please login to merge, or discard this patch.
src/Dummy/CacheItem.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch 
@@ -10,7 +10,7 @@  discard block
 
 block discarded – undo
10 10 
     /**
11 11 
      * {@inheritdoc}
12 12 
      */
13 
-    public function getKey()
13 
+    public function getKey ()
14 14 
     {
15 15 
         return 'no-key';
16 16 
     }
 
@@ -18,7 +18,7 @@  discard block
 
 block discarded – undo
18 18 
     /**
19 19 
      * {@inheritdoc}
20 20 
      */
21 
-    public function get()
21 
+    public function get ()
22 22 
     {
23 23 
         return null;
24 24 
     }
 
@@ -26,7 +26,7 @@  discard block
 
 block discarded – undo
26 26 
     /**
27 27 
      * {@inheritdoc}
28 28 
      */
29 
-    public function isHit()
29 
+    public function isHit ()
30 30 
     {
31 31 
         return false;
32 32 
     }
 
@@ -34,7 +34,7 @@  discard block
 
 block discarded – undo
34 34 
     /**
35 35 
      * {@inheritdoc}
36 36 
      */
37 
-    public function set($value)
37 
+    public function set ($value)
38 38 
     {
39 39 
         return $this;
40 40 
     }
 
@@ -42,7 +42,7 @@  discard block
 
 block discarded – undo
42 42 
     /**
43 43 
      * {@inheritdoc}
44 44 
      */
45 
-    public function expiresAt($expiration)
45 
+    public function expiresAt ($expiration)
46 46 
     {
47 47 
         return $this;
48 48 
     }
 
@@ -50,7 +50,7 @@  discard block
 
 block discarded – undo
50 50 
     /**
51 51 
      * {@inheritdoc}
52 52 
      */
53 
-    public function expiresAfter($time)
53 
+    public function expiresAfter ($time)
54 54 
     {
55 55 
         return $this;
56 56 
     }
Please login to merge, or discard this patch.
src/Traits/Routeable.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch 
@@ -15,7 +15,7 @@  discard block
 
 block discarded – undo
15 15 
      * @param mixed $handler
16 16 
      * @return Route
17 17 
      */
18 
-    public function get(string $pattern, $handler)
18 
+    public function get (string $pattern, $handler)
19 19 
     {
20 20 
         return $this->map('GET', $pattern, $handler);
21 21 
     }
 
@@ -28,7 +28,7 @@  discard block
 
 block discarded – undo
28 28 
      * @param mixed $handler
29 29 
      * @return Route
30 30 
      */
31 
-    public function post(string $pattern, $handler)
31 
+    public function post (string $pattern, $handler)
32 32 
     {
33 33 
         return $this->map('POST', $pattern, $handler);
34 34 
     }
 
@@ -41,7 +41,7 @@  discard block
 
 block discarded – undo
41 41 
      * @param mixed $handler
42 42 
      * @return Route
43 43 
      */
44 
-    public function put(string $pattern, $handler)
44 
+    public function put (string $pattern, $handler)
45 45 
     {
46 46 
         return $this->map('PUT', $pattern, $handler);
47 47 
     }
 
@@ -54,7 +54,7 @@  discard block
 
 block discarded – undo
54 54 
      * @param mixed $handler
55 55 
      * @return Route
56 56 
      */
57 
-    public function patch(string $pattern, $handler)
57 
+    public function patch (string $pattern, $handler)
58 58 
     {
59 59 
         return $this->map('PATCH', $pattern, $handler);
60 60 
     }
 
@@ -67,7 +67,7 @@  discard block
 
 block discarded – undo
67 67 
      * @param mixed $handler
68 68 
      * @return Route
69 69 
      */
70 
-    public function delete(string $pattern, $handler)
70 
+    public function delete (string $pattern, $handler)
71 71 
     {
72 72 
         return $this->map('DELETE', $pattern, $handler);
73 73 
     }
 
@@ -80,7 +80,7 @@  discard block
 
 block discarded – undo
80 80 
      * @param mixed $handler
81 81 
      * @return Route
82 82 
      */
83 
-    public function options(string $pattern, $handler)
83 
+    public function options (string $pattern, $handler)
84 84 
     {
85 85 
         return $this->map('OPTIONS', $pattern, $handler);
86 86 
     }
 
@@ -93,7 +93,7 @@  discard block
 
 block discarded – undo
93 93 
      * @param mixed $handler
94 94 
      * @return Route
95 95 
      */
96 
-    public function any(string $pattern, $handler)
96 
+    public function any (string $pattern, $handler)
97 97 
     {
98 98 
         return $this->map(['GET', 'POST', 'PUT', 'PATCH', 'DELETE', 'OPTIONS'], $pattern, $handler);
99 99 
     }
 
@@ -108,5 +108,5 @@  discard block
 
 block discarded – undo
108 108 
      * @param mixed $handler
109 109 
      * @return Route
110 110 
      */
111 
-    abstract public function map($methods, string $pattern, $handler);
111 
+    abstract public function map ($methods, string $pattern, $handler);
112 112 
 }
Please login to merge, or discard this patch.
src/Traits/Bindable.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch 
@@ -10,7 +10,7 @@  discard block
 
 block discarded – undo
10 10 
 {
11 11 
     protected $binded;
12 12
13 
-    public function bind(string $name, callable $callable)
13 
+    public function bind (string $name, callable $callable)
14 14 
     {
15 15 
         if (!is_callable($callable)) {
16 16 
             throw new InvalidArgumentException('Second param must be callable');
 
@@ -21,12 +21,12 @@  discard block
 
 block discarded – undo
21 21 
         return $this;
22 22 
     }
23 23
24 
-    public function hasMethod(string $name)
24 
+    public function hasMethod (string $name)
25 25 
     {
26 26 
         return isset($this->binded[$name]);
27 27 
     }
28 28
29 
-    public function __call($name, array $args)
29 
+    public function __call ($name, array $args)
30 30 
     {
31 31 
         if ($this->hasMethod($name)) {
32 32 
             return $this->getBind($name, $args);
 
@@ -35,7 +35,7 @@  discard block
 
 block discarded – undo
35 35 
         throw new RunTimeException('There is no method with the given name to call');
36 36 
     }
37 37
38 
-    public function getBind($name, $args)
38 
+    public function getBind ($name, $args)
39 39 
     {
40 40 
         return $this->binded[$name](...$args);
41 41 
     }
Please login to merge, or discard this patch.
src/Router.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -178,7 +178,7 @@  discard block
 
 block discarded – undo
178 178 
      * setcachePool function.
179 179 
      *
180 180 
      * @access public
181 
-     * @param CacheInterface $cachePool
181 
+     * @param CacheItemPoolInterface $cachePool
182 182 
      * @return Router
183 183 
      */
184 184 
     public function setCachePool(CacheItemPoolInterface $cachePool)
 
@@ -306,7 +306,7 @@  discard block
 
 block discarded – undo
306 306 
      * cacheAble function.
307 307 
      *
308 308 
      * @access protected
309 
-     * @return void
309 
+     * @return boolean
310 310 
      */
311 311 
     protected function cacheAble()
312 312 
     {
Please login to merge, or discard this patch.
Spacing   +22 added lines, -22 removed lines patch added patch discarded remove patch 
@@ -155,7 +155,7 @@  discard block
 
 block discarded – undo
155 155 
      * @access public
156 156 
      * @param mixed $parser
157 157 
      */
158 
-    public function __construct($parser)
158 
+    public function __construct ($parser)
159 159 
     {
160 160 
         $this->parser = $parser ?: new StdParser;
161 161 
     }
 
@@ -167,7 +167,7 @@  discard block
 
 block discarded – undo
167 167 
      * @param Dispatcher $dispatcher
168 168 
      * @return Router
169 169 
      */
170 
-    public function setDispatcher(Dispatcher $dispatcher)
170 
+    public function setDispatcher (Dispatcher $dispatcher)
171 171 
     {
172 172 
         $this->dispatcher = $dispatcher;
173 173 
 
@@ -181,7 +181,7 @@  discard block
 
 block discarded – undo
181 181 
      * @param CacheInterface $cachePool
182 182 
      * @return Router
183 183 
      */
184 
-    public function setCachePool(CacheItemPoolInterface $cachePool)
184 
+    public function setCachePool (CacheItemPoolInterface $cachePool)
185 185 
     {
186 186 
         $this->cachePool = $cachePool;
187 187 
 
@@ -195,7 +195,7 @@  discard block
 
 block discarded – undo
195 195 
      * @param int $cacheTtl
196 196 
      * @return Router
197 197 
      */
198 
-    public function setCacheTtl(int $cacheTtl)
198 
+    public function setCacheTtl (int $cacheTtl)
199 199 
     {
200 200 
         $this->cacheTtl = $cacheTtl;
201 201 
 
@@ -209,7 +209,7 @@  discard block
 
 block discarded – undo
209 209 
      * @param string $cacheKey
210 210 
      * @return Router
211 211 
      */
212 
-    public function setCacheKey(string $cacheKey)
212 
+    public function setCacheKey (string $cacheKey)
213 213 
     {
214 214 
         $this->cacheKey = $cacheKey;
215 215 
         return $this;
 
@@ -222,7 +222,7 @@  discard block
 
 block discarded – undo
222 222 
      * @param string $identifier
223 223 
      * @return null|Route
224 224 
      */
225 
-    public function getRoute(string $identifier)
225 
+    public function getRoute (string $identifier)
226 226 
     {
227 227 
         return !empty($this->routes[$identifier]) ? $this->routes[$identifier] : null;
228 228 
     }
 
@@ -233,7 +233,7 @@  discard block
 
 block discarded – undo
233 233 
      * @access public
234 234 
      * @return array
235 235 
      */
236 
-    public function getRoutes()
236 
+    public function getRoutes ()
237 237 
     {
238 238 
         return $this->routes;
239 239 
     }
 
@@ -246,7 +246,7 @@  discard block
 
 block discarded – undo
246 246 
      * @param array $routes
247 247 
      * @return Router
248 248 
      */
249 
-    public function setRoutes(array $method, array $routes)
249 
+    public function setRoutes (array $method, array $routes)
250 250 
     {
251 251 
         foreach ($routes as $pattern => $handler) {
252 252 
             $this->map($method, $pattern, $handler);
 
@@ -261,7 +261,7 @@  discard block
 
 block discarded – undo
261 261 
      * @access public
262 262 
      * @return void
263 263 
      */
264 
-    public function getResult()
264 
+    public function getResult ()
265 265 
     {
266 266 
         return $this->dispatch_result;
267 267 
     }
 
@@ -269,7 +269,7 @@  discard block
 
 block discarded – undo
269 269 
     /**
270 270 
      * {@inheritdoc}
271 271 
      */
272 
-    public function map($method, string $pattern, $handler)
272 
+    public function map ($method, string $pattern, $handler)
273 273 
     {
274 274 
         $method = is_array($method) ? $method : [$method];
275 275 
 
@@ -297,7 +297,7 @@  discard block
 
 block discarded – undo
297 297 
      * @param mixed $handler
298 298 
      * @return Route Route
299 299 
      */
300 
-    protected function createRoute(string $method, string $pattern, $handler)
300 
+    protected function createRoute (string $method, string $pattern, $handler)
301 301 
     {
302 302 
         return new Route($method, $pattern, $handler, $this->routeGroup, 'route_' . $this->routeCount);
303 303 
     }
 
@@ -308,7 +308,7 @@  discard block
 
 block discarded – undo
308 308 
      * @access protected
309 309 
      * @return void
310 310 
      */
311 
-    protected function cacheAble()
311 
+    protected function cacheAble ()
312 312 
     {
313 313 
         return !empty($this->cachePool) && !empty($this->cacheKey);
314 314 
     }
 
@@ -319,7 +319,7 @@  discard block
 
 block discarded – undo
319 319 
      * @access protected
320 320 
      * @return CacheItemInterface
321 321 
      */
322 
-    protected function getCacheItem()
322 
+    protected function getCacheItem ()
323 323 
     {
324 324 
         return $this->cacheAble() ? $this->cachePool->getItem($this->cacheKey) : new \Resilient\Dummy\CacheItem();
325 325 
     }
 
@@ -331,7 +331,7 @@  discard block
 
 block discarded – undo
331 331 
      * @param CacheItemInterface $cacheItem
332 332 
      * @return boolean
333 333 
      */
334 
-    protected function saveCacheItem(CacheItemInterface $cacheItem)
334 
+    protected function saveCacheItem (CacheItemInterface $cacheItem)
335 335 
     {
336 336 
         if ($cacheItem instanceof \Resilient\Dummy\CacheItem) {
337 337 
             return false;
 
@@ -352,7 +352,7 @@  discard block
 
 block discarded – undo
352 352 
      * @param array $options (default: [])
353 353 
      * @return Dispatcher
354 354 
      */
355 
-    protected function routeDispatcher(callable $routeDefinitionCallback, array $options = [])
355 
+    protected function routeDispatcher (callable $routeDefinitionCallback, array $options = [])
356 356 
     {
357 357 
         $options += [
358 358 
             'routeParser' => 'FastRoute\\RouteParser\\Std',
 
@@ -387,13 +387,13 @@  discard block
 
 block discarded – undo
387 387 
      * @access protected
388 388 
      * @return Dispatcher
389 389 
      */
390 
-    protected function createDispatcher()
390 
+    protected function createDispatcher ()
391 391 
     {
392 392 
         if ($this->dispatcher) {
393 393 
             return $this->dispatcher;
394 394 
         }
395 395
396 
-        $this->dispatcher = $this->routeDispatcher(function (RouteCollector $r) {
396 
+        $this->dispatcher = $this->routeDispatcher(function(RouteCollector $r) {
397 397 
             foreach ($this->getRoutes() as $route) {
398 398 
                 $r->addRoute($route->getMethod(), $route->getPattern(), $route->getIdentifier());
399 399 
             }
 
@@ -412,7 +412,7 @@  discard block
 
 block discarded – undo
412 412 
      * @param string $method (default: 'GET')
413 413 
      * @return Route Handling Method
414 414 
      */
415 
-    public function dispatch(UriInterface $uri, $method = 'GET')
415 
+    public function dispatch (UriInterface $uri, $method = 'GET')
416 416 
     {
417 417 
         $this->dispatch_result = $this->createDispatcher()->dispatch(
418 418 
             $method,
 
@@ -443,7 +443,7 @@  discard block
 
 block discarded – undo
443 443 
         return $this->handleException($handling[0], $handling[1], $handling[2]);
444 444 
     }
445 445
446 
-    protected function handleException(string $handler, array $args, string $message)
446 
+    protected function handleException (string $handler, array $args, string $message)
447 447 
     {
448 448 
         if ($this->hasMethod($handler)) {
449 449 
             return $this->$handler(...$args);
 
@@ -459,7 +459,7 @@  discard block
 
 block discarded – undo
459 459 
      * @param callable $callable
460 460 
      * @return Router
461 461 
      */
462 
-    public function whenNotFound(callable $callable)
462 
+    public function whenNotFound (callable $callable)
463 463 
     {
464 464 
         $this->bind($this->notFoundFuncName, $callable);
465 465 
 
@@ -473,7 +473,7 @@  discard block
 
 block discarded – undo
473 473 
      * @param callable $callable
474 474 
      * @return Router
475 475 
      */
476 
-    public function whenForbidden(callable $callable)
476 
+    public function whenForbidden (callable $callable)
477 477 
     {
478 478 
         $this->bind($this->forbiddenFuncName, $callable);
479 479 
 
@@ -488,7 +488,7 @@  discard block
 
 block discarded – undo
488 488 
      * @param mixed $args
489 489 
      * @return void
490 490 
      */
491 
-    protected function routerRoutine($identifier, $args)
491 
+    protected function routerRoutine ($identifier, $args)
492 492 
     {
493 493 
         $route = $this->getRoute($identifier);
494 494
Please login to merge, or discard this patch.