mambax7 / xoopsfaq

class/utility.php

Doc Comments +2 added lines, -2 removed lines

@@ -268,8 +268,8 @@
     /**
      * Render the icon links
      *
-     * @param array $icon_array contains operation=>icon_name as key=>value
-     * @param mixed $param      HTML parameter
+     * @param string[] $icon_array contains operation=>icon_name as key=>value
+     * @param string $param      HTML parameter
      * @param mixed $value      HTML parameter value to set
      * @param mixed $extra      are any additional HTML attributes desired for the <a> tag
      * @return string

Spacing +3 added lines, -3 removed lines

@@ -170,7 +170,7 @@ 
                 static::rrmdir($fObj->getPathname());
             }
         }
-        $iterator = null;   // clear iterator Obj to close file/directory
+        $iterator = null; // clear iterator Obj to close file/directory
         return rmdir($src); // remove the directory & return results
     }
 
@@ -209,7 +209,7 @@ 
                 static::rmove($fObj->getPathname(), $dest . '/' . $fObj->getFilename());
             }
         }
-        $iterator = null;   // clear iterator Obj to close file/directory
+        $iterator = null; // clear iterator Obj to close file/directory
         return rmdir($src); // remove the directory & return results
     }
 
@@ -282,7 +282,7 @@ 
                 }
                 $title = constant(htmlspecialchars(mb_strtoupper('_XO_LA_' . $iconName), ENT_QUOTES | ENT_HTML5));
                 $img   = '<img src="' . \Xmf\Module\Admin::iconUrl($iconName . '.' . $iconExt, '16') . '"' . ' title ="' . $title . '"' . ' alt = "' . $title . '"' . ' class="bnone middle">';
-                $ret   .= '<a href="' . $url . '"' . $extra . '>' . $img . '</a>';
+                $ret .= '<a href="' . $url . '"' . $extra . '>' . $img . '</a>';
             }
         }
         return $ret;

class/CategoryHandler.php

Doc Comments +2 added lines, -2 removed lines

@@ -41,7 +41,7 @@ 
     /**
      * Constructor
      *
-     * @param mixed $db
+     * @param null|\XoopsDatabase $db
      */
     public function __construct(\XoopsDatabase $db = null)
     {
@@ -53,7 +53,7 @@ 
      *
      * @param string $sort order ('id', order', or 'title') - default: id
      *
-     * @return mixed Category | false on failure
+     * @return boolean Category | false on failure
      */
     public function getObj($sort = 'id')
     {

Indentation +17 added lines, -17 removed lines

@@ -103,23 +103,23 @@
         $buttons = ['edit', 'delete'];
 
         $ret = '<table class="outer width100 bnone pad3 marg5">'
-               . '  <thead>'
-               . '  <tr class="xoopsCenter">'
-               . '    <th class="width5">'
-               . _AM_XOOPSFAQ_CATEGORY_ORDER
-               . '</th>'
-               . '    <th class="width5">'
-               . _AM_XOOPSFAQ_CATEGORY_ID
-               . '</th>'
-               . '    <th class="txtleft">'
-               . _AM_XOOPSFAQ_CATEGORY_TITLE
-               . '</th>'
-               . '    <th class="width20">'
-               . _AM_XOOPSFAQ_ACTIONS
-               . '</th>'
-               . '  </tr>'
-               . '  </thead>'
-               . '  <tbody>';
+                . '  <thead>'
+                . '  <tr class="xoopsCenter">'
+                . '    <th class="width5">'
+                . _AM_XOOPSFAQ_CATEGORY_ORDER
+                . '</th>'
+                . '    <th class="width5">'
+                . _AM_XOOPSFAQ_CATEGORY_ID
+                . '</th>'
+                . '    <th class="txtleft">'
+                . _AM_XOOPSFAQ_CATEGORY_TITLE
+                . '</th>'
+                . '    <th class="width20">'
+                . _AM_XOOPSFAQ_ACTIONS
+                . '</th>'
+                . '  </tr>'
+                . '  </thead>'
+                . '  <tbody>';
         if ($objects['count'] > 0) {
             /** @var XoopsObject $object */
             foreach ($objects['list'] as $object) {

class/ContentsHandler.php

Doc Comments +3 added lines, -3 removed lines

@@ -41,7 +41,7 @@ 
     /**
      * Constructor
      *
-     * @param mixed $db
+     * @param null|\XoopsDatabase $db
      */
     public function __construct(\XoopsDatabase $db = null)
     {
@@ -53,7 +53,7 @@ 
      *
      * @param \CriteriaElement|string sort order ('id', 'cid', 'title', 'publish', or 'weight') default: 'id'
      *
-     * @return mixed Contents object | false on failure
+     * @return boolean Contents object | false on failure
      */
     public function getObj($sort = 'id')
     {
@@ -77,7 +77,7 @@ 
      * ContentsHandler::getPublished()
      *
      * @param string $id
-     * @return mixed array of XoopsfaqContent objects | false on failure
+     * @return boolean array of XoopsfaqContent objects | false on failure
      */
     public function getPublished($id = '')
     {

Indentation +59 added lines, -59 removed lines

@@ -159,32 +159,32 @@ 
         $buttons = ['edit', 'delete'];
 
         $ret = '<table class="outer width100 bnone pad3 marg5">'
-               . '  <thead>'
-               . '  <tr class="center">'
-               . '    <th class="width5">'
-               . _AM_XOOPSFAQ_CONTENTS_ID
-               . '</th>'
-               . '    <th class="width5">'
-               . _AM_XOOPSFAQ_CONTENTS_ACTIVE
-               . '</th>'
-               . '    <th class="width5">'
-               . _AM_XOOPSFAQ_CONTENTS_WEIGHT
-               . '</th>'
-               . '    <th class="left">'
-               . _AM_XOOPSFAQ_CONTENTS_TITLE
-               . '</th>'
-               . '    <th class="left">'
-               . _AM_XOOPSFAQ_CATEGORY_TITLE
-               . '</th>'
-               . '    <th>'
-               . _AM_XOOPSFAQ_CONTENTS_PUBLISH
-               . '</th>'
-               . '    <th class="width20">'
-               . _AM_XOOPSFAQ_ACTIONS
-               . '</th>'
-               . '  </tr>'
-               . '  </thead>'
-               . '  <tbody>';
+                . '  <thead>'
+                . '  <tr class="center">'
+                . '    <th class="width5">'
+                . _AM_XOOPSFAQ_CONTENTS_ID
+                . '</th>'
+                . '    <th class="width5">'
+                . _AM_XOOPSFAQ_CONTENTS_ACTIVE
+                . '</th>'
+                . '    <th class="width5">'
+                . _AM_XOOPSFAQ_CONTENTS_WEIGHT
+                . '</th>'
+                . '    <th class="left">'
+                . _AM_XOOPSFAQ_CONTENTS_TITLE
+                . '</th>'
+                . '    <th class="left">'
+                . _AM_XOOPSFAQ_CATEGORY_TITLE
+                . '</th>'
+                . '    <th>'
+                . _AM_XOOPSFAQ_CONTENTS_PUBLISH
+                . '</th>'
+                . '    <th class="width20">'
+                . _AM_XOOPSFAQ_ACTIONS
+                . '</th>'
+                . '  </tr>'
+                . '  </thead>'
+                . '  <tbody>';
         if ($objects['count'] > 0) {
             $tdClass = 0;
             /** @var \Contents $object */
@@ -195,39 +195,39 @@ 
                 ++$tdClass;
                 $dispClass = ($tdClass % 1) ? 'even' : 'odd';
                 $ret       .= '  <tr class="center middle">'
-                              . '    <td class="'
-                              . $dispClass
-                              . '">'
-                              . $object->getVar('contents_id')
-                              . '</td>'
-                              . '    <td class="'
-                              . $dispClass
-                              . '">'
-                              . $object->getActiveIcon()
-                              . '</td>'
-                              . '    <td class="'
-                              . $dispClass
-                              . '">'
-                              . $object->getVar('contents_weight')
-                              . '</td>'
-                              . '    <td class="'
-                              . $dispClass
-                              . ' left">'
-                              . $thisContentTitle
-                              . '</td>'
-                              . '    <td class="'
-                              . $dispClass
-                              . ' left">'
-                              . $thisCatTitle
-                              . '</td>'
-                              . '    <td class="'
-                              . $dispClass
-                              . '">'
-                              . $object->getPublished(_SHORTDATESTRING)
-                              . '</td>'
-                              . '    <td class="'
-                              . $dispClass
-                              . '">';
+                                . '    <td class="'
+                                . $dispClass
+                                . '">'
+                                . $object->getVar('contents_id')
+                                . '</td>'
+                                . '    <td class="'
+                                . $dispClass
+                                . '">'
+                                . $object->getActiveIcon()
+                                . '</td>'
+                                . '    <td class="'
+                                . $dispClass
+                                . '">'
+                                . $object->getVar('contents_weight')
+                                . '</td>'
+                                . '    <td class="'
+                                . $dispClass
+                                . ' left">'
+                                . $thisContentTitle
+                                . '</td>'
+                                . '    <td class="'
+                                . $dispClass
+                                . ' left">'
+                                . $thisCatTitle
+                                . '</td>'
+                                . '    <td class="'
+                                . $dispClass
+                                . '">'
+                                . $object->getPublished(_SHORTDATESTRING)
+                                . '</td>'
+                                . '    <td class="'
+                                . $dispClass
+                                . '">';
                 $ret       .= Xoopsfaq\Utility::renderIconLinks($buttons, 'contents_id', $object->getVar('contents_id')) . '</td>' . '  </tr>';
             }
         } else {

Spacing +2 added lines, -2 removed lines

@@ -194,7 +194,7 @@ 
                 $thisContentTitle = '<a href="' . $helper->url('index.php?cat_id=' . $thisCatId . '#q' . $object->getVar('contents_id')) . '" title="' . _AM_XOOPSFAQ_CONTENTS_VIEW . '">' . $object->getVar('contents_title') . '</a>';
                 ++$tdClass;
                 $dispClass = ($tdClass % 1) ? 'even' : 'odd';
-                $ret       .= '  <tr class="center middle">'
+                $ret .= '  <tr class="center middle">'
                               . '    <td class="'
                               . $dispClass
                               . '">'
@@ -228,7 +228,7 @@ 
                               . '    <td class="'
                               . $dispClass
                               . '">';
-                $ret       .= Xoopsfaq\Utility::renderIconLinks($buttons, 'contents_id', $object->getVar('contents_id')) . '</td>' . '  </tr>';
+                $ret .= Xoopsfaq\Utility::renderIconLinks($buttons, 'contents_id', $object->getVar('contents_id')) . '</td>' . '  </tr>';
             }
         } else {
             $ret .= '  <tr class="center"><td colspan="7" class="even">' . _AM_XOOPSFAQ_NOLISTING . '</td></tr>';

preloads/autoloader.php

Spacing +1 added lines, -1 removed lines

@@ -4,7 +4,7 @@
  * @see http://www.php-fig.org/psr/psr-4/examples/
  */
 spl_autoload_register(
-    static function ($class) {
+    static function($class) {
         // project-specific namespace prefix
         $prefix = 'XoopsModules\\' . ucfirst(basename(dirname(__DIR__)));
 

blocks/xoopsfaq_category.php

Indentation +11 added lines, -11 removed lines

@@ -106,16 +106,16 @@
     $ychck = (isset($options[0]) && ($options[0] > 0)) ? ' checked' : '';
     $nchck = !empty($ychck) ? '' : ' checked';
     $form  = '<div class="line140">'
-             . _MB_XOOPSFAQ_SHOW_EMPTY
-             . '&nbsp;<label for="r0">'
-             . _NO
-             . '</label><input type="radio" name="options[0]" id="r0" value="0"'
-             . $nchck
-             . '>&nbsp;<label for="r1">'
-             . _YES
-             . '</label><input type="radio" name="options[0]" id="r1" value="1"'
-             . $ychck
-             . '></div>'
-             . "\n";
+                . _MB_XOOPSFAQ_SHOW_EMPTY
+                . '&nbsp;<label for="r0">'
+                . _NO
+                . '</label><input type="radio" name="options[0]" id="r0" value="0"'
+                . $nchck
+                . '>&nbsp;<label for="r1">'
+                . _YES
+                . '</label><input type="radio" name="options[0]" id="r1" value="1"'
+                . $ychck
+                . '></div>'
+                . "\n";
     return $form;
 }

index.php

Spacing +3 added lines, -3 removed lines

@@ -111,11 +111,11 @@ 
         foreach ($objects['list'] as $object) {
             // only list categories and/or FAQs if user has rights
             if (false !== $permHelper->checkPermission('viewcat', $object->getVar('category_id'))) {
-                $category    = [
+                $category = [
                     'id'   => $object->getVar('category_id'),
                     'name' => $object->getVar('category_title'),
                 ];
-                $bodyWords   .= ' ' . $object->getVar('category_title');
+                $bodyWords .= ' ' . $object->getVar('category_title');
                 $contentsObj = $contentsHandler->getPublished($object->getVar('category_id'));
                 if ($contentsObj['count']) {
                     $category['questions'] = [];
@@ -125,7 +125,7 @@ 
                             'link'  => $content->getVar('contents_id'),
                             'title' => $content->getVar('contents_title'),
                         ];
-                        $bodyWords               .= ' ' . $content->getVar('contents_title');
+                        $bodyWords .= ' ' . $content->getVar('contents_title');
                     }
                 }
                 $GLOBALS['xoopsTpl']->append_by_ref('categories', $category);

class/contents.php

Spacing +1 added lines, -1 removed lines

@@ -138,7 +138,7 @@
         $options_tray  = new \XoopsFormElementTray(_AM_XOOPSFAQ_E_CONTENTS_CONTENT, '<br>');
         if (class_exists('XoopsFormEditor')) {
             // $editorConfigs = array('editor' => $GLOBALS['xoopsConfig']['general_editor'],
-            $editorConfigs     = [
+            $editorConfigs = [
                 'editor' => $helper->getConfig('use_wysiwyg', 'dhtmltextarea'),
                 'rows'   => 25,
                 'cols'   => '100%',

class/Common/FilesManagement.php

Spacing +2 added lines, -2 removed lines

@@ -204,7 +204,7 @@ 
                 self::rrmdir($fObj->getPathname());
             }
         }
-        $iterator = null;   // clear iterator Obj to close file/directory
+        $iterator = null; // clear iterator Obj to close file/directory
         return rmdir($src); // remove the directory & return results
     }
 
@@ -244,7 +244,7 @@ 
                 //                rmdir($fObj->getPath()); // now delete the directory
             }
         }
-        $iterator = null;   // clear iterator Obj to close file/directory
+        $iterator = null; // clear iterator Obj to close file/directory
         return rmdir($src); // remove the directory & return results
     }
 

class/Common/ServerStats.php

Spacing +2 added lines, -2 removed lines

@@ -45,7 +45,7 @@ 
         $html .= '<ul>';
 
         $gdlib = function_exists('gd_info') ? '<span style="color: #008000;">' . constant('CO_' . $moduleDirNameUpper . '_GDON') . '</span>' : '<span style="color: #ff0000;">' . constant('CO_' . $moduleDirNameUpper . '_GDOFF') . '</span>';
-        $html  .= '<li>' . constant('CO_' . $moduleDirNameUpper . '_GDLIBSTATUS') . $gdlib;
+        $html .= '<li>' . constant('CO_' . $moduleDirNameUpper . '_GDLIBSTATUS') . $gdlib;
         if (function_exists('gd_info')) {
             if (true === ($gdlib = gd_info())) {
                 $html .= '<li>' . constant('CO_' . $moduleDirNameUpper . '_GDLIBVERSION') . '<b>' . $gdlib['GD Version'] . '</b>';
@@ -59,7 +59,7 @@ 
         //    $html .= '<li>' . constant('CO_' . $moduleDirNameUpper . '_REGISTERGLOBALS . $registerglobals;
 
         $downloads = ini_get('file_uploads') ? '<span style="color: #008000;">' . constant('CO_' . $moduleDirNameUpper . '_ON') . '</span>' : '<span style="color: #ff0000;">' . constant('CO_' . $moduleDirNameUpper . '_OFF') . '</span>';
-        $html      .= '<li>' . constant('CO_' . $moduleDirNameUpper . '_SERVERUPLOADSTATUS') . $downloads;
+        $html .= '<li>' . constant('CO_' . $moduleDirNameUpper . '_SERVERUPLOADSTATUS') . $downloads;
 
         $html .= '<li>' . constant('CO_' . $moduleDirNameUpper . '_MAXUPLOADSIZE') . ' <b><span style="color: #0000ff;">' . ini_get('upload_max_filesize') . '</span></b>';
         $html .= '<li>' . constant('CO_' . $moduleDirNameUpper . '_MAXPOSTSIZE') . ' <b><span style="color: #0000ff;">' . ini_get('post_max_size') . '</span></b>';