+global\MartinSearchHandler::Search()

Complexity

Conditions	17
Paths	> 20000

Size

Total Lines

49

Duplication

Lines	13
Ratio	26.53 %

Importance

Changes

0

<?php
    public function Search($Data)
    {
        global $hotel_handler, $xoopsModuleConfig;
        //var_dump($xoopsModuleConfig);

        $rows     = array();
        $dateTime = strtotime(date('Y-m-d'));

$dateTime is not used, you could remove the assignment.

        foreach ($Data as $key => $value) {
            ${$key} = $value;
        }
        $city_ids = $this->GetCityIds($hotel_address);

The variable $hotel_address does not exist. Did you forget to declare it?

        //var_dump($Data);
        $sql = "SELECT h.*,hc.city_name as hotel_city FROM " . $this->db->prefix("martin_hotel") . " h ";
        $sql .= "INNER JOIN " . $this->db->prefix("martin_room") . " r ON (h.hotel_id = r.hotel_id) ";
        $sql .= "INNER JOIN " . $this->db->prefix("martin_room_price") . " rp ON (r.room_id = rp.room_id) ";
        $sql .= "INNER JOIN " . $this->db->prefix("martin_hotel_city") . " hc ON (h.hotel_city = hc.city_id) ";
        $sql .= " WHERE 1 = 1 ";
        $sql .= (empty($hotel_address) || empty($hotel_ids)) ? "" : $city_ids . " IN h.hotel_city_id ";

The variable $hotel_ids seems only to be defined at a later point. As such the call to empty() seems to always evaluate to true.

        $sql .= empty($hotel_name) ? "" : "AND h.hotel_name LIKE '%$hotel_name%' ";

The variable $hotel_name seems to never exist, and therefore empty should always return true. Did you maybe rename this variable?

        $sql .= $city_id > 0 ? "AND h.hotel_city IN (SELECT city_id FROM " . $this->db->prefix("martin_hotel_city") . " WHERE city_parentid = $city_id ) " : "";

The variable $city_id does not exist. Did you mean $city_ids?

        $sql .= $hotel_star > 0 ? "AND h.hotel_star = $hotel_star " : "";

The variable $hotel_star does not exist. Did you forget to declare it?

        $sql .= (is_array($price) && $price[0] > 0 && $price[1] > 0) ? "AND rp.room_price >= {$price[0]} AND rp.room_price <= {$price[1]} " : "";

The variable $price does not exist. Did you forget to declare it?

        $sql .= (is_array($check_date) && $check_date[0] > 0 && $check_date[1] > 0) ? "AND rp.room_date >= {$check_date[0]} AND rp.room_date <= {$check_date[1]} " : "";

The variable $check_date does not exist. Did you forget to declare it?

        $sql .= "GROUP BY h.hotel_id  ";
        $sql .= (empty($order) || empty($by)) ? " ORDER BY h.hotel_rank DESC , h.hotel_id DESC " : " ORDER BY $order $by ,h.hotel_rank DESC ";

The variable $order seems to never exist, and therefore empty should always return true. Did you maybe rename this variable?

The variable $by seems to never exist, and therefore empty should always return true. Did you maybe rename this variable?

The variable $order does not exist. Did you forget to declare it?

        $rows['count'] = $this->GetCount(str_replace("h.*", "count(h.hotel_id) as count", $sql));
        $sql .= "LIMIT $start,{$xoopsModuleConfig['perpage']}";

The variable $start does not exist. Did you forget to declare it?

        //echo $sql;

        $result          = $this->db->query($sql);
        $this->hotel_ids = &$hotel_ids;

The variable $hotel_ids does not seem to be defined for all execution paths leading up to this point.

        $cityList        = &$hotel_handler->getCityList();
        while ($row = $this->db->fetchArray($result)) {

This code seems to be duplicated across your project.

            $hotel_ids[] = $row['hotel_id'];
            $city_ids    = explode(',', $row['hotel_city_id']);
            foreach ($city_ids as $id) {
                $city_name[] = $cityList[$id];

$city_name was never initialized. Although not strictly required by PHP, it is generally a good practice to add $city_name = array(); before regardless.

            }
            $row['city_name']    = implode('、', $city_name);

The variable $city_name does not seem to be defined for all execution paths leading up to this point.

            $row['hotel_image']  = unserialize($row['hotel_image']);
            $row['hotel_google'] = unserialize(unserialize($row['hotel_google']));
            //var_dump($row['hotel_google']);
            $rows[] = $row;
            unset($city_name);
        }

        //$rows = $this->GetRows($sql,'hotel_id');
        return $rows;
    }