MartinSearchHandler

Complexity

Total Complexity

38

Size/Duplication

Total Lines	204
Duplicated Lines	13.73 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	create()	0	4	1
A	GetRows()	15	15	3
F	Search()	13	49	17
A	GetCount()	0	13	3
A	GetCityIds()	0	11	3
B	GethotelRooms()	0	35	8
A	GetCityName()	0	10	3

<?php
/**
 * @hotel     search object
 * @license   http://www.blags.org/
 * @created   :2010年06月27日 14时08分
 * @copyright 1997-2010 The Martin Group
 * @author    Martin <china.codehome@gmail.com>
 * */
if (!defined("XOOPS_ROOT_PATH")) {
    die("XOOPS root path not defined");
}

/**
 * Class MartinSearch
 */
class MartinSearch extends XoopsObject
{
    public function MartinSearch()
    {
        /*$this->initVar("city_id", XOBJ_DTYPE_INT, null, false);
        $this->initVar("hotel_star", XOBJ_DTYPE_TXTBOX, null, true, 255);
        $this->initVar("hotel_name", XOBJ_DTYPE_TXTBOX, null, false, 255);*/
    }
}

/**
 * Class MartinSearchHandler
 */
class MartinSearchHandler extends XoopsObjectHandler
{
    /**
     * @return MartinSearch
     */
    public function create()
    {
        return new MartinSearch();
    }

    /**
     * @get       rows
     * @license   http://www.blags.org/
     * @created   :2010年06月20日 13时09分
     * @copyright 1997-2010 The Martin Group
     * @author    Martin <china.codehome@gmail.com>
     * @param      $sql
     * @param null $key
     * @return array
     */
    public function GetRows($sql, $key = null)

This method seems to be duplicated in your project.

    {
        global $xoopsDB;
        $result = $xoopsDB->query($sql);
        $rows   = array();
        while ($row = $xoopsDB->fetchArray($result)) {
            if (is_null($key)) {
                $rows[] = $row;
            } else {
                $rows[$row[$key]] = $row;
            }
        }

        return $rows;
    }

    /**
     * @search    hotels
     * @license   http://www.blags.org/
     * @created   :2010年06月27日 19时57分
     * @copyright 1997-2010 The Martin Group
     * @author    Martin <china.codehome@gmail.com>
     * @param $Data
     * @return array
     */
    public function Search($Data)
    {
        global $hotel_handler, $xoopsModuleConfig;
        //var_dump($xoopsModuleConfig);

        $rows     = array();
        $dateTime = strtotime(date('Y-m-d'));

$dateTime is not used, you could remove the assignment.

        foreach ($Data as $key => $value) {
            ${$key} = $value;
        }
        $city_ids = $this->GetCityIds($hotel_address);

The variable $hotel_address does not exist. Did you forget to declare it?

        //var_dump($Data);
        $sql = "SELECT h.*,hc.city_name as hotel_city FROM " . $this->db->prefix("martin_hotel") . " h ";
        $sql .= "INNER JOIN " . $this->db->prefix("martin_room") . " r ON (h.hotel_id = r.hotel_id) ";
        $sql .= "INNER JOIN " . $this->db->prefix("martin_room_price") . " rp ON (r.room_id = rp.room_id) ";
        $sql .= "INNER JOIN " . $this->db->prefix("martin_hotel_city") . " hc ON (h.hotel_city = hc.city_id) ";
        $sql .= " WHERE 1 = 1 ";
        $sql .= (empty($hotel_address) || empty($hotel_ids)) ? "" : $city_ids . " IN h.hotel_city_id ";

The variable $hotel_ids seems only to be defined at a later point. As such the call to empty() seems to always evaluate to true.

        $sql .= empty($hotel_name) ? "" : "AND h.hotel_name LIKE '%$hotel_name%' ";

The variable $hotel_name seems to never exist, and therefore empty should always return true. Did you maybe rename this variable?

        $sql .= $city_id > 0 ? "AND h.hotel_city IN (SELECT city_id FROM " . $this->db->prefix("martin_hotel_city") . " WHERE city_parentid = $city_id ) " : "";

The variable $city_id does not exist. Did you mean $city_ids?

        $sql .= $hotel_star > 0 ? "AND h.hotel_star = $hotel_star " : "";

The variable $hotel_star does not exist. Did you forget to declare it?

        $sql .= (is_array($price) && $price[0] > 0 && $price[1] > 0) ? "AND rp.room_price >= {$price[0]} AND rp.room_price <= {$price[1]} " : "";

The variable $price does not exist. Did you forget to declare it?

        $sql .= (is_array($check_date) && $check_date[0] > 0 && $check_date[1] > 0) ? "AND rp.room_date >= {$check_date[0]} AND rp.room_date <= {$check_date[1]} " : "";

The variable $check_date does not exist. Did you forget to declare it?

        $sql .= "GROUP BY h.hotel_id  ";
        $sql .= (empty($order) || empty($by)) ? " ORDER BY h.hotel_rank DESC , h.hotel_id DESC " : " ORDER BY $order $by ,h.hotel_rank DESC ";

The variable $order seems to never exist, and therefore empty should always return true. Did you maybe rename this variable?

The variable $by seems to never exist, and therefore empty should always return true. Did you maybe rename this variable?

The variable $order does not exist. Did you forget to declare it?

        $rows['count'] = $this->GetCount(str_replace("h.*", "count(h.hotel_id) as count", $sql));
        $sql .= "LIMIT $start,{$xoopsModuleConfig['perpage']}";

The variable $start does not exist. Did you forget to declare it?

        //echo $sql;

        $result          = $this->db->query($sql);
        $this->hotel_ids = &$hotel_ids;

The variable $hotel_ids does not seem to be defined for all execution paths leading up to this point.

        $cityList        = &$hotel_handler->getCityList();
        while ($row = $this->db->fetchArray($result)) {

This code seems to be duplicated across your project.

            $hotel_ids[] = $row['hotel_id'];
            $city_ids    = explode(',', $row['hotel_city_id']);
            foreach ($city_ids as $id) {
                $city_name[] = $cityList[$id];

$city_name was never initialized. Although not strictly required by PHP, it is generally a good practice to add $city_name = array(); before regardless.

            }
            $row['city_name']    = implode('、', $city_name);

The variable $city_name does not seem to be defined for all execution paths leading up to this point.

            $row['hotel_image']  = unserialize($row['hotel_image']);
            $row['hotel_google'] = unserialize(unserialize($row['hotel_google']));
            //var_dump($row['hotel_google']);
            $rows[] = $row;
            unset($city_name);
        }

        //$rows = $this->GetRows($sql,'hotel_id');
        return $rows;
    }

    /**
     * @get       search count
     * @license   http://www.blags.org/
     * @created   :2010年06月27日 19时57分
     * @copyright 1997-2010 The Martin Group
     * @author    Martin <china.codehome@gmail.com>
     * @param $sql
     * @return int
     */
    public function GetCount($sql)
    {
        if (empty($sql)) {
            return $sql;
        }
        $count  = 0;
        $result = $this->db->query($sql);
        while ($this->db->fetchArray($result)) {
            $count++;
        }

        return $count;
    }

    /**
     * @get       city ids
     * @license   http://www.blags.org/
     * @created   :2010年06月27日 14时08分
     * @copyright 1997-2010 The Martin Group
     * @author    Martin <china.codehome@gmail.com>
     * @param $city_name
     * @return null|string
     */
    public function GetCityIds($city_name)
    {
        global $xoopsDB;
        $sql    = "SELECT city_id FROM " . $xoopsDB->prefix("martin_hotel_city") . " WHERE city_name LIKE '%$city_name%'";
        $result = $xoopsDB->query($sql);
        while ($city_id = $xoopsDB->fetchArray($result)) {
            $city_ids[] = $city_id['city_id'];

$city_ids was never initialized. Although not strictly required by PHP, it is generally a good practice to add $city_ids = array(); before regardless.

        }

        return is_array($city_ids) ? implode(',', $city_ids) : null;

The variable $city_ids does not seem to be defined for all execution paths leading up to this point.

    }

    /**
     * get hotel rooms
     * @access    public
     * @param $room_date
     * @copyright 1997-2010 The Martin Group
     * @author    Martin <china.codehome@gmail.com>
     * @created   time :2010-06-25 15:27:34
     */
    public function GethotelRooms($room_date)

The return type could not be reliably inferred; please add a @return annotation.

    {
        if (empty($this->hotel_ids)) {
            return $this->hotel_ids;
        }
        $sql = "SELECT r.*,rt.room_type_info,rp.room_is_today_special,rp.room_date,
            GROUP_CONCAT(room_price) as room_prices,GROUP_CONCAT(room_date) as room_dates,
            round(avg(rp.room_price),2) as room_price,round(avg(rp.room_advisory_range_small),2) as room_advisory_range_small,
            round(avg(rp.room_advisory_range_max),2) as room_advisory_range_max,round(avg(rp.room_sented_coupon),2) as room_sented_coupon
            FROM " . $this->db->prefix("martin_room") . " r INNER JOIN " . $this->db->prefix("martin_room_type") . " rt ON (r.room_type_id = rt.room_type_id)
            INNER JOIN " . $this->db->prefix("martin_room_price") . " rp ON (rp.room_id = r.room_id)
            WHERE r.hotel_id IN (" . implode(",", $this->hotel_ids) . ") ";
        $sql .= ($room_date[0] > 0 && $room_date[1] > 0) ? "AND rp.room_date >= {$room_date[0]} AND rp.room_price <= {$room_date[1]} " : " ";
        $sql .= "GROUP BY r.room_id";
        $rows   = array();
        $result = $this->db->query($sql);
        while ($row = $this->db->fetchArray($result)) {
            $room_dates         = array();

$room_dates is not used, you could remove the assignment.

            $row['room_prices'] = explode(",", $row['room_prices']);
            $row['room_dates']  = explode(",", $row['room_dates']);
            foreach ($row['room_prices'] as $key => $room_price) {
                $d = $row['room_dates'][$key];
                if ($d >= $room_date[0] && $d < $room_date[1]) {
                    $room_prices[] = array('date' => date('Y-m-d', $d), 'price' => $room_price);

$room_prices was never initialized. Although not strictly required by PHP, it is generally a good practice to add $room_prices = array(); before regardless.

                }
            }
            unset($row['room_prices'], $row['room_dates']);
            $row['room_prices']       = $room_prices;

The variable $room_prices does not seem to be defined for all execution paths leading up to this point.

            $row['room_date']         = date('Y-m-d', $row['room_date']);
            $rows[$row['hotel_id']][] = $row;
            unset($row, $room_prices);
        }

        return $rows;
    }

    /**
     * @get       city name
     * @method:
     * @license   http://www.blags.org/
     * @created   :2010年06月27日 19时57分
     * @copyright 1997-2010 The Martin Group
     * @author    Martin <china.codehome@gmail.com>
     * @param $city_id
     * @return null
     */
    public function GetCityName($city_id)
    {
        if (empty($city_id)) {
            return $city_id;
        }
        $sql = "SELECT city_name FROM " . $this->db->prefix("martin_hotel_city") . " WHERE city_id = $city_id";
        $row = $this->db->fetchRow($this->db->query($sql));

        return isset($row[0]) ? $row[0] : null;
    }
}