Issues in PagesList.php (master) - Issues in master - mambax7/tdmcreate-1.91 - Measure and Improve Code Quality continuously with Scrutinizer

Issues (519)

Security Analysis not enabled

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

Header Injection

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

class/Files/Templates/user/PagesList.php (3 issues)

Labels

Severity

Minor 3

<?php namespace XoopsModules\Tdmcreate\Files\Templates\User;

use XoopsModules\Tdmcreate;
use XoopsModules\Tdmcreate\Files;

/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 */
/**
 * tdmcreate module.
 *
 * @copyright       XOOPS Project (https://xoops.org)
 * @license         GNU GPL 2 (http://www.gnu.org/licenses/old-licenses/gpl-2.0.html)
 *
 * @since           2.5.0
 *
 * @author          Txmod Xoops http://www.txmodxoops.org
 *
 * @version         $Id: TemplatesUserPagesList.php 12258 2014-01-02 09:33:29Z timgno $
 */

/**
 * class PagesList.
 */
class PagesList extends Files\CreateFile
{
    /**
     *  @public function constructor
     *  @param null
     */
    public function __construct()
    {
        parent::__construct();
    }

    /**
     *  @static function getInstance
     *  @param null
     * @return PagesList
     */
    public static function getInstance()
    {
        static $instance = false;
        if (!$instance) {
            $instance = new self();
        }

        return $instance;
    }

    /**
     *  @public function write
     *  @param string $module
     *  @param string $table
     *  @param string $filename
     * @param $tables
     */
    public function write($module, $table, $tables, $filename)
    {
        $this->setModule($module);
        $this->setTable($table);
        $this->setTables($tables);
        $this->setFileName($filename);
    }

    /**
     * @private function getTemplatesUserPagesListPanel
     * @param string $moduleDirname
     * @param        $tableId
     * @param        $tableMid
     * @param        $tableName
     * @param        $tableSoleName
     * @param        $language
     * @return string
     */
    private function getTemplatesUserPagesListPanel($moduleDirname, $tableId, $tableMid, $tableName, $tableSoleName, $language)
    {
        $hc = Tdmcreate\Files\CreateHtmlSmartyCodes::getInstance();
        $fields = $this->getTableFields($tableMid, $tableId);
        $ret = '';
        $retNumb = '';
        foreach (array_keys($fields) as $f) {
            $fieldElement = $fields[$f]->getVar('field_element');
            if (1 == $fields[$f]->getVar('field_user')) {
                if (1 == $fields[$f]->getVar('field_thead')) {
                    switch ($fieldElement) {
                        default:
                        case 2:
                            $fieldName = $fields[$f]->getVar('field_name');
                            $rpFieldName = $this->getRightString($fieldName);
                            $doubleVar = $hc->getSmartyDoubleVar($tableSoleName, $rpFieldName);
                            $retNumb = $hc->getHtmlHNumb($doubleVar, '3', 'panel-title');
                            break;
                    }
                }
            }
        }
        $ret .= $hc->getHtmlDiv($retNumb, 'panel-heading') . PHP_EOL;
        $retElem = '';
        foreach (array_keys($fields) as $f) {
            $fieldElement = $fields[$f]->getVar('field_element');
            if (1 == $fields[$f]->getVar('field_user')) {
                if (1 == $fields[$f]->getVar('field_tbody')) {
                    switch ($fieldElement) {
                        default:
                        case 3:
                        case 4:
                            $fieldName = $fields[$f]->getVar('field_name');
                            $rpFieldName = $this->getRightString($fieldName);
                            $doubleVar = $hc->getSmartyDoubleVar($tableSoleName, $rpFieldName);
                            $retElem .= $hc->getHtmlSpan($doubleVar, 'col-sm-9 justify') . PHP_EOL;
                            break;
                        case 10:
                            $fieldName = $fields[$f]->getVar('field_name');
                            $rpFieldName = $this->getRightString($fieldName);
                            $singleVar = $hc->getSmartySingleVar('xoops_icons32_url');
                            $doubleVar = $hc->getSmartyDoubleVar($tableSoleName, $rpFieldName);
                            $img = $hc->getHtmlImage($singleVar . '/' . $doubleVar, (string)$tableName);
                            $retElem .= $hc->getHtmlSpan($img, 'col-sm-3') . PHP_EOL;
                            unset($img);
                            break;
                        case 13:
                            $fieldName = $fields[$f]->getVar('field_name');
                            $rpFieldName = $this->getRightString($fieldName);
                            $singleVar = $hc->getSmartySingleVar($moduleDirname . '_upload_url');
                            $doubleVar = $hc->getSmartyDoubleVar($tableSoleName, $rpFieldName);
                            $img = $hc->getHtmlImage($singleVar . "/images/{$tableName}/" . $doubleVar, (string)$tableName);
                            $retElem .= $hc->getHtmlSpan($img, 'col-sm-3') . PHP_EOL;
                            unset($img);
                            break;
                    }
                }
            }
        }
        $ret .= $hc->getHtmlDiv($retElem, 'panel-body') . PHP_EOL;
        $retFoot = '';
        foreach (array_keys($fields) as $f) {
            if (1 == $fields[$f]->getVar('field_user')) {
                if (1 == $fields[$f]->getVar('field_tfoot')) {
                    $fieldName = $fields[$f]->getVar('field_name');
                    $rpFieldName = $this->getRightString($fieldName);
                    $langConst = mb_strtoupper($tableSoleName) . '_' . mb_strtoupper($rpFieldName);
                    $lang = $hc->getSmartyConst($language, $langConst);
                    $doubleVar = $hc->getSmartyDoubleVar($tableSoleName, $rpFieldName);
                    $retFoot .= $hc->getHtmlSpan($lang . ': ' . $doubleVar, 'block-pie justify') . PHP_EOL;
                }
            }
        }
        $ret .= $hc->getHtmlDiv($retFoot, 'panel-foot') . PHP_EOL;

        return $ret;
    }

    /**
     *  @public function render
     *  @param null
     * @return bool|string
     */
    public function render()
    {
        $module = $this->getModule();
        $table = $this->getTable();
        //$tables = $this->getTables();
        $tables = $this->getTableTables($module->getVar('mod_id'), 'table_order');

        $moduleDirname = $module->getVar('mod_dirname');
        $filename = $this->getFileName();
        $language = $this->getLanguage($moduleDirname, 'MA');
        $content = '';
        //foreach (array_keys($tables) as $t) {
        $tableId = $table/*s[$t]*/->getVar('table_id');
        $tableMid = $table/*s[$t]*/->getVar('table_mid');
        $tableName = $table/*s[$t]*/->getVar('table_name');
        $tableSoleName = $table/*s[$t]*/->getVar('table_solename');
        $tableCategory[] = $table/*s[$t]*/->getVar('table_category');

        $tableIndex = $table/*s[$t]*/->getVar('table_index');

        if (in_array(0, $tableCategory)) {
            $content .= $this->getTemplatesUserPagesListPanel($moduleDirname, $tableId, $tableMid, $tableName, $tableSoleName, $language);
        }
        //}
        //$content = $this->getTemplatesUserPagesListPanel($moduleDirname, $table);

        $this->create($moduleDirname, 'templates', $filename, $content, _AM_TDMCREATE_FILE_CREATED, _AM_TDMCREATE_FILE_NOTCREATED);

        return $this->renderFile();
    }
}


1			<?php namespace XoopsModules\Tdmcreate\Files\Templates\User;
2
3			use XoopsModules\Tdmcreate;
4			use XoopsModules\Tdmcreate\Files;
5
6			/*
7			You may not change or alter any portion of this comment or credits
8			of supporting developers from this source code or any supporting source code
9			which is considered copyrighted (c) material of the original comment or credit authors.
10
11			This program is distributed in the hope that it will be useful,
12			but WITHOUT ANY WARRANTY; without even the implied warranty of
13			MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
14			*/
15			/**
16			* tdmcreate module.
17			*
18			* @copyright XOOPS Project (https://xoops.org)
19			* @license GNU GPL 2 (http://www.gnu.org/licenses/old-licenses/gpl-2.0.html)
20			*
21			* @since 2.5.0
22			*
23			* @author Txmod Xoops http://www.txmodxoops.org
24			*
25			* @version $Id: TemplatesUserPagesList.php 12258 2014-01-02 09:33:29Z timgno $
26			*/
27
28			/**
29			* class PagesList.
30			*/
31			class PagesList extends Files\CreateFile
32			{
33			/**
34			* @public function constructor
35			* @param null
36			*/
37			public function __construct()
38			{
39			parent::__construct();
40			}
41
42			/**
43			* @static function getInstance
44			* @param null
45			* @return PagesList
46			*/
47			public static function getInstance()
48			{
49			static $instance = false;
50			if (!$instance) {
51			$instance = new self();
52			}
53
54			return $instance;
55			}
56
57			/**
58			* @public function write
59			* @param string $module
60			* @param string $table
61			* @param string $filename
62			* @param $tables
63			*/
64			public function write($module, $table, $tables, $filename)
65			{
66			$this->setModule($module);
67			$this->setTable($table);
68			$this->setTables($tables);
69			$this->setFileName($filename);
70			}
71
72			/**
73			* @private function getTemplatesUserPagesListPanel
74			* @param string $moduleDirname
75			* @param $tableId
76			* @param $tableMid
77			* @param $tableName
78			* @param $tableSoleName
79			* @param $language
80			* @return string
81			*/
82			private function getTemplatesUserPagesListPanel($moduleDirname, $tableId, $tableMid, $tableName, $tableSoleName, $language)
83			{
84			$hc = Tdmcreate\Files\CreateHtmlSmartyCodes::getInstance();
85			$fields = $this->getTableFields($tableMid, $tableId);
86			$ret = '';
87			$retNumb = '';
88			foreach (array_keys($fields) as $f) {
89			$fieldElement = $fields[$f]->getVar('field_element');
90			if (1 == $fields[$f]->getVar('field_user')) {
91			if (1 == $fields[$f]->getVar('field_thead')) {
92			switch ($fieldElement) {
93			default:
94			case 2:
95			$fieldName = $fields[$f]->getVar('field_name');
96			$rpFieldName = $this->getRightString($fieldName);
97			$doubleVar = $hc->getSmartyDoubleVar($tableSoleName, $rpFieldName);
98			$retNumb = $hc->getHtmlHNumb($doubleVar, '3', 'panel-title');
99			break;
100			}
101			}
102			}
103			}
104			$ret .= $hc->getHtmlDiv($retNumb, 'panel-heading') . PHP_EOL;
105			$retElem = '';
106			foreach (array_keys($fields) as $f) {
107			$fieldElement = $fields[$f]->getVar('field_element');
108			if (1 == $fields[$f]->getVar('field_user')) {
109			if (1 == $fields[$f]->getVar('field_tbody')) {
110			switch ($fieldElement) {
111			default:
112			case 3:
113			case 4:
114			$fieldName = $fields[$f]->getVar('field_name');
115			$rpFieldName = $this->getRightString($fieldName);
116			$doubleVar = $hc->getSmartyDoubleVar($tableSoleName, $rpFieldName);
117			$retElem .= $hc->getHtmlSpan($doubleVar, 'col-sm-9 justify') . PHP_EOL;
118			break;
119			case 10:
120			$fieldName = $fields[$f]->getVar('field_name');
121			$rpFieldName = $this->getRightString($fieldName);
122			$singleVar = $hc->getSmartySingleVar('xoops_icons32_url');
123			$doubleVar = $hc->getSmartyDoubleVar($tableSoleName, $rpFieldName);
124			$img = $hc->getHtmlImage($singleVar . '/' . $doubleVar, (string)$tableName);
125			$retElem .= $hc->getHtmlSpan($img, 'col-sm-3') . PHP_EOL;
126			unset($img);
127			break;
128			case 13:
129			$fieldName = $fields[$f]->getVar('field_name');
130			$rpFieldName = $this->getRightString($fieldName);
131			$singleVar = $hc->getSmartySingleVar($moduleDirname . '_upload_url');
132			$doubleVar = $hc->getSmartyDoubleVar($tableSoleName, $rpFieldName);
133			$img = $hc->getHtmlImage($singleVar . "/images/{$tableName}/" . $doubleVar, (string)$tableName);
134			$retElem .= $hc->getHtmlSpan($img, 'col-sm-3') . PHP_EOL;
135			unset($img);
136			break;
137			}
138			}
139			}
140			}
141			$ret .= $hc->getHtmlDiv($retElem, 'panel-body') . PHP_EOL;
142			$retFoot = '';
143			foreach (array_keys($fields) as $f) {
144			if (1 == $fields[$f]->getVar('field_user')) {
145			if (1 == $fields[$f]->getVar('field_tfoot')) {
146			$fieldName = $fields[$f]->getVar('field_name');
147			$rpFieldName = $this->getRightString($fieldName);
148			$langConst = mb_strtoupper($tableSoleName) . '_' . mb_strtoupper($rpFieldName);
149			$lang = $hc->getSmartyConst($language, $langConst);
150			$doubleVar = $hc->getSmartyDoubleVar($tableSoleName, $rpFieldName);
151			$retFoot .= $hc->getHtmlSpan($lang . ': ' . $doubleVar, 'block-pie justify') . PHP_EOL;
152			}
153			}
154			}
155			$ret .= $hc->getHtmlDiv($retFoot, 'panel-foot') . PHP_EOL;
156
157			return $ret;
158			}
159
160			/**
161			* @public function render
162			* @param null
163			* @return bool\|string
164			*/
165			public function render()
166			{
167			$module = $this->getModule();
168			$table = $this->getTable();
169			//$tables = $this->getTables();
170			$tables = $this->getTableTables($module->getVar('mod_id'), 'table_order');
			0 ignored issues – show Unused Code introduced 2020-01-02 01:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this The assignment to `$tables` is dead and can be removed. Loading history...
171			$moduleDirname = $module->getVar('mod_dirname');
172			$filename = $this->getFileName();
173			$language = $this->getLanguage($moduleDirname, 'MA');
174			$content = '';
175			//foreach (array_keys($tables) as $t) {
176			$tableId = $table/s[$t]/->getVar('table_id');
177			$tableMid = $table/s[$t]/->getVar('table_mid');
178			$tableName = $table/s[$t]/->getVar('table_name');
179			$tableSoleName = $table/s[$t]/->getVar('table_solename');
180			$tableCategory[] = $table/s[$t]/->getVar('table_category');
			0 ignored issues – show Comprehensibility Best Practice introduced 2020-01-02 01:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$tableCategory` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$tableCategory = array();` before regardless. Loading history...
181			$tableIndex = $table/s[$t]/->getVar('table_index');
			0 ignored issues – show Unused Code introduced 2020-01-02 01:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this The assignment to `$tableIndex` is dead and can be removed. Loading history...
182			if (in_array(0, $tableCategory)) {
183			$content .= $this->getTemplatesUserPagesListPanel($moduleDirname, $tableId, $tableMid, $tableName, $tableSoleName, $language);
184			}
185			//}
186			//$content = $this->getTemplatesUserPagesListPanel($moduleDirname, $table);
187
188			$this->create($moduleDirname, 'templates', $filename, $content, _AM_TDMCREATE_FILE_CREATED, _AM_TDMCREATE_FILE_NOTCREATED);
189
190			return $this->renderFile();
191			}
192			}
193

mambax7 / tdmcreate-1.91

Issues (519)

Security Analysis not enabled

class/Files/Templates/user/PagesList.php (3 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like