| Conditions | 15 |
| Paths | 160 |
| Total Lines | 76 |
| Code Lines | 62 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php namespace XoopsModules\Tdmcreate\Files\Templates\User; |
||
| 82 | private function getTemplatesUserPagesListPanel($moduleDirname, $tableId, $tableMid, $tableName, $tableSoleName, $language) |
||
| 83 | { |
||
| 84 | $hc = Tdmcreate\Files\CreateHtmlSmartyCodes::getInstance(); |
||
| 85 | $fields = $this->getTableFields($tableMid, $tableId); |
||
| 86 | $ret = ''; |
||
| 87 | $retNumb = ''; |
||
| 88 | foreach (array_keys($fields) as $f) { |
||
| 89 | $fieldElement = $fields[$f]->getVar('field_element'); |
||
| 90 | if (1 == $fields[$f]->getVar('field_user')) { |
||
| 91 | if (1 == $fields[$f]->getVar('field_thead')) { |
||
| 92 | switch ($fieldElement) { |
||
| 93 | default: |
||
| 94 | case 2: |
||
| 95 | $fieldName = $fields[$f]->getVar('field_name'); |
||
| 96 | $rpFieldName = $this->getRightString($fieldName); |
||
| 97 | $doubleVar = $hc->getSmartyDoubleVar($tableSoleName, $rpFieldName); |
||
| 98 | $retNumb = $hc->getHtmlHNumb($doubleVar, '3', 'panel-title'); |
||
| 99 | break; |
||
| 100 | } |
||
| 101 | } |
||
| 102 | } |
||
| 103 | } |
||
| 104 | $ret .= $hc->getHtmlDiv($retNumb, 'panel-heading') . PHP_EOL; |
||
| 105 | $retElem = ''; |
||
| 106 | foreach (array_keys($fields) as $f) { |
||
| 107 | $fieldElement = $fields[$f]->getVar('field_element'); |
||
| 108 | if (1 == $fields[$f]->getVar('field_user')) { |
||
| 109 | if (1 == $fields[$f]->getVar('field_tbody')) { |
||
| 110 | switch ($fieldElement) { |
||
| 111 | default: |
||
| 112 | case 3: |
||
| 113 | case 4: |
||
| 114 | $fieldName = $fields[$f]->getVar('field_name'); |
||
| 115 | $rpFieldName = $this->getRightString($fieldName); |
||
| 116 | $doubleVar = $hc->getSmartyDoubleVar($tableSoleName, $rpFieldName); |
||
| 117 | $retElem .= $hc->getHtmlSpan($doubleVar, 'col-sm-9 justify') . PHP_EOL; |
||
| 118 | break; |
||
| 119 | case 10: |
||
| 120 | $fieldName = $fields[$f]->getVar('field_name'); |
||
| 121 | $rpFieldName = $this->getRightString($fieldName); |
||
| 122 | $singleVar = $hc->getSmartySingleVar('xoops_icons32_url'); |
||
| 123 | $doubleVar = $hc->getSmartyDoubleVar($tableSoleName, $rpFieldName); |
||
| 124 | $img = $hc->getHtmlImage($singleVar . '/' . $doubleVar, (string)$tableName); |
||
| 125 | $retElem .= $hc->getHtmlSpan($img, 'col-sm-3') . PHP_EOL; |
||
| 126 | unset($img); |
||
| 127 | break; |
||
| 128 | case 13: |
||
| 129 | $fieldName = $fields[$f]->getVar('field_name'); |
||
| 130 | $rpFieldName = $this->getRightString($fieldName); |
||
| 131 | $singleVar = $hc->getSmartySingleVar($moduleDirname . '_upload_url'); |
||
| 132 | $doubleVar = $hc->getSmartyDoubleVar($tableSoleName, $rpFieldName); |
||
| 133 | $img = $hc->getHtmlImage($singleVar . "/images/{$tableName}/" . $doubleVar, (string)$tableName); |
||
| 134 | $retElem .= $hc->getHtmlSpan($img, 'col-sm-3') . PHP_EOL; |
||
| 135 | unset($img); |
||
| 136 | break; |
||
| 137 | } |
||
| 138 | } |
||
| 139 | } |
||
| 140 | } |
||
| 141 | $ret .= $hc->getHtmlDiv($retElem, 'panel-body') . PHP_EOL; |
||
| 142 | $retFoot = ''; |
||
| 143 | foreach (array_keys($fields) as $f) { |
||
| 144 | if (1 == $fields[$f]->getVar('field_user')) { |
||
| 145 | if (1 == $fields[$f]->getVar('field_tfoot')) { |
||
| 146 | $fieldName = $fields[$f]->getVar('field_name'); |
||
| 147 | $rpFieldName = $this->getRightString($fieldName); |
||
| 148 | $langConst = mb_strtoupper($tableSoleName) . '_' . mb_strtoupper($rpFieldName); |
||
| 149 | $lang = $hc->getSmartyConst($language, $langConst); |
||
| 150 | $doubleVar = $hc->getSmartyDoubleVar($tableSoleName, $rpFieldName); |
||
| 151 | $retFoot .= $hc->getHtmlSpan($lang . ': ' . $doubleVar, 'block-pie justify') . PHP_EOL; |
||
| 152 | } |
||
| 153 | } |
||
| 154 | } |
||
| 155 | $ret .= $hc->getHtmlDiv($retFoot, 'panel-foot') . PHP_EOL; |
||
| 156 | |||
| 157 | return $ret; |
||
| 158 | } |
||
| 193 |