mambax7 / smartfaq

smartfaq/footer.php

Spacing +3 added lines, -3 removed lines

@@ -9,10 +9,10 @@ 
 
 global $xoopsTpl, $xoopsModule, $xoopsModuleConfig;
 
-$uid = ($xoopsUser)? ($xoopsUser->getVar("uid")) : 0;
+$uid = ($xoopsUser) ? ($xoopsUser->getVar("uid")) : 0;
 $isAdmin = (sf_userIsAdmin() || sf_moderator());
 
-$xoopsTpl->assign("sf_adminpage", "<a href='" . XOOPS_URL . "/modules/smartfaq/admin/index.php'>" . _MD_SF_ADMIN_PAGE . "</a>");
+$xoopsTpl->assign("sf_adminpage", "<a href='".XOOPS_URL."/modules/smartfaq/admin/index.php'>"._MD_SF_ADMIN_PAGE."</a>");
 $xoopsTpl->assign("isAdmin", $isAdmin);
 
 $xoopsTpl->assign(array('lang_on' => _MD_SF_ON, 'lang_postedby' => _MD_SF_POSTEDBY, 'lang_faq' => _MD_SF_QUESTION, 'lang_datesub' => _MD_SF_DATESUB, 'lang_hits' => _MD_SF_HITS));
@@ -29,4 +29,4 @@ 
 
 $xoopsTpl->assign("ref_smartfaq", "SmartFAQ is developed by The SmartFactory (http://www.smartfactory.ca), a division of InBox Solutions (http://www.inboxsolutions.net)");
 
-$xoopsTpl->assign("xoops_module_header", "<link rel='stylesheet' type='text/css' href='" . XOOPS_URL . "/modules/smartfaq/smartfaq.css'/>");
+$xoopsTpl->assign("xoops_module_header", "<link rel='stylesheet' type='text/css' href='".XOOPS_URL."/modules/smartfaq/smartfaq.css'/>");

smartfaq/index.php

Spacing +24 added lines, -24 removed lines

@@ -6,27 +6,27 @@ 
 * Author: The SmartFactory <www.smartfactory.ca>
 * Licence: GNU
 */
-include_once __DIR__ . '/header.php';
+include_once __DIR__.'/header.php';
 
 // At which record shall we start for the Categories
-$catstart = isset($_GET['catstart'])? intval($_GET['catstart']) : 0;
+$catstart = isset($_GET['catstart']) ? intval($_GET['catstart']) : 0;
 
 // At which record shall we start for the FAQ
-$start = isset($_GET['start'])? intval($_GET['start']) : 0;
+$start = isset($_GET['start']) ? intval($_GET['start']) : 0;
 
 // Creating the category handler object
-$category_handler =& sf_gethandler('category');
+$category_handler = & sf_gethandler('category');
 
 // Creating the faq handler object
-$faq_handler =& sf_gethandler('faq');
+$faq_handler = & sf_gethandler('faq');
 
 $totalCategories = $category_handler->getCategoriesCount(0);
 
 // Total number of published FAQ in the module
 $totalFaqs = $faq_handler->getFaqsCount(-1, array(_SF_STATUS_PUBLISHED, _SF_STATUS_NEW_ANSWER));
 
-if ($totalFaqs  == 0) {
-    if ( ($totalCategories > 0) && ($xoopsModuleConfig['allowrequest'] && ($xoopsModuleConfig['anonpost']) || is_object($xoopsUser))) {
+if ($totalFaqs == 0) {
+    if (($totalCategories > 0) && ($xoopsModuleConfig['allowrequest'] && ($xoopsModuleConfig['anonpost']) || is_object($xoopsUser))) {
         redirect_header("request.php", 2, _AM_SF_NO_TOP_PERMISSIONS);
     } else {
         redirect_header("../../index.php", 2, _AM_SF_NO_TOP_PERMISSIONS);
@@ -36,14 +36,14 @@ 
 
 $xoopsOption['template_main'] = 'smartfaq_index.tpl';
 
-include_once(XOOPS_ROOT_PATH . "/header.php");
-include_once __DIR__ . '/footer.php';
+include_once(XOOPS_ROOT_PATH."/header.php");
+include_once __DIR__.'/footer.php';
 
 // Creating the categories objects
 $categoriesObj = $category_handler->getCategories($xoopsModuleConfig['catperpage'], $catstart);
 // If no categories are found, exit
 $totalCategoriesOnPage = count($categoriesObj);
-if ($totalCategoriesOnPage  == 0) {
+if ($totalCategoriesOnPage == 0) {
     redirect_header("javascript:history.go(-1)", 2, _AM_SF_NO_CAT_EXISTS);
     exit;
 }
@@ -55,13 +55,13 @@ 
     $subcats = $category_handler->getSubCats($categoriesObj);
 //}
 $totalQnas = $category_handler->publishedFaqsCount();
-$faq_handler =& sf_gethandler('faq');
+$faq_handler = & sf_gethandler('faq');
 
 if ($xoopsModuleConfig['displaylastfaq'] == 1) {
     // Get the last smartfaq in each category
     $last_qnaObj = $faq_handler->getLastPublishedByCat();
 }
-$lastfaqsize = intval($xoopsModuleConfig['lastfaqsize'])    ;
+$lastfaqsize = intval($xoopsModuleConfig['lastfaqsize']);
 $categories = array();
 foreach ($categoriesObj as $cat_id => $category) {
     $total = 0;
@@ -71,7 +71,7 @@ 
             if (isset($totalQnas[$subcat_id]) && $totalQnas[$subcat_id] > 0) {
                 if (isset($last_qnaObj[$subcat_id])) {
                     $subcat->setVar('last_faqid', $last_qnaObj[$subcat_id]->getVar('faqid'));
-                    $subcat->setVar('last_question_link', "<a href='faq.php?faqid=" . $last_qnaObj[$subcat_id]->getVar('faqid') . "'>" . $last_qnaObj[$subcat_id]->question($lastfaqsize) . "</a>");
+                    $subcat->setVar('last_question_link', "<a href='faq.php?faqid=".$last_qnaObj[$subcat_id]->getVar('faqid')."'>".$last_qnaObj[$subcat_id]->question($lastfaqsize)."</a>");
                 }
                 $subcat->setVar('faqcount', $totalQnas[$subcat_id]);
                 if ($xoopsModuleConfig['displaysubcatonindex']) {
@@ -89,7 +89,7 @@ 
     if ($total > 0) {
         if (isset($last_qnaObj[$cat_id])) {
             $category->setVar('last_faqid', $last_qnaObj[$cat_id]->getVar('faqid'));
-            $category->setVar('last_question_link', "<a href='faq.php?faqid=" . $last_qnaObj[$cat_id]->getVar('faqid') . "'>" . $last_qnaObj[$cat_id]->question($lastfaqsize) . "</a>");
+            $category->setVar('last_question_link', "<a href='faq.php?faqid=".$last_qnaObj[$cat_id]->getVar('faqid')."'>".$last_qnaObj[$cat_id]->question($lastfaqsize)."</a>");
         }
         $category->setVar('faqcount', $total);
         if (!isset($categories[$cat_id])) {
@@ -120,7 +120,7 @@ 
             $faqids[] = $thisfaq->getVar('faqid');
             $userids[$thisfaq->uid()] = 1;
         }
-        $answer_handler =& sf_gethandler('answer');
+        $answer_handler = & sf_gethandler('answer');
         $allanswers = $answer_handler->getLastPublishedByFaq($faqids);
 
         foreach ($allanswers as $key => $thisanswer) {
@@ -133,7 +133,7 @@ 
             $faq = $faqsObj[$i]->toArray(null, $allcategories);
 
             // Creating the answer object
-            $answerObj =& $allanswers[$faqsObj[$i]->faqid()];
+            $answerObj = & $allanswers[$faqsObj[$i]->faqid()];
 
             $answerObj->setVar('dohtml', $faqsObj[$i]->getVar('html'));
             $answerObj->setVar('doxcode', $faqsObj[$i]->getVar('xcodes'));
@@ -159,9 +159,9 @@ 
 $xoopsTpl->assign('displaysubcatonindex', $xoopsModuleConfig['displaysubcatonindex']);
 $xoopsTpl->assign('displaylastfaqs', $xoopsModuleConfig['displaylastfaqs']);
 $xoopsTpl->assign('display_categoryname', true);
-$xoopsTpl->assign('displayFull', $xoopsModuleConfig['displaytype']=='full');
+$xoopsTpl->assign('displayFull', $xoopsModuleConfig['displaytype'] == 'full');
 
-$xoopsTpl->assign('lang_mainhead', _MD_SF_MAINHEAD . " " . $moduleName);
+$xoopsTpl->assign('lang_mainhead', _MD_SF_MAINHEAD." ".$moduleName);
 $xoopsTpl->assign('lang_mainintro', $myts->displayTarea($xoopsModuleConfig['indexwelcomemsg'], 1));
 $xoopsTpl->assign('lang_total', _MD_SF_TOTAL_SMARTFAQS);
 $xoopsTpl->assign('lang_home', _MD_SF_HOME);
@@ -180,20 +180,20 @@ 
 $xoopsTpl->assign('lang_comments', _MD_SF_COMMENTS);
 
 // Category Navigation Bar
-include_once XOOPS_ROOT_PATH . '/class/pagenav.php';
+include_once XOOPS_ROOT_PATH.'/class/pagenav.php';
 $pagenav = new XoopsPageNav($totalCategories, $xoopsModuleConfig['catperpage'], $catstart, 'catstart', '');
 if ($xoopsModuleConfig['useimagenavpage'] == 1) {
-    $xoopsTpl->assign('catnavbar', '<div style="text-align:right;">' . $pagenav->renderImageNav() . '</div>');
+    $xoopsTpl->assign('catnavbar', '<div style="text-align:right;">'.$pagenav->renderImageNav().'</div>');
 } else {
-    $xoopsTpl->assign('catnavbar', '<div style="text-align:right;">' . $pagenav->renderNav() . '</div>');
+    $xoopsTpl->assign('catnavbar', '<div style="text-align:right;">'.$pagenav->renderNav().'</div>');
 }
 
 // FAQ Navigation Bar
 $pagenav = new XoopsPageNav($totalFaqs, $xoopsModuleConfig['indexperpage'], $start, 'start', '');
 if ($xoopsModuleConfig['useimagenavpage'] == 1) {
-    $xoopsTpl->assign('navbar', '<div style="text-align:right;">' . $pagenav->renderImageNav() . '</div>');
+    $xoopsTpl->assign('navbar', '<div style="text-align:right;">'.$pagenav->renderImageNav().'</div>');
 } else {
-    $xoopsTpl->assign('navbar', '<div style="text-align:right;">' . $pagenav->renderNav() . '</div>');
+    $xoopsTpl->assign('navbar', '<div style="text-align:right;">'.$pagenav->renderNav().'</div>');
 }
 
 // Page Title Hack by marcan
@@ -201,4 +201,4 @@ 
 $xoopsTpl->assign('xoops_pagetitle', $module_name);
 // End Page Title Hack by marcan
 
-include_once(XOOPS_ROOT_PATH . "/footer.php");
+include_once(XOOPS_ROOT_PATH."/footer.php");

smartfaq/print.php

Spacing +17 added lines, -17 removed lines

@@ -7,9 +7,9 @@ 
 * Licence: GNU
 */
 
-include_once __DIR__ . '/header.php';
+include_once __DIR__.'/header.php';
 
-$faqid = isset($_GET['faqid'])? intval($_GET['faqid']) : 0;
+$faqid = isset($_GET['faqid']) ? intval($_GET['faqid']) : 0;
 
 if ($faqid == 0) {
     redirect_header("javascript:history.go(-1)", 1, _MD_SF_NOFAQSELECTED);
@@ -17,7 +17,7 @@ 
 }
 
 // Creating the FAQ handler object
-$faq_handler =& sf_gethandler('faq');
+$faq_handler = & sf_gethandler('faq');
 
 // Creating the FAQ object for the selected FAQ
 $faqObj = new sfFaq($faqid);
@@ -29,10 +29,10 @@ 
 }
 
 // Creating the category object that holds the selected FAQ
-$categoryObj =& $faqObj->category();
+$categoryObj = & $faqObj->category();
 
 // Creating the answer object
-$answerObj =& $faqObj->answer();
+$answerObj = & $faqObj->answer();
 
 // Check user permissions to access that category of the selected FAQ
 if (faqAccessGranted($faqObj) < 0) {
@@ -43,27 +43,27 @@ 
 global $xoopsConfig, $xoopsDB, $xoopsModule, $myts;
 
 $who_where = $faqObj->getWhoAndWhen();
-$comeFrom =  $faqObj->getComeFrom();
+$comeFrom = $faqObj->getComeFrom();
 
 echo "<!DOCTYPE HTML PUBLIC '-//W3C//DTD HTML 4.01 Transitional//EN'>\n";
 echo "<html>\n<head>\n";
-echo "<title>" . _MD_SF_FAQCOMEFROM . " " . $xoopsConfig['sitename'] . "</title>\n";
-echo "<meta http-equiv='Content-Type' content='text/html; charset=" . _CHARSET . "' />\n";
-echo "<meta name='AUTHOR' content='" . $xoopsConfig['sitename'] . "' />\n";
-echo "<meta name='COPYRIGHT' content='Copyright (c) 2001 by " . $xoopsConfig['sitename'] . "' />\n";
-echo "<meta name='DESCRIPTION' content='" . $xoopsConfig['slogan'] . "' />\n";
-echo "<meta name='GENERATOR' content='" . XOOPS_VERSION . "' />\n\n\n";
+echo "<title>"._MD_SF_FAQCOMEFROM." ".$xoopsConfig['sitename']."</title>\n";
+echo "<meta http-equiv='Content-Type' content='text/html; charset="._CHARSET."' />\n";
+echo "<meta name='AUTHOR' content='".$xoopsConfig['sitename']."' />\n";
+echo "<meta name='COPYRIGHT' content='Copyright (c) 2001 by ".$xoopsConfig['sitename']."' />\n";
+echo "<meta name='DESCRIPTION' content='".$xoopsConfig['slogan']."' />\n";
+echo "<meta name='GENERATOR' content='".XOOPS_VERSION."' />\n\n\n";
 
 echo "<body bgcolor='#ffffff' text='#000000' onload='window.print()'>
      <div style='width: 650px; border: 1px solid #000; padding: 20px;'>
-     <div style='text-align: center; display: block; margin: 0 0 6px 0;'><img src='" . XOOPS_URL . "/modules/smartfaq/assets/images/smartfaq_logo.png' border='0' alt='' /><h2 style='margin: 0;'>" . $faqObj->question() . "</h2></div>
-     <div align='center'>" . $who_where . "</div>
+     <div style='text-align: center; display: block; margin: 0 0 6px 0;'><img src='" . XOOPS_URL."/modules/smartfaq/assets/images/smartfaq_logo.png' border='0' alt='' /><h2 style='margin: 0;'>".$faqObj->question()."</h2></div>
+     <div align='center'>" . $who_where."</div>
                 <div style='text-align: center; display: block; padding-bottom: 12px; margin: 0 0 6px 0; border-bottom: 2px solid #ccc;'></div>
                 <div></div>
-                <b><p>" . $faqObj->question() . "</p></b>
-                <p>" . $answerObj->answer() . "</p>
+                <b><p>" . $faqObj->question()."</p></b>
+                <p>" . $answerObj->answer()."</p>
                 <div style='padding-top: 12px; border-top: 2px solid #ccc;'></div>
-                <p>". $comeFrom . "</p>
+                <p>". $comeFrom."</p>
             </div>
     <br />";
 

smartfaq/open_category.php

Spacing +18 added lines, -18 removed lines

@@ -7,16 +7,16 @@ 
 * Licence: GNU
 */
 
-include_once __DIR__ . '/header.php';
+include_once __DIR__.'/header.php';
 
 global $xoopsConfig, $xoopsModuleConfig, $xoopsModule;
 
 $xoopsOption['template_main'] = 'smartfaq_category.tpl';
 
-include_once(XOOPS_ROOT_PATH . "/header.php");
-include_once __DIR__ . '/footer.php';
+include_once(XOOPS_ROOT_PATH."/header.php");
+include_once __DIR__.'/footer.php';
 
-$categoryid = isset($_GET['categoryid'])? intval($_GET['categoryid']) : 0;
+$categoryid = isset($_GET['categoryid']) ? intval($_GET['categoryid']) : 0;
 
 // Creating the category object for the selected category
 $categoryObj = new sfCategory($categoryid);
@@ -34,13 +34,13 @@ 
 }
 
 // Creating the category handler object
-$category_handler =& sf_gethandler('category');
+$category_handler = & sf_gethandler('category');
 
 // At which record shall we start
-$start = isset($_GET['start'])? intval($_GET['start']) : 0;
+$start = isset($_GET['start']) ? intval($_GET['start']) : 0;
 
 // Creating the faq handler object
-$faq_handler =& sf_gethandler('faq');
+$faq_handler = & sf_gethandler('faq');
 
 // creating the FAQ objects that belong to the selected category
 $faqsObj = $faq_handler->getFaqs($xoopsModuleConfig['indexperpage'], $start, _SF_STATUS_OPENED, $categoryid);
@@ -63,7 +63,7 @@ 
 $last_qnaObj = $faq_handler->getLastPublishedByCat(array(_SF_STATUS_OPENED));
 if (isset($last_qnaObj[$categoryid])) {
     $categoryObj->setVar('last_faqid', $last_qnaObj[$categoryid]->getVar('faqid'));
-    $categoryObj->setVar('last_question_link', "<a href='faq.php?faqid=" . $last_qnaObj[$categoryid]->getVar('faqid') . "'>" . $last_qnaObj[$categoryid]->question(50) . "</a>");
+    $categoryObj->setVar('last_question_link', "<a href='faq.php?faqid=".$last_qnaObj[$categoryid]->getVar('faqid')."'>".$last_qnaObj[$categoryid]->question(50)."</a>");
 }
 // Populating the smarty variables with informations related to the selected category
 $category = $categoryObj->toArray(null, true);
@@ -75,14 +75,14 @@ 
 $total_subcats = count($subcatsObj);
 $catQnasWithSub = 0;
 if ($total_subcats != 0) {
-    $faq_handler =& sf_gethandler('faq');
+    $faq_handler = & sf_gethandler('faq');
     // Arrays that will hold the informations passed on to smarty variables
     foreach ($subcatsObj as $key => $subcat) {
         $subcat_id = $subcat->getVar('categoryid');
         if (isset($totalQnas[$subcat_id]) && $totalQnas[$subcat_id] > 0) {
             if (isset($last_qnaObj[$subcat_id])) {
                 $subcat->setVar('last_faqid', $last_qnaObj[$subcat_id]->getVar('faqid'));
-                $subcat->setVar('last_question_link', "<a href='faq.php?faqid=" . $last_qnaObj[$subcat_id]->getVar('faqid') . "'>" . $last_qnaObj[$subcat_id]->question(50) . "</a>");
+                $subcat->setVar('last_question_link', "<a href='faq.php?faqid=".$last_qnaObj[$subcat_id]->getVar('faqid')."'>".$last_qnaObj[$subcat_id]->question(50)."</a>");
             }
             $subcat->setVar('faqcount', $totalQnas[$subcat_id]);
             $subcats[$subcat_id] = $subcat->toArray(null, true);
@@ -91,7 +91,7 @@ 
     }
     $xoopsTpl->assign('subcats', $subcats);
 }
-$category['total'] = $catQnasWithSub + $totalQnas[$categoryid];
+$category['total'] = $catQnasWithSub+$totalQnas[$categoryid];
 if ($faqsObj) {
     $userids = array();
     foreach ($faqsObj as $key => $thisfaq) {
@@ -112,7 +112,7 @@ 
     }
 }
 // Language constants
-$xoopsTpl->assign('whereInSection', $myts->htmlSpecialChars($xoopsModule->getVar('name')) . " > <a href='open_index.php'>" . _MD_SF_OPEN_SECTION . "</a>");
+$xoopsTpl->assign('whereInSection', $myts->htmlSpecialChars($xoopsModule->getVar('name'))." > <a href='open_index.php'>"._MD_SF_OPEN_SECTION."</a>");
 $xoopsTpl->assign('modulename', $xoopsModule->dirname());
 
 $xoopsTpl->assign('displaylastfaqs', true);
@@ -129,19 +129,19 @@ 
 $xoopsTpl->assign('lang_category', _MD_SF_CATEGORY);
 
 // The Navigation Bar
-include_once XOOPS_ROOT_PATH . '/class/pagenav.php';
-$pagenav = new XoopsPageNav($totalQnas[$categoryid], $xoopsModuleConfig['indexperpage'], $start, 'start', 'categoryid=' . $categoryObj->getVar('categoryid'));
+include_once XOOPS_ROOT_PATH.'/class/pagenav.php';
+$pagenav = new XoopsPageNav($totalQnas[$categoryid], $xoopsModuleConfig['indexperpage'], $start, 'start', 'categoryid='.$categoryObj->getVar('categoryid'));
 if ($xoopsModuleConfig['useimagenavpage'] == 1) {
-    $category['navbar'] = '<div style="text-align:right;">' . $pagenav->renderImageNav() . '</div>';
+    $category['navbar'] = '<div style="text-align:right;">'.$pagenav->renderImageNav().'</div>';
 } else {
-    $category['navbar'] = '<div style="text-align:right;">' . $pagenav->renderNav() . '</div>';
+    $category['navbar'] = '<div style="text-align:right;">'.$pagenav->renderNav().'</div>';
 }
 
 $xoopsTpl->assign('category', $category);
 
 // Page Title Hack by marcan
 $module_name = $myts->htmlSpecialChars($xoopsModule->getVar('name'));
-$xoopsTpl->assign('xoops_pagetitle', $module_name . ' - ' . $category['name']);
+$xoopsTpl->assign('xoops_pagetitle', $module_name.' - '.$category['name']);
 // End Page Title Hack by marcan
 
-include_once(XOOPS_ROOT_PATH . "/footer.php");
+include_once(XOOPS_ROOT_PATH."/footer.php");

smartfaq/comment_new.php

Spacing +2 added lines, -2 removed lines

@@ -7,5 +7,5 @@
 * Licence: GNU
 */
 
-include dirname(dirname(__DIR__)) . '/mainfile.php';
-include_once XOOPS_ROOT_PATH . '/include/comment_new.php';
+include dirname(dirname(__DIR__)).'/mainfile.php';
+include_once XOOPS_ROOT_PATH.'/include/comment_new.php';

smartfaq/admin/about.php

Spacing +2 added lines, -2 removed lines

@@ -18,7 +18,7 @@ 
  * @version    $Id $
  */
 
-include_once __DIR__ . '/admin_header.php';
+include_once __DIR__.'/admin_header.php';
 
 xoops_cp_header();
 
@@ -27,4 +27,4 @@ 
 echo $aboutAdmin->addNavigation('about.php');
 echo $aboutAdmin->renderAbout('6KJ7RW5DR3VTJ', false);
 
-include_once __DIR__ . '/admin_footer.php';
+include_once __DIR__.'/admin_footer.php';

smartfaq/admin/admin_header.php

Spacing +13 added lines, -13 removed lines

@@ -19,20 +19,20 @@ 
  */
 
 $path = dirname(dirname(dirname(__DIR__)));
-include_once $path . '/mainfile.php';
-include_once $path . '/include/cp_functions.php';
-require_once $path . '/include/cp_header.php';
+include_once $path.'/mainfile.php';
+include_once $path.'/include/cp_functions.php';
+require_once $path.'/include/cp_header.php';
 
-include_once $path . "/kernel/module.php";
-include_once $path . "/class/xoopstree.php";
-include_once $path . "/class/xoopslists.php";
-include_once $path . '/class/pagenav.php';
-include_once $path . "/class/xoopsformloader.php";
+include_once $path."/kernel/module.php";
+include_once $path."/class/xoopstree.php";
+include_once $path."/class/xoopslists.php";
+include_once $path.'/class/pagenav.php';
+include_once $path."/class/xoopsformloader.php";
 
-include_once $path .'/modules/smartfaq/include/functions.php';
-include_once $path .'/modules/smartfaq/class/category.php';
-include_once $path .'/modules/smartfaq/class/faq.php';
-include_once $path .'/modules/smartfaq/class/answer.php';
+include_once $path.'/modules/smartfaq/include/functions.php';
+include_once $path.'/modules/smartfaq/class/category.php';
+include_once $path.'/modules/smartfaq/class/faq.php';
+include_once $path.'/modules/smartfaq/class/answer.php';
 
 $myts = &MyTextSanitizer::getInstance();
 
@@ -52,7 +52,7 @@ 
 $pathIcon32 = '../'.$xoopsModule->getInfo('icons32');
 $pathModuleAdmin = $xoopsModule->getInfo('dirmoduleadmin');
 
-if ( file_exists($GLOBALS['xoops']->path($pathModuleAdmin.'/moduleadmin.php'))) {
+if (file_exists($GLOBALS['xoops']->path($pathModuleAdmin.'/moduleadmin.php'))) {
         include_once $GLOBALS['xoops']->path($pathModuleAdmin.'/moduleadmin.php');
     } else {
         redirect_header("../../../admin.php", 5, _AM_BIRTHDAY_MODULEADMIN_MISSING, false);

smartfaq/admin/answer.php

Spacing +43 added lines, -43 removed lines

@@ -7,7 +7,7 @@ 
 * Licence: GNU
 */
 
-include_once __DIR__ . '/admin_header.php';
+include_once __DIR__.'/admin_header.php';
 
 $op = '';
 
@@ -16,20 +16,20 @@ 
 if (isset($_POST['op'])) $op = $_POST['op'];
 
 // Creating the answer handler object
-$answer_handler =& sf_gethandler('answer');
+$answer_handler = & sf_gethandler('answer');
 
 function editfaq($faqid = '')
 {
 
     global $answer_handler, $xoopsUser, $xoopsUser, $xoopsConfig, $xoopsDB, $modify, $xoopsModuleConfig, $xoopsModule, $XOOPS_URL, $myts, $pathIcon16, $smartModuleConfig;
 
-    include_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
+    include_once XOOPS_ROOT_PATH.'/class/xoopsformloader.php';
 
     // Creating the FAQ object
     $faqObj = new sfFaq($faqid);
 
     // Creating the category object
-    $categoryObj =& $faqObj->category();
+    $categoryObj = & $faqObj->category();
 
     if ($faqObj->notLoaded()) {
         redirect_header("index.php", 1, _AM_SF_NOFAQSELECTED);
@@ -39,8 +39,8 @@ 
     switch ($faqObj->status()) {
 
         case _SF_STATUS_ANSWERED :
-        $breadcrumb_action1 =    _AM_SF_SUBMITTED;
-        $breadcrumb_action2 =    _AM_SF_APPROVING;
+        $breadcrumb_action1 = _AM_SF_SUBMITTED;
+        $breadcrumb_action2 = _AM_SF_APPROVING;
         $collapsableBar_title = _AM_SF_SUBMITTED_TITLE;
         $collapsableBar_info = _AM_SF_SUBMITTED_INFO;
         $button_caption = _AM_SF_APPROVE;
@@ -51,7 +51,7 @@ 
 
     $module_id = $xoopsModule->getVar('mid');
     $gperm_handler = &xoops_gethandler('groupperm');
-    $groups = ($xoopsUser)? ($xoopsUser->getGroups()) : XOOPS_GROUP_ANONYMOUS;
+    $groups = ($xoopsUser) ? ($xoopsUser->getGroups()) : XOOPS_GROUP_ANONYMOUS;
 
     if (!sf_userIsAdmin() && (!($gperm_handler->checkRight('category_admin', $faqObj->categoryid(), $groups, $module_id)))) {
         redirect_header("javascript:history.go(-1)", 1, _NOPERM);
@@ -63,9 +63,9 @@ 
     //sf_adminMenu(-1, _AM_SF_SMARTFAQ . " > " . _AM_SF_ANSWER);
 
     sf_collapsableBar('bottomtable', 'bottomtableicon');
-    echo "<img id='bottomtableicon' src=" . XOOPS_URL . "/modules/" . $xoopsModule->dirname() . "/assets/images/icon/close12.gif alt='' /></a>&nbsp;" . _AM_SF_SUBMITTED_ANSWER . "</h3>";
+    echo "<img id='bottomtableicon' src=".XOOPS_URL."/modules/".$xoopsModule->dirname()."/assets/images/icon/close12.gif alt='' /></a>&nbsp;"._AM_SF_SUBMITTED_ANSWER."</h3>";
     echo "<div id='bottomtable'>";
-    echo "<span style=\"color: #567; margin: 3px 0 12px 0; font-size: small; display: block; \">" . _AM_SF_SUBMITTED_ANSWER_INFO . "</span>";
+    echo "<span style=\"color: #567; margin: 3px 0 12px 0; font-size: small; display: block; \">"._AM_SF_SUBMITTED_ANSWER_INFO."</span>";
 
     $proposed_answers = $answer_handler->getAllAnswers($faqid, _SF_AN_STATUS_PROPOSED);
 
@@ -76,31 +76,31 @@ 
 
     echo "<table width='100%' cellspacing=1 cellpadding=3 border=0 class = outer>
             <tr>
-              <td class='head' width='100px'>" . _AM_SF_CATEGORY . "</td>
-              <td class='even'>" . $categoryObj->name() . "</td>
+              <td class='head' width='100px'>" . _AM_SF_CATEGORY."</td>
+              <td class='even'>" . $categoryObj->name()."</td>
             </tr>
             <tr>
-              <td class='head' width='100px'>" . _AM_SF_QUESTION . "</td>
-              <td class='even'>" . $faqObj->question() . "</td>
+              <td class='head' width='100px'>" . _AM_SF_QUESTION."</td>
+              <td class='even'>" . $faqObj->question()."</td>
             </tr>";
     if ($official_answer) {
         echo "
             <tr>
-              <td class='head' width='100px'>" . _AM_SF_ANSWER_OFFICIAL . "</td>
-              <td class='even'>" . $official_answer->answer() . "</td>
+              <td class='head' width='100px'>" . _AM_SF_ANSWER_OFFICIAL."</td>
+              <td class='even'>" . $official_answer->answer()."</td>
             </tr>";
     }
     echo "</table><br />\n";
 
     echo "<table width='100%' cellspacing=1 cellpadding=3 border=0 class = outer>";
     echo "<tr>";
-    echo "<th width='40' class='bg3' align='center'><b>" . _AM_SF_ARTID . "</b></td>";
-    echo "<th class='bg3' class='bg3' align='center'><b>" . _AM_SF_ANSWER . "</b></td>";
+    echo "<th width='40' class='bg3' align='center'><b>"._AM_SF_ARTID."</b></td>";
+    echo "<th class='bg3' class='bg3' align='center'><b>"._AM_SF_ANSWER."</b></td>";
 
-    echo "<th width='90' class='bg3' align='center'><b>" . _AM_SF_ANSWERED . "</b></td>";
+    echo "<th width='90' class='bg3' align='center'><b>"._AM_SF_ANSWERED."</b></td>";
 
-    echo "<th width='180' class='bg3' align='center'><b>" . _AM_SF_CREATED . "</b></td>";
-    echo "<th width='120' class='bg3' align='center'><b>" . _AM_SF_ACTION . "</b></td>";
+    echo "<th width='180' class='bg3' align='center'><b>"._AM_SF_CREATED."</b></td>";
+    echo "<th width='120' class='bg3' align='center'><b>"._AM_SF_ACTION."</b></td>";
     echo "</tr>";
 
     $merge = '';
@@ -108,20 +108,20 @@ 
     $approve = '';
     foreach ($proposed_answers as $proposed_answer) {
         if ($faqObj->status() == _SF_STATUS_NEW_ANSWER) {
-            $merge = "<a href='faq.php?op=merge&amp;faqid=" . $faqObj->faqid() . "&amp;answerid=" . $proposed_answer->answerid() . "'><img src='" . XOOPS_URL . "/modules/" . $xoopsModule->dirname() . "/assets/images/icon/merge.gif' title='" . _AM_SF_FAQ_MERGE . "' alt='" . _AM_SF_FAQ_MERGE . "' /></a>&nbsp;";
-            $approve = "<a href='answer.php?op=selectanswer&amp;faqid=" . $faqid . "&amp;answerid=" . $proposed_answer->answerid() . "'><img src='". $pathIcon16 .'/on.png'."' title='" . _AM_SF_FAQ_APPROVE_NEW_ANSWER . "' alt='" . _AM_SF_APPROVESUB . "' /></a>";
+            $merge = "<a href='faq.php?op=merge&amp;faqid=".$faqObj->faqid()."&amp;answerid=".$proposed_answer->answerid()."'><img src='".XOOPS_URL."/modules/".$xoopsModule->dirname()."/assets/images/icon/merge.gif' title='"._AM_SF_FAQ_MERGE."' alt='"._AM_SF_FAQ_MERGE."' /></a>&nbsp;";
+            $approve = "<a href='answer.php?op=selectanswer&amp;faqid=".$faqid."&amp;answerid=".$proposed_answer->answerid()."'><img src='".$pathIcon16.'/on.png'."' title='"._AM_SF_FAQ_APPROVE_NEW_ANSWER."' alt='"._AM_SF_APPROVESUB."' /></a>";
         }
-        $modify = "<a href='faq.php?op=mod&amp;faqid=" . $faqObj->faqid() . "&amp;answerid=" . $proposed_answer->answerid() . "'><img src='". $pathIcon16 .'/edit.png'."' title='" . _AM_SF_FAQ_REVIEW . "' alt='" . _AM_SF_FAQ_REVIEW . "' /></a>&nbsp;";
-        $delete = "<a href='answer.php?op=del&amp;faqid=" . $faqObj->faqid() . "&amp;answerid=" .  $proposed_answer->answerid() . "'><img src='". $pathIcon16 .'/delete.png'."' title='" . _AM_SF_DELETESUBM . "' alt='" . _AM_SF_DELETESUBM . "' /></a>";
+        $modify = "<a href='faq.php?op=mod&amp;faqid=".$faqObj->faqid()."&amp;answerid=".$proposed_answer->answerid()."'><img src='".$pathIcon16.'/edit.png'."' title='"._AM_SF_FAQ_REVIEW."' alt='"._AM_SF_FAQ_REVIEW."' /></a>&nbsp;";
+        $delete = "<a href='answer.php?op=del&amp;faqid=".$faqObj->faqid()."&amp;answerid=".$proposed_answer->answerid()."'><img src='".$pathIcon16.'/delete.png'."' title='"._AM_SF_DELETESUBM."' alt='"._AM_SF_DELETESUBM."' /></a>";
         echo "<tr>";
-        echo "<td class='head' align='center'>" . $proposed_answer->answerid(). "</td>";
-        echo "<td class='even' align='left'>" . $proposed_answer->answer() . "</td>";
+        echo "<td class='head' align='center'>".$proposed_answer->answerid()."</td>";
+        echo "<td class='even' align='left'>".$proposed_answer->answer()."</td>";
 
 //show name of the answer submitter
-        $submitter= sf_getLinkedUnameFromId($proposed_answer->uid(), $smartModuleConfig['userealname']);
-        echo "<td class='even' align='center'>" . $submitter . "</td>";
+        $submitter = sf_getLinkedUnameFromId($proposed_answer->uid(), $smartModuleConfig['userealname']);
+        echo "<td class='even' align='center'>".$submitter."</td>";
 
-        echo "<td class='even' align='center'>" . $proposed_answer->datesub() . "</td>";
+        echo "<td class='even' align='center'>".$proposed_answer->datesub()."</td>";
         echo "<td class='even' align='center'> $merge $modify $approve $delete </td>";
         echo "</tr>";
     }
@@ -133,17 +133,17 @@ 
 switch ($op) {
     case "mod":
     xoops_cp_header();
-    include_once XOOPS_ROOT_PATH . "/class/xoopsformloader.php";
+    include_once XOOPS_ROOT_PATH."/class/xoopsformloader.php";
     Global $xoopsUser, $xoopsUser, $xoopsConfig, $xoopsDB, $xoopsModuleConfig, $xoopsModule, $modify, $myts;
-    $faqid = isset($_GET['faqid'])? intval($_GET['faqid']) : 0;
+    $faqid = isset($_GET['faqid']) ? intval($_GET['faqid']) : 0;
     editfaq($faqid);
     break;
 
     case "selectanswer":
     global $xoopsUser, $_GET, $xoopsModuleConfig;
 
-    $faqid = isset($_GET['faqid'])? intval($_GET['faqid']) : 0;
-    $answerid = isset($_GET['answerid'])? intval($_GET['answerid']) : 0;
+    $faqid = isset($_GET['faqid']) ? intval($_GET['faqid']) : 0;
+    $answerid = isset($_GET['answerid']) ? intval($_GET['answerid']) : 0;
 
     // Creating the FAQ object
     $faqObj = new sfFaq($faqid);
@@ -194,13 +194,13 @@ 
     }
 
     // Storing the FAQ object in the database
-    if ( !$faqObj->store() ) {
+    if (!$faqObj->store()) {
         redirect_header("javascript:history.go(-1)", 2, _AM_SF_ERROR_FAQ_NOT_SAVED);
         exit();
     }
 
     // Storing the answer object in the database
-    if ( !$answerObj->store() ) {
+    if (!$answerObj->store()) {
         redirect_header("javascript:history.go(-1)", 2, _AM_SF_ERROR_ANSWER_NOT_SAVED);
         exit();
     }
@@ -222,11 +222,11 @@ 
     case "del":
     Global $xoopsUser, $xoopsUser, $xoopsConfig, $xoopsDB;
 
-    $faqid = isset($_POST['faqid'])? intval($_POST['faqid']) : 0;
-    $faqid = isset($_GET['faqid'])? intval($_GET['faqid']) : $faqid;
-    $answerid = isset($_POST['answerid'])? intval($_POST['answerid']) : 0;
-    $answerid = isset($_GET['answerid'])? intval($_GET['answerid']) : $answerid;
-    $confirm = isset($_POST['confirm'])? intval($_POST['confirm']) : 0;
+    $faqid = isset($_POST['faqid']) ? intval($_POST['faqid']) : 0;
+    $faqid = isset($_GET['faqid']) ? intval($_GET['faqid']) : $faqid;
+    $answerid = isset($_POST['answerid']) ? intval($_POST['answerid']) : 0;
+    $answerid = isset($_GET['answerid']) ? intval($_GET['answerid']) : $answerid;
+    $confirm = isset($_POST['confirm']) ? intval($_POST['confirm']) : 0;
     $faqObj = new sfFaq($faqid);
     $answerObj = new sfAnswer($answerid);
     if ($confirm) {
@@ -245,7 +245,7 @@ 
             $proposed_answers = $answer_handler->getAllAnswers($faqid, _SF_AN_STATUS_PROPOSED);
             if (count($proposed_answers) > 0) {
                 // This question has other proposed answer
-                $redirect_page = "answer.php?op=mod&faqid=" . $faqid;
+                $redirect_page = "answer.php?op=mod&faqid=".$faqid;
                 $redirect_msg = _AM_SF_ANSWER_REJECTED;
             } else {
                 // The question has no other proposed answer
@@ -270,11 +270,11 @@ 
     default:
     xoops_cp_header();
 
-    include_once XOOPS_ROOT_PATH . "/class/xoopsformloader.php";
+    include_once XOOPS_ROOT_PATH."/class/xoopsformloader.php";
     global $xoopsUser, $xoopsUser, $xoopsConfig, $xoopsDB, $xoopsModuleConfig, $xoopsModule;
 
     editfaq();
     break;
 }
 
-include_once __DIR__ . '/admin_footer.php';
+include_once __DIR__.'/admin_footer.php';

Braces +6 added lines, -2 removed lines

@@ -12,8 +12,12 @@
 $op = '';
 
 // Getting the operation we are doing
-if (isset($_GET['op'])) $op = $_GET['op'];
-if (isset($_POST['op'])) $op = $_POST['op'];
+if (isset($_GET['op'])) {
+    $op = $_GET['op'];
+}
+if (isset($_POST['op'])) {
+    $op = $_POST['op'];
+}
 
 // Creating the answer handler object
 $answer_handler =& sf_gethandler('answer');

smartfaq/admin/faq.php

Indentation +13 added lines, -13 removed lines

@@ -195,19 +195,19 @@
 
 
 $editorTray = new XoopsFormElementTray(_AM_SF_ANSWER_FAQ, '<br />');
-   if (class_exists('XoopsFormEditor')) {
-           $options['name'] = 'answer';
-           $options['value'] = $theanswer;
-           $options['rows'] = 5;
-           $options['cols'] = '100%';
-           $options['width'] = '100%';
-           $options['height'] = '200px';
-       $answerEditor  = new XoopsFormEditor('', $xoopsModuleConfig['form_editorOptions'], $options, $nohtml = false, $onfailure = 'textarea');
-           $editorTray->addElement($answerEditor,true );
-       } else {
-       $answerEditor  = new XoopsFormDhtmlTextArea(_AM_SF_ANSWER_FAQ, 'answer', $theanswer, '100%', '100%');
-       $editorTray->addElement($answerEditor,true );
-   }
+    if (class_exists('XoopsFormEditor')) {
+            $options['name'] = 'answer';
+            $options['value'] = $theanswer;
+            $options['rows'] = 5;
+            $options['cols'] = '100%';
+            $options['width'] = '100%';
+            $options['height'] = '200px';
+        $answerEditor  = new XoopsFormEditor('', $xoopsModuleConfig['form_editorOptions'], $options, $nohtml = false, $onfailure = 'textarea');
+            $editorTray->addElement($answerEditor,true );
+        } else {
+        $answerEditor  = new XoopsFormDhtmlTextArea(_AM_SF_ANSWER_FAQ, 'answer', $theanswer, '100%', '100%');
+        $editorTray->addElement($answerEditor,true );
+    }
 
 $sform->addElement($editorTray);
 

Spacing +75 added lines, -75 removed lines

@@ -7,29 +7,29 @@ 
 * Licence: GNU
 */
 
-include_once __DIR__ . '/admin_header.php';
+include_once __DIR__.'/admin_header.php';
 
 // Creating the faq handler object
-$faq_handler =& sf_gethandler('faq');
+$faq_handler = & sf_gethandler('faq');
 
 // Creating the category handler object
-$category_handler =& sf_gethandler('category');
+$category_handler = & sf_gethandler('category');
 
 // Creating the answer handler object
-$answer_handler =& sf_gethandler('answer');
+$answer_handler = & sf_gethandler('answer');
 
 $op = '';
 if (isset($_GET['op'])) $op = $_GET['op'];
 if (isset($_POST['op'])) $op = $_POST['op'];
 
 // Where shall we start?
-$startfaq = isset($_GET['startfaq'])? intval($_GET['startfaq']) : 0;
+$startfaq = isset($_GET['startfaq']) ? intval($_GET['startfaq']) : 0;
 
-function editfaq($showmenu = false, $faqid = -1, $answerid = -1, $merge=false)
+function editfaq($showmenu = false, $faqid = -1, $answerid = -1, $merge = false)
 {
     global $answer_handler, $faq_handler, $category_handler, $xoopsUser, $xoopsUser, $xoopsConfig, $xoopsDB, $modify, $xoopsModuleConfig, $xoopsModule, $XOOPS_URL, $myts;
 
-    include_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
+    include_once XOOPS_ROOT_PATH.'/class/xoopsformloader.php';
     // If there is a parameter, and the id exists, retrieve data: we're editing a faq
     if ($faqid != -1) {
         // Creating the FAQ object
@@ -42,20 +42,20 @@ 
 
         if ($answerid == -1) {
             // Creating the object for the official answer
-            $answerObj =& $faqObj->answer();
+            $answerObj = & $faqObj->answer();
             if (!$answerObj) {
                 $answerObj = $answer_handler->create();
             }
         } else {
             $answerObj = new sfAnswer($answerid);
-            $originalAnswerObj =& $faqObj->answer();
+            $originalAnswerObj = & $faqObj->answer();
         }
 
         switch ($faqObj->status()) {
 
             case _SF_STATUS_ASKED :
-            $breadcrumb_action1 =    _AM_SF_ASKED;
-            $breadcrumb_action2 =    _AM_SF_APPROVING;
+            $breadcrumb_action1 = _AM_SF_ASKED;
+            $breadcrumb_action2 = _AM_SF_APPROVING;
             $collapsableBar_title = _AM_SF_ASKED_TITLE;
             $collapsableBar_info = _AM_SF_ASKED_TITLE_INFO;
             $button_caption = _AM_SF_PUBLISHED;
@@ -64,8 +64,8 @@ 
             break;
 
             case _SF_STATUS_ANSWERED :
-            $breadcrumb_action1 =    _AM_SF_ANSWERED;
-            $breadcrumb_action2 =    _AM_SF_APPROVING;
+            $breadcrumb_action1 = _AM_SF_ANSWERED;
+            $breadcrumb_action2 = _AM_SF_APPROVING;
             $collapsableBar_title = _AM_SF_ANSWERED_TITLE;
             $collapsableBar_info = _AM_SF_ANSWERED_TITLE_INFO;
             $button_caption = _AM_SF_APPROVE;
@@ -73,8 +73,8 @@ 
             break;
 
             case _SF_STATUS_SUBMITTED :
-            $breadcrumb_action1 =    _AM_SF_SUBMITTED;
-            $breadcrumb_action2 =    _AM_SF_APPROVING;
+            $breadcrumb_action1 = _AM_SF_SUBMITTED;
+            $breadcrumb_action2 = _AM_SF_APPROVING;
             $collapsableBar_title = _AM_SF_SUBMITTED_TITLE;
             $collapsableBar_info = _AM_SF_SUBMITTED_INFO;
             $button_caption = _AM_SF_APPROVE;
@@ -82,8 +82,8 @@ 
             break;
 
             case _SF_STATUS_PUBLISHED :
-            $breadcrumb_action1 =    _AM_SF_PUBLISHED;
-            $breadcrumb_action2 =    _AM_SF_EDITING;
+            $breadcrumb_action1 = _AM_SF_PUBLISHED;
+            $breadcrumb_action2 = _AM_SF_EDITING;
             $collapsableBar_title = _AM_SF_PUBLISHEDEDITING;
             $collapsableBar_info = _AM_SF_PUBLISHEDEDITING_INFO;
             $button_caption = _AM_SF_MODIFY;
@@ -91,8 +91,8 @@ 
             break;
 
             case _SF_STATUS_OFFLINE :
-            $breadcrumb_action1 =    _AM_SF_OFFLINE;
-            $breadcrumb_action2 =    _AM_SF_EDITING;
+            $breadcrumb_action1 = _AM_SF_OFFLINE;
+            $breadcrumb_action2 = _AM_SF_EDITING;
             $collapsableBar_title = _AM_SF_OFFLINEEDITING;
             $collapsableBar_info = _AM_SF_OFFLINEEDITING_INFO;
             $button_caption = _AM_SF_MODIFY;
@@ -100,8 +100,8 @@ 
             break;
 
             case _SF_STATUS_OPENED :
-            $breadcrumb_action1 =    _AM_SF_OPEN_QUESTIONS;
-            $breadcrumb_action2 =    _AM_SF_ANSWERING;
+            $breadcrumb_action1 = _AM_SF_OPEN_QUESTIONS;
+            $breadcrumb_action2 = _AM_SF_ANSWERING;
             $collapsableBar_title = _AM_SF_OPEN_QUESTION_ANSWERING;
             $collapsableBar_info = _AM_SF_OPEN_QUESTION_ANSWERING_INFO;
             $button_caption = _AM_SF_PUBLISH;
@@ -110,8 +110,8 @@ 
             break;
 
             case _SF_STATUS_NEW_ANSWER :
-            $breadcrumb_action1 =    _AM_SF_PUBLISHED;
-            $breadcrumb_action2 =    _AM_SF_EDITING;
+            $breadcrumb_action1 = _AM_SF_PUBLISHED;
+            $breadcrumb_action2 = _AM_SF_EDITING;
             $collapsableBar_title = _AM_SF_NEW_ANSWER_EDITING;
             $collapsableBar_info = _AM_SF_NEW_ANSWER_EDITING_INFO;
             $button_caption = _AM_SF_PUBLISH;
@@ -129,7 +129,7 @@ 
         }		*/
 
         // Creating the category of this FAQ
-        $categoryObj =& $faqObj->category();
+        $categoryObj = & $faqObj->category();
 
         if ($showmenu) {
             //sf_adminMenu(2, $breadcrumb_action1 . " > " . $breadcrumb_action2);
@@ -137,15 +137,15 @@ 
 
         echo "<br />\n";
         sf_collapsableBar('bottomtable', 'bottomtableicon');
-        echo "<img id='bottomtableicon' src=" . XOOPS_URL . "/modules/" . $xoopsModule->dirname() . "/assets/images/icon/close12.gif alt='' /></a>&nbsp;" . $collapsableBar_title . "</h3>";
+        echo "<img id='bottomtableicon' src=".XOOPS_URL."/modules/".$xoopsModule->dirname()."/assets/images/icon/close12.gif alt='' /></a>&nbsp;".$collapsableBar_title."</h3>";
         echo "<div id='bottomtable'>";
-        echo "<span style=\"color: #567; margin: 3px 0 12px 0; font-size: small; display: block; \">" . $collapsableBar_info . "</span>";
+        echo "<span style=\"color: #567; margin: 3px 0 12px 0; font-size: small; display: block; \">".$collapsableBar_info."</span>";
     } else {
         // there's no parameter, so we're adding a faq
-        $faqObj =& $faq_handler->create();
+        $faqObj = & $faq_handler->create();
         $faqObj->setVar('uid', $xoopsUser->getVar('uid'));
-        $categoryObj =& $category_handler->create();
-        $answerObj =& $answer_handler->create();
+        $categoryObj = & $category_handler->create();
+        $answerObj = & $answer_handler->create();
         $answerObj->setVar('uid', $xoopsUser->getVar('uid'));
 
         $breadcrumb_action1 = _AM_SF_SMARTFAQS;
@@ -155,7 +155,7 @@ 
             //sf_adminMenu(2, $breadcrumb_action1 . " > " . $breadcrumb_action2);
         }
         sf_collapsableBar('bottomtable', 'bottomtableicon');
-        echo "<img id='bottomtableicon' src=" . XOOPS_URL . "/modules/" . $xoopsModule->dirname() . "/assets/images/icon/close12.gif alt='' /></a>&nbsp;" . _AM_SF_CREATESMARTFAQ . "</h3>";
+        echo "<img id='bottomtableicon' src=".XOOPS_URL."/modules/".$xoopsModule->dirname()."/assets/images/icon/close12.gif alt='' /></a>&nbsp;"._AM_SF_CREATESMARTFAQ."</h3>";
         echo "<div id='bottomtable'>";
     }
     $sform = new XoopsThemeForm(_AM_SF_SMARTFAQ, "op", xoops_getenv('PHP_SELF'));
@@ -175,7 +175,7 @@ 
     * Last one is not set as we do not have sub menus in Smartfaq
     */
 
-    $mytree = new XoopsTree($xoopsDB->prefix("smartfaq_categories"), "categoryid" , "parentid");
+    $mytree = new XoopsTree($xoopsDB->prefix("smartfaq_categories"), "categoryid", "parentid");
     ob_start();
     $mytree->makeMySelBox("name", "weight", $categoryObj->categoryid());
     $sform->addElement(new XoopsFormLabel(_AM_SF_CATEGORY_FAQ, ob_get_contents()));
@@ -186,7 +186,7 @@ 
 
     // ANSWER
     if ($merge) {
-        $theanswer = $originalAnswerObj->answer('e') . "\n\n" . sprintf(_AM_SF_NEW_CONTRIBUTION,  sf_getLinkedUnameFromId($answerObj->uid(), $xoopsModuleConfig['userealname']), $answerObj->datesub(), $answerObj->answer('e'));
+        $theanswer = $originalAnswerObj->answer('e')."\n\n".sprintf(_AM_SF_NEW_CONTRIBUTION, sf_getLinkedUnameFromId($answerObj->uid(), $xoopsModuleConfig['userealname']), $answerObj->datesub(), $answerObj->answer('e'));
     } else {
         $theanswer = $answerObj->answer('e');
     }
@@ -203,10 +203,10 @@ 
            $options['width'] = '100%';
            $options['height'] = '200px';
        $answerEditor  = new XoopsFormEditor('', $xoopsModuleConfig['form_editorOptions'], $options, $nohtml = false, $onfailure = 'textarea');
-           $editorTray->addElement($answerEditor,true );
+           $editorTray->addElement($answerEditor, true);
        } else {
        $answerEditor  = new XoopsFormDhtmlTextArea(_AM_SF_ANSWER_FAQ, 'answer', $theanswer, '100%', '100%');
-       $editorTray->addElement($answerEditor,true );
+       $editorTray->addElement($answerEditor, true);
    }
 
 $sform->addElement($editorTray);
@@ -227,7 +227,7 @@ 
 
     $modulelink_select = new XoopsFormSelect('', 'modulelink', $faqObj->modulelink());
     $modulelink_select->addOptionArray($modulelink_select_array);
-    $modulelink_tray = new XoopsFormElementTray(_AM_SF_CONTEXTMODULELINK_FAQ , '&nbsp;');
+    $modulelink_tray = new XoopsFormElementTray(_AM_SF_CONTEXTMODULELINK_FAQ, '&nbsp;');
     $modulelink_tray->addElement($modulelink_select);
     $sform->addElement($modulelink_tray);
 
@@ -235,14 +235,14 @@ 
     $sform->addElement(new XoopsFormText(_AM_SF_SPECIFIC_URL, 'contextpage', 50, 60, $faqObj->contextpage()), false);
 
     // EXACT URL?
-    $excaturl_radio = new XoopsFormRadioYN(_AM_SF_EXACTURL, 'exacturl', $faqObj->exacturl(), ' ' . _AM_SF_YES . '', ' ' . _AM_SF_NO . '');
+    $excaturl_radio = new XoopsFormRadioYN(_AM_SF_EXACTURL, 'exacturl', $faqObj->exacturl(), ' '._AM_SF_YES.'', ' '._AM_SF_NO.'');
     $sform->addElement($excaturl_radio);
     // WEIGHT
     $sform->addElement(new XoopsFormText(_AM_SF_WEIGHT, 'weight', 5, 5, $faqObj->weight()), true);
 
     // COMMENTS
     // Code to allow comments
-    $addcomments_radio = new XoopsFormRadioYN(_AM_SF_ALLOWCOMMENTS, 'cancomment', $faqObj->cancomment(), ' ' . _AM_SF_YES . '', ' ' . _AM_SF_NO . '');
+    $addcomments_radio = new XoopsFormRadioYN(_AM_SF_ALLOWCOMMENTS, 'cancomment', $faqObj->cancomment(), ' '._AM_SF_YES.'', ' '._AM_SF_NO.'');
     $sform->addElement($addcomments_radio);
 
     // PER ITEM PERMISSIONS
@@ -256,7 +256,7 @@ 
     }
     $sform->addElement($groups_checkbox);
 
-    $partial_view = new XoopsFormRadioYN(_AM_SF_PARTIALVIEW, 'partialview', $faqObj->partialview(), ' ' . _AM_SF_YES . '', ' ' . _AM_SF_NO . '');
+    $partial_view = new XoopsFormRadioYN(_AM_SF_PARTIALVIEW, 'partialview', $faqObj->partialview(), ' '._AM_SF_YES.'', ' '._AM_SF_NO.'');
     $sform->addElement($partial_view);
 
     // VARIOUS OPTIONS
@@ -277,9 +277,9 @@ 
     $sform->addElement($options_tray);
 
     // OFFLINE
-    if ( $faqObj->status() == _SF_STATUS_OFFLINE ) {
+    if ($faqObj->status() == _SF_STATUS_OFFLINE) {
         // Back OnLine
-        $offline_radio = new XoopsFormRadioYN(_AM_SF_OFFLINE_FIELD, 'offline', 1, ' ' . _AM_SF_YES . '', ' ' . _AM_SF_NO . '');
+        $offline_radio = new XoopsFormRadioYN(_AM_SF_OFFLINE_FIELD, 'offline', 1, ' '._AM_SF_YES.'', ' '._AM_SF_NO.'');
         $sform->addElement($offline_radio);
     }
 
@@ -343,8 +343,8 @@ 
 switch ($op) {
     case "merge":
 
-    $faqid = (isset($_GET['faqid']))? $_GET['faqid'] : -1;
-    $answerid = (isset($_GET['answerid']))? $_GET['answerid'] : -1;
+    $faqid = (isset($_GET['faqid'])) ? $_GET['faqid'] : -1;
+    $answerid = (isset($_GET['answerid'])) ? $_GET['answerid'] : -1;
     if ($faqid == -1) {
         $totalcategories = $category_handler->getCategoriesCount(-1);
         if ($totalcategories == 0) {
@@ -354,7 +354,7 @@ 
     }
 
     xoops_cp_header();
-    include_once XOOPS_ROOT_PATH . "/class/xoopsformloader.php";
+    include_once XOOPS_ROOT_PATH."/class/xoopsformloader.php";
 
     editfaq(true, $faqid, $answerid, true);
     break;
@@ -362,8 +362,8 @@ 
     case "mod":
 
     Global $xoopsUser, $xoopsUser, $xoopsConfig, $xoopsDB, $xoopsModuleConfig, $xoopsModule, $modify, $myts;
-    $faqid = (isset($_GET['faqid']))? $_GET['faqid'] : -1;
-    $answerid = (isset($_GET['answerid']))? $_GET['answerid'] : -1;
+    $faqid = (isset($_GET['faqid'])) ? $_GET['faqid'] : -1;
+    $answerid = (isset($_GET['answerid'])) ? $_GET['answerid'] : -1;
     if ($faqid == -1) {
         $totalcategories = $category_handler->getCategoriesCount(-1);
         if ($totalcategories == 0) {
@@ -376,7 +376,7 @@ 
     xoops_cp_header();
 
     echo $indexAdmin->addNavigation('faq.php');
-    include_once XOOPS_ROOT_PATH . "/class/xoopsformloader.php";
+    include_once XOOPS_ROOT_PATH."/class/xoopsformloader.php";
 
     editfaq(true, $faqid, $answerid);
     break;
@@ -384,14 +384,14 @@ 
     case "addfaq":
     global $xoopsUser;
 
-    $faqid = (isset($_POST['faqid']))? intval($_POST['faqid']) : -1;
-    $requester_uid = (isset($_POST['requester_uid']))? intval($_POST['requester_uid']) : 0;
-    $answerer_uid = (isset($_POST['answerer_uid']))? intval($_POST['answerer_uid']) : 0;
+    $faqid = (isset($_POST['faqid'])) ? intval($_POST['faqid']) : -1;
+    $requester_uid = (isset($_POST['requester_uid'])) ? intval($_POST['requester_uid']) : 0;
+    $answerer_uid = (isset($_POST['answerer_uid'])) ? intval($_POST['answerer_uid']) : 0;
 
     // Creating the FAQ and answer objects
     if ($faqid != -1) {
         $faqObj = new sfFaq($faqid);
-        $answerObj =& $faqObj -> answer();
+        $answerObj = & $faqObj -> answer();
         // If the FAQ does not have an answer, then it's an answered opened question
         if (!$answerObj) {
             echo "error in faq.php...200412111827";
@@ -407,23 +407,23 @@ 
     } else {
         $faqObj->setGroups_read();
     }
-    $faqObj->setVar('categoryid', (isset($_POST['categoryid']))? intval($_POST['categoryid']) : 0);
+    $faqObj->setVar('categoryid', (isset($_POST['categoryid'])) ? intval($_POST['categoryid']) : 0);
     $faqObj->setVar('question', $_POST['question']);
     $faqObj->setVar('howdoi', $_POST['howdoi']);
     $faqObj->setVar('diduno', $_POST['diduno']);
 
-    $faqObj->setVar('status', (isset($_POST['status']))? intval($_POST['status']) : _SF_STATUS_ASKED);
+    $faqObj->setVar('status', (isset($_POST['status'])) ? intval($_POST['status']) : _SF_STATUS_ASKED);
 
     // If this SmartFAQ is offline and the user set this option to No
-    $offline = (isset($_POST['offline']))? $_POST['offline'] : 1;
-    if ( ($faqObj->status() == _SF_STATUS_OFFLINE) && ($offline == 0) ) {
+    $offline = (isset($_POST['offline'])) ? $_POST['offline'] : 1;
+    if (($faqObj->status() == _SF_STATUS_OFFLINE) && ($offline == 0)) {
         $faqObj->setVar('status', _SF_STATUS_PUBLISHED);
     }
-    $faqObj->setVar('weight', (isset($_POST['weight']))? intval($_POST['weight']) : $faqObj->weight());
-    $faqObj->setVar('html', (isset($_POST['html']))? intval($_POST['html']) : 0);
-    $faqObj->setVar('smiley', (isset($_POST['smiley']))? intval($_POST['smiley']) : 0);
-    $faqObj->setVar('xcodes', (isset($_POST['xcodes']))? intval($_POST['xcodes']) : 0);
-    $faqObj->setVar('cancomment', (isset($_POST['cancomment']))? intval($_POST['cancomment']) : 0);
+    $faqObj->setVar('weight', (isset($_POST['weight'])) ? intval($_POST['weight']) : $faqObj->weight());
+    $faqObj->setVar('html', (isset($_POST['html'])) ? intval($_POST['html']) : 0);
+    $faqObj->setVar('smiley', (isset($_POST['smiley'])) ? intval($_POST['smiley']) : 0);
+    $faqObj->setVar('xcodes', (isset($_POST['xcodes'])) ? intval($_POST['xcodes']) : 0);
+    $faqObj->setVar('cancomment', (isset($_POST['cancomment'])) ? intval($_POST['cancomment']) : 0);
     $faqObj->setVar('modulelink', $_POST['modulelink']);
     $faqObj->setVar('contextpage', $_POST['contextpage']);
     $faqObj->setVar('exacturl', $_POST['exacturl']);
@@ -506,15 +506,15 @@ 
     $answerObj->setVar('uid', $answerer_uid);
 
     // Storing the FAQ
-    if ( !$faqObj->store() ) {
-        redirect_header("javascript:history.go(-1)", 3, $error_msg . sf_formatErrors($faqObj->getErrors()));
+    if (!$faqObj->store()) {
+        redirect_header("javascript:history.go(-1)", 3, $error_msg.sf_formatErrors($faqObj->getErrors()));
         exit;
     }
 
     // Storing the answer
     $answerObj->setVar('faqid', $faqObj->faqid());
-    if ( !$answerObj->store() ) {
-        redirect_header("javascript:history.go(-1)", 3, $error_msg . sf_formatErrors($answerObj->getErrors()));
+    if (!$answerObj->store()) {
+        redirect_header("javascript:history.go(-1)", 3, $error_msg.sf_formatErrors($answerObj->getErrors()));
         exit;
     }
 
@@ -534,17 +534,17 @@ 
     $module_id = $xoopsModule->getVar('mid');
     $gperm_handler = &xoops_gethandler('groupperm');
 
-    $faqid = (isset($_POST['faqid']))? intval($_POST['faqid']) : 0;
-    $faqid = (isset($_GET['faqid']))? intval($_GET['faqid']) : $faqid;
+    $faqid = (isset($_POST['faqid'])) ? intval($_POST['faqid']) : 0;
+    $faqid = (isset($_GET['faqid'])) ? intval($_GET['faqid']) : $faqid;
 
     $faqObj = new sfFaq($faqid);
 
-    $confirm = (isset($_POST['confirm']))? $_POST['confirm'] : 0;
-    $question = (isset($_POST['question']))? $_POST['question'] : '';
+    $confirm = (isset($_POST['confirm'])) ? $_POST['confirm'] : 0;
+    $question = (isset($_POST['question'])) ? $_POST['question'] : '';
 
     if ($confirm) {
-        if ( !$faq_handler->delete($faqObj)) {
-            redirect_header("faq.php", 2, _AM_SF_FAQ_DELETE_ERROR . sf_formatErrors($faqObj->getErrors()));
+        if (!$faq_handler->delete($faqObj)) {
+            redirect_header("faq.php", 2, _AM_SF_FAQ_DELETE_ERROR.sf_formatErrors($faqObj->getErrors()));
             exit;
         }
 
@@ -552,9 +552,9 @@ 
         exit();
     } else {
         // no confirm: show deletion condition
-        $faqid = (isset($_GET['faqid']))? intval($_GET['faqid']) : 0;
+        $faqid = (isset($_GET['faqid'])) ? intval($_GET['faqid']) : 0;
         xoops_cp_header();
-        xoops_confirm(array('op' => 'del', 'faqid' => $faqObj->faqid(), 'confirm' => 1, 'name' => $faqObj->question()), 'faq.php', _AM_SF_DELETETHISARTICLE . " <br />'" . $faqObj->question() . "'. <br /> <br />", _AM_SF_DELETE);
+        xoops_confirm(array('op' => 'del', 'faqid' => $faqObj->faqid(), 'confirm' => 1, 'name' => $faqObj->question()), 'faq.php', _AM_SF_DELETETHISARTICLE." <br />'".$faqObj->question()."'. <br /> <br />", _AM_SF_DELETE);
         xoops_cp_footer();
     }
 
@@ -570,10 +570,10 @@ 
 
     //sf_adminMenu(2, _AM_SF_SMARTFAQS);
 
-    include_once XOOPS_ROOT_PATH . "/class/xoopsformloader.php";
-    include_once XOOPS_ROOT_PATH . '/class/pagenav.php';
+    include_once XOOPS_ROOT_PATH."/class/xoopsformloader.php";
+    include_once XOOPS_ROOT_PATH.'/class/pagenav.php';
 
-    include_once XOOPS_ROOT_PATH . "/modules/smartfaq/include/displayfaqs.php";
+    include_once XOOPS_ROOT_PATH."/modules/smartfaq/include/displayfaqs.php";
 
     $totalcategories = $category_handler->getCategoriesCount(-1);
     if ($totalcategories > 0) {
@@ -583,4 +583,4 @@ 
     break;
 }
 
-include_once __DIR__ . '/admin_footer.php';
+include_once __DIR__.'/admin_footer.php';

Braces +6 added lines, -2 removed lines

@@ -19,8 +19,12 @@
 $answer_handler =& sf_gethandler('answer');
 
 $op = '';
-if (isset($_GET['op'])) $op = $_GET['op'];
-if (isset($_POST['op'])) $op = $_POST['op'];
+if (isset($_GET['op'])) {
+    $op = $_GET['op'];
+}
+if (isset($_POST['op'])) {
+    $op = $_POST['op'];
+}
 
 // Where shall we start?
 $startfaq = isset($_GET['startfaq'])? intval($_GET['startfaq']) : 0;