mambax7 / smartfaq

smartfaq/admin/mygrouppermform.php

Doc Comments +7 added lines

@@ -85,6 +85,10 @@ 
 
     /**
      * Constructor
+     * @param string $title
+     * @param integer $modid
+     * @param string $permname
+     * @param string $permdesc
      */
     function MyXoopsGroupPermForm($title, $modid, $permname, $permdesc)
     {
@@ -117,6 +121,8 @@ 
      * Add appendix
      *
      * @access public
+     * @param string $permName
+     * @param string $itemName
      */
     function addAppendix($permName,$itemId,$itemName)
     {
@@ -249,6 +255,7 @@ 
 
     /**
      * Constructor
+     * @param string $name
      */
     function MyXoopsGroupFormCheckBox($caption, $name, $groupId, $values = null)
     {

Spacing +25 added lines, -25 removed lines

@@ -81,7 +81,7 @@ 
      * Appendix
      * @var array ('permname'=>,'itemid'=>,'itemname'=>,'selected'=>)
      */
-    var $_appendix = array() ;
+    var $_appendix = array();
 
     /**
      * Constructor
@@ -89,7 +89,7 @@ 
     function MyXoopsGroupPermForm($title, $modid, $permname, $permdesc)
     {
 //		$this->XoopsForm($title, 'groupperm_form', XOOPS_URL.'/modules/system/admin/groupperm.php', 'post'); GIJ
-        $this->XoopsForm($title, 'groupperm_form', '' , 'post');
+        $this->XoopsForm($title, 'groupperm_form', '', 'post');
         $this->_modid = intval($modid);
         $this->_permName = $permname;
         $this->_permDesc = $permdesc;
@@ -118,9 +118,9 @@ 
      *
      * @access public
      */
-    function addAppendix($permName,$itemId,$itemName)
+    function addAppendix($permName, $itemId, $itemName)
     {
-        $this->_appendix[] = array('permname'=>$permName,'itemid'=>$itemId,'itemname'=>$itemName,'selected'=>false);
+        $this->_appendix[] = array('permname'=>$permName, 'itemid'=>$itemId, 'itemname'=>$itemName, 'selected'=>false);
     }
 
     /**
@@ -159,9 +159,9 @@ 
             $this->_itemTree[$item_id]['allchild'] = array();
             $this->_loadAllChildItemIds($item_id, $this->_itemTree[$item_id]['allchild']);
         }
-        $gperm_handler =& xoops_gethandler('groupperm');
-        $member_handler =& xoops_gethandler('member');
-        $glist =& $member_handler->getGroupList();
+        $gperm_handler = & xoops_gethandler('groupperm');
+        $member_handler = & xoops_gethandler('member');
+        $glist = & $member_handler->getGroupList();
         foreach (array_keys($glist) as $i) {
             // get selected item id(s) for each group
             $selected = $gperm_handler->getItemIds($this->_permName, $i, $this->_modid);
@@ -169,7 +169,7 @@ 
             $ele->setOptionTree($this->_itemTree);
 
             foreach ($this->_appendix as $key => $append) {
-                $this->_appendix[$key]['selected'] = $gperm_handler->checkRight($append['permname'], $append['itemid'], $i, $this->_modid ) ;
+                $this->_appendix[$key]['selected'] = $gperm_handler->checkRight($append['permname'], $append['itemid'], $i, $this->_modid);
             }
             $ele->setAppendix($this->_appendix);
             $this->addElement($ele);
@@ -179,11 +179,11 @@ 
         // GIJ start
         $jstray = new XoopsFormElementTray('   ');
         $jsuncheckbutton = new XoopsFormButton('', 'none', _NONE, 'button');
-        $jsuncheckbutton->setExtra( "onclick=\"with(document.groupperm_form){for (i=0;i<length;i++) {if (elements[i].type=='checkbox') {elements[i].checked=false;}}}\"" ) ;
+        $jsuncheckbutton->setExtra("onclick=\"with(document.groupperm_form){for (i=0;i<length;i++) {if (elements[i].type=='checkbox') {elements[i].checked=false;}}}\"");
         $jscheckbutton = new XoopsFormButton('', 'all', _ALL, 'button');
-        $jscheckbutton->setExtra( "onclick=\"with(document.groupperm_form){for (i=0;i<length;i++) {if (elements[i].type=='checkbox' && (elements[i].name.indexOf('module_admin')<0 || elements[i].name.indexOf('[groups][1]')>=0)) {elements[i].checked=true;}}}\"" ) ;
-        $jstray->addElement( $jsuncheckbutton ) ;
-        $jstray->addElement( $jscheckbutton ) ;
+        $jscheckbutton->setExtra("onclick=\"with(document.groupperm_form){for (i=0;i<length;i++) {if (elements[i].type=='checkbox' && (elements[i].name.indexOf('module_admin')<0 || elements[i].name.indexOf('[groups][1]')>=0)) {elements[i].checked=true;}}}\"");
+        $jstray->addElement($jsuncheckbutton);
+        $jstray->addElement($jscheckbutton);
         $this->addElement($jstray);
         // GIJ end
 
@@ -194,7 +194,7 @@ 
 
         $ret = '<h4>'.$this->getTitle().'</h4>'.$this->_permDesc.'<br />';
         $ret .= "<form name='".$this->getName()."' id='".$this->getName()."' action='".$this->getAction()."' method='".$this->getMethod()."'".$this->getExtra().">\n<table width='100%' class='outer' cellspacing='1'>\n";
-        $elements =& $this->getElements();
+        $elements = & $this->getElements();
         foreach (array_keys($elements) as $i) {
             if (!is_object($elements[$i])) {
                 $ret .= $elements[$i];
@@ -245,7 +245,7 @@ 
      * Appendix
      * @var array ('permname'=>,'itemid'=>,'itemname'=>,'selected'=>)
      */
-    var $_appendix = array() ;
+    var $_appendix = array();
 
     /**
      * Constructor
@@ -285,7 +285,7 @@ 
      */
     function setOptionTree(&$optionTree)
     {
-        $this->_optionTree =& $optionTree;
+        $this->_optionTree = & $optionTree;
     }
 
     /**
@@ -295,7 +295,7 @@ 
      */
     function setAppendix($appendix)
     {
-        $this->_appendix = $appendix ;
+        $this->_appendix = $appendix;
     }
 
     /**
@@ -306,9 +306,9 @@ 
      */
     function render()
     {
-        $ret = '' ;
+        $ret = '';
 
-        if ( sizeof( $this->_appendix ) > 0 ) {
+        if (sizeof($this->_appendix) > 0) {
             $ret .= '<table class="outer"><tr>';
             $cols = 1;
             foreach ($this->_appendix as $append) {
@@ -316,11 +316,11 @@ 
                     $ret .= '</tr><tr>';
                     $cols = 1;
                 }
-                $checked = $append['selected']? 'checked="checked"' : '' ;
-                $name = 'perms['.$append['permname'].']' ;
-                $itemid = $append['itemid'] ;
-                $itemid = $append['itemid'] ;
-                $ret .= "<td class=\"odd\"><input type=\"checkbox\" name=\"{$name}[groups][$this->_groupId][$itemid]\" id=\"{$name}[groups][$this->_groupId][$itemid]\" value=\"1\" $checked />{$append['itemname']}<input type=\"hidden\" name=\"{$name}[parents][$itemid]\" value=\"\" /><input type=\"hidden\" name=\"{$name}[itemname][$itemid]\" value=\"{$append['itemname']}\" /><br /></td>" ;
+                $checked = $append['selected'] ? 'checked="checked"' : '';
+                $name = 'perms['.$append['permname'].']';
+                $itemid = $append['itemid'];
+                $itemid = $append['itemid'];
+                $ret .= "<td class=\"odd\"><input type=\"checkbox\" name=\"{$name}[groups][$this->_groupId][$itemid]\" id=\"{$name}[groups][$this->_groupId][$itemid]\" value=\"1\" $checked />{$append['itemname']}<input type=\"hidden\" name=\"{$name}[parents][$itemid]\" value=\"\" /><input type=\"hidden\" name=\"{$name}[itemname][$itemid]\" value=\"{$append['itemname']}\" /><br /></td>";
                 ++$cols;
             }
             $ret .= '</tr></table>';
@@ -372,11 +372,11 @@ 
             $tree .= "var ele = xoopsGetElementById('".$child_ele."'); if (this.checked != true) {ele.checked = false;}";
         }
         $tree .= '" value="1"';
-        if ( isset( $this->_value ) && in_array($option['id'], $this->_value)) {
+        if (isset($this->_value) && in_array($option['id'], $this->_value)) {
             $tree .= ' checked="checked"';
         }
         $tree .= " />".$option['name']."<input type=\"hidden\" name=\"".$this->getName()."[parents][".$option['id']."]\" value=\"".implode(':', $parentIds)."\" /><input type=\"hidden\" name=\"".$this->getName()."[itemname][".$option['id']."]\" value=\"".htmlspecialchars($option['name'])."\" /><br />\n";
-        if ( isset( $option['children'] ) ) foreach ($option['children'] as $child) {
+        if (isset($option['children'])) foreach ($option['children'] as $child) {
             array_push($parentIds, $option['id']);
             $this->_renderOptionTree($tree, $this->_optionTree[$child], $prefix.'&nbsp;-', $parentIds);
         }

Braces +3 added lines, -1 removed lines

@@ -376,8 +376,10 @@
             $tree .= ' checked="checked"';
         }
         $tree .= " />".$option['name']."<input type=\"hidden\" name=\"".$this->getName()."[parents][".$option['id']."]\" value=\"".implode(':', $parentIds)."\" /><input type=\"hidden\" name=\"".$this->getName()."[itemname][".$option['id']."]\" value=\"".htmlspecialchars($option['name'])."\" /><br />\n";
-        if ( isset( $option['children'] ) ) foreach ($option['children'] as $child) {
+        if ( isset( $option['children'] ) ) {
+            foreach ($option['children'] as $child) {
             array_push($parentIds, $option['id']);
+        }
             $this->_renderOptionTree($tree, $this->_optionTree[$child], $prefix.'&nbsp;-', $parentIds);
         }
     }

smartfaq/class/answer.php

Doc Comments +3 added lines, -6 removed lines

@@ -24,6 +24,7 @@ 
     var $attachment_array = array();
     /**
     * constructor
+    * @param integer $id
     */
     function __construct ($id = null)
     {
@@ -297,7 +298,7 @@ 
     * create a new answer
     *
     * @param bool $isNew flag the new objects as "new"?
-    * @return object sfAnswer
+    * @return sfAnswer sfAnswer
     */
     function &create($isNew = true)
     {
@@ -338,7 +339,7 @@ 
     /**
     * insert a new answer in the database
     *
-    * @param object $answer reference to the {@link sfAnswer} object
+    * @param sfAnswer $answerObj reference to the {@link sfAnswer} object
     * @param bool $force
     * @return bool FALSE if failed, TRUE if already present and unchanged or successful
     */
@@ -414,8 +415,6 @@ 
     /**
     * delete an answer from the database
     *
-    * @param object $answer reference to the answer to delete
-    * @param bool $force
     * @return bool FALSE if failed.
     */
     function deleteFaqAnswers(&$faqObj)
@@ -476,7 +475,6 @@ 
     /**
     * retrieve 1 official answer (for now SmartFAQ only allow 1 official answer...)
     *
-    * @param object $criteria {@link CriteriaElement} conditions to be met
     * @param int $faqid
     * @return mixed reference to the {@link sfAnswer} object, FALSE if failed
     */
@@ -495,7 +493,6 @@ 
     /**
     * retrieve all answers
     *
-    * @param object $criteria {@link CriteriaElement} conditions to be met
     * @param int $faqid
     * @return array array of {@link sfAnswer} objects
     */

Indentation +73 added lines, -73 removed lines

@@ -23,8 +23,8 @@ 
 {
     var $attachment_array = array();
     /**
-    * constructor
-    */
+     * constructor
+     */
     function __construct ($id = null)
     {
         $this->db =& XoopsDatabaseFactory::getDatabaseConnection();
@@ -184,7 +184,7 @@ 
                 }
                 $post_attachment .= '<br />';
             }
-       }
+        }
 
         return $post_attachment;
     }
@@ -240,7 +240,7 @@ 
 
     function notLoaded()
     {
-       return ($this->getVar('answerid')== -1);
+        return ($this->getVar('answerid')== -1);
     }
 
     function sendNotifications($notifications=array())
@@ -294,11 +294,11 @@ 
 {
 
     /**
-    * create a new answer
-    *
-    * @param bool $isNew flag the new objects as "new"?
-    * @return object sfAnswer
-    */
+     * create a new answer
+     *
+     * @param bool $isNew flag the new objects as "new"?
+     * @return object sfAnswer
+     */
     function &create($isNew = true)
     {
         $answer = new sfAnswer();
@@ -310,11 +310,11 @@ 
     }
 
     /**
-    * retrieve an answer
-    *
-    * @param int $id answerid of the answer
-    * @return mixed reference to the {@link sfAnswer} object, FALSE if failed
-    */
+     * retrieve an answer
+     *
+     * @param int $id answerid of the answer
+     * @return mixed reference to the {@link sfAnswer} object, FALSE if failed
+     */
     function &get($id)
     {
         if (intval($id) > 0) {
@@ -336,12 +336,12 @@ 
     }
 
     /**
-    * insert a new answer in the database
-    *
-    * @param object $answer reference to the {@link sfAnswer} object
-    * @param bool $force
-    * @return bool FALSE if failed, TRUE if already present and unchanged or successful
-    */
+     * insert a new answer in the database
+     *
+     * @param object $answer reference to the {@link sfAnswer} object
+     * @param bool $force
+     * @return bool FALSE if failed, TRUE if already present and unchanged or successful
+     */
     function insert(&$answerObj, $force = false)
     {
         if (strtolower(get_class($answerObj)) != 'sfanswer') {
@@ -384,12 +384,12 @@ 
     }
 
     /**
-    * delete an answer from the database
-    *
-    * @param object $answer reference to the answer to delete
-    * @param bool $force
-    * @return bool FALSE if failed.
-    */
+     * delete an answer from the database
+     *
+     * @param object $answer reference to the answer to delete
+     * @param bool $force
+     * @return bool FALSE if failed.
+     */
     function delete(&$answer, $force = false)
     {
         if (strtolower(get_class($answer)) != 'sfanswer') {
@@ -412,12 +412,12 @@ 
     }
 
     /**
-    * delete an answer from the database
-    *
-    * @param object $answer reference to the answer to delete
-    * @param bool $force
-    * @return bool FALSE if failed.
-    */
+     * delete an answer from the database
+     *
+     * @param object $answer reference to the answer to delete
+     * @param bool $force
+     * @return bool FALSE if failed.
+     */
     function deleteFaqAnswers(&$faqObj)
     {
         if (strtolower(get_class($faqObj)) != 'sffaq') {
@@ -435,12 +435,12 @@ 
     }
 
     /**
-    * retrieve answers from the database
-    *
-    * @param object $criteria {@link CriteriaElement} conditions to be met
-    * @param bool $id_as_key use the answerid as key for the array?
-    * @return array array of {@link sfAnswer} objects
-    */
+     * retrieve answers from the database
+     *
+     * @param object $criteria {@link CriteriaElement} conditions to be met
+     * @param bool $id_as_key use the answerid as key for the array?
+     * @return array array of {@link sfAnswer} objects
+     */
     function &getObjects($criteria = null, $id_as_key = false)
     {
         $ret = array();
@@ -474,12 +474,12 @@ 
     }
 
     /**
-    * retrieve 1 official answer (for now SmartFAQ only allow 1 official answer...)
-    *
-    * @param object $criteria {@link CriteriaElement} conditions to be met
-    * @param int $faqid
-    * @return mixed reference to the {@link sfAnswer} object, FALSE if failed
-    */
+     * retrieve 1 official answer (for now SmartFAQ only allow 1 official answer...)
+     *
+     * @param object $criteria {@link CriteriaElement} conditions to be met
+     * @param int $faqid
+     * @return mixed reference to the {@link sfAnswer} object, FALSE if failed
+     */
     function &getOfficialAnswer($faqid=0)
     {
         $theaAnswers =& $this->getAllAnswers($faqid, _SF_AN_STATUS_APPROVED, 1, 0);
@@ -493,12 +493,12 @@ 
     }
 
     /**
-    * retrieve all answers
-    *
-    * @param object $criteria {@link CriteriaElement} conditions to be met
-    * @param int $faqid
-    * @return array array of {@link sfAnswer} objects
-    */
+     * retrieve all answers
+     *
+     * @param object $criteria {@link CriteriaElement} conditions to be met
+     * @param int $faqid
+     * @return array array of {@link sfAnswer} objects
+     */
     function &getAllAnswers($faqid=0, $status = -1, $limit = 0, $start = 0, $sort = 'datesub', $order = 'DESC')
     {
         $hasStatusCriteria = false;
@@ -531,11 +531,11 @@ 
     }
 
     /**
-    * count answers matching a condition
-    *
-    * @param object $criteria {@link CriteriaElement} to match
-    * @return int count of answers
-    */
+     * count answers matching a condition
+     *
+     * @param object $criteria {@link CriteriaElement} to match
+     * @return int count of answers
+     */
     function getCount($criteria = null)
     {
         $sql = 'SELECT COUNT(*) FROM '.$this->db->prefix('smartfaq_answers');
@@ -552,11 +552,11 @@ 
     }
 
     /**
-    * count answers matching a condition and group by faq ID
-    *
-    * @param object $criteria {@link CriteriaElement} to match
-    * @return array
-    */
+     * count answers matching a condition and group by faq ID
+     *
+     * @param object $criteria {@link CriteriaElement} to match
+     * @return array
+     */
     function getCountByFAQ($criteria = null)
     {
         $sql = 'SELECT faqid, COUNT(*) FROM '.$this->db->prefix('smartfaq_answers');
@@ -580,11 +580,11 @@ 
     }
 
     /**
-    * delete answers matching a set of conditions
-    *
-    * @param object $criteria {@link CriteriaElement}
-    * @return bool FALSE if deletion failed
-    */
+     * delete answers matching a set of conditions
+     *
+     * @param object $criteria {@link CriteriaElement}
+     * @return bool FALSE if deletion failed
+     */
     function deleteAll($criteria = null)
     {
         $sql = 'DELETE FROM '.$this->db->prefix('smartfaq_answers');
@@ -599,14 +599,14 @@ 
     }
 
     /**
-    * Change a value for answers with a certain criteria
-    *
-    * @param   string  $fieldname  Name of the field
-    * @param   string  $fieldvalue Value to write
-    * @param   object  $criteria   {@link CriteriaElement}
-    *
-    * @return  bool
-    **/
+     * Change a value for answers with a certain criteria
+     *
+     * @param   string  $fieldname  Name of the field
+     * @param   string  $fieldvalue Value to write
+     * @param   object  $criteria   {@link CriteriaElement}
+     *
+     * @return  bool
+     **/
     function updateAll($fieldname, $fieldvalue, $criteria = null)
     {
         $set_clause = is_numeric($fieldvalue)? $fieldname.' = '.$fieldvalue : $fieldname.' = '.$this->db->quoteString($fieldvalue);

Spacing +41 added lines, -41 removed lines

@@ -25,9 +25,9 @@ 
     /**
     * constructor
     */
-    function __construct ($id = null)
+    function __construct($id = null)
     {
-        $this->db =& XoopsDatabaseFactory::getDatabaseConnection();
+        $this->db = & XoopsDatabaseFactory::getDatabaseConnection();
         $this->initVar("answerid", XOBJ_DTYPE_INT, null, false);
         $this->initVar("status", XOBJ_DTYPE_INT, -1, false);
         $this->initVar("faqid", XOBJ_DTYPE_INT, null, false);
@@ -50,7 +50,7 @@ 
                 $this->assignVars($id);
             } else {
                 $answer_handler = new sfAnswerHandler($this->db);
-                $answer =& $answer_handler->get($id);
+                $answer = & $answer_handler->get($id);
                 foreach ($answer->vars as $k => $v) {
                     $this->assignVar($k, $v['value']);
                 }
@@ -73,7 +73,7 @@ 
     function incrementDownload($attach_key)
     {
         if (!$attach_key) return false;
-        $this->attachment_array[strval($attach_key)]['num_download'] ++;
+        $this->attachment_array[strval($attach_key)]['num_download']++;
 
         return $this->attachment_array[strval($attach_key)]['num_download'];
     }
@@ -84,7 +84,7 @@ 
             $attachment_save = base64_encode(serialize($this->attachment_array));
         else $attachment_save = '';
         $this->setVar('attachment', $attachment_save);
-        $sql = "UPDATE " . $GLOBALS["xoopsDB"]->prefix("smartfaq_answers") . " SET attachment=" . $GLOBALS["xoopsDB"]->quoteString($attachment_save) . " WHERE post_id = " . $this->getVar('answerid');
+        $sql = "UPDATE ".$GLOBALS["xoopsDB"]->prefix("smartfaq_answers")." SET attachment=".$GLOBALS["xoopsDB"]->quoteString($attachment_save)." WHERE post_id = ".$this->getVar('answerid');
         if (!$result = $GLOBALS["xoopsDB"]->queryF($sql)) {
             //xoops_error($GLOBALS["xoopsDB"]->error());
             return false;
@@ -106,8 +106,8 @@ 
 
         foreach ($attach_old as $key => $attach) {
             if (in_array($key, $attach_array)) {
-                @unlink(XOOPS_ROOT_PATH . '/' . $xoopsModuleConfig['dir_attachments'] . '/' . $attach['name_saved']);
-                @unlink(XOOPS_ROOT_PATH . '/' . $xoopsModuleConfig['dir_attachments'] . '/thumbs/' . $attach['name_saved']); // delete thumbnails
+                @unlink(XOOPS_ROOT_PATH.'/'.$xoopsModuleConfig['dir_attachments'].'/'.$attach['name_saved']);
+                @unlink(XOOPS_ROOT_PATH.'/'.$xoopsModuleConfig['dir_attachments'].'/thumbs/'.$attach['name_saved']); // delete thumbnails
                 continue;
             }
             $this->attachment_array[$key] = $attach;
@@ -122,14 +122,14 @@ 
 
     function setAttachment($name_saved = '', $name_display = '', $mimetype = '', $num_download = 0)
     {
-        static $counter=0;
+        static $counter = 0;
         $this->attachment_array = $this->getAttachment();
         if ($name_saved) {
             $key = strval(time()+$counter++);
             $this->attachment_array[$key] = array('name_saved' => $name_saved,
-                'name_display' => isset($name_display)?$name_display:$name_saved,
+                'name_display' => isset($name_display) ? $name_display : $name_saved,
                 'mimetype' => $mimetype,
-                'num_download' => isset($num_download)?intval($num_download):0
+                'num_download' => isset($num_download) ? intval($num_download) : 0
                 );
         }
         if (is_array($this->attachment_array)) {
@@ -154,30 +154,30 @@ 
         if (is_array($attachments) && count($attachments) > 0) {
             $icon_handler = sf_getIconHandler();
             $mime_path = $icon_handler->getPath("mime");
-            include_once XOOPS_ROOT_PATH . '/modules/' . $xoopsModule->getVar("dirname", "n") . '/include/functions.image.php';
+            include_once XOOPS_ROOT_PATH.'/modules/'.$xoopsModule->getVar("dirname", "n").'/include/functions.image.php';
             $image_extensions = array("jpg", "jpeg", "gif", "png", "bmp"); // need improve !!!
-            $post_attachment .= '<br /><strong>' . _MD_ATTACHMENT . '</strong>:';
+            $post_attachment .= '<br /><strong>'._MD_ATTACHMENT.'</strong>:';
             $post_attachment .= '<br /><hr size="1" noshade="noshade" /><br />';
             foreach ($attachments as $key => $att) {
                 $file_extension = ltrim(strrchr($att['name_saved'], '.'), '.');
                 $filetype = $file_extension;
-                if (file_exists(XOOPS_ROOT_PATH . '/' . $mime_path . '/' . $filetype . '.gif')) {
-                    $icon_filetype = XOOPS_URL . '/' . $mime_path . '/' . $filetype . '.gif';
+                if (file_exists(XOOPS_ROOT_PATH.'/'.$mime_path.'/'.$filetype.'.gif')) {
+                    $icon_filetype = XOOPS_URL.'/'.$mime_path.'/'.$filetype.'.gif';
                 } else {
-                    $icon_filetype = XOOPS_URL . '/' . $mime_path . '/unknown.gif';
+                    $icon_filetype = XOOPS_URL.'/'.$mime_path.'/unknown.gif';
                 }
-                $file_size = @filesize(XOOPS_ROOT_PATH . '/' . $xoopsModuleConfig['dir_attachments'] . '/' . $att['name_saved']);
-                $file_size = number_format ($file_size / 1024, 2)." KB";
+                $file_size = @filesize(XOOPS_ROOT_PATH.'/'.$xoopsModuleConfig['dir_attachments'].'/'.$att['name_saved']);
+                $file_size = number_format($file_size / 1024, 2)." KB";
                 if (in_array(strtolower($file_extension), $image_extensions) && $xoopsModuleConfig['media_allowed']) {
-                        $post_attachment .= '<br /><img src="' . $icon_filetype . '" alt="' . $filetype . '" /><strong>&nbsp; ' . $att['name_display'] . '</strong> <small>('.$file_size.')</small>';
-                        $post_attachment .= '<br />' . sf_attachmentImage($att['name_saved']);
+                        $post_attachment .= '<br /><img src="'.$icon_filetype.'" alt="'.$filetype.'" /><strong>&nbsp; '.$att['name_display'].'</strong> <small>('.$file_size.')</small>';
+                        $post_attachment .= '<br />'.sf_attachmentImage($att['name_saved']);
                         $isDisplayed = true;
                 } else {
                     global $xoopsUser;
                     if (empty($xoopsModuleConfig['show_userattach'])) {
-                        $post_attachment .= '<a href="' . XOOPS_URL . '/modules/' . $xoopsModule->getVar("dirname", "n") . '/dl_attachment.php?attachid=' . $key . '&amp;post_id=' . $this->getVar('post_id') . '"> <img src="' . $icon_filetype . '" alt="' . $filetype . '" /> ' . $att['name_display'] . '</a> ' . _MD_FILESIZE . ': '. $file_size . '; '._MD_HITS.': ' . $att['num_download'];
-                    } elseif (($xoopsUser && $xoopsUser->uid() > 0 && $xoopsUser->isactive()) ) {
-                        $post_attachment .= '<a href="' . XOOPS_URL . '/modules/' . $xoopsModule->getVar("dirname", "n") . '/dl_attachment.php?attachid=' . $key . '&amp;post_id=' . $this->getVar('post_id') . '"> <img src="' . $icon_filetype . '" alt="' . $filetype . '" /> ' . $att['name_display'] . '</a> ' . _MD_FILESIZE . ': '. $file_size . '; '._MD_HITS.': ' . $att['num_download'];
+                        $post_attachment .= '<a href="'.XOOPS_URL.'/modules/'.$xoopsModule->getVar("dirname", "n").'/dl_attachment.php?attachid='.$key.'&amp;post_id='.$this->getVar('post_id').'"> <img src="'.$icon_filetype.'" alt="'.$filetype.'" /> '.$att['name_display'].'</a> '._MD_FILESIZE.': '.$file_size.'; '._MD_HITS.': '.$att['num_download'];
+                    } elseif (($xoopsUser && $xoopsUser->uid() > 0 && $xoopsUser->isactive())) {
+                        $post_attachment .= '<a href="'.XOOPS_URL.'/modules/'.$xoopsModule->getVar("dirname", "n").'/dl_attachment.php?attachid='.$key.'&amp;post_id='.$this->getVar('post_id').'"> <img src="'.$icon_filetype.'" alt="'.$filetype.'" /> '.$att['name_display'].'</a> '._MD_FILESIZE.': '.$file_size.'; '._MD_HITS.': '.$att['num_download'];
                     } else {
                         $post_attachment .= _MD_NEWBB_SEENOTGUEST;
                     }
@@ -213,7 +213,7 @@ 
         return $this->getVar("faqid");
     }
 
-    function answer($format="S")
+    function answer($format = "S")
     {
         return $this->getVar("answer", $format);
     }
@@ -223,10 +223,10 @@ 
         return $this->getVar("uid");
     }
 
-    function datesub($dateFormat='none', $format="S")
+    function datesub($dateFormat = 'none', $format = "S")
     {
         if ($dateFormat == 'none') {
-            $smartModuleConfig =& sf_getModuleConfig();
+            $smartModuleConfig = & sf_getModuleConfig();
             $dateFormat = $smartModuleConfig['dateformat'];
         }
 
@@ -240,14 +240,14 @@ 
 
     function notLoaded()
     {
-       return ($this->getVar('answerid')== -1);
+       return ($this->getVar('answerid') == -1);
     }
 
-    function sendNotifications($notifications=array())
+    function sendNotifications($notifications = array())
     {
-        $smartModule =& sf_getModuleInfo();
+        $smartModule = & sf_getModuleInfo();
 
-        $myts =& MyTextSanitizer::getInstance();
+        $myts = & MyTextSanitizer::getInstance();
         $notification_handler = &xoops_gethandler('notification');
 
         $faqObj = new sfFaq($this->faqid());
@@ -255,9 +255,9 @@ 
         $tags = array();
         $tags['MODULE_NAME'] = $myts->displayTarea($smartModule->getVar('name'));
         $tags['FAQ_NAME'] = $faqObj->question();
-        $tags['FAQ_URL'] = XOOPS_URL . '/modules/' . $smartModule->getVar('dirname') . '/faq.php?faqid=' . $faqObj->faqid();
+        $tags['FAQ_URL'] = XOOPS_URL.'/modules/'.$smartModule->getVar('dirname').'/faq.php?faqid='.$faqObj->faqid();
         $tags['CATEGORY_NAME'] = $faqObj->getCategoryName();
-        $tags['CATEGORY_URL'] = XOOPS_URL . '/modules/' . $smartModule->getVar('dirname') . '/category.php?categoryid=' . $faqObj->categoryid();
+        $tags['CATEGORY_URL'] = XOOPS_URL.'/modules/'.$smartModule->getVar('dirname').'/category.php?categoryid='.$faqObj->categoryid();
         $tags['FAQ_QUESTION'] = $faqObj->question();
 
         // TODO : Not sure about the 'formpreview' ...
@@ -423,7 +423,7 @@ 
         if (strtolower(get_class($faqObj)) != 'sffaq') {
             return false;
         }
-        $answers =& $this->getAllAnswers($faqObj->faqid());
+        $answers = & $this->getAllAnswers($faqObj->faqid());
         $result = true;
         foreach ($answers as $answer) {
             if (!$this->delete($answer)) {
@@ -463,9 +463,9 @@ 
             $answer = new sfAnswer();
             $answer->assignVars($myrow);
             if (!$id_as_key) {
-                $ret[] =& $answer;
+                $ret[] = & $answer;
             } else {
-                $ret[$myrow['answerid']] =& $answer;
+                $ret[$myrow['answerid']] = & $answer;
             }
             unset($answer);
         }
@@ -480,9 +480,9 @@ 
     * @param int $faqid
     * @return mixed reference to the {@link sfAnswer} object, FALSE if failed
     */
-    function &getOfficialAnswer($faqid=0)
+    function &getOfficialAnswer($faqid = 0)
     {
-        $theaAnswers =& $this->getAllAnswers($faqid, _SF_AN_STATUS_APPROVED, 1, 0);
+        $theaAnswers = & $this->getAllAnswers($faqid, _SF_AN_STATUS_APPROVED, 1, 0);
         if (count($theaAnswers) == 1) {
             $ret = $theaAnswers[0];
         } else {
@@ -499,11 +499,11 @@ 
     * @param int $faqid
     * @return array array of {@link sfAnswer} objects
     */
-    function &getAllAnswers($faqid=0, $status = -1, $limit = 0, $start = 0, $sort = 'datesub', $order = 'DESC')
+    function &getAllAnswers($faqid = 0, $status = -1, $limit = 0, $start = 0, $sort = 'datesub', $order = 'DESC')
     {
         $hasStatusCriteria = false;
         $criteriaStatus = new CriteriaCompo();
-        if ( is_array($status)) {
+        if (is_array($status)) {
             $hasStatusCriteria = true;
             foreach ($status as $v) {
                 $criteriaStatus->add(new Criteria('status', $v), 'OR');
@@ -609,7 +609,7 @@ 
     **/
     function updateAll($fieldname, $fieldvalue, $criteria = null)
     {
-        $set_clause = is_numeric($fieldvalue)? $fieldname.' = '.$fieldvalue : $fieldname.' = '.$this->db->quoteString($fieldvalue);
+        $set_clause = is_numeric($fieldvalue) ? $fieldname.' = '.$fieldvalue : $fieldname.' = '.$this->db->quoteString($fieldvalue);
         $sql = 'UPDATE '.$this->db->prefix('smartfaq_answers').' SET '.$set_clause;
         if (isset($criteria) && is_subclass_of($criteria, 'criteriaelement')) {
             $sql .= ' '.$criteria->renderWhere();
@@ -626,7 +626,7 @@ 
     {
         $ret = array();
         $sql = "SELECT faqid, answer, uid, datesub FROM ".$this->db->prefix("smartfaq_answers")."
-               WHERE faqid IN (".implode(',', $faqids).") AND status = ". _SF_AN_STATUS_APPROVED." GROUP BY faqid";
+               WHERE faqid IN (".implode(',', $faqids).") AND status = "._SF_AN_STATUS_APPROVED." GROUP BY faqid";
         $result = $this->db->query($sql);
         if (!$result) {
             return $ret;
@@ -634,7 +634,7 @@ 
         while ($row = $this->db->fetchArray($result)) {
             $answer = new sfAnswer();
             $answer->assignVars($row);
-            $ret[$row['faqid']] =& $answer;
+            $ret[$row['faqid']] = & $answer;
             unset($answer);
         }
 

Braces +31 added lines, -13 removed lines

@@ -62,17 +62,24 @@ 
     // attachment functions    TODO: there should be a file/attachment management class
     function getAttachment()
     {
-        if (count($this->attachment_array)) return $this->attachment_array;
+        if (count($this->attachment_array)) {
+            return $this->attachment_array;
+        }
         $attachment = $this->getVar('attachment');
-        if (empty($attachment)) $this->attachment_array = null;
-        else $this->attachment_array = @unserialize(base64_decode($attachment));
+        if (empty($attachment)) {
+            $this->attachment_array = null;
+        } else {
+            $this->attachment_array = @unserialize(base64_decode($attachment));
+        }
 
         return $this->attachment_array;
     }
 
     function incrementDownload($attach_key)
     {
-        if (!$attach_key) return false;
+        if (!$attach_key) {
+            return false;
+        }
         $this->attachment_array[strval($attach_key)]['num_download'] ++;
 
         return $this->attachment_array[strval($attach_key)]['num_download'];
@@ -80,9 +87,11 @@ 
 
     function saveAttachment()
     {
-        if (is_array($this->attachment_array) && count($this->attachment_array) > 0)
-            $attachment_save = base64_encode(serialize($this->attachment_array));
-        else $attachment_save = '';
+        if (is_array($this->attachment_array) && count($this->attachment_array) > 0) {
+                    $attachment_save = base64_encode(serialize($this->attachment_array));
+        } else {
+            $attachment_save = '';
+        }
         $this->setVar('attachment', $attachment_save);
         $sql = "UPDATE " . $GLOBALS["xoopsDB"]->prefix("smartfaq_answers") . " SET attachment=" . $GLOBALS["xoopsDB"]->quoteString($attachment_save) . " WHERE post_id = " . $this->getVar('answerid');
         if (!$result = $GLOBALS["xoopsDB"]->queryF($sql)) {
@@ -98,11 +107,18 @@ 
         global $xoopsModuleConfig;
 
         $attach_old = $this->getAttachment();
-        if (!is_array($attach_old) || count($attach_old) < 1) return true;
+        if (!is_array($attach_old) || count($attach_old) < 1) {
+            return true;
+        }
         $this->attachment_array = array();
 
-        if ($attach_array === null) $attach_array = array_keys($attach_old); // to delete all!
-        if (!is_array($attach_array)) $attach_array = array($attach_array);
+        if ($attach_array === null) {
+            $attach_array = array_keys($attach_old);
+        }
+        // to delete all!
+        if (!is_array($attach_array)) {
+            $attach_array = array($attach_array);
+        }
 
         foreach ($attach_old as $key => $attach) {
             if (in_array($key, $attach_array)) {
@@ -112,9 +128,11 @@ 
             }
             $this->attachment_array[$key] = $attach;
         }
-        if (is_array($this->attachment_array) && count($this->attachment_array) > 0)
-            $attachment_save = base64_encode(serialize($this->attachment_array));
-        else $attachment_save = '';
+        if (is_array($this->attachment_array) && count($this->attachment_array) > 0) {
+                    $attachment_save = base64_encode(serialize($this->attachment_array));
+        } else {
+            $attachment_save = '';
+        }
         $this->setVar('attachment', $attachment_save);
 
         return true;

smartfaq/class/category.php

Doc Comments +2 added lines, -2 removed lines

@@ -228,7 +228,7 @@ 
     * create a new category
     *
     * @param bool $isNew flag the new objects as "new"?
-    * @return object sfCategory
+    * @return sfCategory sfCategory
     */
     function &create($isNew = true)
     {
@@ -270,7 +270,7 @@ 
     /**
     * insert a new category in the database
     *
-    * @param object $category reference to the {@link sfCategory} object
+    * @param sfCategory $category reference to the {@link sfCategory} object
     * @param bool $force
     * @return bool FALSE if failed, TRUE if already present and unchanged or successful
     */

Indentation +50 added lines, -50 removed lines

@@ -24,8 +24,8 @@ 
     var $_groups_admin = null;
 
     /**
-    * constructor
-    */
+     * constructor
+     */
     function __construct($id = null)
     {
         $this->db =& XoopsDatabaseFactory::getDatabaseConnection();
@@ -59,7 +59,7 @@ 
 
     function notLoaded()
     {
-       return ($this->getVar('categoryid')== -1);
+        return ($this->getVar('categoryid')== -1);
     }
 
     function assignOtherProperties()
@@ -160,7 +160,7 @@ 
 
     function setGroups_read($groups_read = array('0'))
     {
-      $this->_groups_read = $groups_read;
+        $this->_groups_read = $groups_read;
     }
 
     function store($sendNotifications = true, $force = true )
@@ -225,11 +225,11 @@ 
 class sfCategoryHandler extends XoopsObjectHandler
 {
     /**
-    * create a new category
-    *
-    * @param bool $isNew flag the new objects as "new"?
-    * @return object sfCategory
-    */
+     * create a new category
+     *
+     * @param bool $isNew flag the new objects as "new"?
+     * @return object sfCategory
+     */
     function &create($isNew = true)
     {
         $category = new sfCategory();
@@ -241,11 +241,11 @@ 
     }
 
     /**
-    * retrieve a category
-    *
-    * @param int $id categoryid of the category
-    * @return mixed reference to the {@link sfCategory} object, FALSE if failed
-    */
+     * retrieve a category
+     *
+     * @param int $id categoryid of the category
+     * @return mixed reference to the {@link sfCategory} object, FALSE if failed
+     */
     function &get($id)
     {
         $false = false;
@@ -268,12 +268,12 @@ 
     }
 
     /**
-    * insert a new category in the database
-    *
-    * @param object $category reference to the {@link sfCategory} object
-    * @param bool $force
-    * @return bool FALSE if failed, TRUE if already present and unchanged or successful
-    */
+     * insert a new category in the database
+     *
+     * @param object $category reference to the {@link sfCategory} object
+     * @param bool $force
+     * @return bool FALSE if failed, TRUE if already present and unchanged or successful
+     */
     function insert(&$category, $force = false)
     {
         if (strtolower(get_class($category)) != 'sfcategory') {
@@ -313,12 +313,12 @@ 
     }
 
     /**
-    * delete a category from the database
-    *
-    * @param object $category reference to the category to delete
-    * @param bool $force
-    * @return bool FALSE if failed.
-    */
+     * delete a category from the database
+     *
+     * @param object $category reference to the category to delete
+     * @param bool $force
+     * @return bool FALSE if failed.
+     */
     function delete(&$category, $force = false)
     {
 
@@ -360,12 +360,12 @@ 
     }
 
     /**
-    * retrieve categories from the database
-    *
-    * @param object $criteria {@link CriteriaElement} conditions to be met
-    * @param bool $id_as_key use the categoryid as key for the array?
-    * @return array array of {@link XoopsFaq} objects
-    */
+     * retrieve categories from the database
+     *
+     * @param object $criteria {@link CriteriaElement} conditions to be met
+     * @param bool $id_as_key use the categoryid as key for the array?
+     * @return array array of {@link XoopsFaq} objects
+     */
     function &getObjects($criteria = null, $id_as_key = false)
     {
         $ret = array();
@@ -476,11 +476,11 @@ 
     }
 
     /**
-    * count Categories matching a condition
-    *
-    * @param object $criteria {@link CriteriaElement} to match
-    * @return int count of categories
-    */
+     * count Categories matching a condition
+     *
+     * @param object $criteria {@link CriteriaElement} to match
+     * @return int count of categories
+     */
     function getCount($criteria = null)
     {
         $sql = 'SELECT COUNT(*) FROM '.$this->db->prefix('smartfaq_categories');
@@ -569,11 +569,11 @@ 
     }
 
     /**
-    * delete categories matching a set of conditions
-    *
-    * @param object $criteria {@link CriteriaElement}
-    * @return bool FALSE if deletion failed
-    */
+     * delete categories matching a set of conditions
+     *
+     * @param object $criteria {@link CriteriaElement}
+     * @return bool FALSE if deletion failed
+     */
     function deleteAll($criteria = null)
     {
         $sql = 'DELETE FROM '.$this->db->prefix('smartfaq_categories');
@@ -590,14 +590,14 @@ 
     }
 
     /**
-    * Change a value for categories with a certain criteria
-    *
-    * @param   string  $fieldname  Name of the field
-    * @param   string  $fieldvalue Value to write
-    * @param   object  $criteria   {@link CriteriaElement}
-    *
-    * @return  bool
-    **/
+     * Change a value for categories with a certain criteria
+     *
+     * @param   string  $fieldname  Name of the field
+     * @param   string  $fieldvalue Value to write
+     * @param   object  $criteria   {@link CriteriaElement}
+     *
+     * @return  bool
+     **/
     function updateAll($fieldname, $fieldvalue, $criteria = null)
     {
         $set_clause = is_numeric($fieldvalue)? $fieldname.' = '.$fieldvalue : $fieldname.' = '.$this->db->quoteString($fieldvalue);

Spacing +43 added lines, -43 removed lines

@@ -28,7 +28,7 @@ 
     */
     function __construct($id = null)
     {
-        $this->db =& XoopsDatabaseFactory::getDatabaseConnection();
+        $this->db = & XoopsDatabaseFactory::getDatabaseConnection();
         $this->initVar("categoryid", XOBJ_DTYPE_INT, null, false);
         $this->initVar("parentid", XOBJ_DTYPE_INT, null, false);
         $this->initVar("name", XOBJ_DTYPE_TXTBOX, null, true, 100);
@@ -48,7 +48,7 @@ 
                 $this->assignVars($id);
             } else {
                 $category_handler = new sfCategoryHandler($this->db);
-                $category =& $category_handler->get($id);
+                $category = & $category_handler->get($id);
                 foreach ($category->vars as $k => $v) {
                     $this->assignVar($k, $v['value']);
                 }
@@ -59,13 +59,13 @@ 
 
     function notLoaded()
     {
-       return ($this->getVar('categoryid')== -1);
+       return ($this->getVar('categoryid') == -1);
     }
 
     function assignOtherProperties()
     {
         global $xoopsUser;
-        $smartModule =& sf_getModuleInfo();
+        $smartModule = & sf_getModuleInfo();
         $module_id = $smartModule->getVar('mid');
 
         $gperm_handler = &xoops_gethandler('groupperm');
@@ -82,10 +82,10 @@ 
             return true;
         }
 
-        $smartPermHandler =& xoops_getmodulehandler('permission', 'smartfaq');
+        $smartPermHandler = & xoops_getmodulehandler('permission', 'smartfaq');
 
         $categoriesGranted = $smartPermHandler->getPermissions('category');
-        if ( in_array($this->categoryid(), $categoriesGranted) ) {
+        if (in_array($this->categoryid(), $categoriesGranted)) {
             $ret = true;
         }
 
@@ -102,18 +102,18 @@ 
         return $this->getVar("parentid");
     }
 
-    function name($format="S")
+    function name($format = "S")
     {
         $ret = $this->getVar("name", $format);
-        if (($format=='s') || ($format=='S') || ($format=='show')) {
-            $myts =& MyTextSanitizer::getInstance();
+        if (($format == 's') || ($format == 'S') || ($format == 'show')) {
+            $myts = & MyTextSanitizer::getInstance();
             $ret = $myts->displayTarea($ret);
         }
 
         return $ret;
     }
 
-    function description($format="S")
+    function description($format = "S")
     {
         return $this->getVar("description", $format);
     }
@@ -131,19 +131,19 @@ 
             $filename = "category.php";
         }
         if ($withAllLink) {
-            $ret = "<a href='" . XOOPS_URL . "/modules/smartfaq/".$filename."?categoryid=" . $this->categoryid() . "'>" . $this->name() . "</a>";
+            $ret = "<a href='".XOOPS_URL."/modules/smartfaq/".$filename."?categoryid=".$this->categoryid()."'>".$this->name()."</a>";
         } else {
             $ret = $this->name();
         }
         $parentid = $this->parentid();
-        $category_handler =& sf_gethandler('category');
+        $category_handler = & sf_gethandler('category');
         if ($parentid != 0) {
-            $parentObj =& $category_handler->get($parentid);
+            $parentObj = & $category_handler->get($parentid);
             if ($parentObj->notLoaded()) {
                 exit;
             }
             $parentid = $parentObj->parentid();
-            $ret = $parentObj->getCategoryPath(true, $open) . " > " .$ret;
+            $ret = $parentObj->getCategoryPath(true, $open)." > ".$ret;
         }
 
         return $ret;
@@ -163,12 +163,12 @@ 
       $this->_groups_read = $groups_read;
     }
 
-    function store($sendNotifications = true, $force = true )
+    function store($sendNotifications = true, $force = true)
     {
         $category_handler = new sfCategoryHandler($this->db);
 
         $ret = $category_handler->insert($this, $force);
-        if ( $sendNotifications && $ret && ($this->isNew()) ) {
+        if ($sendNotifications && $ret && ($this->isNew())) {
             $this->sendNotifications();
         }
         $this->unsetNew();
@@ -178,15 +178,15 @@ 
 
     function sendNotifications()
     {
-        $smartModule =& sf_getModuleInfo();
+        $smartModule = & sf_getModuleInfo();
 
-        $myts =& MyTextSanitizer::getInstance();
+        $myts = & MyTextSanitizer::getInstance();
         $notification_handler = &xoops_gethandler('notification');
 
         $tags = array();
         $tags['MODULE_NAME'] = $myts->htmlSpecialChars($smartModule->getVar('name'));
         $tags['CATEGORY_NAME'] = $this->name();
-        $tags['CATEGORY_URL'] = XOOPS_URL . '/modules/' . $smartModule->getVar('dirname') . '/category.php?categoryid=' . $this->categoryid();
+        $tags['CATEGORY_URL'] = XOOPS_URL.'/modules/'.$smartModule->getVar('dirname').'/category.php?categoryid='.$this->categoryid();
 
         $notification_handler = &xoops_gethandler('notification');
         $notification_handler->triggerEvent('global_faq', 0, 'category_created', $tags);
@@ -197,9 +197,9 @@ 
         $category['categoryid'] = $this->categoryid();
         $category['name'] = $this->name();
         if ($open != false) {
-            $category['categorylink'] = "<a href='" . XOOPS_URL . "/modules/smartfaq/open_category.php?categoryid=" . $this->categoryid() . "'>" . $this->name() . "</a>";
+            $category['categorylink'] = "<a href='".XOOPS_URL."/modules/smartfaq/open_category.php?categoryid=".$this->categoryid()."'>".$this->name()."</a>";
         } else {
-            $category['categorylink'] = "<a href='" . XOOPS_URL . "/modules/smartfaq/category.php?categoryid=" . $this->categoryid() . "'>" . $this->name() . "</a>";
+            $category['categorylink'] = "<a href='".XOOPS_URL."/modules/smartfaq/category.php?categoryid=".$this->categoryid()."'>".$this->name()."</a>";
         }
         $category['total'] = $this->getVar('faqcount');
         $category['description'] = $this->description();
@@ -291,7 +291,7 @@ 
         }
 
         if ($category->isNew()) {
-            $sql = sprintf("INSERT INTO %s (categoryid, parentid, name, description, total, weight, created) VALUES (NULL, %u, %s, %s, %u, %u, %u)", $this->db->prefix('smartfaq_categories'),  $parentid, $this->db->quoteString($name), $this->db->quoteString($description), $total, $weight, time());
+            $sql = sprintf("INSERT INTO %s (categoryid, parentid, name, description, total, weight, created) VALUES (NULL, %u, %s, %s, %u, %u, %u)", $this->db->prefix('smartfaq_categories'), $parentid, $this->db->quoteString($name), $this->db->quoteString($description), $total, $weight, time());
         } else {
             $sql = sprintf("UPDATE %s SET parentid = %u, name = %s, description = %s, total = %s, weight = %u, created = %u WHERE categoryid = %u", $this->db->prefix('smartfaq_categories'), $parentid, $this->db->quoteString($name), $this->db->quoteString($description), $total, $weight, $created, $categoryid);
         }
@@ -333,14 +333,14 @@ 
         }
 
         // Deleteing the sub categories
-        $subcats =& $this->getCategories(0, 0, $category->categoryid());
+        $subcats = & $this->getCategories(0, 0, $category->categoryid());
         foreach ($subcats as $subcat) {
             $this->delete($subcat);
         }
 
         $sql = sprintf("DELETE FROM %s WHERE categoryid = %u", $this->db->prefix("smartfaq_categories"), $category->getVar('categoryid'));
 
-        $smartModule =& sf_getModuleInfo();
+        $smartModule = & sf_getModuleInfo();
         $module_id = $smartModule->getVar('mid');
 
         if (false != $force) {
@@ -349,7 +349,7 @@ 
             $result = $this->db->query($sql);
         }
 
-        xoops_groupperm_deletebymoditem ($module_id, "category_read", $category->categoryid());
+        xoops_groupperm_deletebymoditem($module_id, "category_read", $category->categoryid());
         //xoops_groupperm_deletebymoditem ($module_id, "category_admin", $categoryObj->categoryid());
 
         if (!$result) {
@@ -389,9 +389,9 @@ 
             $category = new sfCategory();
             $category->assignVars($myrow);
             if (!$id_as_key) {
-                $ret[] =& $category;
+                $ret[] = & $category;
             } else {
-                $ret[$myrow['categoryid']] =& $category;
+                $ret[$myrow['categoryid']] = & $category;
             }
             unset($category);
         }
@@ -399,7 +399,7 @@ 
         return $ret;
     }
 
-    function &getCategories($limit=0, $start=0, $parentid=0, $sort='weight', $order='ASC', $id_as_key = true)
+    function &getCategories($limit = 0, $start = 0, $parentid = 0, $sort = 'weight', $order = 'ASC', $id_as_key = true)
     {
         include_once XOOPS_ROOT_PATH.'/modules/smartfaq/include/functions.php';
 
@@ -412,7 +412,7 @@ 
             $criteria->add(new Criteria('parentid', $parentid));
         }
         if (!sf_userIsAdmin()) {
-            $smartPermHandler =& xoops_getmodulehandler('permission', 'smartfaq');
+            $smartPermHandler = & xoops_getmodulehandler('permission', 'smartfaq');
 
             $categoriesGranted = $smartPermHandler->getPermissions('category');
             $criteria->add(new Criteria('categoryid', "(".implode(',', $categoriesGranted).")", 'IN'));
@@ -424,7 +424,7 @@ 
         return $ret;
     }
 
-    function &getCategoriesWithOpenQuestion($limit=0, $start=0, $parentid=0, $sort='weight', $order='ASC')
+    function &getCategoriesWithOpenQuestion($limit = 0, $start = 0, $parentid = 0, $sort = 'weight', $order = 'ASC')
     {
         include_once XOOPS_ROOT_PATH.'/modules/smartfaq/include/functions.php';
 
@@ -437,7 +437,7 @@ 
             $criteria->add(new Criteria('c.parentid', $parentid));
         }
         if (!sf_userIsAdmin()) {
-            $smartPermHandler =& xoops_getmodulehandler('permission', 'smartfaq');
+            $smartPermHandler = & xoops_getmodulehandler('permission', 'smartfaq');
 
             $categoriesGranted = $smartPermHandler->getPermissions('category');
             $criteria->add(new Criteria('categoryid', "(".implode(',', $categoriesGranted).")", 'IN'));
@@ -449,7 +449,7 @@ 
 
         $ret = array();
         $limit = $start = 0;
-        $sql = 'SELECT DISTINCT c.categoryid, c.parentid, c.name, c.description, c.total, c.weight, c.created FROM '.$this->db->prefix('smartfaq_categories') . ' AS c INNER JOIN '.$this->db->prefix('smartfaq_faq') . ' AS f ON c.categoryid = f.categoryid';
+        $sql = 'SELECT DISTINCT c.categoryid, c.parentid, c.name, c.description, c.total, c.weight, c.created FROM '.$this->db->prefix('smartfaq_categories').' AS c INNER JOIN '.$this->db->prefix('smartfaq_faq').' AS f ON c.categoryid = f.categoryid';
         if (isset($criteria) && is_subclass_of($criteria, 'criteriaelement')) {
             $sql .= ' '.$criteria->renderWhere();
             if ($criteria->getSort() != '') {
@@ -467,7 +467,7 @@ 
         while ($myrow = $this->db->fetchArray($result)) {
             $category = new sfCategory();
             $category->assignVars($myrow);
-            $ret[] =& $category;
+            $ret[] = & $category;
             unset($category);
         }
 
@@ -496,7 +496,7 @@ 
         return $count;
     }
 
-    function getCategoriesCount($parentid=0)
+    function getCategoriesCount($parentid = 0)
     {
 
         if ($parentid == -1) {
@@ -506,7 +506,7 @@ 
         if (isset($parentid) && ($parentid != -1)) {
             $criteria->add(new criteria('parentid', $parentid));
             if (!sf_userIsAdmin()) {
-                $smartPermHandler =& xoops_getmodulehandler('permission', 'smartfaq');
+                $smartPermHandler = & xoops_getmodulehandler('permission', 'smartfaq');
 
                 $categoriesGranted = $smartPermHandler->getPermissions('category');
                 $criteria->add(new Criteria('categoryid', "(".implode(',', $categoriesGranted).")", 'IN'));
@@ -516,7 +516,7 @@ 
         return $this->getCount($criteria);
     }
 
-    function getCategoriesWithOpenQuestionsCount($parentid=0)
+    function getCategoriesWithOpenQuestionsCount($parentid = 0)
     {
 
         if ($parentid == -1) {
@@ -526,7 +526,7 @@ 
         if (isset($parentid) && ($parentid != -1)) {
             $criteria->add(new criteria('parentid', $parentid));
             if (!sf_userIsAdmin()) {
-                $smartPermHandler =& xoops_getmodulehandler('permission', 'smartfaq');
+                $smartPermHandler = & xoops_getmodulehandler('permission', 'smartfaq');
 
                 $categoriesGranted = $smartPermHandler->getPermissions('category');
                 $criteria->add(new Criteria('categoryid', "(".implode(',', $categoriesGranted).")", 'IN'));
@@ -535,7 +535,7 @@ 
 
         $criteria->add(new Criteria('f.status', _SF_STATUS_OPENED));
 
-        $sql = 'SELECT COUNT(c.categoryid) FROM '.$this->db->prefix('smartfaq_categories') . ' AS c INNER JOIN '.$this->db->prefix('smartfaq_faq') . ' AS f ON c.categoryid = f.categoryid';
+        $sql = 'SELECT COUNT(c.categoryid) FROM '.$this->db->prefix('smartfaq_categories').' AS c INNER JOIN '.$this->db->prefix('smartfaq_faq').' AS f ON c.categoryid = f.categoryid';
 
         if (isset($criteria) && is_subclass_of($criteria, 'criteriaelement')) {
             $sql .= ' '.$criteria->renderWhere();
@@ -555,7 +555,7 @@ 
         $criteria = new CriteriaCompo('parentid', "(".implode(',', array_keys($categories)).")", 'IN');
         $ret = array();
         if (!sf_userIsAdmin()) {
-            $smartPermHandler =& xoops_getmodulehandler('permission', 'smartfaq');
+            $smartPermHandler = & xoops_getmodulehandler('permission', 'smartfaq');
 
             $categoriesGranted = $smartPermHandler->getPermissions('category');
             $criteria->add(new Criteria('categoryid', "(".implode(',', $categoriesGranted).")", 'IN'));
@@ -600,7 +600,7 @@ 
     **/
     function updateAll($fieldname, $fieldvalue, $criteria = null)
     {
-        $set_clause = is_numeric($fieldvalue)? $fieldname.' = '.$fieldvalue : $fieldname.' = '.$this->db->quoteString($fieldvalue);
+        $set_clause = is_numeric($fieldvalue) ? $fieldname.' = '.$fieldvalue : $fieldname.' = '.$this->db->quoteString($fieldvalue);
         $sql = 'UPDATE '.$this->db->prefix('smartfaq_categories').' SET '.$set_clause;
         if (isset($criteria) && is_subclass_of($criteria, 'criteriaelement')) {
             $sql .= ' '.$criteria->renderWhere();
@@ -614,16 +614,16 @@ 
 
     function publishedFaqsCount($cat_id = 0)
     {
-        return $this->faqsCount($cat_id, $status=array(_SF_STATUS_PUBLISHED, _SF_STATUS_NEW_ANSWER));
+        return $this->faqsCount($cat_id, $status = array(_SF_STATUS_PUBLISHED, _SF_STATUS_NEW_ANSWER));
     }
 
-    function faqsCount($cat_id = 0, $status='')
+    function faqsCount($cat_id = 0, $status = '')
     {
 
         Global $xoopsUser;
         include_once XOOPS_ROOT_PATH.'/modules/smartfaq/include/functions.php';
 
-        $faq_handler =& sf_gethandler('faq');
+        $faq_handler = & sf_gethandler('faq');
 
         return $faq_handler->getCountsByCat($cat_id, $status);
     }

smartfaq/class/faq.php

Doc Comments +4 added lines, -1 removed lines

@@ -207,6 +207,9 @@ 
         return $ret;
     }
 
+    /**
+     * @return integer
+     */
     function uid()
     {
         return $this->getVar("uid");
@@ -619,7 +622,7 @@ 
     /**
     * insert a new faq in the database
     *
-    * @param object $faq reference to the {@link sfFaq} object
+    * @param sfFaq $faq reference to the {@link sfFaq} object
     * @param bool $force
     * @return bool FALSE if failed, TRUE if already present and unchanged or successful
     */

Indentation +43 added lines, -43 removed lines

@@ -70,8 +70,8 @@ 
     var $_smartModule= null;
     var $_smartModuleConfig;
     /**
-    * constructor
-    */
+     * constructor
+     */
     function __construct($id= null)
     {
         $this->db= & XoopsDatabaseFactory::getDatabaseConnection();
@@ -591,11 +591,11 @@ 
     }
 
     /**
-    * retrieve an FAQ
-    *
-    * @param int $id faqid of the user
-    * @return mixed reference to the {@link sfFaq} object, FALSE if failed
-    */
+     * retrieve an FAQ
+     *
+     * @param int $id faqid of the user
+     * @return mixed reference to the {@link sfFaq} object, FALSE if failed
+     */
     function & get($id)
     {
         if (intval($id) > 0) {
@@ -617,12 +617,12 @@ 
     }
 
     /**
-    * insert a new faq in the database
-    *
-    * @param object $faq reference to the {@link sfFaq} object
-    * @param bool $force
-    * @return bool FALSE if failed, TRUE if already present and unchanged or successful
-    */
+     * insert a new faq in the database
+     *
+     * @param object $faq reference to the {@link sfFaq} object
+     * @param bool $force
+     * @return bool FALSE if failed, TRUE if already present and unchanged or successful
+     */
     function insert(& $faq, $force= false)
     {
 
@@ -668,12 +668,12 @@ 
     }
 
     /**
-    * delete an FAQ from the database
-    *
-    * @param object $faq reference to the FAQ to delete
-    * @param bool $force
-    * @return bool FALSE if failed.
-    */
+     * delete an FAQ from the database
+     *
+     * @param object $faq reference to the FAQ to delete
+     * @param bool $force
+     * @return bool FALSE if failed.
+     */
     function delete(& $faq, $force= false)
     {
         $smartModule= & sf_getModuleInfo();
@@ -707,12 +707,12 @@ 
     }
 
     /**
-    * retrieve FAQs from the database
-    *
-    * @param object $criteria {@link CriteriaElement} conditions to be met
-    * @param bool $id_as_key use the faqid as key for the array?
-    * @return array array of {@link sfFaq} objects
-    */
+     * retrieve FAQs from the database
+     *
+     * @param object $criteria {@link CriteriaElement} conditions to be met
+     * @param bool $id_as_key use the faqid as key for the array?
+     * @return array array of {@link sfFaq} objects
+     */
     function & getObjects($criteria= null, $id_as_key= false, $notNullFields= '')
     {
         $ret= array();
@@ -851,11 +851,11 @@ 
     }
 
     /**
-    * count FAQs matching a condition
-    *
-    * @param object $criteria {@link CriteriaElement} to match
-    * @return int count of FAQs
-    */
+     * count FAQs matching a condition
+     *
+     * @param object $criteria {@link CriteriaElement} to match
+     * @return int count of FAQs
+     */
     function getCount($criteria= null, $notNullFields= '')
     {
         $sql= 'SELECT COUNT(*) FROM '.$this->db->prefix('smartfaq_faq');
@@ -1224,11 +1224,11 @@ 
     }
 
     /**
-    * delete FAQs matching a set of conditions
-    *
-    * @param object $criteria {@link CriteriaElement}
-    * @return bool FALSE if deletion failed
-    */
+     * delete FAQs matching a set of conditions
+     *
+     * @param object $criteria {@link CriteriaElement}
+     * @return bool FALSE if deletion failed
+     */
     function deleteAll($criteria= null)
     {
         $sql= 'DELETE FROM '.$this->db->prefix('smartfaq_faq');
@@ -1244,14 +1244,14 @@ 
     }
 
     /**
-    * Change a value for FAQ with a certain criteria
-    *
-    * @param   string  $fieldname  Name of the field
-    * @param   string  $fieldvalue Value to write
-    * @param   object  $criteria   {@link CriteriaElement}
-    *
-    * @return  bool
-    **/
+     * Change a value for FAQ with a certain criteria
+     *
+     * @param   string  $fieldname  Name of the field
+     * @param   string  $fieldvalue Value to write
+     * @param   object  $criteria   {@link CriteriaElement}
+     *
+     * @return  bool
+     **/
     function updateAll($fieldname, $fieldvalue, $criteria= null)
     {
         $set_clause= is_numeric($fieldvalue) ? $fieldname.' = '.$fieldvalue : $fieldname.' = '.$this->db->quoteString($fieldvalue);

Spacing +308 added lines, -308 removed lines

@@ -41,40 +41,40 @@ 
      * @var sfCategory
      * @access private
      */
-    var $_category= null;
+    var $_category = null;
 
     /**
      * @var sfAnswer
      * @access private
      */
-    var $_answer= null;
+    var $_answer = null;
 
     /**
      * @var array
      * @access private
      */
-    var $_notifications= null;
+    var $_notifications = null;
     // TODO : Create a seperated class for notifications
 
     /**
      * @var array
      * @access private
      */
-    var $_groups_read= null;
+    var $_groups_read = null;
 
     /**
      * @var object
      * @access private
      */
     // Is this still usefull??
-    var $_smartModule= null;
+    var $_smartModule = null;
     var $_smartModuleConfig;
     /**
     * constructor
     */
-    function __construct($id= null)
+    function __construct($id = null)
     {
-        $this->db= & XoopsDatabaseFactory::getDatabaseConnection();
+        $this->db = & XoopsDatabaseFactory::getDatabaseConnection();
         $this->initVar("faqid", XOBJ_DTYPE_INT, -1, false);
         $this->initVar("categoryid", XOBJ_DTYPE_INT, 0, false);
         $this->initVar("question", XOBJ_DTYPE_TXTBOX, null, true, 100000);
@@ -99,8 +99,8 @@ 
         $this->initVar("partialview", XOBJ_DTYPE_INT, 0, false);
 
         if (isset($id)) {
-            $faq_handler= new sfFaqHandler($this->db);
-            $faq= & $faq_handler->get($id);
+            $faq_handler = new sfFaqHandler($this->db);
+            $faq = & $faq_handler->get($id);
             foreach ($faq->vars as $k => $v) {
                 $this->assignVar($k, $v['value']);
             }
@@ -110,29 +110,29 @@ 
 
     function assignOtherProperties()
     {
-        $smartModule= & sf_getModuleInfo();
-        $module_id= $smartModule->getVar('mid');
+        $smartModule = & sf_getModuleInfo();
+        $module_id = $smartModule->getVar('mid');
 
-        $gperm_handler= & xoops_gethandler('groupperm');
+        $gperm_handler = & xoops_gethandler('groupperm');
 
-        $this->_category= new sfCategory($this->getVar('categoryid'));
-        $this->_groups_read= $gperm_handler->getGroupIds('item_read', $this->faqid(), $module_id);
+        $this->_category = new sfCategory($this->getVar('categoryid'));
+        $this->_groups_read = $gperm_handler->getGroupIds('item_read', $this->faqid(), $module_id);
     }
 
     function checkPermission()
     {
         include_once XOOPS_ROOT_PATH.'/modules/smartfaq/include/functions.php';
 
-        $userIsAdmin= sf_userIsAdmin();
+        $userIsAdmin = sf_userIsAdmin();
         if ($userIsAdmin) {
             return true;
         }
 
-        $smartPermHandler= & xoops_getmodulehandler('permission', 'smartfaq');
+        $smartPermHandler = & xoops_getmodulehandler('permission', 'smartfaq');
 
-        $faqsGranted= $smartPermHandler->getPermissions('item');
+        $faqsGranted = $smartPermHandler->getPermissions('item');
         if (in_array($this->categoryid(), $faqsGranted)) {
-            $ret= true;
+            $ret = true;
         }
 
         return $ret;
@@ -147,9 +147,9 @@ 
         return $this->_groups_read;
     }
 
-    function setGroups_read($groups_read= array('0'))
+    function setGroups_read($groups_read = array('0'))
     {
-        $this->_groups_read= $groups_read;
+        $this->_groups_read = $groups_read;
     }
 
     function faqid()
@@ -167,17 +167,17 @@ 
         return $this->_category;
     }
 
-    function question($maxLength= 0, $format= "S")
+    function question($maxLength = 0, $format = "S")
     {
-        $ret= $this->getVar("question", $format);
-        if (($format == 's') ||($format == 'S') ||($format == 'show')) {
-            $myts= & MyTextSanitizer :: getInstance();
-            $ret= $myts->displayTarea($ret);
+        $ret = $this->getVar("question", $format);
+        if (($format == 's') || ($format == 'S') || ($format == 'show')) {
+            $myts = & MyTextSanitizer :: getInstance();
+            $ret = $myts->displayTarea($ret);
         }
         if ($maxLength != 0) {
             if (!XOOPS_USE_MULTIBYTES) {
                 if (strlen($ret) >= $maxLength) {
-                    $ret= substr($ret, 0,($maxLength -1))."...";
+                    $ret = substr($ret, 0, ($maxLength-1))."...";
                 }
             }
         }
@@ -185,23 +185,23 @@ 
         return $ret;
     }
 
-    function howdoi($format= "S")
+    function howdoi($format = "S")
     {
-        $ret= $this->getVar("howdoi", $format);
-        if (($format == 's') ||($format == 'S') ||($format == 'show')) {
-            $myts= & MyTextSanitizer :: getInstance();
-            $ret= $myts->displayTarea($ret);
+        $ret = $this->getVar("howdoi", $format);
+        if (($format == 's') || ($format == 'S') || ($format == 'show')) {
+            $myts = & MyTextSanitizer :: getInstance();
+            $ret = $myts->displayTarea($ret);
         }
 
         return $ret;
     }
 
-    function diduno($format= "S")
+    function diduno($format = "S")
     {
-        $ret= $this->getVar("diduno", $format);
-        if (($format == 's') ||($format == 'S') ||($format == 'show')) {
-            $myts= & MyTextSanitizer :: getInstance();
-            $ret= $myts->displayTarea($ret);
+        $ret = $this->getVar("diduno", $format);
+        if (($format == 's') || ($format == 'S') || ($format == 'show')) {
+            $myts = & MyTextSanitizer :: getInstance();
+            $ret = $myts->displayTarea($ret);
         }
 
         return $ret;
@@ -212,11 +212,11 @@ 
         return $this->getVar("uid");
     }
 
-    function datesub($dateFormat= 'none', $format= "S")
+    function datesub($dateFormat = 'none', $format = "S")
     {
         if ($dateFormat == 'none') {
-            $smartConfig= & sf_getModuleConfig();
-            $dateFormat= $smartConfig['dateformat'];
+            $smartConfig = & sf_getModuleConfig();
+            $dateFormat = $smartConfig['dateformat'];
         }
 
         return formatTimestamp($this->getVar('datesub', $format), $dateFormat);
@@ -267,12 +267,12 @@ 
         return $this->getVar("notifypub");
     }
 
-    function modulelink($format= "S")
+    function modulelink($format = "S")
     {
         return $this->getVar("modulelink", $format);
     }
 
-    function contextpage($format= "S")
+    function contextpage($format = "S")
     {
         return $this->getVar("contextpage", $format);
     }
@@ -287,11 +287,11 @@ 
         return $this->getVar("partialview");
     }
 
-    function posterName($realName= -1)
+    function posterName($realName = -1)
     {
         if ($realName == -1) {
-            $smartConfig= & sf_getModuleConfig();
-            $realName= $smartConfig['userealname'];
+            $smartConfig = & sf_getModuleConfig();
+            $realName = $smartConfig['userealname'];
         }
 
         return sf_getLinkedUnameFromId($this->uid(), $realName);
@@ -299,33 +299,33 @@ 
 
     function answer()
     {
-        $answer_handler= new sfAnswerHandler($this->db);
+        $answer_handler = new sfAnswerHandler($this->db);
         switch ($this->status()) {
             case _SF_STATUS_SUBMITTED :
-                $theAnswers= & $answer_handler->getAllAnswers($this->faqid(), _SF_AN_STATUS_APPROVED, 1, 0);
+                $theAnswers = & $answer_handler->getAllAnswers($this->faqid(), _SF_AN_STATUS_APPROVED, 1, 0);
                 //echo "test";
                 //exit;
-                $this->_answer= & $theAnswers[0];
+                $this->_answer = & $theAnswers[0];
                 break;
 
             case _SF_STATUS_ANSWERED :
-                $theAnswers= & $answer_handler->getAllAnswers($this->faqid(), _SF_AN_STATUS_PROPOSED, 1, 0);
+                $theAnswers = & $answer_handler->getAllAnswers($this->faqid(), _SF_AN_STATUS_PROPOSED, 1, 0);
                 //echo "test";
                 //exit;
-                $this->_answer= & $theAnswers[0];
+                $this->_answer = & $theAnswers[0];
                 break;
 
             case _SF_STATUS_PUBLISHED :
             case _SF_STATUS_NEW_ANSWER :
             case _SF_STATUS_OFFLINE :
-                $this->_answer= & $answer_handler->getOfficialAnswer($this->faqid());
+                $this->_answer = & $answer_handler->getOfficialAnswer($this->faqid());
                 break;
 
             case _SF_STATUS_ASKED :
-                $this->_answer= & $answer_handler->create();
+                $this->_answer = & $answer_handler->create();
 
             case _SF_STATUS_OPENED :
-                $this->_answer= & $answer_handler->create();
+                $this->_answer = & $answer_handler->create();
                 break;
         }
 
@@ -342,21 +342,21 @@ 
 
     function getAllAnswers()
     {
-        $answer_handler= new sfAnswerHandler($this->db);
+        $answer_handler = new sfAnswerHandler($this->db);
 
         return $answer_handler->getAllAnswers($this->faqid());
     }
 
     function updateCounter()
     {
-        $faq_handler= new sfFaqHandler($this->db);
+        $faq_handler = new sfFaqHandler($this->db);
 
         return $faq_handler->updateCounter($this->faqid());
     }
 
-    function store($force= true)
+    function store($force = true)
     {
-        $faq_handler= new sfFaqHandler($this->db);
+        $faq_handler = new sfFaqHandler($this->db);
 
         return $faq_handler->insert($this, $force);
     }
@@ -364,37 +364,37 @@ 
     function getCategoryName()
     {
         if (!isset($this->_category)) {
-            $this->_category= new sfCategory($this->getVar('categoryid'));
+            $this->_category = new sfCategory($this->getVar('categoryid'));
         }
 
         return $this->_category->name();
     }
 
-    function sendNotifications($notifications= array())
+    function sendNotifications($notifications = array())
     {
-        $smartModule= & sf_getModuleInfo();
+        $smartModule = & sf_getModuleInfo();
 
-        $myts= & MyTextSanitizer :: getInstance();
-        $notification_handler= & xoops_gethandler('notification');
+        $myts = & MyTextSanitizer :: getInstance();
+        $notification_handler = & xoops_gethandler('notification');
         //$categoryObj = $this->category();
 
-        $tags= array();
-        $tags['MODULE_NAME']= $myts->displayTarea($smartModule->getVar('name'));
-        $tags['FAQ_NAME']= $this->question();
-        $tags['CATEGORY_NAME']= $this->getCategoryName();
-        $tags['CATEGORY_URL']= XOOPS_URL.'/modules/'.$smartModule->getVar('dirname').'/category.php?categoryid='.$this->categoryid();
-        $tags['FAQ_QUESTION']= $this->question();
-        $answerObj= & $this->answer();
+        $tags = array();
+        $tags['MODULE_NAME'] = $myts->displayTarea($smartModule->getVar('name'));
+        $tags['FAQ_NAME'] = $this->question();
+        $tags['CATEGORY_NAME'] = $this->getCategoryName();
+        $tags['CATEGORY_URL'] = XOOPS_URL.'/modules/'.$smartModule->getVar('dirname').'/category.php?categoryid='.$this->categoryid();
+        $tags['FAQ_QUESTION'] = $this->question();
+        $answerObj = & $this->answer();
         if (is_object($answerObj)) {
             // TODO : Not sure about the 'formpreview' ...
-            $tags['FAQ_ANSWER']= $answerObj->answer('formpreview');
+            $tags['FAQ_ANSWER'] = $answerObj->answer('formpreview');
         }
-        $tags['DATESUB']= $this->datesub();
+        $tags['DATESUB'] = $this->datesub();
 
         foreach ($notifications as $notification) {
             switch ($notification) {
                 case _SF_NOT_FAQ_PUBLISHED :
-                    $tags['FAQ_URL']= XOOPS_URL.'/modules/'.$smartModule->getVar('dirname').'/faq.php?faqid='.$this->faqid();
+                    $tags['FAQ_URL'] = XOOPS_URL.'/modules/'.$smartModule->getVar('dirname').'/faq.php?faqid='.$this->faqid();
 
                     $notification_handler->triggerEvent('global_faq', 0, 'published', $tags);
                     $notification_handler->triggerEvent('category_faq', $this->categoryid(), 'published', $tags);
@@ -402,20 +402,20 @@ 
                     break;
 
                 case _SF_NOT_FAQ_SUBMITTED :
-                    $tags['WAITINGFILES_URL']= XOOPS_URL.'/modules/'.$smartModule->getVar('dirname').'/admin/faq.php?faqid='.$this->faqid();
+                    $tags['WAITINGFILES_URL'] = XOOPS_URL.'/modules/'.$smartModule->getVar('dirname').'/admin/faq.php?faqid='.$this->faqid();
                     $notification_handler->triggerEvent('global_faq', 0, 'submitted', $tags);
                     $notification_handler->triggerEvent('category_faq', $this->categoryid(), 'submitted', $tags);
                     break;
 
                 case _SF_NOT_QUESTION_PUBLISHED :
-                    $tags['FAQ_URL']= XOOPS_URL.'/modules/'.$smartModule->getVar('dirname').'/answer.php?faqid='.$this->faqid();
+                    $tags['FAQ_URL'] = XOOPS_URL.'/modules/'.$smartModule->getVar('dirname').'/answer.php?faqid='.$this->faqid();
                     $notification_handler->triggerEvent('global_question', 0, 'published', $tags);
                     $notification_handler->triggerEvent('category_question', $this->categoryid(), 'published', $tags);
                     $notification_handler->triggerEvent('question', $this->faqid(), 'approved', $tags);
                     break;
 
                 case _SF_NOT_QUESTION_SUBMITTED :
-                    $tags['WAITINGFILES_URL']= XOOPS_URL.'/modules/'.$smartModule->getVar('dirname').'/admin/question.php?op=mod&faqid='.$this->faqid();
+                    $tags['WAITINGFILES_URL'] = XOOPS_URL.'/modules/'.$smartModule->getVar('dirname').'/admin/question.php?op=mod&faqid='.$this->faqid();
                     $notification_handler->triggerEvent('global_question', 0, 'submitted', $tags);
                     $notification_handler->triggerEvent('category_question', $this->categoryid(), 'submitted', $tags);
                     break;
@@ -425,7 +425,7 @@ 
                     break;
 
                 case _SF_NOT_NEW_ANSWER_PROPOSED :
-                    $tags['WAITINGFILES_URL']= XOOPS_URL.'/modules/'.$smartModule->getVar('dirname').'/admin/answer.php?op=mod&faqid='.$this->faqid();
+                    $tags['WAITINGFILES_URL'] = XOOPS_URL.'/modules/'.$smartModule->getVar('dirname').'/admin/answer.php?op=mod&faqid='.$this->faqid();
                     $notification_handler->triggerEvent('global_faq', 0, 'answer_proposed', $tags);
                     $notification_handler->triggerEvent('category_faq', $this->categoryid(), 'answer_proposed', $tags);
                     break;
@@ -461,28 +461,28 @@ 
     function setDefaultPermissions()
     {
 
-        $member_handler= & xoops_gethandler('member');
-        $groups= & $member_handler->getGroupList();
+        $member_handler = & xoops_gethandler('member');
+        $groups = & $member_handler->getGroupList();
 
-        $j= 0;
-        $group_ids= array();
+        $j = 0;
+        $group_ids = array();
         foreach (array_keys($groups) as $i) {
-            $group_ids[$j]= $i;
+            $group_ids[$j] = $i;
             ++$j;
         }
-        $this->_groups_read= $group_ids;
+        $this->_groups_read = $group_ids;
     }
 
     function setPermissions($group_ids)
     {
         if (!isset($group_ids)) {
-            $member_handler= & xoops_gethandler('member');
-            $groups= & $member_handler->getGroupList();
+            $member_handler = & xoops_gethandler('member');
+            $groups = & $member_handler->getGroupList();
 
-            $j= 0;
-            $group_ids= array();
+            $j = 0;
+            $group_ids = array();
             foreach (array_keys($groups) as $i) {
-                $group_ids[$j]= $i;
+                $group_ids[$j] = $i;
                 ++$j;
             }
         }
@@ -494,27 +494,27 @@ 
         return($this->getVar('faqid') == -1);
     }
 
-    function getWhoAndWhen($answerObj= null, $users= array())
+    function getWhoAndWhen($answerObj = null, $users = array())
     {
-        $smartModuleConfig= sf_getModuleConfig();
+        $smartModuleConfig = sf_getModuleConfig();
 
-        $requester= sf_getLinkedUnameFromId($this->uid(), $smartModuleConfig['userealname'], $users);
-        $requestdate= $this->datesub();
+        $requester = sf_getLinkedUnameFromId($this->uid(), $smartModuleConfig['userealname'], $users);
+        $requestdate = $this->datesub();
 
         if (($this->status() == _SF_STATUS_PUBLISHED) || $this->status() == _SF_STATUS_NEW_ANSWER) {
             if ($answerObj == null) {
-                $answerObj= & $this->answer();
+                $answerObj = & $this->answer();
             }
-            $submitdate= $answerObj->datesub();
+            $submitdate = $answerObj->datesub();
             if ($this->uid() == $answerObj->uid()) {
-                $result= sprintf(_MD_SF_REQUESTEDANDANSWERED, $requester, $submitdate);
+                $result = sprintf(_MD_SF_REQUESTEDANDANSWERED, $requester, $submitdate);
             } else {
-                $submitter= sf_getLinkedUnameFromId($answerObj->uid(), $smartModuleConfig['userealname'], $users);
-                $result= sprintf(_MD_SF_REQUESTEDBYANDANSWEREDBY, $requester, $submitter, $submitdate);
+                $submitter = sf_getLinkedUnameFromId($answerObj->uid(), $smartModuleConfig['userealname'], $users);
+                $result = sprintf(_MD_SF_REQUESTEDBYANDANSWEREDBY, $requester, $submitter, $submitdate);
             }
 
         } else {
-            $result= sprintf(_MD_SF_REQUESTEDBY, $requester, $requestdate);
+            $result = sprintf(_MD_SF_REQUESTEDBY, $requester, $requestdate);
         }
 
         return $result;
@@ -524,44 +524,44 @@ 
     {
         global $xoopsConfig;
         if (($this->status() == _SF_STATUS_PUBLISHED) || $this->status() == _SF_STATUS_NEW_ANSWER) {
-            $text= _MD_SF_FAQCOMEFROM;
+            $text = _MD_SF_FAQCOMEFROM;
         } else {
-            $text= _MD_SF_QUESTIONCOMEFROM;
+            $text = _MD_SF_QUESTIONCOMEFROM;
         }
 
         return $text.$xoopsConfig['sitename']." : <a href=".XOOPS_URL."/modules/smartfaq/faq.php?faqid=".$this->faqid().">".XOOPS_URL."/modules/smartfaq/faq.php?faqid=".$this->faqid()."</a>";
     }
 
-    function toArray($faq= array(), $category= null, $linkInQuestion= true)
+    function toArray($faq = array(), $category = null, $linkInQuestion = true)
     {
 
         global $xoopsModuleConfig;
-        $lastfaqsize= intval($xoopsModuleConfig['lastfaqsize']);
+        $lastfaqsize = intval($xoopsModuleConfig['lastfaqsize']);
 
-        $faq['id']= $this->faqid();
-        $faq['categoryid']= $this->categoryid();
-        $faq['question']= $this->question();
-        $page=($this->status() == _SF_STATUS_OPENED) ? 'answer.php' : 'faq.php';
+        $faq['id'] = $this->faqid();
+        $faq['categoryid'] = $this->categoryid();
+        $faq['question'] = $this->question();
+        $page = ($this->status() == _SF_STATUS_OPENED) ? 'answer.php' : 'faq.php';
 
-        $faq['questionlink']= "<a href='$page?faqid=".$this->faqid()."'>".$this->question($lastfaqsize)."</a>";
+        $faq['questionlink'] = "<a href='$page?faqid=".$this->faqid()."'>".$this->question($lastfaqsize)."</a>";
         if ($linkInQuestion) {
-            $faq['fullquestionlink']= "<a href='$page?faqid=".$this->faqid()."'>".$this->question()."</a>";
+            $faq['fullquestionlink'] = "<a href='$page?faqid=".$this->faqid()."'>".$this->question()."</a>";
         } else {
-            $faq['fullquestionlink']= $this->question();
+            $faq['fullquestionlink'] = $this->question();
         }
-        $faq['faqid']= $this->faqid();
-        $faq['counter']= $this->counter();
-        $faq['cancomment']= $this->cancomment();
-        $faq['comments']= $this->comments();
-        $faq['datesub']= $this->datesub();
+        $faq['faqid'] = $this->faqid();
+        $faq['counter'] = $this->counter();
+        $faq['cancomment'] = $this->cancomment();
+        $faq['comments'] = $this->comments();
+        $faq['datesub'] = $this->datesub();
         if (isset($category)) {
             if (is_object($category) && strtolower(get_class($category)) == 'sfcategory') {
-                $categoryObj= $category;
+                $categoryObj = $category;
             } elseif (is_array($category)) {
-                $categoryObj= $category[$this->categoryid()];
+                $categoryObj = $category[$this->categoryid()];
             }
-            $faq['categoryname']= $categoryObj->getVar('name');
-            $faq['categorylink']= "<a href='".XOOPS_URL."/modules/smartfaq/category.php?categoryid=".$this->categoryid()."'>".$categoryObj->getVar('name')."</a>";
+            $faq['categoryname'] = $categoryObj->getVar('name');
+            $faq['categorylink'] = "<a href='".XOOPS_URL."/modules/smartfaq/category.php?categoryid=".$this->categoryid()."'>".$categoryObj->getVar('name')."</a>";
         }
 
         return $faq;
@@ -579,9 +579,9 @@ 
 
 class sfFaqHandler extends XoopsObjectHandler
 {
-    function & create($isNew= true)
+    function & create($isNew = true)
     {
-        $faq= new sfFaq();
+        $faq = new sfFaq();
         if ($isNew) {
             $faq->setDefaultPermissions();
             $faq->setNew();
@@ -599,14 +599,14 @@ 
     function & get($id)
     {
         if (intval($id) > 0) {
-            $sql= 'SELECT * FROM '.$this->db->prefix('smartfaq_faq').' WHERE faqid='.$id;
-            if (!$result= $this->db->query($sql)) {
+            $sql = 'SELECT * FROM '.$this->db->prefix('smartfaq_faq').' WHERE faqid='.$id;
+            if (!$result = $this->db->query($sql)) {
                 return false;
             }
 
-            $numrows= $this->db->getRowsNum($result);
+            $numrows = $this->db->getRowsNum($result);
             if ($numrows == 1) {
-                $faq= new sfFaq();
+                $faq = new sfFaq();
                 $faq->assignVars($this->db->fetchArray($result));
 
                 return $faq;
@@ -623,7 +623,7 @@ 
     * @param bool $force
     * @return bool FALSE if failed, TRUE if already present and unchanged or successful
     */
-    function insert(& $faq, $force= false)
+    function insert(& $faq, $force = false)
     {
 
         if (strtolower(get_class($faq)) != 'sffaq') {
@@ -639,19 +639,19 @@ 
         }
 
         foreach ($faq->cleanVars as $k => $v) {
-            ${ $k }= $v;
+            ${ $k } = $v;
         }
 
         if ($faq->isNew()) {
-            $sql= sprintf("INSERT INTO %s (faqid, categoryid, question, howdoi, diduno, uid, datesub, `status`, counter, weight, html, smiley, xcodes, cancomment, comments, notifypub, modulelink, contextpage, exacturl, partialview) VALUES (NULL, %u, %s, %s, %s, %u, %u, %u, %u, %u, %u, %u, %u, %u, %u, %u, %s, %s, %u, %u)", $this->db->prefix('smartfaq_faq'), $categoryid, $this->db->quoteString($question), $this->db->quoteString($howdoi), $this->db->quoteString($diduno), $uid, time(), $status, $counter, $weight, $html, $smiley, $xcodes, $cancomment, $comments, $notifypub, $this->db->quoteString($modulelink), $this->db->quoteString($contextpage), $exacturl, $partialview);
+            $sql = sprintf("INSERT INTO %s (faqid, categoryid, question, howdoi, diduno, uid, datesub, `status`, counter, weight, html, smiley, xcodes, cancomment, comments, notifypub, modulelink, contextpage, exacturl, partialview) VALUES (NULL, %u, %s, %s, %s, %u, %u, %u, %u, %u, %u, %u, %u, %u, %u, %u, %s, %s, %u, %u)", $this->db->prefix('smartfaq_faq'), $categoryid, $this->db->quoteString($question), $this->db->quoteString($howdoi), $this->db->quoteString($diduno), $uid, time(), $status, $counter, $weight, $html, $smiley, $xcodes, $cancomment, $comments, $notifypub, $this->db->quoteString($modulelink), $this->db->quoteString($contextpage), $exacturl, $partialview);
 
         } else {
-            $sql= sprintf("UPDATE %s SET categoryid = %u, question = %s, howdoi = %s, diduno = %s, uid = %u, datesub = %u, `status` = %u, counter = %u, weight = %u, html = %u, smiley = %u, xcodes = %u, cancomment = %u, comments = %u, notifypub = %u, modulelink = %s, contextpage = %s, exacturl = %u, partialview = %u  WHERE faqid = %u", $this->db->prefix('smartfaq_faq'), $categoryid, $this->db->quoteString($question), $this->db->quoteString($howdoi), $this->db->quoteString($diduno), $uid, $datesub, $status, $counter, $weight, $html, $smiley, $xcodes, $cancomment, $comments, $notifypub, $this->db->quoteString($modulelink), $this->db->quoteString($contextpage), $exacturl, $partialview, $faqid);
+            $sql = sprintf("UPDATE %s SET categoryid = %u, question = %s, howdoi = %s, diduno = %s, uid = %u, datesub = %u, `status` = %u, counter = %u, weight = %u, html = %u, smiley = %u, xcodes = %u, cancomment = %u, comments = %u, notifypub = %u, modulelink = %s, contextpage = %s, exacturl = %u, partialview = %u  WHERE faqid = %u", $this->db->prefix('smartfaq_faq'), $categoryid, $this->db->quoteString($question), $this->db->quoteString($howdoi), $this->db->quoteString($diduno), $uid, $datesub, $status, $counter, $weight, $html, $smiley, $xcodes, $cancomment, $comments, $notifypub, $this->db->quoteString($modulelink), $this->db->quoteString($contextpage), $exacturl, $partialview, $faqid);
         }
         if (false != $force) {
-            $result= $this->db->queryF($sql);
+            $result = $this->db->queryF($sql);
         } else {
-            $result= $this->db->query($sql);
+            $result = $this->db->query($sql);
         }
 
         if (!$result) {
@@ -674,28 +674,28 @@ 
     * @param bool $force
     * @return bool FALSE if failed.
     */
-    function delete(& $faq, $force= false)
+    function delete(& $faq, $force = false)
     {
-        $smartModule= & sf_getModuleInfo();
-        $module_id= $smartModule->getVar('mid');
+        $smartModule = & sf_getModuleInfo();
+        $module_id = $smartModule->getVar('mid');
 
         if (strtolower(get_class($faq)) != 'sffaq') {
             return false;
         }
 
         // Deleting the answers
-        $answer_handler= new sfAnswerHandler($this->db);
+        $answer_handler = new sfAnswerHandler($this->db);
         if (!$answer_handler->deleteFaqAnswers($faq)) {
             // error msg...
             echo "error while deleteing an answer";
         }
 
-        $sql= sprintf("DELETE FROM %s WHERE faqid = %u", $this->db->prefix("smartfaq_faq"), $faq->getVar('faqid'));
+        $sql = sprintf("DELETE FROM %s WHERE faqid = %u", $this->db->prefix("smartfaq_faq"), $faq->getVar('faqid'));
 
         if (false != $force) {
-            $result= $this->db->queryF($sql);
+            $result = $this->db->queryF($sql);
         } else {
-            $result= $this->db->query($sql);
+            $result = $this->db->query($sql);
         }
         if (!$result) {
             return false;
@@ -713,14 +713,14 @@ 
     * @param bool $id_as_key use the faqid as key for the array?
     * @return array array of {@link sfFaq} objects
     */
-    function & getObjects($criteria= null, $id_as_key= false, $notNullFields= '')
+    function & getObjects($criteria = null, $id_as_key = false, $notNullFields = '')
     {
-        $ret= array();
-        $limit= $start= 0;
-        $sql= 'SELECT * FROM '.$this->db->prefix('smartfaq_faq');
+        $ret = array();
+        $limit = $start = 0;
+        $sql = 'SELECT * FROM '.$this->db->prefix('smartfaq_faq');
 
         if (isset($criteria) && is_subclass_of($criteria, 'criteriaelement')) {
-            $whereClause= $criteria->renderWhere();
+            $whereClause = $criteria->renderWhere();
 
             if ($whereClause != 'WHERE ()') {
                 $sql .= ' '.$criteria->renderWhere();
@@ -733,14 +733,14 @@ 
             if ($criteria->getSort() != '') {
                 $sql .= ' ORDER BY '.$criteria->getSort().' '.$criteria->getOrder();
             }
-            $limit= $criteria->getLimit();
-            $start= $criteria->getStart();
+            $limit = $criteria->getLimit();
+            $start = $criteria->getStart();
         } elseif (!empty($notNullFields)) {
             $sql .= $sql .= " WHERE ".$this->NotNullFieldClause($notNullFields);
         }
 
         //echo "<br />" . $sql . "<br />";
-        $result= $this->db->query($sql, $limit, $start);
+        $result = $this->db->query($sql, $limit, $start);
         if (!$result) {
             return false;
         }
@@ -749,14 +749,14 @@ 
             return false;
         }
 
-        while ($myrow= $this->db->fetchArray($result)) {
-            $faq= new sfFaq();
+        while ($myrow = $this->db->fetchArray($result)) {
+            $faq = new sfFaq();
             $faq->assignVars($myrow);
 
             if (!$id_as_key) {
-                $ret[]= & $faq;
+                $ret[] = & $faq;
             } else {
-                $ret[$myrow['faqid']]= & $faq;
+                $ret[$myrow['faqid']] = & $faq;
             }
             unset($faq);
         }
@@ -764,11 +764,11 @@ 
         return $ret;
     }
 
-    function & getObjectsAdminSide($criteria= null, $id_as_key= false, $notNullFields= '')
+    function & getObjectsAdminSide($criteria = null, $id_as_key = false, $notNullFields = '')
     {
-        $ret= array();
-        $limit= $start= 0;
-        $sql= "SELECT
+        $ret = array();
+        $limit = $start = 0;
+        $sql = "SELECT
                             faq.faqid AS faqid,
                             faq.categoryid AS categoryid,
                             faq.question AS question,
@@ -793,7 +793,7 @@ 
                 FROM ".$this->db->prefix('smartfaq_faq')." AS faq INNER JOIN ".$this->db->prefix('smartfaq_categories')." AS category ON faq.categoryid = category.categoryid ";
 
         if (isset($criteria) && is_subclass_of($criteria, 'criteriaelement')) {
-            $whereClause= $criteria->renderWhere();
+            $whereClause = $criteria->renderWhere();
 
             if ($whereClause != 'WHERE ()') {
                 $sql .= ' '.$criteria->renderWhere();
@@ -806,14 +806,14 @@ 
             if ($criteria->getSort() != '') {
                 $sql .= ' ORDER BY '.$criteria->getSort().' '.$criteria->getOrder();
             }
-            $limit= $criteria->getLimit();
-            $start= $criteria->getStart();
+            $limit = $criteria->getLimit();
+            $start = $criteria->getStart();
         } elseif (!empty($notNullFields)) {
             $sql .= $sql .= " WHERE ".$this->NotNullFieldClause($notNullFields);
         }
 
         //echo "<br />" . $sql . "<br />";
-        $result= $this->db->query($sql, $limit, $start);
+        $result = $this->db->query($sql, $limit, $start);
         if (!$result) {
             return false;
         }
@@ -822,14 +822,14 @@ 
             return false;
         }
 
-        while ($myrow= $this->db->fetchArray($result)) {
-            $faq= new sfFaq();
+        while ($myrow = $this->db->fetchArray($result)) {
+            $faq = new sfFaq();
             $faq->assignVars($myrow);
 
             if (!$id_as_key) {
-                $ret[]= & $faq;
+                $ret[] = & $faq;
             } else {
-                $ret[$myrow['faqid']]= & $faq;
+                $ret[$myrow['faqid']] = & $faq;
             }
             unset($faq);
         }
@@ -856,11 +856,11 @@ 
     * @param object $criteria {@link CriteriaElement} to match
     * @return int count of FAQs
     */
-    function getCount($criteria= null, $notNullFields= '')
+    function getCount($criteria = null, $notNullFields = '')
     {
-        $sql= 'SELECT COUNT(*) FROM '.$this->db->prefix('smartfaq_faq');
+        $sql = 'SELECT COUNT(*) FROM '.$this->db->prefix('smartfaq_faq');
         if (isset($criteria) && is_subclass_of($criteria, 'criteriaelement')) {
-            $whereClause= $criteria->renderWhere();
+            $whereClause = $criteria->renderWhere();
             if ($whereClause != 'WHERE ()') {
                 $sql .= ' '.$criteria->renderWhere();
                 if (!empty($notNullFields)) {
@@ -874,16 +874,16 @@ 
         }
 
         //echo "<br />" . $sql . "<br />";
-        $result= $this->db->query($sql);
+        $result = $this->db->query($sql);
         if (!$result) {
             return 0;
         }
-        list($count)= $this->db->fetchRow($result);
+        list($count) = $this->db->fetchRow($result);
 
         return $count;
     }
 
-    function getFaqsCount($categoryid= -1, $status= '', $notNullFields= '')
+    function getFaqsCount($categoryid = -1, $status = '', $notNullFields = '')
     {
 
         global $xoopsUser;
@@ -892,16 +892,16 @@ 
         //return $this->getCount();
         //}
 
-        $userIsAdmin= sf_userIsAdmin();
+        $userIsAdmin = sf_userIsAdmin();
         // Categories for which user has access
         if (!$userIsAdmin) {
-            $smartPermHandler= & xoops_getmodulehandler('permission', 'smartfaq');
+            $smartPermHandler = & xoops_getmodulehandler('permission', 'smartfaq');
 
-            $categoriesGranted= $smartPermHandler->getPermissions('category');
-            $grantedCategories= new Criteria('categoryid', "(".implode(',', $categoriesGranted).")", 'IN');
+            $categoriesGranted = $smartPermHandler->getPermissions('category');
+            $grantedCategories = new Criteria('categoryid', "(".implode(',', $categoriesGranted).")", 'IN');
 
-            $faqsGranted= $smartPermHandler->getPermissions('item');
-            $grantedFaq= new CriteriaCompo();
+            $faqsGranted = $smartPermHandler->getPermissions('item');
+            $grantedFaq = new CriteriaCompo();
             $grantedFaq->add(new Criteria('faqid', "(".implode(',', $faqsGranted).")", 'IN'), 'OR');
             // If user is anonymous, check if the FAQ allow partialview
             if (!is_object($xoopsUser)) {
@@ -909,31 +909,31 @@ 
             }
         }
 
-        if (isset($categoryid) &&($categoryid != -1)) {
-            $criteriaCategory= new criteria('categoryid', $categoryid);
+        if (isset($categoryid) && ($categoryid != -1)) {
+            $criteriaCategory = new criteria('categoryid', $categoryid);
         }
 
-        $criteriaStatus= new CriteriaCompo();
-        if (!empty($status) &&(is_array($status))) {
+        $criteriaStatus = new CriteriaCompo();
+        if (!empty($status) && (is_array($status))) {
             foreach ($status as $v) {
                 $criteriaStatus->add(new Criteria('status', $v), 'OR');
             }
-        } elseif (!empty($status) &&($status != -1)) {
+        } elseif (!empty($status) && ($status != -1)) {
             $criteriaStatus->add(new Criteria('status', $status), 'OR');
         }
 
-        $criteriaPermissions= new CriteriaCompo();
+        $criteriaPermissions = new CriteriaCompo();
         if (!$userIsAdmin) {
             $criteriaPermissions->add($grantedCategories, 'AND');
             $criteriaPermissions->add($grantedFaq, 'AND');
         }
 
-        $criteria= new CriteriaCompo();
+        $criteria = new CriteriaCompo();
         if (!empty($criteriaCategory)) {
             $criteria->add($criteriaCategory);
         }
 
-        if (!empty($criteriaPermissions) &&(!$userIsAdmin)) {
+        if (!empty($criteriaPermissions) && (!$userIsAdmin)) {
             $criteria->add($criteriaPermissions);
         }
 
@@ -946,25 +946,25 @@ 
 
     function getFaqsCountByStatus()
     {
-        $sql= 'SELECT status, COUNT(*) FROM '.$this->db->prefix('smartfaq_faq').' GROUP BY status';
-        $result= $this->db->query($sql);
+        $sql = 'SELECT status, COUNT(*) FROM '.$this->db->prefix('smartfaq_faq').' GROUP BY status';
+        $result = $this->db->query($sql);
         if (!$result) {
             return array();
         }
-        $ret= array();
-        while (list($status, $count)= $this->db->fetchRow($result)) {
-            $ret[$status]= $count;
+        $ret = array();
+        while (list($status, $count) = $this->db->fetchRow($result)) {
+            $ret[$status] = $count;
         }
 
         return $ret;
     }
 
-    function getAllPublished($limit= 0, $start= 0, $categoryid= -1, $sort= 'datesub', $order= 'DESC', $asobject= true)
+    function getAllPublished($limit = 0, $start = 0, $categoryid = -1, $sort = 'datesub', $order = 'DESC', $asobject = true)
     {
         return $this->getFaqs($limit, $start, array(_SF_STATUS_PUBLISHED, _SF_STATUS_NEW_ANSWER), $categoryid, $sort, $order, null, $asobject, null);
     }
 
-    function getFaqs($limit= 0, $start= 0, $status= '', $categoryid= -1, $sort= 'datesub', $order= 'DESC', $notNullFields= '', $asobject= true, $otherCriteria= null)
+    function getFaqs($limit = 0, $start = 0, $status = '', $categoryid = -1, $sort = 'datesub', $order = 'DESC', $notNullFields = '', $asobject = true, $otherCriteria = null)
     {
         global $xoopsUser;
         include_once XOOPS_ROOT_PATH.'/modules/smartfaq/include/functions.php';
@@ -972,17 +972,17 @@ 
         //if ( ($categoryid == -1) && (empty($status) || ($status == -1)) && ($limit == 0) && ($start ==0) ) {
         //	return $this->getObjects();
         //}
-        $ret= array();
-        $userIsAdmin= sf_userIsAdmin();
+        $ret = array();
+        $userIsAdmin = sf_userIsAdmin();
         // Categories for which user has access
         if (!$userIsAdmin) {
-            $smartPermHandler= & xoops_getmodulehandler('permission', 'smartfaq');
+            $smartPermHandler = & xoops_getmodulehandler('permission', 'smartfaq');
 
-            $categoriesGranted= $smartPermHandler->getPermissions('category');
-            $grantedCategories= new Criteria('categoryid', "(".implode(',', $categoriesGranted).")", 'IN');
+            $categoriesGranted = $smartPermHandler->getPermissions('category');
+            $grantedCategories = new Criteria('categoryid', "(".implode(',', $categoriesGranted).")", 'IN');
 
-            $faqsGranted= $smartPermHandler->getPermissions('item');
-            $grantedFaq= new CriteriaCompo();
+            $faqsGranted = $smartPermHandler->getPermissions('item');
+            $grantedFaq = new CriteriaCompo();
             $grantedFaq->add(new Criteria('faqid', "(".implode(',', $faqsGranted).")", 'IN'), 'OR');
             // If user is anonymous, check if the FAQ allow partialview
             if (!is_object($xoopsUser)) {
@@ -991,36 +991,36 @@ 
 
         }
 
-        if (isset($categoryid) &&($categoryid != -1)) {
+        if (isset($categoryid) && ($categoryid != -1)) {
             if (is_array($categoryid)) {
-                $criteriaCategory= new Criteria('categoryid', "(".implode(',', $categoryid).")", 'IN');
+                $criteriaCategory = new Criteria('categoryid', "(".implode(',', $categoryid).")", 'IN');
             } else {
-                $criteriaCategory= new Criteria('categoryid', intval($categoryid));
+                $criteriaCategory = new Criteria('categoryid', intval($categoryid));
             }
         }
 
-        if (!empty($status) &&(is_array($status))) {
-            $criteriaStatus= new CriteriaCompo();
+        if (!empty($status) && (is_array($status))) {
+            $criteriaStatus = new CriteriaCompo();
             foreach ($status as $v) {
                 $criteriaStatus->add(new Criteria('status', $v), 'OR');
             }
-        } elseif (!empty($status) &&($status != -1)) {
-            $criteriaStatus= new CriteriaCompo();
+        } elseif (!empty($status) && ($status != -1)) {
+            $criteriaStatus = new CriteriaCompo();
             $criteriaStatus->add(new Criteria('status', $status), 'OR');
         }
 
-        $criteriaPermissions= new CriteriaCompo();
+        $criteriaPermissions = new CriteriaCompo();
         if (!$userIsAdmin) {
             $criteriaPermissions->add($grantedCategories, 'AND');
             $criteriaPermissions->add($grantedFaq, 'AND');
         }
 
-        $criteria= new CriteriaCompo();
+        $criteria = new CriteriaCompo();
         if (!empty($criteriaCategory)) {
             $criteria->add($criteriaCategory);
         }
 
-        if (!empty($criteriaPermissions) &&(!$userIsAdmin)) {
+        if (!empty($criteriaPermissions) && (!$userIsAdmin)) {
             $criteria->add($criteriaPermissions);
         }
 
@@ -1036,34 +1036,34 @@ 
         $criteria->setStart($start);
         $criteria->setSort($sort);
         $criteria->setOrder($order);
-        $ret= & $this->getObjects($criteria, false, $notNullFields);
+        $ret = & $this->getObjects($criteria, false, $notNullFields);
 
         return $ret;
     }
 
-    function getFaqsAdminSide($limit= 0, $start= 0, $status= '', $categoryid= -1, $sort= 'datesub', $order= 'DESC', $asobject= true, $otherCriteria= null)
+    function getFaqsAdminSide($limit = 0, $start = 0, $status = '', $categoryid = -1, $sort = 'datesub', $order = 'DESC', $asobject = true, $otherCriteria = null)
     {
         include_once XOOPS_ROOT_PATH.'/modules/smartfaq/include/functions.php';
 
-        $smartModule= & sf_getModuleInfo();
+        $smartModule = & sf_getModuleInfo();
 
-        $ret= array();
+        $ret = array();
 
-        if (isset($categoryid) &&($categoryid != -1)) {
-            $criteriaCategory= new criteria('faq.categoryid', $categoryid);
+        if (isset($categoryid) && ($categoryid != -1)) {
+            $criteriaCategory = new criteria('faq.categoryid', $categoryid);
         }
 
-        if (!empty($status) &&(is_array($status))) {
-            $criteriaStatus= new CriteriaCompo();
+        if (!empty($status) && (is_array($status))) {
+            $criteriaStatus = new CriteriaCompo();
             foreach ($status as $v) {
                 $criteriaStatus->add(new Criteria('faq.status', $v), 'OR');
             }
-        } elseif (!empty($status) &&($status != -1)) {
-            $criteriaStatus= new CriteriaCompo();
+        } elseif (!empty($status) && ($status != -1)) {
+            $criteriaStatus = new CriteriaCompo();
             $criteriaStatus->add(new Criteria('faq.status', $status), 'OR');
         }
 
-        $criteria= new CriteriaCompo();
+        $criteria = new CriteriaCompo();
         if (!empty($criteriaCategory)) {
             $criteria->add($criteriaCategory);
         }
@@ -1080,27 +1080,27 @@ 
         $criteria->setStart($start);
         $criteria->setSort($sort);
         $criteria->setOrder($order);
-        $ret= & $this->getObjectsAdminSide($criteria, false);
+        $ret = & $this->getObjectsAdminSide($criteria, false);
 
         return $ret;
     }
 
-    function getRandomFaq($field= '', $status= '', $category= -1)
+    function getRandomFaq($field = '', $status = '', $category = -1)
     {
-        $ret= false;
+        $ret = false;
 
-        $notNullFields= $field;
+        $notNullFields = $field;
 
         // Getting the number of published FAQ
-        $totalFaqs= $this->getFaqsCount(-1, $status, $notNullFields);
+        $totalFaqs = $this->getFaqsCount(-1, $status, $notNullFields);
 
         if ($totalFaqs > 0) {
-            $totalFaqs= $totalFaqs -1;
+            $totalFaqs = $totalFaqs-1;
             mt_srand((double) microtime() * 1000000);
-            $entrynumber= mt_rand(0, $totalFaqs);
-            $faq= & $this->getFaqs(1, $entrynumber, $status, -1, 'datesub', 'DESC', $notNullFields);
+            $entrynumber = mt_rand(0, $totalFaqs);
+            $faq = & $this->getFaqs(1, $entrynumber, $status, -1, 'datesub', 'DESC', $notNullFields);
             if ($faq) {
-                $ret= & $faq[0];
+                $ret = & $faq[0];
             }
         }
 
@@ -1108,92 +1108,92 @@ 
 
     }
 
-    function getContextualFaqs($limit= 0)
+    function getContextualFaqs($limit = 0)
     {
-        $ret= false;
+        $ret = false;
 
-        $otherCriteria= new CriteriaCompo();
+        $otherCriteria = new CriteriaCompo();
         $otherCriteria->add(new Criteria('modulelink', 'None', '<>'));
 
-        $faqsObj= & $this->getFaqs(0, 0, Array(_SF_STATUS_PUBLISHED, _SF_STATUS_NEW_ANSWER), -1, 'datesub', 'DESC', '', true, $otherCriteria);
+        $faqsObj = & $this->getFaqs(0, 0, Array(_SF_STATUS_PUBLISHED, _SF_STATUS_NEW_ANSWER), -1, 'datesub', 'DESC', '', true, $otherCriteria);
 
-        $totalfaqs= count($faqsObj);
-        $randomFaqs= array();
+        $totalfaqs = count($faqsObj);
+        $randomFaqs = array();
         if ($faqsObj) {
-            for ($i= 0; $i < $totalfaqs; ++$i) {
-                $display= false;
+            for ($i = 0; $i < $totalfaqs; ++$i) {
+                $display = false;
 
-                $http=((strpos(XOOPS_URL, "https://")) === false) ?("http://") :("https://");
-                $phpself= $_SERVER['PHP_SELF'];
-                $httphost= $_SERVER['HTTP_HOST'];
-                $querystring= $_SERVER['QUERY_STRING'];
+                $http = ((strpos(XOOPS_URL, "https://")) === false) ? ("http://") : ("https://");
+                $phpself = $_SERVER['PHP_SELF'];
+                $httphost = $_SERVER['HTTP_HOST'];
+                $querystring = $_SERVER['QUERY_STRING'];
                 if ($querystring != '') {
-                    $querystring= '?'.$querystring;
+                    $querystring = '?'.$querystring;
                 }
-                $currenturl= $http.$httphost.$phpself.$querystring;
-                $fullcontexturl= XOOPS_URL."/".$faqsObj[$i]->contextpage();
+                $currenturl = $http.$httphost.$phpself.$querystring;
+                $fullcontexturl = XOOPS_URL."/".$faqsObj[$i]->contextpage();
                 switch ($faqsObj[$i]->modulelink()) {
                     case '' :
-                        $display= false;
+                        $display = false;
                         break;
                     case 'None' :
-                        $display= false;
+                        $display = false;
                         break;
                     case 'All' :
-                        $display= true;
+                        $display = true;
                         break;
                     case 'url' :
                         if ($faqsObj[$i]->exacturl()) {
-                            $display=($currenturl == $fullcontexturl);
+                            $display = ($currenturl == $fullcontexturl);
                         } else {
-                            $display=(strpos($currenturl, $fullcontexturl) === false) ?(false) :(true);
+                            $display = (strpos($currenturl, $fullcontexturl) === false) ? (false) : (true);
                         }
                         break;
                     default :
                         if (strpos($currenturl, XOOPS_URL."/modules/") === false) {
-                            $display= false;
+                            $display = false;
                         } else {
                             if (strpos($currenturl, $faqsObj[$i]->modulelink()) === false) {
-                                $display= false;
+                                $display = false;
                             } else {
-                                $display= true;
+                                $display = true;
                             }
                         }
                         break;
                 }
                 if ($display) {
-                    $randomFaqs[]= & $faqsObj[$i];
+                    $randomFaqs[] = & $faqsObj[$i];
                 }
             }
         }
 
         if (count($randomFaqs) > $limit) {
             srand((float) microtime() * 10000000);
-            $rand_keys= array_rand($randomFaqs, $limit);
-            for ($j= 0; $j < count($rand_keys); ++$j) {
-                $ret[]= & $randomFaqs[$rand_keys[$j]];
+            $rand_keys = array_rand($randomFaqs, $limit);
+            for ($j = 0; $j < count($rand_keys); ++$j) {
+                $ret[] = & $randomFaqs[$rand_keys[$j]];
             }
         } else {
-            $ret= & $randomFaqs;
+            $ret = & $randomFaqs;
         }
 
         return $ret;
     }
 
-    function getLastPublishedByCat($status= array(_SF_STATUS_PUBLISHED, _SF_STATUS_NEW_ANSWER))
+    function getLastPublishedByCat($status = array(_SF_STATUS_PUBLISHED, _SF_STATUS_NEW_ANSWER))
     {
-        $ret= array();
-        $faqclause= "";
+        $ret = array();
+        $faqclause = "";
         if (!sf_userIsAdmin()) {
-            $smartPermHandler= & xoops_getmodulehandler('permission', 'smartfaq');
-            $items= $smartPermHandler->getPermissions('item');
-            $faqclause= " AND faqid IN (".implode(',', $items).")";
+            $smartPermHandler = & xoops_getmodulehandler('permission', 'smartfaq');
+            $items = $smartPermHandler->getPermissions('item');
+            $faqclause = " AND faqid IN (".implode(',', $items).")";
         }
 
-        $sql= "CREATE TEMPORARY TABLE tmp (categoryid INT(8) UNSIGNED NOT NULL,datesub int(11) DEFAULT '0' NOT NULL);";
-        $sql2= " LOCK TABLES ".$this->db->prefix('smartfaq_faq')." READ;";
-        $sql3= " INSERT INTO tmp SELECT categoryid, MAX(datesub) FROM ".$this->db->prefix('smartfaq_faq')." WHERE status IN (".implode(',', $status).") $faqclause GROUP BY categoryid;";
-        $sql4= " SELECT ".$this->db->prefix('smartfaq_faq').".categoryid, faqid, question, uid, ".$this->db->prefix('smartfaq_faq').".datesub FROM ".$this->db->prefix('smartfaq_faq').", tmp
+        $sql = "CREATE TEMPORARY TABLE tmp (categoryid INT(8) UNSIGNED NOT NULL,datesub int(11) DEFAULT '0' NOT NULL);";
+        $sql2 = " LOCK TABLES ".$this->db->prefix('smartfaq_faq')." READ;";
+        $sql3 = " INSERT INTO tmp SELECT categoryid, MAX(datesub) FROM ".$this->db->prefix('smartfaq_faq')." WHERE status IN (".implode(',', $status).") $faqclause GROUP BY categoryid;";
+        $sql4 = " SELECT ".$this->db->prefix('smartfaq_faq').".categoryid, faqid, question, uid, ".$this->db->prefix('smartfaq_faq').".datesub FROM ".$this->db->prefix('smartfaq_faq').", tmp
                               WHERE ".$this->db->prefix('smartfaq_faq').".categoryid=tmp.categoryid AND ".$this->db->prefix('smartfaq_faq').".datesub=tmp.datesub;";
         /*
         //Old implementation
@@ -1204,8 +1204,8 @@ 
         $this->db->queryF($sql);
         $this->db->queryF($sql2);
         $this->db->queryF($sql3);
-        $result= $this->db->query($sql4);
-        $error= $this->db->error();
+        $result = $this->db->query($sql4);
+        $error = $this->db->error();
         $this->db->queryF("UNLOCK TABLES;");
         $this->db->queryF("DROP TABLE tmp;");
         if (!$result) {
@@ -1213,10 +1213,10 @@ 
 
             return $ret;
         }
-        while ($row= $this->db->fetchArray($result)) {
-            $faq= new sfFaq();
+        while ($row = $this->db->fetchArray($result)) {
+            $faq = new sfFaq();
             $faq->assignVars($row);
-            $ret[$row['categoryid']]= & $faq;
+            $ret[$row['categoryid']] = & $faq;
             unset($faq);
         }
 
@@ -1229,9 +1229,9 @@ 
     * @param object $criteria {@link CriteriaElement}
     * @return bool FALSE if deletion failed
     */
-    function deleteAll($criteria= null)
+    function deleteAll($criteria = null)
     {
-        $sql= 'DELETE FROM '.$this->db->prefix('smartfaq_faq');
+        $sql = 'DELETE FROM '.$this->db->prefix('smartfaq_faq');
         if (isset($criteria) && is_subclass_of($criteria, 'criteriaelement')) {
             $sql .= ' '.$criteria->renderWhere();
         }
@@ -1252,10 +1252,10 @@ 
     *
     * @return  bool
     **/
-    function updateAll($fieldname, $fieldvalue, $criteria= null)
+    function updateAll($fieldname, $fieldvalue, $criteria = null)
     {
-        $set_clause= is_numeric($fieldvalue) ? $fieldname.' = '.$fieldvalue : $fieldname.' = '.$this->db->quoteString($fieldvalue);
-        $sql= 'UPDATE '.$this->db->prefix('smartfaq_faq').' SET '.$set_clause;
+        $set_clause = is_numeric($fieldvalue) ? $fieldname.' = '.$fieldvalue : $fieldname.' = '.$this->db->quoteString($fieldvalue);
+        $sql = 'UPDATE '.$this->db->prefix('smartfaq_faq').' SET '.$set_clause;
         if (isset($criteria) && is_subclass_of($criteria, 'criteriaelement')) {
             $sql .= ' '.$criteria->renderWhere();
         }
@@ -1268,7 +1268,7 @@ 
 
     function updateCounter($faqid)
     {
-        $sql= "UPDATE ".$this->db->prefix("smartfaq_faq")." SET counter=counter+1 WHERE faqid = ".$faqid;
+        $sql = "UPDATE ".$this->db->prefix("smartfaq_faq")." SET counter=counter+1 WHERE faqid = ".$faqid;
         if ($this->db->queryF($sql)) {
             return true;
         } else {
@@ -1276,13 +1276,13 @@ 
         }
     }
 
-    function NotNullFieldClause($notNullFields= '', $withAnd= false)
+    function NotNullFieldClause($notNullFields = '', $withAnd = false)
     {
-        $ret= '';
+        $ret = '';
         if ($withAnd) {
             $ret .= " AND ";
         }
-        if (!empty($notNullFields) &&(is_array($notNullFields))) {
+        if (!empty($notNullFields) && (is_array($notNullFields))) {
             foreach ($notNullFields as $v) {
                 $ret .= " ($v IS NOT NULL AND $v <> ' ' )";
             }
@@ -1293,24 +1293,24 @@ 
         return $ret;
     }
 
-    function getFaqsFromSearch($queryarray= array(), $andor= 'AND', $limit= 0, $offset= 0, $userid= 0)
+    function getFaqsFromSearch($queryarray = array(), $andor = 'AND', $limit = 0, $offset = 0, $userid = 0)
     {
         global $xoopsUser;
 
-        $ret= array();
+        $ret = array();
 
-        $userIsAdmin= sf_userIsAdmin();
+        $userIsAdmin = sf_userIsAdmin();
 
         if ($userid != 0) {
-            $criteriaUser= new CriteriaCompo();
+            $criteriaUser = new CriteriaCompo();
             $criteriaUser->add(new Criteria('faq.uid', $userid), 'OR');
             $criteriaUser->add(new Criteria('answer.uid', $userid), 'OR');
         }
 
         if ($queryarray) {
-            $criteriaKeywords= new CriteriaCompo();
-            for ($i= 0; $i < count($queryarray); ++$i) {
-                $criteriaKeyword= new CriteriaCompo();
+            $criteriaKeywords = new CriteriaCompo();
+            for ($i = 0; $i < count($queryarray); ++$i) {
+                $criteriaKeyword = new CriteriaCompo();
                 $criteriaKeyword->add(new Criteria('faq.question', '%'.$queryarray[$i].'%', 'LIKE'), 'OR');
                 $criteriaKeyword->add(new Criteria('answer.answer', '%'.$queryarray[$i].'%', 'LIKE'), 'OR');
                 $criteriaKeywords->add($criteriaKeyword, $andor);
@@ -1320,18 +1320,18 @@ 
 
         // Categories for which user has access
         if (!$userIsAdmin) {
-            $smartPermHandler= & xoops_getmodulehandler('permission', 'smartfaq');
+            $smartPermHandler = & xoops_getmodulehandler('permission', 'smartfaq');
 
-            $categoriesGranted= $smartPermHandler->getPermissions('category');
-            $faqsGranted= $smartPermHandler->getPermissions('item');
+            $categoriesGranted = $smartPermHandler->getPermissions('category');
+            $faqsGranted = $smartPermHandler->getPermissions('item');
             if (!$categoriesGranted) {
                 return $ret;
             }
             if (!$faqsGranted) {
                 return $ret;
             }
-            $grantedCategories= new Criteria('faq.categoryid', "(".implode(',', $categoriesGranted).")", 'IN');
-            $grantedFaq= new CriteriaCompo();
+            $grantedCategories = new Criteria('faq.categoryid', "(".implode(',', $categoriesGranted).")", 'IN');
+            $grantedFaq = new CriteriaCompo();
             $grantedFaq->add(new Criteria('faq.faqid', "(".implode(',', $faqsGranted).")", 'IN'), 'OR');
             // If user is anonymous, check if the FAQ allow partialview
             if (!is_object($xoopsUser)) {
@@ -1339,20 +1339,20 @@ 
             }
         }
 
-        $criteriaPermissions= new CriteriaCompo();
+        $criteriaPermissions = new CriteriaCompo();
         if (!$userIsAdmin) {
             $criteriaPermissions->add($grantedCategories, 'AND');
             $criteriaPermissions->add($grantedFaq, 'AND');
         }
 
-        $criteriaAnswersStatus= new CriteriaCompo();
+        $criteriaAnswersStatus = new CriteriaCompo();
         $criteriaAnswersStatus->add(new Criteria('answer.status', _SF_AN_STATUS_APPROVED));
 
-        $criteriaFasStatus= new CriteriaCompo();
+        $criteriaFasStatus = new CriteriaCompo();
         $criteriaFasStatus->add(new Criteria('faq.status', _SF_STATUS_OPENED), 'OR');
         $criteriaFasStatus->add(new Criteria('faq.status', _SF_STATUS_PUBLISHED), 'OR');
 
-        $criteria= new CriteriaCompo();
+        $criteria = new CriteriaCompo();
         if (!empty($criteriaUser)) {
             $criteria->add($criteriaUser, 'AND');
         }
@@ -1361,7 +1361,7 @@ 
             $criteria->add($criteriaKeywords, 'AND');
         }
 
-        if (!empty($criteriaPermissions) &&(!$userIsAdmin)) {
+        if (!empty($criteriaPermissions) && (!$userIsAdmin)) {
             $criteria->add($criteriaPermissions);
         }
 
@@ -1378,24 +1378,24 @@ 
         $criteria->setSort('faq.datesub');
         $criteria->setOrder('DESC');
 
-        $sql= 'SELECT faq.faqid, faq.question, faq.datesub, faq.uid FROM '.$this->db->prefix('smartfaq_faq').' as faq INNER JOIN '.$this->db->prefix('smartfaq_answers').' as answer ON faq.faqid = answer.faqid';
+        $sql = 'SELECT faq.faqid, faq.question, faq.datesub, faq.uid FROM '.$this->db->prefix('smartfaq_faq').' as faq INNER JOIN '.$this->db->prefix('smartfaq_answers').' as answer ON faq.faqid = answer.faqid';
 
         if (isset($criteria) && is_subclass_of($criteria, 'criteriaelement')) {
-            $whereClause= $criteria->renderWhere();
+            $whereClause = $criteria->renderWhere();
 
             if ($whereClause != 'WHERE ()') {
                 $sql .= ' '.$criteria->renderWhere();
                 if ($criteria->getSort() != '') {
                     $sql .= ' ORDER BY '.$criteria->getSort().' '.$criteria->getOrder();
                 }
-                $limit= $criteria->getLimit();
-                $start= $criteria->getStart();
+                $limit = $criteria->getLimit();
+                $start = $criteria->getStart();
             }
         }
 
         //echo "<br />" . $sql . "<br />";
 
-        $result= $this->db->query($sql, $limit, $start);
+        $result = $this->db->query($sql, $limit, $start);
         if (!$result) {
             trigger_error("Query did not work in smartfaq", E_USER_WARNING);
 
@@ -1406,29 +1406,29 @@ 
             return $ret;
         }
 
-        while ($myrow= $this->db->fetchArray($result)) {
-            $faq= new sfFaq();
+        while ($myrow = $this->db->fetchArray($result)) {
+            $faq = new sfFaq();
             $faq->assignVars($myrow);
-            $ret[]= & $faq;
+            $ret[] = & $faq;
             unset($faq);
         }
 
         return $ret;
     }
 
-    function getCountsByCat($cat_id= 0, $status)
+    function getCountsByCat($cat_id = 0, $status)
     {
         global $xoopsUser;
-        $ret= array();
-        $sql= 'SELECT categoryid, COUNT(*) AS count FROM '.$this->db->prefix('smartfaq_faq');
+        $ret = array();
+        $sql = 'SELECT categoryid, COUNT(*) AS count FROM '.$this->db->prefix('smartfaq_faq');
         if (intval($cat_id) > 0) {
             $sql .= ' WHERE categoryid = '.intval($cat_id);
             $sql .= ' AND status IN ('.implode(',', $status).')';
         } else {
             $sql .= ' WHERE status IN ('.implode(',', $status).')';
             if (!sf_userIsAdmin()) {
-                $smartPermHandler= & xoops_getmodulehandler('permission', 'smartfaq');
-                $items= $smartPermHandler->getPermissions('item');
+                $smartPermHandler = & xoops_getmodulehandler('permission', 'smartfaq');
+                $items = $smartPermHandler->getPermissions('item');
                 if (is_object($xoopsUser)) {
                     $sql .= ' AND faqid IN ('.implode(',', $items).')';
                 } else {
@@ -1440,12 +1440,12 @@ 
 
         //echo "<br />" . $sql . "<br />";
 
-        $result= $this->db->query($sql);
+        $result = $this->db->query($sql);
         if (!$result) {
             return $ret;
         }
-        while ($row= $this->db->fetchArray($result)) {
-            $ret[$row['categoryid']]= intval($row['count']);
+        while ($row = $this->db->fetchArray($result)) {
+            $ret[$row['categoryid']] = intval($row['count']);
         }
 
         return $ret;

smartfaq/class/smartdbupdater.php

Doc Comments +4 added lines, -1 removed lines

@@ -164,6 +164,9 @@ 
         return $fields;
     }
 
+    /**
+     * @param string $field
+     */
     function fieldExists($field)
     {
         $existingFields = $this->getExistingFieldsArray();
@@ -620,7 +623,7 @@ 
    /**
     * Use to update a table
     *
-    * @param object $table {@link SmartDbTable} that will be updated
+    * @param SmartDbTable $table {@link SmartDbTable} that will be updated
     *
     * @see SmartDbTable
     *

Indentation +196 added lines, -196 removed lines

@@ -102,7 +102,7 @@ 
     var $_flagForDrop = false;
 
     /**
- * @var array $_updatedFields containing fields which values will be updated
+     * @var array $_updatedFields containing fields which values will be updated
      */
     var $_updatedFields;
 
@@ -111,24 +111,24 @@ 
      */    //felix
     var $_updatedWhere;
 
-   /**
-    * Constructor
-    *
-    * @param string $name name of the table
-    *
-    */
+    /**
+     * Constructor
+     *
+     * @param string $name name of the table
+     *
+     */
     function __construct($name)
     {
         $this->_name = $name;
         $this->_data = array();
     }
 
-   /**
-    * Return the table name, prefixed with site table prefix
-    *
-    * @return string table name
-    *
-    */
+    /**
+     * Return the table name, prefixed with site table prefix
+     *
+     * @return string table name
+     *
+     */
     function name()
     {
         global $xoopsDB;
@@ -136,12 +136,12 @@ 
         return $xoopsDB->prefix($this->_name);
     }
 
-   /**
-    * Checks if the table already exists in the database
-    *
-    * @return bool TRUE if it exists, FALSE if not
-    *
-    */
+    /**
+     * Checks if the table already exists in the database
+     *
+     * @return bool TRUE if it exists, FALSE if not
+     *
+     */
     function exists()
     {
         return smart_TableExists($this->_name);
@@ -152,13 +152,13 @@ 
         global $xoopsDB;
         $result = $xoopsDB->query("SHOW COLUMNS FROM ".$this->name());
         while ($existing_field = $xoopsDB->fetchArray($result)) {
-             $fields[$existing_field['Field']] = $existing_field['Type'];
-             if ($existing_field['Null'] != "YES") {
-                 $fields[$existing_field['Field']] .= " NOT NULL";
-             }
-             if ($existing_field['Extra']) {
-                 $fields[$existing_field['Field']] .= " ".$existing_field['Extra'];
-             }
+                $fields[$existing_field['Field']] = $existing_field['Type'];
+                if ($existing_field['Null'] != "YES") {
+                    $fields[$existing_field['Field']] .= " NOT NULL";
+                }
+                if ($existing_field['Extra']) {
+                    $fields[$existing_field['Field']] .= " ".$existing_field['Extra'];
+                }
         }
 
         return $fields;
@@ -171,56 +171,56 @@ 
         return isset($existingFields[$field]);
     }
 
-   /**
-    * Set the table structure
-    *
-    * @param  string $structure table structure
-    *
-    */
+    /**
+     * Set the table structure
+     *
+     * @param  string $structure table structure
+     *
+     */
     function setStructure($structure)
     {
         $this->_structure = $structure;
     }
 
     /**
-    * Return the table structure
-    *
-    * @return string table structure
-    *
-    */
+     * Return the table structure
+     *
+     * @return string table structure
+     *
+     */
     function getStructure()
     {
         return sprintf($this->_structure, $this->name());
     }
 
-   /**
-    * Add values of a record to be added
-    *
-    * @param string $data values of a record
-    *
-    */
+    /**
+     * Add values of a record to be added
+     *
+     * @param string $data values of a record
+     *
+     */
     function setData($data)
     {
         $this->_data[] = $data;
     }
 
-   /**
-    * Get the data array
-    *
-    * @return array containing the records values to be added
-    *
-    */
+    /**
+     * Get the data array
+     *
+     * @return array containing the records values to be added
+     *
+     */
     function getData()
     {
         return $this->_data;
     }
 
-   /**
-    * Use to insert data in a table
-    *
-    * @return bool true if success, false if an error occured
-    *
-    */
+    /**
+     * Use to insert data in a table
+     *
+     * @return bool true if success, false if an error occured
+     *
+     */
     function addData()
     {
         global $xoopsDB;
@@ -239,13 +239,13 @@ 
 
     }
 
-   /**
-    * Add a field to be added
-    *
-    * @param string $name name of the field
-    * @param string $properties properties of the field
-    *
-    */
+    /**
+     * Add a field to be added
+     *
+     * @param string $name name of the field
+     * @param string $properties properties of the field
+     *
+     */
     function addAlteredField($name, $properties, $showerror=true)
     {
         $field['name'] = $name;
@@ -255,13 +255,13 @@ 
     }
 
     /**
-    * Invert values 0 to 1 and 1 to 0
-    *
-    * @param string $name name of the field
-    * @param string $old old propertie
-    * @param string $new new propertie
-    *
-    */    //felix
+     * Invert values 0 to 1 and 1 to 0
+     *
+     * @param string $name name of the field
+     * @param string $old old propertie
+     * @param string $new new propertie
+     *
+     */    //felix
     function addUpdatedWhere($name, $newValue, $oldValue)
     {
         $field['name'] = $name;
@@ -270,13 +270,13 @@ 
         $this->_updatedWhere[] = $field;
     }
 
-   /**
-    * Add new field of a record to be added
-    *
-    * @param string $name name of the field
-    * @param string $properties properties of the field
-    *
-    */
+    /**
+     * Add new field of a record to be added
+     *
+     * @param string $name name of the field
+     * @param string $properties properties of the field
+     *
+     */
     function addNewField($name, $properties)
     {
         $field['name'] = $name;
@@ -284,24 +284,24 @@ 
         $this->_newFields[] = $field;
     }
 
-   /**
-    * Get fields that need to be altered
-    *
-    * @return array fields that need to be altered
-    *
-    */
+    /**
+     * Get fields that need to be altered
+     *
+     * @return array fields that need to be altered
+     *
+     */
     function getAlteredFields()
     {
         return $this->_alteredFields;
     }
 
-   /**
-    * Add field for which the value will be updated
-    *
-    * @param string $name name of the field
-    * @param string $value value to be set
-    *
-    */
+    /**
+     * Add field for which the value will be updated
+     *
+     * @param string $name name of the field
+     * @param string $value value to be set
+     *
+     */
     function addUpdatedField($name, $value)
     {
         $field['name'] = $name;
@@ -309,76 +309,76 @@ 
         $this->_updatedFields[] = $field;
     }
 
-   /**
-    * Get new fields to be added
-    *
-    * @return array fields to be added
-    *
-    */
+    /**
+     * Get new fields to be added
+     *
+     * @return array fields to be added
+     *
+     */
     function getNewFields()
     {
         return $this->_newFields;
     }
 
-   /**
-    * Get fields which values need to be updated
-    *
-    * @return array fields which values need to be updated
-    *
-    */
+    /**
+     * Get fields which values need to be updated
+     *
+     * @return array fields which values need to be updated
+     *
+     */
     function getUpdatedFields()
     {
         return $this->_updatedFields;
     }
 
-     /**
-    * Get fields which values need to be updated
-    *
-    * @return array fields which values need to be updated
-    *
-    */    //felix
+        /**
+         * Get fields which values need to be updated
+         *
+         * @return array fields which values need to be updated
+         *
+         */    //felix
     function getUpdatedWhere()
     {
         return $this->_updatedWhere;
     }
 
-   /**
-    * Add values of a record to be added
-    *
-    * @param string $name name of the field
-    *
-    */
+    /**
+     * Add values of a record to be added
+     *
+     * @param string $name name of the field
+     *
+     */
     function addDropedField($name)
     {
         $this->_dropedFields[] = $name;
     }
 
-   /**
-    * Get fields that need to be droped
-    *
-    * @return array fields that need to be droped
-    *
-    */
+    /**
+     * Get fields that need to be droped
+     *
+     * @return array fields that need to be droped
+     *
+     */
     function getDropedFields()
     {
         return $this->_dropedFields;
     }
 
-   /**
-    * Set the flag to drop the table
-    *
-    */
+    /**
+     * Set the flag to drop the table
+     *
+     */
     function setFlagForDrop()
     {
         $this->_flagForDrop = true;
     }
 
-   /**
-    * Use to create a table
-    *
-    * @return bool true if success, false if an error occured
-    *
-    */
+    /**
+     * Use to create a table
+     *
+     * @return bool true if success, false if an error occured
+     *
+     */
     function createTable()
     {
         global $xoopsDB;
@@ -395,12 +395,12 @@ 
         return $ret;
     }
 
-   /**
-    * Use to drop a table
-    *
-    * @return bool true if success, false if an error occured
-    *
-    */
+    /**
+     * Use to drop a table
+     *
+     * @return bool true if success, false if an error occured
+     *
+     */
     function dropTable()
     {
         global $xoopsDB;
@@ -418,12 +418,12 @@ 
         }
     }
 
-   /**
-    * Use to alter a table
-    *
-    * @return bool true if success, false if an error occured
-    *
-    */
+    /**
+     * Use to alter a table
+     *
+     * @return bool true if success, false if an error occured
+     *
+     */
     function alterTable()
     {
         global $xoopsDB;
@@ -446,12 +446,12 @@ 
         return $ret;
     }
 
-   /**
-    * Use to add new fileds in the table
-    *
-    * @return bool true if success, false if an error occured
-    *
-    */
+    /**
+     * Use to add new fileds in the table
+     *
+     * @return bool true if success, false if an error occured
+     *
+     */
     function addNewFields()
     {
         global $xoopsDB;
@@ -471,12 +471,12 @@ 
         return $ret;
     }
 
-   /**
-    * Use to update fields values
-    *
-    * @return bool true if success, false if an error occured
-    *
-    */
+    /**
+     * Use to update fields values
+     *
+     * @return bool true if success, false if an error occured
+     *
+     */
     function updateFieldsValues()
     {
         global $xoopsDB;
@@ -491,16 +491,16 @@ 
             } else {
                 echo "&nbsp;&nbsp;" . sprintf(_SDU_MSG_UPDATE_TABLE, $this->name()) . "<br />";
             }
-         }
+            }
 
-         return $ret;
+            return $ret;
     }
-       /**
-    * Use to update fields values
-    *
-    * @return bool true if success, false if an error occured
-    *
-    */        //felix
+        /**
+         * Use to update fields values
+         *
+         * @return bool true if success, false if an error occured
+         *
+         */        //felix
     function updateWhereValues()
     {
         global $xoopsDB;
@@ -516,16 +516,16 @@ 
             } else {
                 echo "&nbsp;&nbsp;" . sprintf(_SDU_MSG_UPDATE_TABLE, $this->name()) . "<br />";
             }
-         }
+            }
 
-         return $ret;
+            return $ret;
     }
-   /**
-    * Use to drop fields
-    *
-    * @return bool true if success, false if an error occured
-    *
-    */
+    /**
+     * Use to drop fields
+     *
+     * @return bool true if success, false if an error occured
+     *
+     */
     function dropFields()
     {
         global $xoopsDB;
@@ -564,16 +564,16 @@ 
 
     }
 
-   /**
-    * Use to execute a general query
-    *
-    * @param string $query query that will be executed
-    * @param string $goodmsg message displayed on success
-    * @param string $badmsg message displayed on error
-    *
-    * @return bool true if success, false if an error occured
-    *
-    */
+    /**
+     * Use to execute a general query
+     *
+     * @param string $query query that will be executed
+     * @param string $goodmsg message displayed on success
+     * @param string $badmsg message displayed on error
+     *
+     * @return bool true if success, false if an error occured
+     *
+     */
     function runQuery($query, $goodmsg, $badmsg)
     {
         global $xoopsDB;
@@ -589,14 +589,14 @@ 
         }
     }
 
-   /**
-    * Use to rename a table
-    *
-    * @param string $from name of the table to rename
-    * @param string $to new name of the renamed table
-    *
-    * @return bool true if success, false if an error occured
-    */
+    /**
+     * Use to rename a table
+     *
+     * @param string $from name of the table to rename
+     * @param string $to new name of the renamed table
+     *
+     * @return bool true if success, false if an error occured
+     */
     function renameTable($from, $to)
     {
         global $xoopsDB;
@@ -617,15 +617,15 @@ 
         }
     }
 
-   /**
-    * Use to update a table
-    *
-    * @param object $table {@link SmartDbTable} that will be updated
-    *
-    * @see SmartDbTable
-    *
-    * @return bool true if success, false if an error occured
-    */
+    /**
+     * Use to update a table
+     *
+     * @param object $table {@link SmartDbTable} that will be updated
+     *
+     * @see SmartDbTable
+     *
+     * @return bool true if success, false if an error occured
+     */
     function updateTable($table)
     {
         global $xoopsDB;

Spacing +36 added lines, -36 removed lines

@@ -15,13 +15,13 @@ 
 
     $bRetVal = false;
     //Verifies that a MySQL table exists
-    $xoopsDB =& XoopsDatabaseFactory::getDatabaseConnection();
+    $xoopsDB = & XoopsDatabaseFactory::getDatabaseConnection();
     $realname = $xoopsDB->prefix($table);
     $sql = "SHOW TABLES FROM ".XOOPS_DB_NAME;
     $ret = $xoopsDB->queryF($sql);
-    while (list($m_table)=$xoopsDB->fetchRow($ret)) {
+    while (list($m_table) = $xoopsDB->fetchRow($ret)) {
 
-        if ($m_table ==  $realname) {
+        if ($m_table == $realname) {
             $bRetVal = true;
             break;
         }
@@ -56,10 +56,10 @@ 
  * Include the language constants for the SmartObjectDBUpdater
  */
 global $xoopsConfig;
-$common_file = XOOPS_ROOT_PATH . "/modules/smartfaq/language/" . $xoopsConfig['language'] . "/smartdbupdater.php";
+$common_file = XOOPS_ROOT_PATH."/modules/smartfaq/language/".$xoopsConfig['language']."/smartdbupdater.php";
 if (!file_exists($common_file)) {
 
-    $common_file = XOOPS_ROOT_PATH . "/modules/smartfaq/language/english/smartdbupdater.php";
+    $common_file = XOOPS_ROOT_PATH."/modules/smartfaq/language/english/smartdbupdater.php";
 }
 
 include($common_file);
@@ -226,12 +226,12 @@ 
         global $xoopsDB;
 
         foreach ($this->getData() as $data) {
-                $query = sprintf('INSERT INTO %s VALUES (%s)',$this->name(), $data);
+                $query = sprintf('INSERT INTO %s VALUES (%s)', $this->name(), $data);
             $ret = $xoopsDB->query($query);
-            if (! $ret) {
-                echo "&nbsp;&nbsp;" . sprintf(_SDU_MSG_ADD_DATA_ERR, $this->name()) . "<br />";
+            if (!$ret) {
+                echo "&nbsp;&nbsp;".sprintf(_SDU_MSG_ADD_DATA_ERR, $this->name())."<br />";
             } else {
-                echo "&nbsp;&nbsp;" . sprintf(_SDU_MSG_ADD_DATA, $this->name()) . "<br />";
+                echo "&nbsp;&nbsp;".sprintf(_SDU_MSG_ADD_DATA, $this->name())."<br />";
             }
         }
 
@@ -246,7 +246,7 @@ 
     * @param string $properties properties of the field
     *
     */
-    function addAlteredField($name, $properties, $showerror=true)
+    function addAlteredField($name, $properties, $showerror = true)
     {
         $field['name'] = $name;
         $field['properties'] = $properties;
@@ -386,10 +386,10 @@ 
         $query = $this->getStructure();
 
         $ret = $xoopsDB->query($query);
-        if (! $ret) {
-            echo "&nbsp;&nbsp;" . sprintf(_SDU_MSG_CREATE_TABLE_ERR, $this->name()) . "<br />";
+        if (!$ret) {
+            echo "&nbsp;&nbsp;".sprintf(_SDU_MSG_CREATE_TABLE_ERR, $this->name())."<br />";
         } else {
-            echo "&nbsp;&nbsp;" . sprintf(_SDU_MSG_CREATE_TABLE, $this->name()) . "<br />";
+            echo "&nbsp;&nbsp;".sprintf(_SDU_MSG_CREATE_TABLE, $this->name())."<br />";
         }
 
         return $ret;
@@ -407,12 +407,12 @@ 
 
         $query = sprintf("DROP TABLE %s", $this->name());
         $ret = $xoopsDB->query($query);
-        if (! $ret) {
-            echo "&nbsp;&nbsp;" . sprintf(_SDU_MSG_DROP_TABLE_ERR,  $this->name()) . "<br />";
+        if (!$ret) {
+            echo "&nbsp;&nbsp;".sprintf(_SDU_MSG_DROP_TABLE_ERR, $this->name())."<br />";
 
             return false;
         } else {
-            echo "&nbsp;&nbsp;" . sprintf(_SDU_MSG_DROP_TABLE,  $this->name()) . "<br />";
+            echo "&nbsp;&nbsp;".sprintf(_SDU_MSG_DROP_TABLE, $this->name())."<br />";
 
             return true;
         }
@@ -435,10 +435,10 @@ 
             //echo $query;
             $ret = $ret && $xoopsDB->query($query);
             if ($alteredField['showerror']) {
-                if (! $ret) {
-                    echo "&nbsp;&nbsp;" . sprintf(_SDU_MSG_CHGFIELD_ERR, $alteredField['name'], $this->name()) . "<br />";
+                if (!$ret) {
+                    echo "&nbsp;&nbsp;".sprintf(_SDU_MSG_CHGFIELD_ERR, $alteredField['name'], $this->name())."<br />";
                 } else {
-                    echo "&nbsp;&nbsp;" . sprintf(_SDU_MSG_CHGFIELD,$alteredField['name'], $this->name()) . "<br />";
+                    echo "&nbsp;&nbsp;".sprintf(_SDU_MSG_CHGFIELD, $alteredField['name'], $this->name())."<br />";
                 }
             }
         }
@@ -461,10 +461,10 @@ 
             $query = sprintf("ALTER TABLE `%s` ADD `%s` %s", $this->name(), $newField['name'], $newField['properties']);
             //echo $query;
             $ret = $ret && $xoopsDB->query($query);
-            if (! $ret) {
-                echo "&nbsp;&nbsp;" . sprintf(_SDU_MSG_NEWFIELD_ERR, $newField['name'], $this->name()) . "<br />";
+            if (!$ret) {
+                echo "&nbsp;&nbsp;".sprintf(_SDU_MSG_NEWFIELD_ERR, $newField['name'], $this->name())."<br />";
             } else {
-                echo "&nbsp;&nbsp;" . sprintf(_SDU_MSG_NEWFIELD,$newField['name'], $this->name()) . "<br />";
+                echo "&nbsp;&nbsp;".sprintf(_SDU_MSG_NEWFIELD, $newField['name'], $this->name())."<br />";
             }
         }
 
@@ -486,10 +486,10 @@ 
         foreach ($this->getUpdatedFields() as $updatedField) {
             $query = sprintf("UPDATE %s SET %s = %s", $this->name(), $updatedField['name'], $updatedField['value']);
             $ret = $ret && $xoopsDB->query($query);
-            if (! $ret) {
-                echo "&nbsp;&nbsp;" . sprintf(_SDU_MSG_UPDATE_TABLE_ERR, $this->name()) . "<br />";
+            if (!$ret) {
+                echo "&nbsp;&nbsp;".sprintf(_SDU_MSG_UPDATE_TABLE_ERR, $this->name())."<br />";
             } else {
-                echo "&nbsp;&nbsp;" . sprintf(_SDU_MSG_UPDATE_TABLE, $this->name()) . "<br />";
+                echo "&nbsp;&nbsp;".sprintf(_SDU_MSG_UPDATE_TABLE, $this->name())."<br />";
             }
          }
 
@@ -511,10 +511,10 @@ 
             $query = sprintf("UPDATE %s SET %s = %s WHERE %s  %s", $this->name(), $updatedWhere['name'], $updatedWhere['value'], $updatedWhere['name'], $updatedWhere['where']);
             //echo $query."<br>";
             $ret = $ret && $xoopsDB->query($query);
-            if (! $ret) {
-                echo "&nbsp;&nbsp;" . sprintf(_SDU_MSG_UPDATE_TABLE_ERR, $this->name()) . "<br />";
+            if (!$ret) {
+                echo "&nbsp;&nbsp;".sprintf(_SDU_MSG_UPDATE_TABLE_ERR, $this->name())."<br />";
             } else {
-                echo "&nbsp;&nbsp;" . sprintf(_SDU_MSG_UPDATE_TABLE, $this->name()) . "<br />";
+                echo "&nbsp;&nbsp;".sprintf(_SDU_MSG_UPDATE_TABLE, $this->name())."<br />";
             }
          }
 
@@ -536,10 +536,10 @@ 
             $query = sprintf("ALTER TABLE %s DROP %s", $this->name(), $dropedField);
 
             $ret = $ret && $xoopsDB->query($query);
-            if (! $ret) {
-                echo "&nbsp;&nbsp;" . sprintf(_SDU_MSG_DROPFIELD_ERR, $dropedField, $this->name()) . "<br />";
+            if (!$ret) {
+                echo "&nbsp;&nbsp;".sprintf(_SDU_MSG_DROPFIELD_ERR, $dropedField, $this->name())."<br />";
             } else {
-                echo "&nbsp;&nbsp;" . sprintf(_SDU_MSG_DROPFIELD, $dropedField, $this->name()) . "<br />";
+                echo "&nbsp;&nbsp;".sprintf(_SDU_MSG_DROPFIELD, $dropedField, $this->name())."<br />";
             }
         }
 
@@ -578,7 +578,7 @@ 
     {
         global $xoopsDB;
         $ret = $xoopsDB->query($query);
-        if (! $ret) {
+        if (!$ret) {
             echo "&nbsp;&nbsp;$badmsg<br />";
 
             return false;
@@ -606,12 +606,12 @@ 
 
         $query = sprintf("ALTER TABLE %s RENAME %s", $from, $to);
         $ret = $xoopsDB->query($query);
-        if (! $ret) {
-            echo "&nbsp;&nbsp;" . sprintf(_SDU_MSG_RENAME_TABLE_ERR, $from) . "<br />";
+        if (!$ret) {
+            echo "&nbsp;&nbsp;".sprintf(_SDU_MSG_RENAME_TABLE_ERR, $from)."<br />";
 
             return false;
         } else {
-            echo "&nbsp;&nbsp;" . sprintf(_SDU_MSG_RENAME_TABLE, $from, $to) . "<br />";
+            echo "&nbsp;&nbsp;".sprintf(_SDU_MSG_RENAME_TABLE, $from, $to)."<br />";
 
             return true;
         }
@@ -639,7 +639,7 @@ 
 
         // If table is flag for drop, drop it
         if ($table->_flagForDrop) {
-            $ret = $table->dropTable()  && $ret;
+            $ret = $table->dropTable() && $ret;
         }
 
         // If table has data, insert it

smartfaq/class/uploader.php

Doc Comments +1 added lines, -1 removed lines

@@ -23,7 +23,7 @@
      * Constructor
      *
      * @param string $uploadDir
-     * @param array  $allowedMimeTypes
+     * @param integer  $allowedMimeTypes
      * @param int    $maxFileSize
      * @param int    $maxWidth
      * @param int    $maxHeight

Indentation +9 added lines, -9 removed lines

@@ -1,14 +1,14 @@
 <?php
 /**
- * CBB, XOOPS forum module
- *
- * @copyright	The XOOPS Project http://xoops.sf.net
- * @license		http://www.fsf.org/copyleft/gpl.html GNU public license
- * @author		Taiwen Jiang (phppp or D.J.) <phppp@users.sourceforge.net>
- * @since		4.00
- * @version		$Id $
- * @package		module::newbb
- */
+     * CBB, XOOPS forum module
+     *
+     * @copyright	The XOOPS Project http://xoops.sf.net
+     * @license		http://www.fsf.org/copyleft/gpl.html GNU public license
+     * @author		Taiwen Jiang (phppp or D.J.) <phppp@users.sourceforge.net>
+     * @since		4.00
+     * @version		$Id $
+     * @package		module::newbb
+     */
 
 // defined("XOOPS_ROOT_PATH") || exit("XOOPS root path not defined");
 

Spacing +1 added lines, -1 removed lines

@@ -12,7 +12,7 @@
 
 // defined("XOOPS_ROOT_PATH") || exit("XOOPS root path not defined");
 
-include_once XOOPS_ROOT_PATH . "/class/uploader.php";
+include_once XOOPS_ROOT_PATH."/class/uploader.php";
 
 class sf_uploader extends XoopsMediaUploader
 {

smartfaq/include/functions.php

Doc Comments +3 added lines

@@ -581,6 +581,9 @@
     echo "<h3 style=\"color: #2F5376; margin: 6px 0 0 0; \"><a href='#' onClick=\"toggle('" . $tablename . "'); toggleIcon('" . $iconname . "');\">";
 }
 
+/**
+ * @param string $name
+ */
 function sf_gethandler($name, $optional = false )
 {
     static $handlers;

Indentation +2 added lines, -3 removed lines

@@ -287,8 +287,7 @@ 
 * @param array $groups : group with granted permission
 * @param integer $itemID : faqid on which we are setting permissions
 * @return boolean : TRUE if the no errors occured
-
-*/
+ */
 function sf_saveItemPermissions($groups, $itemID)
 {
     $result = true;
@@ -536,7 +535,7 @@ 
 function sf_collapsableBar($tablename = '', $iconname = '')
 {
 
-   ?>
+    ?>
     <script type="text/javascript"><!--
     function goto_URL(object)
     {

Spacing +62 added lines, -62 removed lines

@@ -18,7 +18,7 @@ 
     if (!isset($smartModule)) {
         global $xoopsModule;
         if (isset($xoopsModule) && is_object($xoopsModule) && $xoopsModule->getVar('dirname') == 'smartfaq') {
-            $smartModule =& $xoopsModule;
+            $smartModule = & $xoopsModule;
         } else {
             $hModule = &xoops_gethandler('module');
             $smartModule = $hModule->getByDirname('smartfaq');
@@ -35,9 +35,9 @@ 
         global $xoopsModule;
         if (isset($xoopsModule) && is_object($xoopsModule) && $xoopsModule->getVar('dirname') == 'smartfaq') {
             global $xoopsModuleConfig;
-            $smartConfig =& $xoopsModuleConfig;
+            $smartConfig = & $xoopsModuleConfig;
         } else {
-            $smartModule =& sf_getModuleInfo();
+            $smartModule = & sf_getModuleInfo();
             $hModConfig = &xoops_gethandler('config');
             $smartConfig = $hModConfig->getConfigsByCat(0, $smartModule->getVar('mid'));
         }
@@ -48,14 +48,14 @@ 
 
 function sf_getHelpPath()
 {
-    $smartConfig =& sf_getModuleConfig();
+    $smartConfig = & sf_getModuleConfig();
     switch ($smartConfig['helppath_select']) {
         case 'docs.xoops.org' :
             return 'http://docs.xoops.org/help/sfaqh/index.htm';
         break;
 
         case 'inside' :
-            return XOOPS_URL . "/modules/smartfaq/doc/";
+            return XOOPS_URL."/modules/smartfaq/doc/";
         break;
 
         case 'custom' :
@@ -64,31 +64,31 @@ 
     }
 }
 
-function sf_formatErrors($errors=array())
+function sf_formatErrors($errors = array())
 {
     $ret = '';
     foreach ($errors as $key=>$value) {
-        $ret .= "<br /> - " . $value;
+        $ret .= "<br /> - ".$value;
     }
 
     return $ret;
 }
 
-function sf_addCategoryOption($categoryObj, $selectedid=0, $level = 0, $ret='')
+function sf_addCategoryOption($categoryObj, $selectedid = 0, $level = 0, $ret = '')
 {
     // Creating the category handler object
-    $category_handler =& sf_gethandler('category');
+    $category_handler = & sf_gethandler('category');
 
     $spaces = '';
     for ($j = 0; $j < $level; ++$j) {
         $spaces .= '--';
     }
 
-    $ret .= "<option value='" . $categoryObj->categoryid() . "'";
+    $ret .= "<option value='".$categoryObj->categoryid()."'";
     if ($selectedid == $categoryObj->categoryid()) {
         $ret .= " selected='selected'";
     }
-    $ret .= ">" . $spaces . $categoryObj->name() . "</option>\n";
+    $ret .= ">".$spaces.$categoryObj->name()."</option>\n";
 
     $subCategoriesObj = $category_handler->getCategories(0, 0, $categoryObj->categoryid());
     if (count($subCategoriesObj) > 0) {
@@ -101,16 +101,16 @@ 
     return $ret;
 }
 
-function sf_createCategorySelect($selectedid=0, $parentcategory=0, $allCatOption=true)
+function sf_createCategorySelect($selectedid = 0, $parentcategory = 0, $allCatOption = true)
 {
-    $ret = "" . _MB_SF_SELECTCAT . "&nbsp;<select name='options[]'>";
+    $ret = ""._MB_SF_SELECTCAT."&nbsp;<select name='options[]'>";
     if ($allCatOption) {
         $ret .= "<option value='0'";
-        $ret .= ">" . _MB_SF_ALLCAT . "</option>\n";
+        $ret .= ">"._MB_SF_ALLCAT."</option>\n";
     }
 
     // Creating the category handler object
-    $category_handler =& sf_gethandler('category');
+    $category_handler = & sf_gethandler('category');
 
     // Creating category objects
     $categoriesObj = $category_handler->getCategories(0, 0, $parentcategory);
@@ -125,7 +125,7 @@ 
     return $ret;
 }
 
-function sf_getStatusArray ()
+function sf_getStatusArray()
 {
     $result = array("1" => _AM_SF_STATUS1,
     "2" => _AM_SF_STATUS2,
@@ -139,14 +139,14 @@ 
     return $result;
 }
 
-function sf_moderator ()
+function sf_moderator()
 {
     global $xoopsUser;
 
     if (!$xoopsUser) {
         $result = false;
     } else {
-        $smartPermHandler =& xoops_getmodulehandler('permission', 'smartfaq');
+        $smartPermHandler = & xoops_getmodulehandler('permission', 'smartfaq');
 
         $categories = $smartPermHandler->getPermissions('moderation');
         if (count($categories) == 0) {
@@ -159,13 +159,13 @@ 
     return $result;
 }
 
-function sf_modFooter ()
+function sf_modFooter()
 {
-    $smartModule =& sf_getModuleInfo();
+    $smartModule = & sf_getModuleInfo();
 
-    $modfootertxt = "Module " . $smartModule->getInfo('name') . " - Version " . $smartModule->getInfo('version') . "";
+    $modfootertxt = "Module ".$smartModule->getInfo('name')." - Version ".$smartModule->getInfo('version')."";
 
-    $modfooter = "<a href='" . $smartModule->getInfo('support_site_url') . "' target='_blank'><img src='" . XOOPS_URL . "/modules/smartfaq/assets/images/sfcssbutton.gif' title='" . $modfootertxt . "' alt='" . $modfootertxt . "'/></a>";
+    $modfooter = "<a href='".$smartModule->getInfo('support_site_url')."' target='_blank'><img src='".XOOPS_URL."/modules/smartfaq/assets/images/sfcssbutton.gif' title='".$modfootertxt."' alt='".$modfootertxt."'/></a>";
 
     return $modfooter;
 }
@@ -183,7 +183,7 @@ 
 
     $result = false;
 
-    $smartModule =& sf_getModuleInfo();
+    $smartModule = & sf_getModuleInfo();
     $module_id = $smartModule->getVar('mid');
 
     if (!empty($xoopsUser)) {
@@ -216,10 +216,10 @@ 
     } else {
         $result = -1;
 
-        $groups = ($xoopsUser)? $xoopsUser->getGroups() : XOOPS_GROUP_ANONYMOUS;
+        $groups = ($xoopsUser) ? $xoopsUser->getGroups() : XOOPS_GROUP_ANONYMOUS;
 
         $gperm_handler = &xoops_gethandler('groupperm');
-        $smartModule =& sf_getModuleInfo();
+        $smartModule = & sf_getModuleInfo();
         $module_id = $smartModule->getVar('mid');
 
         // Do we have access to the parent category
@@ -255,12 +255,12 @@ 
     Global $xoopsDB;
 
     $result = true;
-    $smartModule =& sf_getModuleInfo();
+    $smartModule = & sf_getModuleInfo();
     $module_id = $smartModule->getVar('mid');
 
     $gperm_handler = &xoops_gethandler('groupperm');
 
-    $sql = "SELECT faqid FROM " . $xoopsDB->prefix("smartfaq_faq") . " WHERE categoryid = '$categoryid' ";
+    $sql = "SELECT faqid FROM ".$xoopsDB->prefix("smartfaq_faq")." WHERE categoryid = '$categoryid' ";
     $result = $xoopsDB->query($sql);
 
     if (count($result) > 0) {
@@ -292,7 +292,7 @@ 
 function sf_saveItemPermissions($groups, $itemID)
 {
     $result = true;
-    $smartModule =& sf_getModuleInfo();
+    $smartModule = & sf_getModuleInfo();
     $module_id = $smartModule->getVar('mid');
 
     $gperm_handler = &xoops_gethandler('groupperm');
@@ -322,7 +322,7 @@ 
 function sf_saveCategory_Permissions($groups, $categoryid, $perm_name)
 {
     $result = true;
-    $smartModule =& sf_getModuleInfo();
+    $smartModule = & sf_getModuleInfo();
     $module_id = $smartModule->getVar('mid');
 
     $gperm_handler = &xoops_gethandler('groupperm');
@@ -351,7 +351,7 @@ 
 function sf_saveModerators($moderators, $categoryid)
 {
     $result = true;
-    $smartModule =& sf_getModuleInfo();
+    $smartModule = & sf_getModuleInfo();
     $module_id = $smartModule->getVar('mid');
 
     $gperm_handler = &xoops_gethandler('groupperm');
@@ -372,7 +372,7 @@ 
     $ret = array();
     global $xoopsDB;
 
-    $result = $xoopsDB->query("SELECT * FROM " . $xoopsDB->prefix("smartfaq_faq") . " WHERE faqid = '$faqid'");
+    $result = $xoopsDB->query("SELECT * FROM ".$xoopsDB->prefix("smartfaq_faq")." WHERE faqid = '$faqid'");
     $ret = $xoopsDB->fetcharray($result);
 
     return $ret;
@@ -386,30 +386,30 @@ 
 */
 
 // TODO : Move this to the sfFaq class
-function sf_getAdminLinks($faqid = 0, $open=false)
+function sf_getAdminLinks($faqid = 0, $open = false)
 {
     global $xoopsUser, $xoopsModule, $xoopsModuleConfig, $xoopsConfig;
     $adminLinks = '';
-    $modulePath = XOOPS_URL . "/modules/" . $xoopsModule->dirname() . "/";
-    $page = $open? 'question.php' : 'faq.php';
+    $modulePath = XOOPS_URL."/modules/".$xoopsModule->dirname()."/";
+    $page = $open ? 'question.php' : 'faq.php';
     if ($xoopsUser && $xoopsUser->isAdmin($xoopsModule->getVar('mid'))) {
         // Edit button
-        $adminLinks .= "<a href='" . $modulePath . "admin/$page?op=mod&amp;faqid=" . $faqid . "'><img src='" . $modulePath . "assets/images/links/edit.gif'" . " title='" . _MD_SF_EDIT . "' alt='" . _MD_SF_EDIT . "'/></a>";
+        $adminLinks .= "<a href='".$modulePath."admin/$page?op=mod&amp;faqid=".$faqid."'><img src='".$modulePath."assets/images/links/edit.gif'"." title='"._MD_SF_EDIT."' alt='"._MD_SF_EDIT."'/></a>";
         $adminLinks .= " ";
         // Delete button
-        $adminLinks .= "<a href='" . $modulePath . "admin/$page?op=del&amp;faqid=" . $faqid . "'><img src='" . $modulePath . "assets/images/links/delete.gif'" . " title='" . _MD_SF_DELETE . "' alt='" . _MD_SF_DELETE . "'/></a>";
+        $adminLinks .= "<a href='".$modulePath."admin/$page?op=del&amp;faqid=".$faqid."'><img src='".$modulePath."assets/images/links/delete.gif'"." title='"._MD_SF_DELETE."' alt='"._MD_SF_DELETE."'/></a>";
         $adminLinks .= " ";
     }
     // Print button
-    $adminLinks .= "<a href='" . $modulePath . "print.php?faqid=" . $faqid . "'><img src='" . $modulePath . "assets/images/links/print.gif' title='" . _MD_SF_PRINT . "' alt='" . _MD_SF_PRINT . "'/></a>";
+    $adminLinks .= "<a href='".$modulePath."print.php?faqid=".$faqid."'><img src='".$modulePath."assets/images/links/print.gif' title='"._MD_SF_PRINT."' alt='"._MD_SF_PRINT."'/></a>";
     $adminLinks .= " ";
     // Email button
-    $maillink = 'mailto:?subject=' . sprintf(_MD_SF_INTARTICLE, $xoopsConfig['sitename']) . '&amp;body=' . sprintf(_MD_SF_INTARTFOUND, $xoopsConfig['sitename']) . ':  ' . $modulePath . 'faq.php?faqid=' . $faqid;
-    $adminLinks .= "<a href=\"" . $maillink . "\"><img src='" . $modulePath . "assets/images/links/friend.gif' title='" . _MD_SF_MAIL . "' alt='" . _MD_SF_MAIL . "'/></a>";
+    $maillink = 'mailto:?subject='.sprintf(_MD_SF_INTARTICLE, $xoopsConfig['sitename']).'&amp;body='.sprintf(_MD_SF_INTARTFOUND, $xoopsConfig['sitename']).':  '.$modulePath.'faq.php?faqid='.$faqid;
+    $adminLinks .= "<a href=\"".$maillink."\"><img src='".$modulePath."assets/images/links/friend.gif' title='"._MD_SF_MAIL."' alt='"._MD_SF_MAIL."'/></a>";
     $adminLinks .= " ";
     // Submit New Answer button
     if (($xoopsModuleConfig['allownewanswer']) && (is_object($xoopsUser) || $xoopsModuleConfig['anonpost'])) {
-        $adminLinks .= "<a href='" . $modulePath . "answer.php?faqid=" . $faqid . "'><img src='" . $modulePath . "assets/images/links/newanswer.gif' title='" . _MD_SF_SUBMITANSWER . "' alt='" . _MD_SF_SUBMITANSWER . "'/></a>";
+        $adminLinks .= "<a href='".$modulePath."answer.php?faqid=".$faqid."'><img src='".$modulePath."assets/images/links/newanswer.gif' title='"._MD_SF_SUBMITANSWER."' alt='"._MD_SF_SUBMITANSWER."'/></a>";
         $adminLinks .= " ";
     }
 
@@ -439,7 +439,7 @@ 
             if (!isset($users[$userid])) {
                 return $GLOBALS['xoopsConfig']['anonymous'];
             }
-            $user =& $users[$userid];
+            $user = & $users[$userid];
         }
 
         if (is_object($user)) {
@@ -453,9 +453,9 @@ 
                 $fullname = $user->getVar('name');
             }
             if (!empty($fullname)) {
-                $linkeduser = "$fullname [<a href='" . XOOPS_URL . "/userinfo.php?uid=" . $userid . "'>" . $ts->htmlSpecialChars($username) . "</a>]";
+                $linkeduser = "$fullname [<a href='".XOOPS_URL."/userinfo.php?uid=".$userid."'>".$ts->htmlSpecialChars($username)."</a>]";
             } else {
-                $linkeduser = "<a href='" . XOOPS_URL . "/userinfo.php?uid=" . $userid . "'>" . ucwords($ts->htmlSpecialChars($username)) . "</a>";
+                $linkeduser = "<a href='".XOOPS_URL."/userinfo.php?uid=".$userid."'>".ucwords($ts->htmlSpecialChars($username))."</a>";
             }
 
             return $linkeduser;
@@ -479,18 +479,18 @@ 
     return $xurl;
 }
 
-function sf_adminMenu ($currentoption = 0, $breadcrumb = '')
+function sf_adminMenu($currentoption = 0, $breadcrumb = '')
 {
 
     /* Nice buttons styles */
     echo "
         <style type='text/css'>
         #buttontop { float:left; width:100%; background: #e7e7e7; font-size:93%; line-height:normal; border-top: 1px solid black; border-left: 1px solid black; border-right: 1px solid black; margin: 0; }
-        #buttonbar { float:left; width:100%; background: #e7e7e7 url('" . XOOPS_URL . "/modules/smartfaq/assets/images/bg.gif') repeat-x left bottom; font-size:93%; line-height:normal; border-left: 1px solid black; border-right: 1px solid black; margin-bottom: 12px; }
+        #buttonbar { float:left; width:100%; background: #e7e7e7 url('" . XOOPS_URL."/modules/smartfaq/assets/images/bg.gif') repeat-x left bottom; font-size:93%; line-height:normal; border-left: 1px solid black; border-right: 1px solid black; margin-bottom: 12px; }
         #buttonbar ul { margin:0; margin-top: 15px; padding:10px 10px 0; list-style:none; }
         #buttonbar li { display:inline; margin:0; padding:0; }
-        #buttonbar a { float:left; background:url('" . XOOPS_URL . "/modules/smartfaq/assets/images/left_both.gif') no-repeat left top; margin:0; padding:0 0 0 9px; border-bottom:1px solid #000; text-decoration:none; }
-        #buttonbar a span { float:left; display:block; background:url('" . XOOPS_URL . "/modules/smartfaq/assets/images/right_both.gif') no-repeat right top; padding:5px 15px 4px 6px; font-weight:bold; color:#765; }
+        #buttonbar a { float:left; background:url('" . XOOPS_URL."/modules/smartfaq/assets/images/left_both.gif') no-repeat left top; margin:0; padding:0 0 0 9px; border-bottom:1px solid #000; text-decoration:none; }
+        #buttonbar a span { float:left; display:block; background:url('" . XOOPS_URL."/modules/smartfaq/assets/images/right_both.gif') no-repeat right top; padding:5px 15px 4px 6px; font-weight:bold; color:#765; }
         /* Commented Backslash Hack hides rule from IE5-Mac \*/
         #buttonbar a span {float:none;}
         /* End IE5-Mac hack */
@@ -509,27 +509,27 @@ 
     $tblColors = Array();
     $tblColors[0] = $tblColors[1] = $tblColors[2] = $tblColors[3] = $tblColors[4] = $tblColors[5] = $tblColors[6] = $tblColors[7] = $tblColors[8] = '';
     $tblColors[$currentoption] = 'current';
-    if (file_exists(XOOPS_ROOT_PATH . '/modules/' . $xoopsModule->getVar('dirname') . '/language/' . $xoopsConfig['language'] . '/modinfo.php')) {
-        include_once XOOPS_ROOT_PATH . '/modules/smartfaq/language/' . $xoopsConfig['language'] . '/modinfo.php';
+    if (file_exists(XOOPS_ROOT_PATH.'/modules/'.$xoopsModule->getVar('dirname').'/language/'.$xoopsConfig['language'].'/modinfo.php')) {
+        include_once XOOPS_ROOT_PATH.'/modules/smartfaq/language/'.$xoopsConfig['language'].'/modinfo.php';
     } else {
-        include_once XOOPS_ROOT_PATH . '/modules/smartfaq/english/modinfo.php';
+        include_once XOOPS_ROOT_PATH.'/modules/smartfaq/english/modinfo.php';
     }
 
     echo "<div id='buttontop'>";
     echo "<table style=\"width: 100%; padding: 0; \" cellspacing=\"0\"><tr>";
     //echo "<td style=\"width: 45%; font-size: 10px; text-align: left; color: #2F5376; padding: 0 6px; line-height: 18px;\"><a class=\"nobutton\" href=\"../../system/admin.php?fct=preferences&amp;op=showmod&amp;mod=" . $xoopsModule->getVar('mid') . "\">" . _AM_SF_OPTS . "</a> | <a href=\"import.php\">" . _AM_SF_IMPORT . "</a> | <a href=\"../index.php\">" . _AM_SF_GOMOD . "</a> | <a href=\"../help/index.html\" target=\"_blank\">" . _AM_SF_HELP . "</a> | <a href=\"about.php\">" . _AM_SF_ABOUT . "</a></td>";
-    echo "<td style='font-size: 10px; text-align: left; color: #2F5376; padding: 0 6px; line-height: 18px;'><a class='nobutton' href='" . XOOPS_URL . "/modules/system/admin.php?fct=preferences&amp;op=showmod&amp;mod=" . $xoopsModule->getVar('mid') . "'>" . _AM_SF_OPTS . "</a> | <a href='" . XOOPS_URL . "/modules/smartfaq/admin/import.php'>" . _AM_SF_IMPORT . "</a> | <a href='" . XOOPS_URL . "/modules/smartfaq/index.php'>" . _AM_SF_GOMOD . "</a> | <a href='" . XOOPS_URL . "/modules/system/admin.php?fct=modulesadmin&op=update&module=" . $xoopsModule->getVar('dirname') . "'>" . _AM_SF_UPDATE . "</a> | <a href='" . sf_getHelpPath() . "' target='_blank'>" . _AM_SF_HELP . "</a> | <a href='" . XOOPS_URL . "/modules/smartfaq/admin/about.php'>" . _AM_SF_ABOUT . "</a></td>";
-    echo "<td style='font-size: 10px; text-align: right; color: #2F5376; padding: 0 6px; line-height: 18px;'><b>" . $myts->displayTarea($xoopsModule->name()) . " " . _AM_SF_MODADMIN . "</b> " . $breadcrumb . "</td>";
+    echo "<td style='font-size: 10px; text-align: left; color: #2F5376; padding: 0 6px; line-height: 18px;'><a class='nobutton' href='".XOOPS_URL."/modules/system/admin.php?fct=preferences&amp;op=showmod&amp;mod=".$xoopsModule->getVar('mid')."'>"._AM_SF_OPTS."</a> | <a href='".XOOPS_URL."/modules/smartfaq/admin/import.php'>"._AM_SF_IMPORT."</a> | <a href='".XOOPS_URL."/modules/smartfaq/index.php'>"._AM_SF_GOMOD."</a> | <a href='".XOOPS_URL."/modules/system/admin.php?fct=modulesadmin&op=update&module=".$xoopsModule->getVar('dirname')."'>"._AM_SF_UPDATE."</a> | <a href='".sf_getHelpPath()."' target='_blank'>"._AM_SF_HELP."</a> | <a href='".XOOPS_URL."/modules/smartfaq/admin/about.php'>"._AM_SF_ABOUT."</a></td>";
+    echo "<td style='font-size: 10px; text-align: right; color: #2F5376; padding: 0 6px; line-height: 18px;'><b>".$myts->displayTarea($xoopsModule->name())." "._AM_SF_MODADMIN."</b> ".$breadcrumb."</td>";
     echo "</tr></table>";
     echo "</div>";
 
     echo "<div id='buttonbar'>";
     echo "<ul>";
-    echo "<li id='" . $tblColors[0] . "'><a href=\"" . XOOPS_URL . "/modules/smartfaq/admin/index.php\"><span>" . _AM_SF_INDEX . "</span></a></li>";
-    echo "<li id='" . $tblColors[1] . "'><a href=\"" . XOOPS_URL . "/modules/smartfaq/admin/category.php\"><span>" . _AM_SF_CATEGORIES . "</span></a></li>";
-    echo "<li id='" . $tblColors[2] . "'><a href=\"" . XOOPS_URL . "/modules/smartfaq/admin/faq.php\"><span>" . _AM_SF_SMARTFAQS . "</span></a></li>";
-    echo "<li id='" . $tblColors[3] . "'><a href=\"" . XOOPS_URL . "/modules/smartfaq/admin/question.php\"><span>" . _AM_SF_OPEN_QUESTIONS . "</span></a></li>";
-    echo "<li id='" . $tblColors[4] . "'><a href=\"" . XOOPS_URL . "/modules/smartfaq/admin/permissions.php\"><span>" . _AM_SF_PERMISSIONS . "</span></a></li>";
+    echo "<li id='".$tblColors[0]."'><a href=\"".XOOPS_URL."/modules/smartfaq/admin/index.php\"><span>"._AM_SF_INDEX."</span></a></li>";
+    echo "<li id='".$tblColors[1]."'><a href=\"".XOOPS_URL."/modules/smartfaq/admin/category.php\"><span>"._AM_SF_CATEGORIES."</span></a></li>";
+    echo "<li id='".$tblColors[2]."'><a href=\"".XOOPS_URL."/modules/smartfaq/admin/faq.php\"><span>"._AM_SF_SMARTFAQS."</span></a></li>";
+    echo "<li id='".$tblColors[3]."'><a href=\"".XOOPS_URL."/modules/smartfaq/admin/question.php\"><span>"._AM_SF_OPEN_QUESTIONS."</span></a></li>";
+    echo "<li id='".$tblColors[4]."'><a href=\"".XOOPS_URL."/modules/smartfaq/admin/permissions.php\"><span>"._AM_SF_PERMISSIONS."</span></a></li>";
     echo "</ul></div>";
 }
 
@@ -578,15 +578,15 @@ 
     //-->
     </script>
     <?php
-    echo "<h3 style=\"color: #2F5376; margin: 6px 0 0 0; \"><a href='#' onClick=\"toggle('" . $tablename . "'); toggleIcon('" . $iconname . "');\">";
+    echo "<h3 style=\"color: #2F5376; margin: 6px 0 0 0; \"><a href='#' onClick=\"toggle('".$tablename."'); toggleIcon('".$iconname."');\">";
 }
 
-function sf_gethandler($name, $optional = false )
+function sf_gethandler($name, $optional = false)
 {
     static $handlers;
     $name = strtolower(trim($name));
     if (!isset($handlers[$name])) {
-        if ( file_exists( $hnd_file = XOOPS_ROOT_PATH.'/modules/smartfaq/class/'.$name.'.php' ) ) {
+        if (file_exists($hnd_file = XOOPS_ROOT_PATH.'/modules/smartfaq/class/'.$name.'.php')) {
             require_once $hnd_file;
         }
         $class = 'sf'.ucfirst($name).'Handler';
@@ -594,10 +594,10 @@ 
             $handlers[$name] = new $class($GLOBALS['xoopsDB']);
         }
     }
-    if (!isset($handlers[$name]) && !$optional ) {
+    if (!isset($handlers[$name]) && !$optional) {
         trigger_error('Class <b>'.$class.'</b> does not exist<br />Handler Name: '.$name, E_USER_ERROR);
     }
     $false = false;
 
-    return isset($handlers[$name])? $handlers[$name] : $false;
+    return isset($handlers[$name]) ? $handlers[$name] : $false;
 }

smartfaq/include/functions.render.php

Doc Comments -1 removed lines

@@ -68,7 +68,6 @@
 /**
  * Display forrum button
  *
- * @param	string	$image		image/button name, without extension
  * @param	string	$alt		alt message
  * @param	boolean	$asImage	true for image mode; false for text mode
  * @param	string	$extra		extra attribute for the button

Spacing +5 added lines, -5 removed lines

@@ -53,7 +53,7 @@ 
     if ($br != 0) {
         $text = $myts->nl2Br($text);
     }
-    $text = $myts->codeConv($text, $xcode, $image);    // Ryuji_edit(2003-11-18)
+    $text = $myts->codeConv($text, $xcode, $image); // Ryuji_edit(2003-11-18)
 
     return $text;
 }
@@ -100,10 +100,10 @@ 
     // START hacked by irmtfan
     // to show text links instead of buttons - func_num_args()==2 => only when $image, $alt is set and optional $display not set
     global $xoopsModuleConfig;
-    if (func_num_args()== 2) {
+    if (func_num_args() == 2) {
         // overall setting
-        if ( !empty($xoopsModuleConfig['display_text_links']) ) {
-            $display=false;
+        if (!empty($xoopsModuleConfig['display_text_links'])) {
+            $display = false;
         }
         // if set for each link => overwrite $display
         if (isset($xoopsModuleConfig['display_text_each_link'][$image])) {
@@ -130,7 +130,7 @@ 
     }
 
     $icon_handler = NewbbIconHandler::instance();
-    $icon_handler->template =& $xoTheme->template;
+    $icon_handler->template = & $xoTheme->template;
     $icon_handler->init($xoopsConfig["language"]);
 
     return $icon_handler;

Braces +3 added lines, -1 removed lines

@@ -123,7 +123,9 @@
     global $xoTheme, $xoopsConfig;
     static $icon_handler;
 
-    if (isset($icon_handler)) return $icon_handler;
+    if (isset($icon_handler)) {
+        return $icon_handler;
+    }
 
     if (!class_exists("NewbbIconHandler")) {
         require_once dirname(__DIR__)."/class/icon.php";

smartfaq/comment_delete.php

Spacing +2 added lines, -2 removed lines

@@ -7,5 +7,5 @@
 * Licence: GNU
 */
 
-include dirname(dirname(__DIR__)) . '/mainfile.php';
-include_once XOOPS_ROOT_PATH . '/include/comment_delete.php';
+include dirname(dirname(__DIR__)).'/mainfile.php';
+include_once XOOPS_ROOT_PATH.'/include/comment_delete.php';