Completed
Push — master ( c004c3...65a58d )
by Michael
04:32
created
smartfaq/class/permission.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -24,11 +24,11 @@  discard block
 block discarded – undo
24 24
         static $permissions;
25 25
 
26 26
         if (!isset($permissions[$type]) || ($id != null && !isset($permissions[$type][$id]))) {
27
-            $smartModule =& sf_getModuleInfo();
27
+            $smartModule = & sf_getModuleInfo();
28 28
             //Get group permissions handler
29
-            $gperm_handler =& xoops_gethandler('groupperm');
29
+            $gperm_handler = & xoops_gethandler('groupperm');
30 30
             //Get user's groups
31
-            $groups = is_object($xoopsUser)? $xoopsUser->getGroups() : array(XOOPS_GROUP_ANONYMOUS);
31
+            $groups = is_object($xoopsUser) ? $xoopsUser->getGroups() : array(XOOPS_GROUP_ANONYMOUS);
32 32
 
33 33
             switch ($type) {
34 34
                 case "category":
@@ -41,14 +41,14 @@  discard block
 block discarded – undo
41 41
 
42 42
                 case "moderation":
43 43
                 $gperm_name = "category_moderation";
44
-                $groups = is_object($xoopsUser)? $xoopsUser->getVar('uid') : 0;
44
+                $groups = is_object($xoopsUser) ? $xoopsUser->getVar('uid') : 0;
45 45
             }
46 46
 
47 47
             //Get all allowed item ids in this module and for this user's groups
48
-            $userpermissions =& $gperm_handler->getItemIds($gperm_name, $groups, $smartModule->getVar('mid'));
48
+            $userpermissions = & $gperm_handler->getItemIds($gperm_name, $groups, $smartModule->getVar('mid'));
49 49
             $permissions[$type] = $userpermissions;
50 50
         }
51 51
         //Return the permission array
52
-        return isset($permissions[$type])? $permissions[$type] : array();
52
+        return isset($permissions[$type]) ? $permissions[$type] : array();
53 53
     }
54 54
 }
Please login to merge, or discard this patch.
smartfaq/blocks/faqs_new.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
     $maxQuestionLength = $options[3];
26 26
 
27 27
     // Creating the faq handler object
28
-    $faq_handler =& sf_gethandler('faq');
28
+    $faq_handler = & sf_gethandler('faq');
29 29
     // creating the FAQ objects that belong to the selected category
30 30
     $faqsObj = $faq_handler->getAllPublished($limit, 0, $categoryid, $sort);
31 31
     $totalfaqs = count($faqsObj);
@@ -56,30 +56,30 @@  discard block
 block discarded – undo
56 56
 
57 57
     $form = sf_createCategorySelect($options[0]);
58 58
 
59
-    $form .= "&nbsp;<br>" . _MB_SF_ORDER . "&nbsp;<select name='options[]'>";
59
+    $form .= "&nbsp;<br>"._MB_SF_ORDER."&nbsp;<select name='options[]'>";
60 60
 
61 61
     $form .= "<option value='datesub'";
62 62
     if ($options[1] == "datesub") {
63 63
         $form .= " selected='selected'";
64 64
     }
65
-    $form .= ">" . _MB_SF_DATE . "</option>\n";
65
+    $form .= ">"._MB_SF_DATE."</option>\n";
66 66
 
67 67
     $form .= "<option value='counter'";
68 68
     if ($options[1] == "counter") {
69 69
         $form .= " selected='selected'";
70 70
     }
71
-    $form .= ">" . _MB_SF_HITS . "</option>\n";
71
+    $form .= ">"._MB_SF_HITS."</option>\n";
72 72
 
73 73
     $form .= "<option value='weight'";
74 74
     if ($options[1] == "weight") {
75 75
         $form .= " selected='selected'";
76 76
     }
77
-    $form .= ">" . _MB_SF_WEIGHT . "</option>\n";
77
+    $form .= ">"._MB_SF_WEIGHT."</option>\n";
78 78
 
79 79
     $form .= "</select>\n";
80 80
 
81
-    $form .= "&nbsp;" . _MB_SF_DISP . "&nbsp;<input type='text' name='options[]' value='" . $options[2] . "' />&nbsp;" . _MB_SF_FAQS . "";
82
-    $form .= "&nbsp;<br>" . _MB_SF_CHARS . "&nbsp;<input type='text' name='options[]' value='" . $options[3] . "' />&nbsp;" . _MB_SF_LENGTH . "";
81
+    $form .= "&nbsp;"._MB_SF_DISP."&nbsp;<input type='text' name='options[]' value='".$options[2]."' />&nbsp;"._MB_SF_FAQS."";
82
+    $form .= "&nbsp;<br>"._MB_SF_CHARS."&nbsp;<input type='text' name='options[]' value='".$options[3]."' />&nbsp;"._MB_SF_LENGTH."";
83 83
 
84 84
     $form .= "<br />"._MB_SF_SHOW_DATE."&nbsp;<input type='radio' id='options[]' name='options[]' value='1'";
85 85
     if ($options[4] == 1) {
Please login to merge, or discard this patch.
smartfaq/blocks/faqs_context.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@  discard block
 block discarded – undo
23 23
     $limit = $options[0];
24 24
 
25 25
     // Creating the faq handler object
26
-    $faq_handler =& sf_gethandler('faq');
26
+    $faq_handler = & sf_gethandler('faq');
27 27
 
28 28
     // creating the FAQ objects that belong to the selected category
29 29
     $faqsObj = $faq_handler->getContextualFaqs($limit);
@@ -42,8 +42,8 @@  discard block
 block discarded – undo
42 42
 }
43 43
 function b_faqs_context_edit($options)
44 44
 {
45
-    $form = "" . _MB_SF_DISP . "&nbsp;";
46
-    $form .= "<input type='text' name='options[]' value='" . $options[0] . "' />&nbsp;" . _MB_SF_FAQS . "";
45
+    $form = ""._MB_SF_DISP."&nbsp;";
46
+    $form .= "<input type='text' name='options[]' value='".$options[0]."' />&nbsp;"._MB_SF_FAQS."";
47 47
 
48 48
     return $form;
49 49
 }
Please login to merge, or discard this patch.
smartfaq/blocks/faqs_recent_questions.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -25,10 +25,10 @@  discard block
 block discarded – undo
25 25
     $maxQuestionLength = $options[3];
26 26
 
27 27
     // Creating the faq handler object
28
-    $faq_handler =& sf_gethandler('faq');
28
+    $faq_handler = & sf_gethandler('faq');
29 29
 
30 30
     // creating the FAQ objects that belong to the selected category
31
-    $faqsObj = $faq_handler->getFaqs( $limit, 0, _SF_STATUS_OPENED, $categoryid, $sort);
31
+    $faqsObj = $faq_handler->getFaqs($limit, 0, _SF_STATUS_OPENED, $categoryid, $sort);
32 32
     $totalfaqs = count($faqsObj);
33 33
 
34 34
     if ($faqsObj) {
@@ -59,30 +59,30 @@  discard block
 block discarded – undo
59 59
 
60 60
     $form = sf_createCategorySelect($options[0]);
61 61
 
62
-    $form .= "&nbsp;<br>" . _MB_SF_ORDER . "&nbsp;<select name='options[]'>";
62
+    $form .= "&nbsp;<br>"._MB_SF_ORDER."&nbsp;<select name='options[]'>";
63 63
 
64 64
     $form .= "<option value='datesub'";
65 65
     if ($options[1] == "datesub") {
66 66
         $form .= " selected='selected'";
67 67
     }
68
-    $form .= ">" . _MB_SF_DATE . "</option>\n";
68
+    $form .= ">"._MB_SF_DATE."</option>\n";
69 69
 
70 70
     $form .= "<option value='counter'";
71 71
     if ($options[1] == "counter") {
72 72
         $form .= " selected='selected'";
73 73
     }
74
-    $form .= ">" . _MB_SF_HITS . "</option>\n";
74
+    $form .= ">"._MB_SF_HITS."</option>\n";
75 75
 
76 76
     $form .= "<option value='weight'";
77 77
     if ($options[1] == "weight") {
78 78
         $form .= " selected='selected'";
79 79
     }
80
-    $form .= ">" . _MB_SF_WEIGHT . "</option>\n";
80
+    $form .= ">"._MB_SF_WEIGHT."</option>\n";
81 81
 
82 82
     $form .= "</select>\n";
83 83
 
84
-    $form .= "&nbsp;" . _MB_SF_DISP . "&nbsp;<input type='text' name='options[]' value='" . $options[2] . "' />&nbsp;" . _MB_SF_QUESTIONS . "";
85
-    $form .= "&nbsp;<br>" . _MB_SF_CHARS . "&nbsp;<input type='text' name='options[]' value='" . $options[3] . "' />&nbsp;" . _MB_SF_LENGTH . "";
84
+    $form .= "&nbsp;"._MB_SF_DISP."&nbsp;<input type='text' name='options[]' value='".$options[2]."' />&nbsp;"._MB_SF_QUESTIONS."";
85
+    $form .= "&nbsp;<br>"._MB_SF_CHARS."&nbsp;<input type='text' name='options[]' value='".$options[3]."' />&nbsp;"._MB_SF_LENGTH."";
86 86
 
87 87
     $form .= "<br />"._MB_SF_SHOW_DATE."&nbsp;<input type='radio' id='options[]' name='options[]' value='1'";
88 88
     if ($options[4] == 1) {
Please login to merge, or discard this patch.
smartfaq/blocks/faqs_most_viewed.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@  discard block
 block discarded – undo
23 23
     $maxQuestionLength = $options[2];
24 24
 
25 25
     // Creating the faq handler object
26
-    $faq_handler =& sf_gethandler('faq');
26
+    $faq_handler = & sf_gethandler('faq');
27 27
     // creating the FAQ objects that belong to the selected category
28 28
     $faqsObj = $faq_handler->getAllPublished($limit, 0, $categoryid, $sort);
29 29
     $totalfaqs = count($faqsObj);
@@ -47,8 +47,8 @@  discard block
 block discarded – undo
47 47
 
48 48
     $form = sf_createCategorySelect($options[0]);
49 49
 
50
-    $form .= "&nbsp;<br />" . _MB_SF_DISP . "&nbsp;<input type='text' name='options[]' value='" . $options[1] . "' />&nbsp;" . _MB_SF_FAQS . "";
51
-    $form .= "&nbsp;<br />" . _MB_SF_CHARS . "&nbsp;<input type='text' name='options[]' value='" . $options[2] . "' />&nbsp;" . _MB_SF_LENGTH . "";
50
+    $form .= "&nbsp;<br />"._MB_SF_DISP."&nbsp;<input type='text' name='options[]' value='".$options[1]."' />&nbsp;"._MB_SF_FAQS."";
51
+    $form .= "&nbsp;<br />"._MB_SF_CHARS."&nbsp;<input type='text' name='options[]' value='".$options[2]."' />&nbsp;"._MB_SF_LENGTH."";
52 52
 
53 53
     return $form;
54 54
 }
Please login to merge, or discard this patch.
smartfaq/blocks/faqs_random_diduno.php 2 patches
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -21,9 +21,9 @@
 block discarded – undo
21 21
     $faqsObj = $faq_handler->getRandomFaq('diduno', array(_SF_STATUS_PUBLISHED, _SF_STATUS_NEW_ANSWER));
22 22
 
23 23
     if ($faqsObj) {
24
-           $block['content'] = $faqsObj->diduno();
25
-           $block['id'] = $faqsObj->faqid();
26
-           $block['lang_answer'] = _MB_SF_MOREDETAILS;
24
+            $block['content'] = $faqsObj->diduno();
25
+            $block['id'] = $faqsObj->faqid();
26
+            $block['lang_answer'] = _MB_SF_MOREDETAILS;
27 27
     }
28 28
 
29 29
     return $block;
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -15,7 +15,7 @@
 block discarded – undo
15 15
     $block = array();
16 16
 
17 17
     // Creating the faq handler object
18
-    $faq_handler =& sf_gethandler('faq');
18
+    $faq_handler = & sf_gethandler('faq');
19 19
 
20 20
     // creating the FAQ object
21 21
     $faqsObj = $faq_handler->getRandomFaq('diduno', array(_SF_STATUS_PUBLISHED, _SF_STATUS_NEW_ANSWER));
Please login to merge, or discard this patch.
smartfaq/blocks/faqs_random_how.php 2 patches
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -21,9 +21,9 @@
 block discarded – undo
21 21
     $faqsObj = $faq_handler->getRandomFaq('howdoi', array(_SF_STATUS_PUBLISHED, _SF_STATUS_NEW_ANSWER));
22 22
 
23 23
     if ($faqsObj) {
24
-           $block['content'] = $faqsObj->howdoi();
25
-           $block['id'] = $faqsObj->faqid();
26
-           $block['lang_answer'] = _MB_SF_ANSWERHERE;
24
+            $block['content'] = $faqsObj->howdoi();
25
+            $block['id'] = $faqsObj->faqid();
26
+            $block['lang_answer'] = _MB_SF_ANSWERHERE;
27 27
     }
28 28
 
29 29
     return $block;
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -15,7 +15,7 @@
 block discarded – undo
15 15
     $block = array();
16 16
 
17 17
     // Creating the faq handler object
18
-    $faq_handler =& sf_gethandler('faq');
18
+    $faq_handler = & sf_gethandler('faq');
19 19
 
20 20
     // creating the FAQ object
21 21
     $faqsObj = $faq_handler->getRandomFaq('howdoi', array(_SF_STATUS_PUBLISHED, _SF_STATUS_NEW_ANSWER));
Please login to merge, or discard this patch.
smartfaq/blocks/faqs_recent.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -14,8 +14,8 @@  discard block
 block discarded – undo
14 14
     include_once(XOOPS_ROOT_PATH."/modules/smartfaq/include/functions.php");
15 15
     $myts = &MyTextSanitizer::getInstance();
16 16
 
17
-    $smartModule =& sf_getModuleInfo();
18
-    $smartModuleConfig =& sf_getModuleConfig();
17
+    $smartModule = & sf_getModuleInfo();
18
+    $smartModuleConfig = & sf_getModuleConfig();
19 19
 
20 20
     $block = array();
21 21
 
@@ -30,10 +30,10 @@  discard block
 block discarded – undo
30 30
     $maxQuestionLength = $options[3];
31 31
 
32 32
     // Creating the faq handler object
33
-    $faq_handler =& sf_gethandler('faq');
33
+    $faq_handler = & sf_gethandler('faq');
34 34
 
35 35
     // Creating the category handler object
36
-    $category_handler =& sf_gethandler('category');
36
+    $category_handler = & sf_gethandler('category');
37 37
 
38 38
     // Creating the last FAQs
39 39
     $faqsObj = $faq_handler->getAllPublished($limit, 0, $categoryid, $sort);
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
44 44
             $faqids[] = $thisfaq->getVar('faqid');
45 45
             $userids[$thisfaq->uid()] = 1;
46 46
         }
47
-        $answer_handler =& sf_gethandler('answer');
47
+        $answer_handler = & sf_gethandler('answer');
48 48
         $allanswers = $answer_handler->getLastPublishedByFaq($faqids);
49 49
 
50 50
         foreach ($allanswers as $key => $thisanswer) {
@@ -53,14 +53,14 @@  discard block
 block discarded – undo
53 53
 
54 54
         $member_handler = &xoops_gethandler('member');
55 55
         $users = $member_handler->getUsers(new Criteria('uid', "(".implode(',', array_keys($userids)).")", "IN"), true);
56
-        for ( $i = 0; $i < count($faqsObj); ++$i ) {
56
+        for ($i = 0; $i < count($faqsObj); ++$i) {
57 57
             $faqs['categoryid'] = $faqsObj[$i]->categoryid();
58 58
             $faqs['question'] = $faqsObj[$i]->question($maxQuestionLength);
59 59
             $faqs['faqid'] = $faqsObj[$i]->faqid();
60 60
             $faqs['categoryname'] = $allcategories[$faqsObj[$i]->categoryid()]->getVar('name');
61 61
 
62 62
             // Creating the answer object
63
-            $answerObj =& $allanswers[$faqsObj[$i]->faqid()];
63
+            $answerObj = & $allanswers[$faqsObj[$i]->faqid()];
64 64
 
65 65
             $faqs['date'] = $faqsObj[$i]->datesub();
66 66
 
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
         $block['lang_poster'] = _MB_SF_ANSWEREDBY;
75 75
         $block['lang_date'] = _MB_SF_DATE;
76 76
         $modulename = $myts->htmlSpecialChars($smartModule->getVar('name'));
77
-        $block['lang_visitfaq'] = _MB_SF_VISITFAQ . " " . $modulename;
77
+        $block['lang_visitfaq'] = _MB_SF_VISITFAQ." ".$modulename;
78 78
 
79 79
     }
80 80
 
@@ -87,30 +87,30 @@  discard block
 block discarded – undo
87 87
 
88 88
     $form = sf_createCategorySelect($options[0]);
89 89
 
90
-    $form .= "&nbsp;<br>" . _MB_SF_ORDER . "&nbsp;<select name='options[]'>";
90
+    $form .= "&nbsp;<br>"._MB_SF_ORDER."&nbsp;<select name='options[]'>";
91 91
 
92 92
     $form .= "<option value='datesub'";
93 93
     if ($options[1] == "datesub") {
94 94
         $form .= " selected='selected'";
95 95
     }
96
-    $form .= ">" . _MB_SF_DATE . "</option>\n";
96
+    $form .= ">"._MB_SF_DATE."</option>\n";
97 97
 
98 98
     $form .= "<option value='counter'";
99 99
     if ($options[1] == "counter") {
100 100
         $form .= " selected='selected'";
101 101
     }
102
-    $form .= ">" . _MB_SF_HITS . "</option>\n";
102
+    $form .= ">"._MB_SF_HITS."</option>\n";
103 103
 
104 104
     $form .= "<option value='weight'";
105 105
     if ($options[1] == "weight") {
106 106
         $form .= " selected='selected'";
107 107
     }
108
-    $form .= ">" . _MB_SF_WEIGHT . "</option>\n";
108
+    $form .= ">"._MB_SF_WEIGHT."</option>\n";
109 109
 
110 110
     $form .= "</select>\n";
111 111
 
112
-    $form .= "&nbsp;" . _MB_SF_DISP . "&nbsp;<input type='text' name='options[]' value='" . $options[2] . "' />&nbsp;" . _MB_SF_FAQS . "";
113
-    $form .= "&nbsp;<br>" . _MB_SF_CHARS . "&nbsp;<input type='text' name='options[]' value='" . $options[3] . "' />&nbsp;" . _MB_SF_LENGTH . "";
112
+    $form .= "&nbsp;"._MB_SF_DISP."&nbsp;<input type='text' name='options[]' value='".$options[2]."' />&nbsp;"._MB_SF_FAQS."";
113
+    $form .= "&nbsp;<br>"._MB_SF_CHARS."&nbsp;<input type='text' name='options[]' value='".$options[3]."' />&nbsp;"._MB_SF_LENGTH."";
114 114
 
115 115
     return $form;
116 116
 }
Please login to merge, or discard this patch.
smartfaq/blocks/faqs_random_faq.php 2 patches
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -21,9 +21,9 @@
 block discarded – undo
21 21
     $faqsObj = $faq_handler->getRandomFaq('question', array(_SF_STATUS_PUBLISHED, _SF_STATUS_NEW_ANSWER));
22 22
 
23 23
     if ($faqsObj) {
24
-           $block['content'] = $faqsObj->question();
25
-           $block['id'] = $faqsObj->faqid();
26
-           $block['lang_answer'] = _MB_SF_ANSWERHERE;
24
+            $block['content'] = $faqsObj->question();
25
+            $block['id'] = $faqsObj->faqid();
26
+            $block['lang_answer'] = _MB_SF_ANSWERHERE;
27 27
     }
28 28
 
29 29
     return $block;
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -15,7 +15,7 @@
 block discarded – undo
15 15
     $block = array();
16 16
 
17 17
     // Creating the faq handler object
18
-    $faq_handler =& sf_gethandler('faq');
18
+    $faq_handler = & sf_gethandler('faq');
19 19
 
20 20
     // creating the FAQ object
21 21
     $faqsObj = $faq_handler->getRandomFaq('question', array(_SF_STATUS_PUBLISHED, _SF_STATUS_NEW_ANSWER));
Please login to merge, or discard this patch.