Issues in TreeHandler.php - New Issues - Inspection of "Merge pull request #3 from zyspec/master" - mambax7/pedigree - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( b847d6...d6d54c )

by Michael

created 2019-10-21 01:45 UTC

class/TreeHandler.php (1 issue)

Labels

Bug 1

Severity

Major 1

<?php namespace XoopsModules\Pedigree;
/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
*/
/**
 * Pedigree module for XOOPS
 *
 * @copyright       {@link http://sourceforge.net/projects/xoops/ The XOOPS Project}
 * @license         GPL 2.0 or later
 * @package         pedigree
 * @since           2.5.x
 * @author          XOOPS Module Dev Team (https://xoops.org)
 */

use XoopsModules\Pedigree;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

defined('XOOPS_ROOT_PATH') || die('Restricted access');

/**
 * Class Pedigree\TreeHandler
 */
class TreeHandler extends \XoopsPersistableObjectHandler
{
    /**
     * @param null|object|\XoopsDatabase $db
     */
    public function __construct(\XoopsDatabase $db)
    {
        parent::__construct($db, 'pedigree_tree', Tree::class, 'id', 'naam');
    }

    /**
     * Get criteria for active animals
     *
     * @param null $roft
     * @return \CriteriaCompo
     */
    public function getActiveCriteria($roft = null)
    {
        $grouppermHandler = xoops_getHandler('groupperm');

        //        $criteria = new \CriteriaCompo(new \Criteria('offline', false));
        //        $criteria->add(new \Criteria('published', 0, '>'));
        //        $criteria->add(new \Criteria('published', time(), '<='));
        //        $expiredCriteria = new \CriteriaCompo(new \Criteria('expired', 0));
        //        $expiredCriteria->add(new \Criteria('expired', time(), '>='), 'OR');
        //        $criteria->add($expiredCriteria);

        // add criteria for categories that the user has permissions for
        //        $groups                   = is_object($GLOBALS['xoopsUser']) ? $GLOBALS['xoopsUser']->getGroups() : array(0 => XOOPS_GROUP_ANONYMOUS);
        //mb        $allowedDownCategoriesIds = $grouppermHandler->getItemIds('WFDownCatPerm', $groups, $this->wfdownloads->getModule()->mid());
        //mb        $criteria->add(new \Criteria('cid', '(' . implode(',', $allowedDownCategoriesIds) . ')', 'IN'));

        $criteria = new \CriteriaCompo();
        if (null !== $roft) {
            $criteria->add(new \Criteria('roft', $roft));
        }
        $criteria->setSort('naam ASC');
        $criteria->setOrder('ASC');

        return $criteria;
    }
}


1			<?php namespace XoopsModules\Pedigree;
2			/*
3			You may not change or alter any portion of this comment or credits
4			of supporting developers from this source code or any supporting source code
5			which is considered copyrighted (c) material of the original comment or credit authors.
6
7			This program is distributed in the hope that it will be useful,
8			but WITHOUT ANY WARRANTY; without even the implied warranty of
9			MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
10			*/
11			/**
12			* Pedigree module for XOOPS
13			*
14			* @copyright {@link http://sourceforge.net/projects/xoops/ The XOOPS Project}
15			* @license GPL 2.0 or later
16			* @package pedigree
17			* @since 2.5.x
18			* @author XOOPS Module Dev Team (https://xoops.org)
19			*/
20
21			use XoopsModules\Pedigree;
			0 ignored issues – show Bug introduced 2019-10-21 01:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this This use statement conflicts with another class in this namespace, `XoopsModules\Pedigree\Pedigree`. Consider defining an alias. Let?s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let?s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
22
23			defined('XOOPS_ROOT_PATH') \|\| die('Restricted access');
24
25			/**
26			* Class Pedigree\TreeHandler
27			*/
28			class TreeHandler extends \XoopsPersistableObjectHandler
29			{
30			/**
31			* @param null\|object\|\XoopsDatabase $db
32			*/
33			public function __construct(\XoopsDatabase $db)
34			{
35			parent::__construct($db, 'pedigree_tree', Tree::class, 'id', 'naam');
36			}
37
38			/**
39			* Get criteria for active animals
40			*
41			* @param null $roft
42			* @return \CriteriaCompo
43			*/
44			public function getActiveCriteria($roft = null)
45			{
46			$grouppermHandler = xoops_getHandler('groupperm');
47
48			// $criteria = new \CriteriaCompo(new \Criteria('offline', false));
49			// $criteria->add(new \Criteria('published', 0, '>'));
50			// $criteria->add(new \Criteria('published', time(), '<='));
51			// $expiredCriteria = new \CriteriaCompo(new \Criteria('expired', 0));
52			// $expiredCriteria->add(new \Criteria('expired', time(), '>='), 'OR');
53			// $criteria->add($expiredCriteria);
54
55			// add criteria for categories that the user has permissions for
56			// $groups = is_object($GLOBALS['xoopsUser']) ? $GLOBALS['xoopsUser']->getGroups() : array(0 => XOOPS_GROUP_ANONYMOUS);
57			//mb $allowedDownCategoriesIds = $grouppermHandler->getItemIds('WFDownCatPerm', $groups, $this->wfdownloads->getModule()->mid());
58			//mb $criteria->add(new \Criteria('cid', '(' . implode(',', $allowedDownCategoriesIds) . ')', 'IN'));
59
60			$criteria = new \CriteriaCompo();
61			if (null !== $roft) {
62			$criteria->add(new \Criteria('roft', $roft));
63			}
64			$criteria->setSort('naam ASC');
65			$criteria->setOrder('ASC');
66
67			return $criteria;
68			}
69			}
70

mambax7 / pedigree

Push — master ( b847d6...d6d54c )

class/TreeHandler.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like