mambax7 / newbb5

class/Digest.php

Spacing +6 added lines, -6 removed lines

@@ -67,7 +67,7 @@ 
         global $myts;
 
         $clean = stripslashes($text);
-        $clean =& $myts->displayTarea($clean, 1, 0, 1);
+        $clean = & $myts->displayTarea($clean, 1, 0, 1);
         $clean = strip_tags($clean);
         $clean = htmlspecialchars($clean, ENT_QUOTES);
 
@@ -87,16 +87,16 @@ 
             $linebreak = $isHtml ? '<br>' : "\n";
             for ($i = 0; $i < $digest_count; ++$i) {
                 if ($isHtml) {
-                    $content .= ($i + 1) . '. <a href=' . $this->items[$i]['link'] . '>' . $this->items[$i]['title'] . '</a>';
+                    $content .= ($i + 1).'. <a href='.$this->items[$i]['link'].'>'.$this->items[$i]['title'].'</a>';
                 } else {
-                    $content .= ($i + 1) . '. ' . $this->items[$i]['title'] . $linebreak . $this->items[$i]['link'];
+                    $content .= ($i + 1).'. '.$this->items[$i]['title'].$linebreak.$this->items[$i]['link'];
                 }
 
-                $content .= $linebreak . $this->items[$i]['author'];
+                $content .= $linebreak.$this->items[$i]['author'];
                 if ($isSummary) {
-                    $content .= $linebreak . $this->items[$i]['summary'];
+                    $content .= $linebreak.$this->items[$i]['summary'];
                 }
-                $content .= $linebreak . $linebreak;
+                $content .= $linebreak.$linebreak;
             }
         }
         $this->setVar('digest_content', $content);

class/Utility.php

Spacing +3 added lines, -3 removed lines

@@ -65,7 +65,7 @@ 
     public function addField($field, $table)
     {
         global $xoopsDB;
-        $result = $xoopsDB->queryF('ALTER TABLE ' . $table . " ADD $field");
+        $result = $xoopsDB->queryF('ALTER TABLE '.$table." ADD $field");
 
         return $result;
     }
@@ -83,7 +83,7 @@ 
             if (!@mkdir($folder) && !is_dir($folder)) {
                 throw new \RuntimeException(sprintf('Unable to create the %s directory', $folder));
             } else {
-                file_put_contents($folder . '/index.html', '<script>history.go(-1);</script>');
+                file_put_contents($folder.'/index.html', '<script>history.go(-1);</script>');
             }
         } catch (\Exception $e) {
             echo 'Caught exception: ', $e->getMessage(), "\n", '<br>';
@@ -98,7 +98,7 @@ 
             return;
         }
         // for 2.5 systems, clear everything
-        require_once XOOPS_ROOT_PATH . '/modules/system/class/maintenance.php';
+        require_once XOOPS_ROOT_PATH.'/modules/system/class/maintenance.php';
         $maintenance = new \SystemMaintenance();
         $cacheList   = [
             3, // xoops_cache

class/ReadHandler.php

Spacing +19 added lines, -19 removed lines

@@ -92,7 +92,7 @@ 
     public function __construct(\XoopsDatabase $db, $type)
     {
         $type = ('forum' === $type) ? 'forum' : 'topic';
-        parent::__construct($db, 'newbb_reads_' . $type, Read::class . $type, 'read_id', 'post_id');
+        parent::__construct($db, 'newbb_reads_'.$type, Read::class.$type, 'read_id', 'post_id');
         $this->type  = $type;
         $newbbConfig = newbbLoadConfig();
         // irmtfan if read_expire = 0 dont clean
@@ -113,7 +113,7 @@ 
             return false;
         }
 
-        $sql = 'DELETE bb FROM ' . $this->table . ' AS bb' . ' LEFT JOIN ' . $this->table . ' AS aa ON bb.read_item = aa.read_item ' . ' WHERE aa.post_id > bb.post_id';
+        $sql = 'DELETE bb FROM '.$this->table.' AS bb'.' LEFT JOIN '.$this->table.' AS aa ON bb.read_item = aa.read_item '.' WHERE aa.post_id > bb.post_id';
         if (!$result = $this->db->queryF($sql)) {
             //xoops_error($this->db->error());
             return false;
@@ -124,7 +124,7 @@ 
         }
         // irmtfan move here and rephrase
         $expire = time() - (int)$this->lifetime;
-        $sql    = 'DELETE FROM ' . $this->table . ' WHERE read_time < ' . $expire;
+        $sql    = 'DELETE FROM '.$this->table.' WHERE read_time < '.$expire;
         if (!$result = $this->db->queryF($sql)) {
             //xoops_error($this->db->error());
             return false;
@@ -180,7 +180,7 @@ 
                 return false;
             }
         }
-        $sql = 'SELECT post_id ' . ' FROM ' . $this->table . ' WHERE read_item = ' . (int)$read_item . '     AND uid = ' . (int)$uid;
+        $sql = 'SELECT post_id '.' FROM '.$this->table.' WHERE read_item = '.(int)$read_item.'     AND uid = '.(int)$uid;
         if (!$result = $this->db->queryF($sql, 1)) {
             return null;
         }
@@ -235,7 +235,7 @@ 
             }
         }
 
-        $sql = 'UPDATE ' . $this->table . ' SET post_id = ' . (int)$post_id . ',' . '     read_time =' . time() . ' WHERE read_item = ' . (int)$read_item . '     AND uid = ' . (int)$uid;
+        $sql = 'UPDATE '.$this->table.' SET post_id = '.(int)$post_id.','.'     read_time ='.time().' WHERE read_item = '.(int)$read_item.'     AND uid = '.(int)$uid;
         if ($this->db->queryF($sql) && $this->db->getAffectedRows()) {
             return true;
         }
@@ -307,7 +307,7 @@ 
         }
 
         $criteria = new \CriteriaCompo(new \Criteria('uid', $uid));
-        $criteria->add(new \Criteria('read_item', '(' . implode(', ', array_map('intval', array_keys($items))) . ')', 'IN'));
+        $criteria->add(new \Criteria('read_item', '('.implode(', ', array_map('intval', array_keys($items))).')', 'IN'));
         $itemsObject = $this->getAll($criteria, ['read_item', 'post_id']);
 
         $items_list = [];
@@ -339,43 +339,43 @@ 
         $sql = "SET sql_mode=(SELECT REPLACE(@@sql_mode, 'ONLY_FULL_GROUP_BY', ''))";
         $this->db->queryF($sql);
 
-        $sql = 'CREATE TABLE ' . $this->table . '_duplicate LIKE ' . $this->table . '; ';
+        $sql = 'CREATE TABLE '.$this->table.'_duplicate LIKE '.$this->table.'; ';
         if (!$result = $this->db->queryF($sql)) {
-            xoops_error($this->db->error() . '<br>' . $sql);
+            xoops_error($this->db->error().'<br>'.$sql);
 
             return false;
         }
-        $sql = 'INSERT ' . $this->table . '_duplicate SELECT * FROM ' . $this->table . ' GROUP BY read_item, uid; ';
+        $sql = 'INSERT '.$this->table.'_duplicate SELECT * FROM '.$this->table.' GROUP BY read_item, uid; ';
         if (!$result = $this->db->queryF($sql)) {
-            xoops_error($this->db->error() . '<br>' . $sql);
+            xoops_error($this->db->error().'<br>'.$sql);
 
             return false;
         }
-        $sql = 'RENAME TABLE ' . $this->table . ' TO ' . $this->table . '_with_duplicate; ';
+        $sql = 'RENAME TABLE '.$this->table.' TO '.$this->table.'_with_duplicate; ';
         if (!$result = $this->db->queryF($sql)) {
-            xoops_error($this->db->error() . '<br>' . $sql);
+            xoops_error($this->db->error().'<br>'.$sql);
 
             return false;
         }
-        $sql = 'RENAME TABLE ' . $this->table . '_duplicate TO ' . $this->table . '; ';
+        $sql = 'RENAME TABLE '.$this->table.'_duplicate TO '.$this->table.'; ';
         if (!$result = $this->db->queryF($sql)) {
-            xoops_error($this->db->error() . '<br>' . $sql);
+            xoops_error($this->db->error().'<br>'.$sql);
 
             return false;
         }
-        $sql    = 'SHOW INDEX FROM ' . $this->table . " WHERE KEY_NAME = 'read_item_uid'";
+        $sql    = 'SHOW INDEX FROM '.$this->table." WHERE KEY_NAME = 'read_item_uid'";
         $result = $this->db->queryF($sql);
         if (empty($result)) {
-            $sql .= 'ALTER TABLE ' . $this->table . ' ADD INDEX read_item_uid ( read_item, uid ); ';
+            $sql .= 'ALTER TABLE '.$this->table.' ADD INDEX read_item_uid ( read_item, uid ); ';
             if (!$result = $this->db->queryF($sql)) {
-                xoops_error($this->db->error() . '<br>' . $sql);
+                xoops_error($this->db->error().'<br>'.$sql);
 
                 return false;
             }
         }
-        $sql = 'DROP TABLE ' . $this->table . '_with_duplicate; ';
+        $sql = 'DROP TABLE '.$this->table.'_with_duplicate; ';
         if (!$result = $this->db->queryF($sql)) {
-            xoops_error($this->db->error() . '<br>' . $sql);
+            xoops_error($this->db->error().'<br>'.$sql);
 
             return false;
         }

class/StatsHandler.php

Indentation +80 added lines, -80 removed lines

@@ -79,50 +79,50 @@ 
         }
 
         $sql    = "    UPDATE {$this->table}"
-                  . '    SET stats_value = CASE '
-                  . "                    WHEN time_format = '' OR DATE_FORMAT(time_update, time_format) = DATE_FORMAT(NOW(), time_format)  THEN stats_value + '{$increment}' "
-                  . "                    ELSE '{$increment}' "
-                  . '                END, '
-                  . '        time_update = NOW()'
-                  . '    WHERE '
-                  . "        (stats_id = '0' OR stats_id = '{$id}') "
-                  . "        AND stats_type='{$type}' ";
+                    . '    SET stats_value = CASE '
+                    . "                    WHEN time_format = '' OR DATE_FORMAT(time_update, time_format) = DATE_FORMAT(NOW(), time_format)  THEN stats_value + '{$increment}' "
+                    . "                    ELSE '{$increment}' "
+                    . '                END, '
+                    . '        time_update = NOW()'
+                    . '    WHERE '
+                    . "        (stats_id = '0' OR stats_id = '{$id}') "
+                    . "        AND stats_type='{$type}' ";
         $result = $this->db->queryF($sql);
         $rows   = $this->db->getAffectedRows();
         if (0 == $rows) {
             $sql    = "    INSERT INTO {$this->table}"
-                      . '        (`stats_id`, `stats_value`, `stats_type`, `stats_period`, `time_update`, `time_format`) '
-                      . '    VALUES '
-                      . "        ('0', '{$increment}', '{$type}', '"
-                      . array_search('total', $this->param['period'], true)
-                      . "', NOW(), ''), "
-                      . "        ('0', '{$increment}', '{$type}', '"
-                      . array_search('day', $this->param['period'], true)
-                      . "', NOW(), '%Y%j'), "
-                      . "        ('0', '{$increment}', '{$type}', '"
-                      . array_search('week', $this->param['period'], true)
-                      . "', NOW(), '%Y%u'), "
-                      . "        ('0', '{$increment}', '{$type}', '"
-                      . array_search('month', $this->param['period'], true)
-                      . "', NOW(), '%Y%m')";
+                        . '        (`stats_id`, `stats_value`, `stats_type`, `stats_period`, `time_update`, `time_format`) '
+                        . '    VALUES '
+                        . "        ('0', '{$increment}', '{$type}', '"
+                        . array_search('total', $this->param['period'], true)
+                        . "', NOW(), ''), "
+                        . "        ('0', '{$increment}', '{$type}', '"
+                        . array_search('day', $this->param['period'], true)
+                        . "', NOW(), '%Y%j'), "
+                        . "        ('0', '{$increment}', '{$type}', '"
+                        . array_search('week', $this->param['period'], true)
+                        . "', NOW(), '%Y%u'), "
+                        . "        ('0', '{$increment}', '{$type}', '"
+                        . array_search('month', $this->param['period'], true)
+                        . "', NOW(), '%Y%m')";
             $result = $this->db->queryF($sql);
         }
         if ($rows < 2 * count($this->param['period']) && !empty($id)) {
             $sql    = "    INSERT INTO {$this->table}"
-                      . '        (`stats_id`, `stats_value`, `stats_type`, `stats_period`, `time_update`, `time_format`) '
-                      . '    VALUES '
-                      . "        ('{$id}', '{$increment}', '{$type}', '"
-                      . array_search('total', $this->param['period'], true)
-                      . "', NOW(), ''), "
-                      . "        ('{$id}', '{$increment}', '{$type}', '"
-                      . array_search('day', $this->param['period'], true)
-                      . "', NOW(), '%Y%j'), "
-                      . "        ('{$id}', '{$increment}', '{$type}', '"
-                      . array_search('week', $this->param['period'], true)
-                      . "', NOW(), '%Y%u'), "
-                      . "        ('{$id}', '{$increment}', '{$type}', '"
-                      . array_search('month', $this->param['period'], true)
-                      . "', NOW(), '%Y%m')";
+                        . '        (`stats_id`, `stats_value`, `stats_type`, `stats_period`, `time_update`, `time_format`) '
+                        . '    VALUES '
+                        . "        ('{$id}', '{$increment}', '{$type}', '"
+                        . array_search('total', $this->param['period'], true)
+                        . "', NOW(), ''), "
+                        . "        ('{$id}', '{$increment}', '{$type}', '"
+                        . array_search('day', $this->param['period'], true)
+                        . "', NOW(), '%Y%j'), "
+                        . "        ('{$id}', '{$increment}', '{$type}', '"
+                        . array_search('week', $this->param['period'], true)
+                        . "', NOW(), '%Y%u'), "
+                        . "        ('{$id}', '{$increment}', '{$type}', '"
+                        . array_search('month', $this->param['period'], true)
+                        . "', NOW(), '%Y%m')";
             $result = $this->db->queryF($sql);
         }
     }
@@ -148,17 +148,17 @@ 
             $_periods[] = array_search($period, $this->param['period']);
         }
         $sql    = '    SELECT stats_id, stats_value, stats_type, stats_period '
-                  . "    FROM {$this->table} "
-                  . '    WHERE '
-                  . "        ( time_format = '' OR DATE_FORMAT(time_update, time_format) = DATE_FORMAT(NOW(), time_format) ) "
-                  . '        '
-                  . (empty($ids) ? '' : 'AND stats_id IN ('
+                    . "    FROM {$this->table} "
+                    . '    WHERE '
+                    . "        ( time_format = '' OR DATE_FORMAT(time_update, time_format) = DATE_FORMAT(NOW(), time_format) ) "
+                    . '        '
+                    . (empty($ids) ? '' : 'AND stats_id IN ('
                                         . implode(', ', array_map('intval', $ids))
                                         . ')')
-                  . '        '
-                  . (empty($_types) ? '' : 'AND stats_type IN (' . implode(', ', $_types) . ')')
-                  . '        '
-                  . (empty($_periods) ? '' : 'AND stats_period IN (' . implode(', ', $_periods) . ')');
+                    . '        '
+                    . (empty($_types) ? '' : 'AND stats_type IN (' . implode(', ', $_types) . ')')
+                    . '        '
+                    . (empty($_periods) ? '' : 'AND stats_period IN (' . implode(', ', $_periods) . ')');
         $result = $this->db->query($sql);
 
         while (false !== ($row = $this->db->fetchArray($result))) {
@@ -204,21 +204,21 @@ 
                 list($topics, $views) = $this->db->fetchRow($result);
                 $views = empty($views) ? 0 : $views; // null check
                 $this->db->queryF("    INSERT INTO {$this->table}"
-                                  . '        (`stats_id`, `stats_value`, `stats_type`, `stats_period`, `time_update`, `time_format`) '
-                                  . '    VALUES '
-                                  . "        ('{$forum_id}', '{$topics}', '"
-                                  . array_search('topic', $this->param['type'], true)
-                                  . "', '"
-                                  . array_search($period, $this->param['period'])
-                                  . "', NOW(), '{$format}')");
+                                    . '        (`stats_id`, `stats_value`, `stats_type`, `stats_period`, `time_update`, `time_format`) '
+                                    . '    VALUES '
+                                    . "        ('{$forum_id}', '{$topics}', '"
+                                    . array_search('topic', $this->param['type'], true)
+                                    . "', '"
+                                    . array_search($period, $this->param['period'])
+                                    . "', NOW(), '{$format}')");
                 $this->db->queryF("    INSERT INTO {$this->table}"
-                                  . '        (`stats_id`, `stats_value`, `stats_type`, `stats_period`, `time_update`, `time_format`) '
-                                  . '    VALUES '
-                                  . "        ('{$forum_id}', '{$views}', '"
-                                  . array_search('view', $this->param['type'], true)
-                                  . "', '"
-                                  . array_search($period, $this->param['period'])
-                                  . "', NOW(), '{$format}')");
+                                    . '        (`stats_id`, `stats_value`, `stats_type`, `stats_period`, `time_update`, `time_format`) '
+                                    . '    VALUES '
+                                    . "        ('{$forum_id}', '{$views}', '"
+                                    . array_search('view', $this->param['type'], true)
+                                    . "', '"
+                                    . array_search($period, $this->param['period'])
+                                    . "', NOW(), '{$format}')");
                 @$counts['topic'][$period] += $topics;
                 @$counts['view'][$period] += $views;
 
@@ -226,26 +226,26 @@ 
                 $result = $this->db->query($sql);
                 list($digests) = $this->db->fetchRow($result);
                 $this->db->queryF("    INSERT INTO {$this->table}"
-                                  . '        (`stats_id`, `stats_value`, `stats_type`, `stats_period`, `time_update`, `time_format`) '
-                                  . '    VALUES '
-                                  . "        ('{$forum_id}', '{$digests}', '"
-                                  . array_search('digest', $this->param['type'], true)
-                                  . "', '"
-                                  . array_search($period, $this->param['period'])
-                                  . "', NOW(), '{$format}')");
+                                    . '        (`stats_id`, `stats_value`, `stats_type`, `stats_period`, `time_update`, `time_format`) '
+                                    . '    VALUES '
+                                    . "        ('{$forum_id}', '{$digests}', '"
+                                    . array_search('digest', $this->param['type'], true)
+                                    . "', '"
+                                    . array_search($period, $this->param['period'])
+                                    . "', NOW(), '{$format}')");
                 @$counts['digest'][$period] += $digests;
 
                 $sql    = '    SELECT COUNT(*)' . '    FROM ' . $this->db->prefix('newbb_posts') . "    WHERE approved=1 AND forum_id = {$forum_id}" . "        AND FROM_UNIXTIME(post_time, '{$format}') >= FROM_UNIXTIME({$now}, '{$format}')";
                 $result = $this->db->query($sql);
                 list($posts) = $this->db->fetchRow($result);
                 $this->db->queryF("    INSERT INTO {$this->table}"
-                                  . '        (`stats_id`, `stats_value`, `stats_type`, `stats_period`, `time_update`, `time_format`) '
-                                  . '    VALUES '
-                                  . "        ('{$forum_id}', '{$posts}', '"
-                                  . array_search('post', $this->param['type'])
-                                  . "', '"
-                                  . array_search($period, $this->param['period'], true)
-                                  . "', NOW(), '{$format}')");
+                                    . '        (`stats_id`, `stats_value`, `stats_type`, `stats_period`, `time_update`, `time_format`) '
+                                    . '    VALUES '
+                                    . "        ('{$forum_id}', '{$posts}', '"
+                                    . array_search('post', $this->param['type'])
+                                    . "', '"
+                                    . array_search($period, $this->param['period'], true)
+                                    . "', NOW(), '{$format}')");
                 @$counts['post'][$period] += $posts;
             }
         }
@@ -254,13 +254,13 @@ 
         foreach ($time_start as $period => $format) {
             foreach (array_keys($counts) as $type) {
                 $this->db->queryF("    INSERT INTO {$this->table}"
-                                  . '        (`stats_id`, `stats_value`, `stats_type`, `stats_period`, `time_update`, `time_format`) '
-                                  . '    VALUES '
-                                  . "        ('0', '{$counts[$type][$period]}', '"
-                                  . array_search($type, $this->param['type'], true)
-                                  . "', '"
-                                  . array_search($period, $this->param['period'], true)
-                                  . "', NOW(), '{$format}')");
+                                    . '        (`stats_id`, `stats_value`, `stats_type`, `stats_period`, `time_update`, `time_format`) '
+                                    . '    VALUES '
+                                    . "        ('0', '{$counts[$type][$period]}', '"
+                                    . array_search($type, $this->param['type'], true)
+                                    . "', '"
+                                    . array_search($period, $this->param['period'], true)
+                                    . "', NOW(), '{$format}')");
             }
         }
     }

Spacing +16 added lines, -16 removed lines

@@ -12,7 +12,7 @@ 
 
 // defined('XOOPS_ROOT_PATH') || die('Restricted access');
 
-defined('NEWBB_FUNCTIONS_INI') || require_once __DIR__ . '/functions.ini.php';
+defined('NEWBB_FUNCTIONS_INI') || require_once __DIR__.'/functions.ini.php';
 
 define('NEWBB_STATS_TYPE_TOPIC', 1);
 define('NEWBB_STATS_TYPE_POST', 2);
@@ -78,7 +78,7 @@ 
             return false;
         }
 
-        $sql    = "    UPDATE {$this->table}"
+        $sql = "    UPDATE {$this->table}"
                   . '    SET stats_value = CASE '
                   . "                    WHEN time_format = '' OR DATE_FORMAT(time_update, time_format) = DATE_FORMAT(NOW(), time_format)  THEN stats_value + '{$increment}' "
                   . "                    ELSE '{$increment}' "
@@ -90,7 +90,7 @@ 
         $result = $this->db->queryF($sql);
         $rows   = $this->db->getAffectedRows();
         if (0 == $rows) {
-            $sql    = "    INSERT INTO {$this->table}"
+            $sql = "    INSERT INTO {$this->table}"
                       . '        (`stats_id`, `stats_value`, `stats_type`, `stats_period`, `time_update`, `time_format`) '
                       . '    VALUES '
                       . "        ('0', '{$increment}', '{$type}', '"
@@ -147,7 +147,7 @@ 
         foreach ($periods as $period) {
             $_periods[] = array_search($period, $this->param['period']);
         }
-        $sql    = '    SELECT stats_id, stats_value, stats_type, stats_period '
+        $sql = '    SELECT stats_id, stats_value, stats_type, stats_period '
                   . "    FROM {$this->table} "
                   . '    WHERE '
                   . "        ( time_format = '' OR DATE_FORMAT(time_update, time_format) = DATE_FORMAT(NOW(), time_format) ) "
@@ -156,9 +156,9 @@ 
                                         . implode(', ', array_map('intval', $ids))
                                         . ')')
                   . '        '
-                  . (empty($_types) ? '' : 'AND stats_type IN (' . implode(', ', $_types) . ')')
+                  . (empty($_types) ? '' : 'AND stats_type IN ('.implode(', ', $_types).')')
                   . '        '
-                  . (empty($_periods) ? '' : 'AND stats_period IN (' . implode(', ', $_periods) . ')');
+                  . (empty($_periods) ? '' : 'AND stats_period IN ('.implode(', ', $_periods).')');
         $result = $this->db->query($sql);
 
         while (false !== ($row = $this->db->fetchArray($result))) {
@@ -170,36 +170,36 @@ 
 
     public function reset()
     {
-        $this->db->queryF('TRUNCATE TABLE ' . $this->table);
+        $this->db->queryF('TRUNCATE TABLE '.$this->table);
         $now        = time();
         $time_start = [
             'day'   => '%Y%j',
             'week'  => '%Y%u',
             'month' => '%Y%m'
         ];
-        $counts     = [];
+        $counts = [];
 
-        $sql = '    SELECT forum_id' . '    FROM ' . $this->db->prefix('newbb_forums');
+        $sql = '    SELECT forum_id'.'    FROM '.$this->db->prefix('newbb_forums');
         $ret = $this->db->query($sql);
         while (false !== (list($forum_id) = $this->db->fetchRow($ret))) {
-            $sql    = '    SELECT COUNT(*), SUM(topic_views)' . '    FROM ' . $this->db->prefix('newbb_topics') . "    WHERE approved=1 AND forum_id = {$forum_id}";
+            $sql    = '    SELECT COUNT(*), SUM(topic_views)'.'    FROM '.$this->db->prefix('newbb_topics')."    WHERE approved=1 AND forum_id = {$forum_id}";
             $result = $this->db->query($sql);
             list($topics, $views) = $this->db->fetchRow($result);
             $this->update($forum_id, 'topic', $topics);
             $this->update($forum_id, 'view', $views);
 
-            $sql    = '    SELECT COUNT(*)' . '    FROM ' . $this->db->prefix('newbb_topics') . "    WHERE approved=1 AND topic_digest >0 AND forum_id = {$forum_id}";
+            $sql    = '    SELECT COUNT(*)'.'    FROM '.$this->db->prefix('newbb_topics')."    WHERE approved=1 AND topic_digest >0 AND forum_id = {$forum_id}";
             $result = $this->db->query($sql);
             list($digests) = $this->db->fetchRow($result);
             $this->update($forum_id, 'digest', $digests);
 
-            $sql    = '    SELECT COUNT(*)' . '    FROM ' . $this->db->prefix('newbb_posts') . "    WHERE approved=1 AND forum_id = {$forum_id}";
+            $sql    = '    SELECT COUNT(*)'.'    FROM '.$this->db->prefix('newbb_posts')."    WHERE approved=1 AND forum_id = {$forum_id}";
             $result = $this->db->query($sql);
             list($posts) = $this->db->fetchRow($result);
             $this->update($forum_id, 'post', $posts);
 
             foreach ($time_start as $period => $format) {
-                $sql    = '    SELECT COUNT(*), SUM(topic_views)' . '    FROM ' . $this->db->prefix('newbb_topics') . "    WHERE approved=1 AND forum_id = {$forum_id}" . "        AND FROM_UNIXTIME(topic_time, '{$format}') >= FROM_UNIXTIME({$now}, '{$format}')";
+                $sql    = '    SELECT COUNT(*), SUM(topic_views)'.'    FROM '.$this->db->prefix('newbb_topics')."    WHERE approved=1 AND forum_id = {$forum_id}"."        AND FROM_UNIXTIME(topic_time, '{$format}') >= FROM_UNIXTIME({$now}, '{$format}')";
                 $result = $this->db->query($sql);
                 list($topics, $views) = $this->db->fetchRow($result);
                 $views = empty($views) ? 0 : $views; // null check
@@ -222,7 +222,7 @@ 
                 @$counts['topic'][$period] += $topics;
                 @$counts['view'][$period] += $views;
 
-                $sql    = '    SELECT COUNT(*)' . '    FROM ' . $this->db->prefix('newbb_topics') . "    WHERE approved=1 AND topic_digest >0 AND forum_id = {$forum_id}" . "        AND FROM_UNIXTIME(digest_time, '{$format}') >= FROM_UNIXTIME({$now}, '{$format}')";
+                $sql    = '    SELECT COUNT(*)'.'    FROM '.$this->db->prefix('newbb_topics')."    WHERE approved=1 AND topic_digest >0 AND forum_id = {$forum_id}"."        AND FROM_UNIXTIME(digest_time, '{$format}') >= FROM_UNIXTIME({$now}, '{$format}')";
                 $result = $this->db->query($sql);
                 list($digests) = $this->db->fetchRow($result);
                 $this->db->queryF("    INSERT INTO {$this->table}"
@@ -235,7 +235,7 @@ 
                                   . "', NOW(), '{$format}')");
                 @$counts['digest'][$period] += $digests;
 
-                $sql    = '    SELECT COUNT(*)' . '    FROM ' . $this->db->prefix('newbb_posts') . "    WHERE approved=1 AND forum_id = {$forum_id}" . "        AND FROM_UNIXTIME(post_time, '{$format}') >= FROM_UNIXTIME({$now}, '{$format}')";
+                $sql    = '    SELECT COUNT(*)'.'    FROM '.$this->db->prefix('newbb_posts')."    WHERE approved=1 AND forum_id = {$forum_id}"."        AND FROM_UNIXTIME(post_time, '{$format}') >= FROM_UNIXTIME({$now}, '{$format}')";
                 $result = $this->db->query($sql);
                 list($posts) = $this->db->fetchRow($result);
                 $this->db->queryF("    INSERT INTO {$this->table}"
@@ -250,7 +250,7 @@ 
             }
         }
 
-        $this->db->queryF("    DELETE FROM {$this->table}" . "    WHERE stats_id = '0' AND stats_period <> " . array_search('total', $this->param['period'], true));
+        $this->db->queryF("    DELETE FROM {$this->table}"."    WHERE stats_id = '0' AND stats_period <> ".array_search('total', $this->param['period'], true));
         foreach ($time_start as $period => $format) {
             foreach (array_keys($counts) as $type) {
                 $this->db->queryF("    INSERT INTO {$this->table}"

class/User.php

Indentation +6 added lines, -6 removed lines

@@ -188,12 +188,12 @@
             }
             // irmtfan hardcore removed align="left"
             $table = "<table class='userlevel'><tr><td class='end'><img src='"
-                     . $rpg_images['img_left']
-                     . "' alt='' /></td><td class='center' background='"
-                     . $rpg_images['img_backing']
-                     . "'><img src='%s' width='%d' alt='' class='icon_left' /></td><td><img src='"
-                     . $rpg_images['img_right']
-                     . "' alt='' /></td></tr></table>";
+                        . $rpg_images['img_left']
+                        . "' alt='' /></td><td class='center' background='"
+                        . $rpg_images['img_backing']
+                        . "'><img src='%s' width='%d' alt='' class='icon_left' /></td><td><img src='"
+                        . $rpg_images['img_right']
+                        . "' alt='' /></td></tr></table>";
 
             $info = _MD_NEWBB_LEVEL . ' ' . $level['level'] . '<br><span title="' . _MD_NEWBB_HP_DESC . '">' . _MD_NEWBB_HP . ' ' . $level['hp'] . ' / ' . $level['hp_max'] . '</span><br>' . sprintf($table, $rpg_images['orange'], $level['hp_width']);
             $info .= '<span title="' . _MD_NEWBB_MP_DESC . '">' . _MD_NEWBB_MP . ' ' . $level['mp'] . ' / ' . $level['mp_max'] . '</span><br>' . sprintf($table, $rpg_images['green'], $level['mp_width']);

Spacing +20 added lines, -20 removed lines

@@ -81,13 +81,13 @@ 
     $level              = [];
     $level['level']     = $showlevel;
     $level['exp']       = $ep;
-    $level['exp_width'] = $ep . '%';
+    $level['exp_width'] = $ep.'%';
     $level['hp']        = $hp;
     $level['hp_max']    = $maxhp;
-    $level['hp_width']  = $hpf . '%';
+    $level['hp_width']  = $hpf.'%';
     $level['mp']        = $mp;
     $level['mp_max']    = $maxmp;
-    $level['mp_width']  = $mpf . '%';
+    $level['mp_width']  = $mpf.'%';
 
     return $level;
 }
@@ -117,49 +117,49 @@ 
 
         $user               = $this->user;
         $userbar['profile'] = [
-            'link' => XOOPS_URL . '/userinfo.php?uid=' . $user->getVar('uid'),
+            'link' => XOOPS_URL.'/userinfo.php?uid='.$user->getVar('uid'),
             'name' => _PROFILE
         ];
 
         if (is_object($GLOBALS['xoopsUser'])) {
             $userbar['pm'] = [
-                'link' => "javascript:void openWithSelfMain('" . XOOPS_URL . '/pmlite.php?send2=1&to_userid=' . $user->getVar('uid') . "', 'pmlite', 450, 380);",
+                'link' => "javascript:void openWithSelfMain('".XOOPS_URL.'/pmlite.php?send2=1&to_userid='.$user->getVar('uid')."', 'pmlite', 450, 380);",
                 'name' => _MD_NEWBB_PM
             ];
         }
         if ($user->getVar('user_viewemail') || $isAdmin) {
             $userbar['email'] = [
-                'link' => "javascript:void window.open('mailto:" . $user->getVar('email') . "', 'new');",
+                'link' => "javascript:void window.open('mailto:".$user->getVar('email')."', 'new');",
                 'name' => _MD_NEWBB_EMAIL
             ];
         }
         if ($url = $user->getVar('url')) {
             $userbar['url'] = [
-                'link' => "javascript:void window.open('" . $url . "', 'new');",
+                'link' => "javascript:void window.open('".$url."', 'new');",
                 'name' => _MD_NEWBB_WWW
             ];
         }
         if ($icq = $user->getVar('user_icq')) {
             $userbar['icq'] = [
-                'link' => "javascript:void window.open('http://wwp.icq.com/scripts/search.dll?to=" . $icq . "', 'new');",
+                'link' => "javascript:void window.open('http://wwp.icq.com/scripts/search.dll?to=".$icq."', 'new');",
                 'name' => _MD_NEWBB_ICQ
             ];
         }
         if ($aim = $user->getVar('user_aim')) {
             $userbar['aim'] = [
-                'link' => "javascript:void window.open('aim:goim?screenname=" . $aim . '&message=Hi+' . $aim . '+Are+you+there?' . "', 'new');",
+                'link' => "javascript:void window.open('aim:goim?screenname=".$aim.'&message=Hi+'.$aim.'+Are+you+there?'."', 'new');",
                 'name' => _MD_NEWBB_AIM
             ];
         }
         if ($yim = $user->getVar('user_yim')) {
             $userbar['yim'] = [
-                'link' => "javascript:void window.open('http://edit.yahoo.com/config/send_webmesg?.target=" . $yim . '&.src=pg' . "', 'new');",
+                'link' => "javascript:void window.open('http://edit.yahoo.com/config/send_webmesg?.target=".$yim.'&.src=pg'."', 'new');",
                 'name' => _MD_NEWBB_YIM
             ];
         }
         if ($msn = $user->getVar('user_msnm')) {
             $userbar['msnm'] = [
-                'link' => "javascript:void window.open('http://members.msn.com?mem=" . $msn . "', 'new');",
+                'link' => "javascript:void window.open('http://members.msn.com?mem=".$msn."', 'new');",
                 'name' => _MD_NEWBB_MSNM
             ];
         }
@@ -183,7 +183,7 @@ 
                 $rpg_path    = $iconHandler->getPath('rpg');
                 foreach (['img_left', 'img_backing', 'img_right', 'blue', 'green', 'orange'] as $img) {
                     // irmtfan fix: double "/" removed
-                    $rpg_images[$img] = XOOPS_URL . $rpg_path . '/' . $img . '.gif';
+                    $rpg_images[$img] = XOOPS_URL.$rpg_path.'/'.$img.'.gif';
                 }
             }
             // irmtfan hardcore removed align="left"
@@ -195,13 +195,13 @@ 
                      . $rpg_images['img_right']
                      . "' alt='' /></td></tr></table>";
 
-            $info = _MD_NEWBB_LEVEL . ' ' . $level['level'] . '<br><span title="' . _MD_NEWBB_HP_DESC . '">' . _MD_NEWBB_HP . ' ' . $level['hp'] . ' / ' . $level['hp_max'] . '</span><br>' . sprintf($table, $rpg_images['orange'], $level['hp_width']);
-            $info .= '<span title="' . _MD_NEWBB_MP_DESC . '">' . _MD_NEWBB_MP . ' ' . $level['mp'] . ' / ' . $level['mp_max'] . '</span><br>' . sprintf($table, $rpg_images['green'], $level['mp_width']);
-            $info .= '<span title="' . _MD_NEWBB_EXP_DESC . '">' . _MD_NEWBB_EXP . ' ' . $level['exp'] . '</span><br>' . sprintf($table, $rpg_images['blue'], $level['exp_width']);
+            $info = _MD_NEWBB_LEVEL.' '.$level['level'].'<br><span title="'._MD_NEWBB_HP_DESC.'">'._MD_NEWBB_HP.' '.$level['hp'].' / '.$level['hp_max'].'</span><br>'.sprintf($table, $rpg_images['orange'], $level['hp_width']);
+            $info .= '<span title="'._MD_NEWBB_MP_DESC.'">'._MD_NEWBB_MP.' '.$level['mp'].' / '.$level['mp_max'].'</span><br>'.sprintf($table, $rpg_images['green'], $level['mp_width']);
+            $info .= '<span title="'._MD_NEWBB_EXP_DESC.'">'._MD_NEWBB_EXP.' '.$level['exp'].'</span><br>'.sprintf($table, $rpg_images['blue'], $level['exp_width']);
         } else {
-            $info = _MD_NEWBB_LEVEL . ' ' . $level['level'] . '; <span title="' . _MD_NEWBB_EXP_DESC . '">' . _MD_NEWBB_EXP . ' ' . $level['exp'] . '</span><br>';
-            $info .= '<span title="' . _MD_NEWBB_HP_DESC . '">' . _MD_NEWBB_HP . ' ' . $level['hp'] . ' / ' . $level['hp_max'] . '</span><br>';
-            $info .= '<span title="' . _MD_NEWBB_MP_DESC . '">' . _MD_NEWBB_MP . ' ' . $level['mp'] . ' / ' . $level['mp_max'] . '</span>';
+            $info = _MD_NEWBB_LEVEL.' '.$level['level'].'; <span title="'._MD_NEWBB_EXP_DESC.'">'._MD_NEWBB_EXP.' '.$level['exp'].'</span><br>';
+            $info .= '<span title="'._MD_NEWBB_HP_DESC.'">'._MD_NEWBB_HP.' '.$level['hp'].' / '.$level['hp_max'].'</span><br>';
+            $info .= '<span title="'._MD_NEWBB_MP_DESC.'">'._MD_NEWBB_MP.' '.$level['mp'].' / '.$level['mp_max'].'</span>';
         }
 
         return $info;
@@ -231,7 +231,7 @@ 
         $name             = empty($GLOBALS['xoopsModuleConfig']['show_realname']) ? $user->getVar('uname') : $user->getVar('name');
         $userinfo['name'] = $name ?: $user->getVar('uname');
 
-        $userinfo['link'] = '<a href=\'' . XOOPS_URL . '/userinfo.php?uid=' . $user->getVar('uid') . '\'>' . $userinfo['name'] . '</a>';
+        $userinfo['link'] = '<a href=\''.XOOPS_URL.'/userinfo.php?uid='.$user->getVar('uid').'\'>'.$userinfo['name'].'</a>';
 
         $userinfo['avatar'] = $user->getVar('user_avatar');
         // START hacked by irmtfan - easier rank getting - consistency with previous version back rank.title and rank.image
@@ -254,7 +254,7 @@ 
         // END hacked by irmtfan - easier groups getting - can we use $_SESSION['xoopsUserGroups']???
         $userinfo['from'] = $user->getVar('user_from');
 
-        require_once __DIR__ . '/../include/functions.time.php';
+        require_once __DIR__.'/../include/functions.time.php';
         $userinfo['regdate']    = newbbFormatTimestamp($user->getVar('user_regdate'), 'reg');
         $userinfo['last_login'] = newbbFormatTimestamp($user->getVar('last_login')); // irmtfan add last_login
 

class/Xmlrss.php

Spacing +2 added lines, -2 removed lines

@@ -85,7 +85,7 @@ 
     {
         if (count($this->items) < $this->max_items) {
             if (!empty($label)) {
-                $label = '[' . $this->cleanup($label) . ']';
+                $label = '['.$this->cleanup($label).']';
             }
             if (!empty($description)) {
                 $description = $this->cleanup($description, $this->max_item_description);
@@ -94,7 +94,7 @@ 
                 //$description = $label;
             }
 
-            $title         = $this->cleanup($title) . ' ' . $label;
+            $title         = $this->cleanup($title).' '.$label;
             $pubdate       = $this->cleanup($pubdate);
             $this->items[] = [
                 'title'       => $title,

class/Tree.php

Spacing +1 added lines, -1 removed lines

@@ -93,7 +93,7 @@
         }
 
         $newPostArray = [];
-        $prefix       .= $this->increment;
+        $prefix .= $this->increment;
         foreach ($this->postArray as $post) {
             if ($post->getVar('pid') == $pid) {
                 $postTree_array[] = [

class/ModerateHandler.php

Spacing +4 added lines, -4 removed lines

@@ -112,16 +112,16 @@ 
     {
         $ips = [];
         if ($isUid) {
-            $criteria = 'uid =' . (int)$item;
+            $criteria = 'uid ='.(int)$item;
         } else {
             $ip_segs = explode('.', $item);
             $segs    = min(count($ip_segs), 4);
             for ($i = 1; $i <= $segs; ++$i) {
                 $ips[] = $this->db->quoteString(implode('.', array_slice($ip_segs, 0, $i)));
             }
-            $criteria = 'ip IN(' . implode(',', $ips) . ')';
+            $criteria = 'ip IN('.implode(',', $ips).')';
         }
-        $sql = 'SELECT MAX(mod_end) AS expire FROM ' . $this->db->prefix('newbb_moderates') . ' WHERE ' . $criteria;
+        $sql = 'SELECT MAX(mod_end) AS expire FROM '.$this->db->prefix('newbb_moderates').' WHERE '.$criteria;
         if (!$result = $this->db->query($sql)) {
             return -1;
         }
@@ -140,7 +140,7 @@ 
      */
     public function cleanOrphan($table_link = '', $field_link = '', $field_object = '') //cleanOrphan()
     {
-        $sql = 'DELETE FROM ' . $this->table . ' WHERE (forum_id >0 AND forum_id NOT IN ( SELECT DISTINCT forum_id FROM ' . $this->db->prefix('newbb_forums') . ') )';
+        $sql = 'DELETE FROM '.$this->table.' WHERE (forum_id >0 AND forum_id NOT IN ( SELECT DISTINCT forum_id FROM '.$this->db->prefix('newbb_forums').') )';
         if (!$result = $this->db->queryF($sql)) {
             //xoops_error($this->db->error());
             return false;

class/TopicRenderer.php

Indentation +11 added lines, -11 removed lines

@@ -488,22 +488,22 @@ 
                 'sort'  => 't.topic_views'
             ],
             'lastpost'        => [ // irmtfan show topic_page_jump_icon smarty
-                                   'title' => _MD_NEWBB_LASTPOST,
-                                   /*irmtfan _MD_NEWBB_DATE to _MD_NEWBB_LASTPOSTTIME again change to _MD_LASTPOST*/
-                                   'sort'  => 't.topic_last_post_id'
+                                    'title' => _MD_NEWBB_LASTPOST,
+                                    /*irmtfan _MD_NEWBB_DATE to _MD_NEWBB_LASTPOSTTIME again change to _MD_LASTPOST*/
+                                    'sort'  => 't.topic_last_post_id'
             ],
             // START irmtfan add more sorts
             'lastposttime'    => [ // irmtfan same as lastpost
-                                   'title' => _MD_NEWBB_LASTPOSTTIME,
-                                   'sort'  => 't.topic_last_post_id'
+                                    'title' => _MD_NEWBB_LASTPOSTTIME,
+                                    'sort'  => 't.topic_last_post_id'
             ],
             'lastposter'      => [ // irmtfan
-                                   'title' => _MD_NEWBB_POSTER,
-                                   'sort'  => 'p.uid',// poster uid
+                                    'title' => _MD_NEWBB_POSTER,
+                                    'sort'  => 'p.uid',// poster uid
             ],
             'lastpostmsgicon' => [ // irmtfan
-                                   'title' => _MD_NEWBB_MESSAGEICON,
-                                   'sort'  => 'p.icon',// post message icon
+                                    'title' => _MD_NEWBB_MESSAGEICON,
+                                    'sort'  => 'p.icon',// post message icon
             ],
             'ratings'         => [
                 'title' => _MD_NEWBB_RATINGS,
@@ -855,7 +855,7 @@ 
         $wheres[] = '1 = 1';
 
         $sql = '    SELECT ' . implode(', ', $selects) . '     FROM ' . implode(', ', $froms) . '        ' . implode(' ', $joins) . (!empty($this->query['join']) ? '        ' . implode(' ', $this->query['join']) : '') . // irmtfan bug fix: Undefined index: join when post_excerpt = 0
-               '     WHERE ' . implode(' AND ', $wheres) . '        AND ' . @implode(' AND ', @$this->query['where']);
+                '     WHERE ' . implode(' AND ', $wheres) . '        AND ' . @implode(' AND ', @$this->query['where']);
 
         if (!$result = $this->handler->db->query($sql)) {
             return 0;
@@ -907,7 +907,7 @@ 
         //if (empty($this->query["sort"])) $this->query["sort"][] = 't.topic_last_post_id DESC'; // irmtfan commented no need
 
         $sql = '    SELECT ' . implode(', ', $selects) . '     FROM ' . implode(', ', $froms) . '        ' . implode(' ', $joins) . (!empty($this->query['join']) ? '        ' . implode(' ', $this->query['join']) : '') . // irmtfan bug fix: Undefined index join when post_excerpt = 0
-               '     WHERE ' . implode(' AND ', $wheres) . '        AND ' . @implode(' AND ', @$this->query['where']) . '     ORDER BY ' . implode(', ', $this->query['sort']);
+                '     WHERE ' . implode(' AND ', $wheres) . '        AND ' . @implode(' AND ', @$this->query['where']) . '     ORDER BY ' . implode(', ', $this->query['sort']);
 
         if (!$result = $this->handler->db->query($sql, $this->config['topics_per_page'], @$this->vars['start'])) {
             if (is_object($xoopsTpl)) {

Spacing +63 added lines, -63 removed lines

@@ -234,7 +234,7 @@ 
                     // START irmtfan use read_uid to find the unread posts when the user is logged in
                     $read_uid = is_object($GLOBALS['xoopsUser']) ? $GLOBALS['xoopsUser']->getVar('uid') : 0;
                     if (!empty($read_uid)) {
-                        $this->query['join'][]  = 'LEFT JOIN ' . $this->handler->db->prefix('newbb_reads_topic') . ' AS r ON r.read_item = t.topic_id AND r.uid = ' . $read_uid . ' ';
+                        $this->query['join'][]  = 'LEFT JOIN '.$this->handler->db->prefix('newbb_reads_topic').' AS r ON r.read_item = t.topic_id AND r.uid = '.$read_uid.' ';
                         $this->query['where'][] = 'r.post_id = t.topic_last_post_id';
                     } else {
                     }
@@ -246,7 +246,7 @@ 
                     if ($lastvisit = max($GLOBALS['last_visit'], $startdate)) {
                         $readmode1query = '';
                         if ($lastvisit > $startdate) {
-                            $readmode1query = 'p.post_time < ' . $lastvisit;
+                            $readmode1query = 'p.post_time < '.$lastvisit;
                         }
                         $topics         = [];
                         $topic_lastread = newbbGetCookie('LT', true);
@@ -258,9 +258,9 @@ 
                             }
                         }
                         if (count($topics) > 0) {
-                            $topicquery = ' t.topic_id IN (' . implode(',', $topics) . ')';
+                            $topicquery = ' t.topic_id IN ('.implode(',', $topics).')';
                             // because it should be OR
-                            $readmode1query = !empty($readmode1query) ? '(' . $readmode1query . ' OR ' . $topicquery . ')' : $topicquery;
+                            $readmode1query = !empty($readmode1query) ? '('.$readmode1query.' OR '.$topicquery.')' : $topicquery;
                         }
                         $this->query['where'][] = $readmode1query;
                     }
@@ -276,7 +276,7 @@ 
                     // START irmtfan use read_uid to find the unread posts when the user is logged in
                     $read_uid = is_object($GLOBALS['xoopsUser']) ? $GLOBALS['xoopsUser']->getVar('uid') : 0;
                     if (!empty($read_uid)) {
-                        $this->query['join'][]  = 'LEFT JOIN ' . $this->handler->db->prefix('newbb_reads_topic') . ' AS r ON r.read_item = t.topic_id AND r.uid = ' . $read_uid . ' ';
+                        $this->query['join'][]  = 'LEFT JOIN '.$this->handler->db->prefix('newbb_reads_topic').' AS r ON r.read_item = t.topic_id AND r.uid = '.$read_uid.' ';
                         $this->query['where'][] = '(r.read_id IS NULL OR r.post_id < t.topic_last_post_id)';
                     } else {
                     }
@@ -287,7 +287,7 @@ 
                     $startdate = !empty($this->vars['since']) ? (time() - newbbGetSinceTime($this->vars['since'])) : 0;
                     if ($lastvisit = max($GLOBALS['last_visit'], $startdate)) {
                         if ($lastvisit > $startdate) {
-                            $this->query['where'][] = 'p.post_time > ' . $lastvisit;
+                            $this->query['where'][] = 'p.post_time > '.$lastvisit;
                         }
                         $topics         = [];
                         $topic_lastread = newbbGetCookie('LT', true);
@@ -299,7 +299,7 @@ 
                             }
                         }
                         if (count($topics) > 0) {
-                            $this->query['where'][] = ' t.topic_id NOT IN (' . implode(',', $topics) . ')';
+                            $this->query['where'][] = ' t.topic_id NOT IN ('.implode(',', $topics).')';
                         }
                     }
                     // END irmtfan fix read_mode = 1 bugs - for all users (member and anon)
@@ -358,20 +358,20 @@ 
                     //} elseif (count($accessForums) === 1) {
                     //$this->query["where"][] = "t.forum_id = " . $accessForums[0];
                 } else {
-                    $this->query['where'][] = 't.forum_id IN ( ' . implode(', ', $accessForums) . ' )';
+                    $this->query['where'][] = 't.forum_id IN ( '.implode(', ', $accessForums).' )';
                 }
                 break;
 
             case 'uid': // irmtfan add multi topic poster
                 if (-1 !== $val) {
                     $val                    = implode(',', array_map('intval', explode(',', $val)));
-                    $this->query['where'][] = 't.topic_poster IN ( ' . $val . ' )';
+                    $this->query['where'][] = 't.topic_poster IN ( '.$val.' )';
                 }
                 break;
             case 'lastposter': // irmtfan add multi lastposter
                 if (-1 !== $val) {
                     $val                    = implode(',', array_map('intval', explode(',', $val)));
-                    $this->query['where'][] = 'p.uid IN ( ' . $val . ' )';
+                    $this->query['where'][] = 'p.uid IN ( '.$val.' )';
                 }
                 break;
 
@@ -385,17 +385,17 @@ 
                     }
                     // irmtfan digest_time | to accept multiple status
                     if (in_array('digest', explode(',', $this->vars['status'], true))) {
-                        $this->query['where'][] = 't.digest_time > ' . $startdate;
+                        $this->query['where'][] = 't.digest_time > '.$startdate;
                     }
                     // irmtfan - should be >= instead of =
-                    $this->query['where'][] = 'p.post_time >= ' . $startdate;
+                    $this->query['where'][] = 'p.post_time >= '.$startdate;
                     // END irmtfan if unread && read_mode = 1 and last_visit > startdate do not add where query
                 }
                 break;
 
             case 'type':
                 if (!empty($val)) {
-                    $this->query['where'][] = 't.type_id = ' . $val;
+                    $this->query['where'][] = 't.type_id = '.$val;
                 }
                 break;
 
@@ -414,9 +414,9 @@ 
 
             case 'sort':
                 if ($sort = $this->getSort($val, 'sort')) {
-                    $this->query['sort'][] = $sort . (empty($this->vars['order']) ? ' DESC' : ' ASC');
+                    $this->query['sort'][] = $sort.(empty($this->vars['order']) ? ' DESC' : ' ASC');
                 } else { // irmtfan if sort is not in the list
-                    $this->query['sort'][] = 't.topic_last_post_id' . (empty($this->vars['order']) ? ' DESC' : ' ASC');
+                    $this->query['sort'][] = 't.topic_last_post_id'.(empty($this->vars['order']) ? ' DESC' : ' ASC');
                 }
                 break;
 
@@ -487,23 +487,23 @@ 
                 'title' => _MD_NEWBB_VIEWS,
                 'sort'  => 't.topic_views'
             ],
-            'lastpost'        => [ // irmtfan show topic_page_jump_icon smarty
+            'lastpost'        => [// irmtfan show topic_page_jump_icon smarty
                                    'title' => _MD_NEWBB_LASTPOST,
                                    /*irmtfan _MD_NEWBB_DATE to _MD_NEWBB_LASTPOSTTIME again change to _MD_LASTPOST*/
                                    'sort'  => 't.topic_last_post_id'
             ],
             // START irmtfan add more sorts
-            'lastposttime'    => [ // irmtfan same as lastpost
+            'lastposttime'    => [// irmtfan same as lastpost
                                    'title' => _MD_NEWBB_LASTPOSTTIME,
                                    'sort'  => 't.topic_last_post_id'
             ],
-            'lastposter'      => [ // irmtfan
+            'lastposter'      => [// irmtfan
                                    'title' => _MD_NEWBB_POSTER,
-                                   'sort'  => 'p.uid',// poster uid
+                                   'sort'  => 'p.uid', // poster uid
             ],
-            'lastpostmsgicon' => [ // irmtfan
+            'lastpostmsgicon' => [// irmtfan
                                    'title' => _MD_NEWBB_MESSAGEICON,
-                                   'sort'  => 'p.icon',// post message icon
+                                   'sort'  => 'p.icon', // post message icon
             ],
             'ratings'         => [
                 'title' => _MD_NEWBB_RATINGS,
@@ -534,7 +534,7 @@ 
                 'sort'  => 't.poll_id'
             ]
         ];
-        $types   = $this->getTypes();
+        $types = $this->getTypes();
         if (!empty($types)) {
             $headers['type'] = [
                 'title' => _MD_NEWBB_TYPE,
@@ -577,7 +577,7 @@ 
         // additional headers - important: those cannot be in sort anyway
         $headers = array_merge($headersSort, [
             'attachment' => _MD_NEWBB_TOPICSHASATT, // show attachment smarty
-            'read'       => _MD_NEWBB_MARK_UNREAD . '|' . _MD_NEWBB_MARK_READ, // read/unread show topic_folder smarty
+            'read'       => _MD_NEWBB_MARK_UNREAD.'|'._MD_NEWBB_MARK_READ, // read/unread show topic_folder smarty
             'pagenav'    => _MD_NEWBB_PAGENAV_DISPLAY, // show topic_page_jump smarty - sort by topic_replies?
         ]);
 
@@ -593,7 +593,7 @@ 
      */
     public function getStatus($type = null, $status = null)
     {
-        $links       = [
+        $links = [
             //""            => "", /* irmtfan remove empty array */
             'all'       => _ALL,
             'digest'    => _MD_NEWBB_DIGEST,
@@ -621,7 +621,7 @@ 
 
         // all status, for admin
         if ($type > 1) {
-            $links = array_merge($links, $links_admin);// irmtfan to accept multiple status
+            $links = array_merge($links, $links_admin); // irmtfan to accept multiple status
         }
 
         return $this->getFromKeys($links, $status); // irmtfan to accept multiple status
@@ -635,10 +635,10 @@ 
     {
         $selection         = ['action' => $this->page];
         $selection['vars'] = $this->vars;
-        require_once __DIR__ . '/../include/functions.forum.php';
+        require_once __DIR__.'/../include/functions.forum.php';
         $forum_selected     = empty($this->vars['forum']) ? null : explode('|', @$this->vars['forum']);
         $selection['forum'] = '<select name="forum[]" multiple="multiple">';
-        $selection['forum'] .= '<option value="0">' . _MD_NEWBB_ALL . '</option>';
+        $selection['forum'] .= '<option value="0">'._MD_NEWBB_ALL.'</option>';
         $selection['forum'] .= newbbForumSelectBox($forum_selected);
         $selection['forum'] .= '</select>';
 
@@ -649,13 +649,13 @@ 
             throw new \RuntimeException('$sorts must be an array.');
         }
         foreach ($sorts as $sort => $title) {
-            $selection['sort'] .= "<option value='" . $sort . "' " . (($sort == $sort_selected) ? " selected='selected'" : '') . '>' . $title . '</option>';
+            $selection['sort'] .= "<option value='".$sort."' ".(($sort == $sort_selected) ? " selected='selected'" : '').'>'.$title.'</option>';
         }
         $selection['sort'] .= '</select>';
 
         $selection['order'] = "<select name='order'>";
-        $selection['order'] .= "<option value='0' " . (empty($this->vars['order']) ? " selected='selected'" : '') . '>' . _DESCENDING . '</option>';
-        $selection['order'] .= "<option value='1' " . (!empty($this->vars['order']) ? " selected='selected'" : '') . '>' . _ASCENDING . '</option>';
+        $selection['order'] .= "<option value='0' ".(empty($this->vars['order']) ? " selected='selected'" : '').'>'._DESCENDING.'</option>';
+        $selection['order'] .= "<option value='1' ".(!empty($this->vars['order']) ? " selected='selected'" : '').'>'._ASCENDING.'</option>';
         $selection['order'] .= '</select>';
 
         $since              = isset($this->vars['since']) ? $this->vars['since'] : $this->config['since_default'];
@@ -698,10 +698,10 @@ 
         foreach ($headers as $header => $title) {
             $_args = ["sort={$header}"];
             if (@$this->vars['sort'] == $header) {
-                $_args[] = 'order=' . ((@$this->vars['order'] + 1) % 2);
+                $_args[] = 'order='.((@$this->vars['order'] + 1) % 2);
             }
             $headers_data[$header]['title'] = $title;
-            $headers_data[$header]['link']  = $this->page . '?' . implode('&amp;', array_merge($args, $_args));
+            $headers_data[$header]['link']  = $this->page.'?'.implode('&amp;', array_merge($args, $_args));
         }
         $xoopsTpl->assign_by_ref('headers', $headers_data);
     }
@@ -725,7 +725,7 @@ 
         foreach ($links as $link => $title) {
             $_args                  = ["status={$link}"];
             $status[$link]['title'] = $title;
-            $status[$link]['link']  = $this->page . '?' . implode('&amp;', array_merge($args, $_args));
+            $status[$link]['link']  = $this->page.'?'.implode('&amp;', array_merge($args, $_args));
         }
         $xoopsTpl->assign_by_ref('filters', $status);
     }
@@ -773,7 +773,7 @@ 
         foreach ($types as $id => $type) {
             $_args                = ["type={$id}"];
             $status[$id]['title'] = $type['type_name'];
-            $status[$id]['link']  = $this->page . '?' . implode('&amp;', array_merge($args, $_args));
+            $status[$id]['link']  = $this->page.'?'.implode('&amp;', array_merge($args, $_args));
         }
         $xoopsTpl->assign_by_ref('types', $status);
     }
@@ -796,7 +796,7 @@ 
         $status          = [];
         $status['title'] = implode(',', $this->getStatus($this->userlevel, $this->vars['status'])); // irmtfan to accept multiple status
         //$status['link'] = $this->page.(empty($this->vars['status']) ? '' : '?status='.$this->vars['status']);
-        $status['link'] = $this->page . (empty($args) ? '' : '?' . implode('&amp;', $args));
+        $status['link'] = $this->page.(empty($args) ? '' : '?'.implode('&amp;', $args));
 
         $xoopsTpl->assign_by_ref('current', $status);
     }
@@ -818,7 +818,7 @@ 
             require_once $GLOBALS['xoops']->path('class/pagenav.php');
             $nav = new \XoopsPageNav($count_topic, $this->config['topics_per_page'], @$this->vars['start'], 'start', implode('&amp;', $args));
             if (isset($GLOBALS['xoopsModuleConfig']['do_rewrite'])) {
-                $nav->url = formatURL(Request::getString('SERVER_NAME', '', 'SERVER')) . ' /' . $nav->url;
+                $nav->url = formatURL(Request::getString('SERVER_NAME', '', 'SERVER')).' /'.$nav->url;
             }
             if ('select' === $this->config['pagenav_display']) {
                 $navi = $nav->renderSelect();
@@ -850,12 +850,12 @@ 
         // topic fields
         $selects[] = 'COUNT(*)';
 
-        $froms[]  = $this->handler->db->prefix('newbb_topics') . ' AS t ';
-        $joins[]  = 'LEFT JOIN ' . $this->handler->db->prefix('newbb_posts') . ' AS p ON p.post_id = t.topic_last_post_id';
+        $froms[]  = $this->handler->db->prefix('newbb_topics').' AS t ';
+        $joins[]  = 'LEFT JOIN '.$this->handler->db->prefix('newbb_posts').' AS p ON p.post_id = t.topic_last_post_id';
         $wheres[] = '1 = 1';
 
-        $sql = '    SELECT ' . implode(', ', $selects) . '     FROM ' . implode(', ', $froms) . '        ' . implode(' ', $joins) . (!empty($this->query['join']) ? '        ' . implode(' ', $this->query['join']) : '') . // irmtfan bug fix: Undefined index: join when post_excerpt = 0
-               '     WHERE ' . implode(' AND ', $wheres) . '        AND ' . @implode(' AND ', @$this->query['where']);
+        $sql = '    SELECT '.implode(', ', $selects).'     FROM '.implode(', ', $froms).'        '.implode(' ', $joins).(!empty($this->query['join']) ? '        '.implode(' ', $this->query['join']) : '').// irmtfan bug fix: Undefined index: join when post_excerpt = 0
+               '     WHERE '.implode(' AND ', $wheres).'        AND '.@implode(' AND ', @$this->query['where']);
 
         if (!$result = $this->handler->db->query($sql)) {
             return 0;
@@ -896,18 +896,18 @@ 
         // post fields
         $selects[] = 'p.post_time as last_post_time, p.poster_name as last_poster_name, p.icon, p.post_id, p.uid';
 
-        $froms[]  = $this->handler->db->prefix('newbb_topics') . ' AS t ';
-        $joins[]  = 'LEFT JOIN ' . $this->handler->db->prefix('newbb_posts') . ' AS p ON p.post_id = t.topic_last_post_id';
+        $froms[]  = $this->handler->db->prefix('newbb_topics').' AS t ';
+        $joins[]  = 'LEFT JOIN '.$this->handler->db->prefix('newbb_posts').' AS p ON p.post_id = t.topic_last_post_id';
         $wheres[] = '1 = 1';
 
         if (!empty($this->config['post_excerpt'])) {
             $selects[]             = 'p.post_karma, p.require_reply, pt.post_text';
-            $this->query['join'][] = 'LEFT JOIN ' . $this->handler->db->prefix('newbb_posts_text') . ' AS pt ON pt.post_id = t.topic_last_post_id';
+            $this->query['join'][] = 'LEFT JOIN '.$this->handler->db->prefix('newbb_posts_text').' AS pt ON pt.post_id = t.topic_last_post_id';
         }
         //if (empty($this->query["sort"])) $this->query["sort"][] = 't.topic_last_post_id DESC'; // irmtfan commented no need
 
-        $sql = '    SELECT ' . implode(', ', $selects) . '     FROM ' . implode(', ', $froms) . '        ' . implode(' ', $joins) . (!empty($this->query['join']) ? '        ' . implode(' ', $this->query['join']) : '') . // irmtfan bug fix: Undefined index join when post_excerpt = 0
-               '     WHERE ' . implode(' AND ', $wheres) . '        AND ' . @implode(' AND ', @$this->query['where']) . '     ORDER BY ' . implode(', ', $this->query['sort']);
+        $sql = '    SELECT '.implode(', ', $selects).'     FROM '.implode(', ', $froms).'        '.implode(' ', $joins).(!empty($this->query['join']) ? '        '.implode(' ', $this->query['join']) : '').// irmtfan bug fix: Undefined index join when post_excerpt = 0
+               '     WHERE '.implode(' AND ', $wheres).'        AND '.@implode(' AND ', @$this->query['where']).'     ORDER BY '.implode(', ', $this->query['sort']);
 
         if (!$result = $this->handler->db->query($sql, $this->config['topics_per_page'], @$this->vars['start'])) {
             if (is_object($xoopsTpl)) {
@@ -919,11 +919,11 @@ 
             return $ret;
         }
 
-        require_once __DIR__ . '/../include/functions.render.php';
-        require_once __DIR__ . '/../include/functions.session.php';
-        require_once __DIR__ . '/../include/functions.time.php';
-        require_once __DIR__ . '/../include/functions.read.php';
-        require_once __DIR__ . '/../include/functions.topic.php';
+        require_once __DIR__.'/../include/functions.render.php';
+        require_once __DIR__.'/../include/functions.session.php';
+        require_once __DIR__.'/../include/functions.time.php';
+        require_once __DIR__.'/../include/functions.read.php';
+        require_once __DIR__.'/../include/functions.topic.php';
 
         $sticky    = 0;
         $topics    = [];
@@ -942,9 +942,9 @@ 
             // START irmtfan remove topic_icon hardcode smarty
             // topic_icon: just regular topic_icon
             if (!empty($myrow['icon'])) {
-                $topic_icon = '<img align="middle" src="' . XOOPS_URL . '/images/subject/' . htmlspecialchars($myrow['icon'], ENT_QUOTES | ENT_HTML5) . '" alt="" />';
+                $topic_icon = '<img align="middle" src="'.XOOPS_URL.'/images/subject/'.htmlspecialchars($myrow['icon'], ENT_QUOTES | ENT_HTML5).'" alt="" />';
             } else {
-                $topic_icon = '<img align="middle" src="' . XOOPS_URL . '/images/icons/no_posticon.gif" alt="" />';
+                $topic_icon = '<img align="middle" src="'.XOOPS_URL.'/images/icons/no_posticon.gif" alt="" />';
             }
             // END irmtfan remove topic_icon hardcode smarty
 
@@ -955,7 +955,7 @@ 
             if ($rating < 1) {
                 $rating_img = newbbDisplayImage('blank');
             } else {
-                $rating_img = newbbDisplayImage('rate' . $rating, constant('_MD_NEWBB_RATE' . $rating));
+                $rating_img = newbbDisplayImage('rate'.$rating, constant('_MD_NEWBB_RATE'.$rating));
             }
 
             // ------------------------------------------------------
@@ -965,22 +965,22 @@ 
             $totalpages           = ceil(($myrow['topic_replies'] + 1) / $this->config['posts_per_page']);
             if ($totalpages > 1) {
                 $topic_page_jump .= '&nbsp;&nbsp;';
-                $append          = false;
+                $append = false;
                 for ($i = 1; $i <= $totalpages; ++$i) {
                     if ($i > 3 && $i < $totalpages) {
                         if (!$append) {
                             $topic_page_jump .= '...';
-                            $append          = true;
+                            $append = true;
                         }
                     } else {
-                        $topic_page_jump .= '[<a href="' . XOOPS_URL . '/modules/newbb/viewtopic.php?topic_id=' . $myrow['topic_id'] . '&amp;start=' . (($i - 1) * $this->config['posts_per_page']) . '">' . $i . '</a>]';
+                        $topic_page_jump .= '[<a href="'.XOOPS_URL.'/modules/newbb/viewtopic.php?topic_id='.$myrow['topic_id'].'&amp;start='.(($i - 1) * $this->config['posts_per_page']).'">'.$i.'</a>]';
                         // irmtfan remove here and move
                         //$topic_page_jump_icon = "<a href='" . XOOPS_URL . "/modules/newbb/viewtopic.php?topic_id=" . $myrow['topic_id'] . "&amp;start=" . (($i - 1) * $this->config['posts_per_page']) . "" . "'>" . newbbDisplayImage('document',_MD_NEWBB_GOTOLASTPOST) . '</a>';
                     }
                 }
             }
             // irmtfan - move here for both topics with and without pages - change topic_id to post_id
-            $topic_page_jump_icon = "<a href='" . XOOPS_URL . '/modules/newbb/viewtopic.php?post_id=' . $myrow['topic_last_post_id'] . '' . "'>" . newbbDisplayImage('lastposticon', _MD_NEWBB_GOTOLASTPOST) . '</a>';
+            $topic_page_jump_icon = "<a href='".XOOPS_URL.'/modules/newbb/viewtopic.php?post_id='.$myrow['topic_last_post_id'].''."'>".newbbDisplayImage('lastposticon', _MD_NEWBB_GOTOLASTPOST).'</a>';
 
             // ------------------------------------------------------
             // => topic array
@@ -1012,7 +1012,7 @@ 
                 'topic_title_excerpt'    => $topic_title_excerpt,
                 //irmtfan use topic_title_excerpt
                 //'topic_link'    => XOOPS_URL . '/modules/newbb/viewtopic.php?topic_id=' . $myrow['topic_id'], // . '&amp;forum=' . $myrow['forum_id'], // irmtfan comment
-                'topic_link'             => 'viewtopic.php?topic_id=' . $myrow['topic_id'],
+                'topic_link'             => 'viewtopic.php?topic_id='.$myrow['topic_id'],
                 // irmtfan remove hardcode link
                 'rating_img'             => $rating_img,
                 'votes'                  => $myrow['votes'],
@@ -1071,14 +1071,14 @@ 
         $forumHandler = Newbb\Helper::getInstance()->getHandler('Forum');
 
         if (count($forums) > 0) {
-            $forum_list = $forumHandler->getAll(new \Criteria('forum_id', '(' . implode(', ', array_keys($forums)) . ')', 'IN'), ['forum_name', 'hot_threshold'], false);
+            $forum_list = $forumHandler->getAll(new \Criteria('forum_id', '('.implode(', ', array_keys($forums)).')', 'IN'), ['forum_name', 'hot_threshold'], false);
         } else {
             $forum_list = $forumHandler->getAll();
         }
 
         foreach (array_keys($topics) as $id) {
             $topics[$id]['topic_read']       = empty($topic_isRead[$id]) ? 0 : 1; // add topic-read/topic-new smarty variable
-            $topics[$id]['topic_forum_link'] = '<a href="' . XOOPS_URL . '/modules/newbb/viewforum.php?forum=' . $topics[$id]['topic_forum'] . '">' . $forum_list[$topics[$id]['topic_forum']]['forum_name'] . '</a>';
+            $topics[$id]['topic_forum_link'] = '<a href="'.XOOPS_URL.'/modules/newbb/viewforum.php?forum='.$topics[$id]['topic_forum'].'">'.$forum_list[$topics[$id]['topic_forum']]['forum_name'].'</a>';
 
             //irmtfan use topic_title_excerpt -- add else
             if (!empty($topics[$id]['type_id']) && isset($type_list[$topics[$id]['type_id']])) {
@@ -1112,14 +1112,14 @@ 
             $topics[$id]['topic_folder'] = newbbDisplayImage($topic_folder, $topic_folder_text);
             // END irmtfan - add topic_folder_text for alt
 
-            unset($topics[$id]['topic_poster_name'], $topics[$id]['topic_last_poster_name']);// irmtfan remove $topics[$id]["stats"] because it is not exist now
+            unset($topics[$id]['topic_poster_name'], $topics[$id]['topic_last_poster_name']); // irmtfan remove $topics[$id]["stats"] because it is not exist now
         }
 
         if (count($topics) > 0) {
-            $sql = ' SELECT DISTINCT topic_id FROM ' . $this->handler->db->prefix('newbb_posts') . " WHERE attachment != ''" . ' AND topic_id IN (' . implode(',', array_keys($topics)) . ')';
+            $sql = ' SELECT DISTINCT topic_id FROM '.$this->handler->db->prefix('newbb_posts')." WHERE attachment != ''".' AND topic_id IN ('.implode(',', array_keys($topics)).')';
             if ($result = $this->handler->db->query($sql)) {
                 while (false !== (list($topic_id) = $this->handler->db->fetchRow($result))) {
-                    $topics[$topic_id]['attachment'] = '&nbsp;' . newbbDisplayImage('attachment', _MD_NEWBB_TOPICSHASATT);
+                    $topics[$topic_id]['attachment'] = '&nbsp;'.newbbDisplayImage('attachment', _MD_NEWBB_TOPICSHASATT);
                 }
             }
         }