Passed
Push — master ( 829601...ed204a )
by Michael
02:18
created
include/common.php 1 patch
Spacing   +27 added lines, -27 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@  discard block
 block discarded – undo
23 23
 use Xmf\Module\Admin;
24 24
 use XoopsModules\Contact;
25 25
 
26
-require_once dirname(__DIR__) . '/preloads/autoloader.php';
26
+require_once dirname(__DIR__).'/preloads/autoloader.php';
27 27
 
28 28
 $moduleDirName      = \basename(\dirname(__DIR__));
29 29
 $moduleDirNameUpper = mb_strtoupper($moduleDirName); //$capsDirName
@@ -42,20 +42,20 @@  discard block
 block discarded – undo
42 42
 //$categoryHandler     = new Contact\CategoryHandler($db);
43 43
 //$downloadHandler     = new Contact\DownloadHandler($db);
44 44
 
45
-if (!defined($moduleDirNameUpper . '_CONSTANTS_DEFINED')) {
46
-    define($moduleDirNameUpper . '_DIRNAME', basename(dirname(__DIR__)));
47
-    define($moduleDirNameUpper . '_ROOT_PATH', XOOPS_ROOT_PATH . '/modules/' . $moduleDirName . '/');
48
-    define($moduleDirNameUpper . '_PATH', XOOPS_ROOT_PATH . '/modules/' . $moduleDirName . '/');
49
-    define($moduleDirNameUpper . '_URL', XOOPS_URL . '/modules/' . $moduleDirName . '/');
50
-    define($moduleDirNameUpper . '_IMAGE_URL', constant($moduleDirNameUpper . '_URL') . '/assets/images/');
51
-    define($moduleDirNameUpper . '_IMAGE_PATH', constant($moduleDirNameUpper . '_ROOT_PATH') . '/assets/images');
52
-    define($moduleDirNameUpper . '_ADMIN_URL', constant($moduleDirNameUpper . '_URL') . '/admin/');
53
-    define($moduleDirNameUpper . '_ADMIN_PATH', constant($moduleDirNameUpper . '_ROOT_PATH') . '/admin/');
54
-    define($moduleDirNameUpper . '_ADMIN', constant($moduleDirNameUpper . '_URL') . '/admin/index.php');
55
-    define($moduleDirNameUpper . '_AUTHOR_LOGOIMG', constant($moduleDirNameUpper . '_URL') . '/assets/images/logoModule.png');
56
-    define($moduleDirNameUpper . '_UPLOAD_URL', XOOPS_UPLOAD_URL . '/' . $moduleDirName); // WITHOUT Trailing slash
57
-    define($moduleDirNameUpper . '_UPLOAD_PATH', XOOPS_UPLOAD_PATH . '/' . $moduleDirName); // WITHOUT Trailing slash
58
-    define($moduleDirNameUpper . '_CONSTANTS_DEFINED', 1);
45
+if (!defined($moduleDirNameUpper.'_CONSTANTS_DEFINED')) {
46
+    define($moduleDirNameUpper.'_DIRNAME', basename(dirname(__DIR__)));
47
+    define($moduleDirNameUpper.'_ROOT_PATH', XOOPS_ROOT_PATH.'/modules/'.$moduleDirName.'/');
48
+    define($moduleDirNameUpper.'_PATH', XOOPS_ROOT_PATH.'/modules/'.$moduleDirName.'/');
49
+    define($moduleDirNameUpper.'_URL', XOOPS_URL.'/modules/'.$moduleDirName.'/');
50
+    define($moduleDirNameUpper.'_IMAGE_URL', constant($moduleDirNameUpper.'_URL').'/assets/images/');
51
+    define($moduleDirNameUpper.'_IMAGE_PATH', constant($moduleDirNameUpper.'_ROOT_PATH').'/assets/images');
52
+    define($moduleDirNameUpper.'_ADMIN_URL', constant($moduleDirNameUpper.'_URL').'/admin/');
53
+    define($moduleDirNameUpper.'_ADMIN_PATH', constant($moduleDirNameUpper.'_ROOT_PATH').'/admin/');
54
+    define($moduleDirNameUpper.'_ADMIN', constant($moduleDirNameUpper.'_URL').'/admin/index.php');
55
+    define($moduleDirNameUpper.'_AUTHOR_LOGOIMG', constant($moduleDirNameUpper.'_URL').'/assets/images/logoModule.png');
56
+    define($moduleDirNameUpper.'_UPLOAD_URL', XOOPS_UPLOAD_URL.'/'.$moduleDirName); // WITHOUT Trailing slash
57
+    define($moduleDirNameUpper.'_UPLOAD_PATH', XOOPS_UPLOAD_PATH.'/'.$moduleDirName); // WITHOUT Trailing slash
58
+    define($moduleDirNameUpper.'_CONSTANTS_DEFINED', 1);
59 59
 }
60 60
 
61 61
 $pathIcon16 = Admin::iconUrl('', 16);
@@ -64,15 +64,15 @@  discard block
 block discarded – undo
64 64
 //$pathModIcon32 = $helper->getModule()->getInfo('modicons32');
65 65
 
66 66
 $icons = [
67
-    'edit'    => "<img src='" . $pathIcon16 . "/edit.png'  alt=" . _EDIT . "' align='middle'>",
68
-    'delete'  => "<img src='" . $pathIcon16 . "/delete.png' alt='" . _DELETE . "' align='middle'>",
69
-    'clone'   => "<img src='" . $pathIcon16 . "/editcopy.png' alt='" . _CLONE . "' align='middle'>",
70
-    'preview' => "<img src='" . $pathIcon16 . "/view.png' alt='" . _PREVIEW . "' align='middle'>",
71
-    'print'   => "<img src='" . $pathIcon16 . "/printer.png' alt='" . _CLONE . "' align='middle'>",
72
-    'pdf'     => "<img src='" . $pathIcon16 . "/pdf.png' alt='" . _CLONE . "' align='middle'>",
73
-    'add'     => "<img src='" . $pathIcon16 . "/add.png' alt='" . _ADD . "' align='middle'>",
74
-    '0'       => "<img src='" . $pathIcon16 . "/0.png' alt='" . 0 . "' align='middle'>",
75
-    '1'       => "<img src='" . $pathIcon16 . "/1.png' alt='" . 1 . "' align='middle'>",
67
+    'edit'    => "<img src='".$pathIcon16."/edit.png'  alt="._EDIT."' align='middle'>",
68
+    'delete'  => "<img src='".$pathIcon16."/delete.png' alt='"._DELETE."' align='middle'>",
69
+    'clone'   => "<img src='".$pathIcon16."/editcopy.png' alt='"._CLONE."' align='middle'>",
70
+    'preview' => "<img src='".$pathIcon16."/view.png' alt='"._PREVIEW."' align='middle'>",
71
+    'print'   => "<img src='".$pathIcon16."/printer.png' alt='"._CLONE."' align='middle'>",
72
+    'pdf'     => "<img src='".$pathIcon16."/pdf.png' alt='"._CLONE."' align='middle'>",
73
+    'add'     => "<img src='".$pathIcon16."/add.png' alt='"._ADD."' align='middle'>",
74
+    '0'       => "<img src='".$pathIcon16."/0.png' alt='".0."' align='middle'>",
75
+    '1'       => "<img src='".$pathIcon16."/1.png' alt='".1."' align='middle'>",
76 76
 ];
77 77
 
78 78
 $debug = false;
@@ -85,15 +85,15 @@  discard block
 block discarded – undo
85 85
     $GLOBALS['xoopsTpl'] = new \XoopsTpl();
86 86
 }
87 87
 
88
-$GLOBALS['xoopsTpl']->assign('mod_url', XOOPS_URL . '/modules/' . $moduleDirName);
88
+$GLOBALS['xoopsTpl']->assign('mod_url', XOOPS_URL.'/modules/'.$moduleDirName);
89 89
 // Local icons path
90 90
 if (is_object($helper->getModule())) {
91 91
     $pathModIcon16 = $helper->getModule()->getInfo('modicons16');
92 92
     $pathModIcon32 = $helper->getModule()->getInfo('modicons32');
93 93
 
94
-    $GLOBALS['xoopsTpl']->assign('pathModIcon16', XOOPS_URL . '/modules/' . $moduleDirName . '/' . $pathModIcon16);
94
+    $GLOBALS['xoopsTpl']->assign('pathModIcon16', XOOPS_URL.'/modules/'.$moduleDirName.'/'.$pathModIcon16);
95 95
     $GLOBALS['xoopsTpl']->assign('pathModIcon32', $pathModIcon32);
96 96
 }
97 97
 
98 98
 //require_once CONTACT_PATH.'/class/helper.php';
99
-require_once __DIR__ . '/include/functions.php';
99
+require_once __DIR__.'/include/functions.php';
Please login to merge, or discard this patch.
admin/admin_header.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -27,11 +27,11 @@
 block discarded – undo
27 27
 /** @var Admin $adminObject */
28 28
 /** @var ContactHandler $contactHandler */
29 29
 
30
-require dirname(__DIR__, 3) . '/include/cp_header.php';
31
-require dirname(__DIR__) . '/preloads/autoloader.php';
30
+require dirname(__DIR__, 3).'/include/cp_header.php';
31
+require dirname(__DIR__).'/preloads/autoloader.php';
32 32
 
33
-require_once XOOPS_ROOT_PATH . '/class/pagenav.php';
34
-require_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
33
+require_once XOOPS_ROOT_PATH.'/class/pagenav.php';
34
+require_once XOOPS_ROOT_PATH.'/class/xoopsformloader.php';
35 35
 global $xoopsModule;
36 36
 
37 37
 $moduleDirName = $GLOBALS['xoopsModule']->getVar('dirname');
Please login to merge, or discard this patch.
admin/main.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
 /** @var Admin $adminObject */
30 30
 
31 31
 // Call header
32
-require_once __DIR__ . '/admin_header.php';
32
+require_once __DIR__.'/admin_header.php';
33 33
 
34 34
 // Display Admin header
35 35
 xoops_cp_header();
@@ -48,11 +48,11 @@  discard block
 block discarded – undo
48 48
 // Define scripts
49 49
 $GLOBALS['xoTheme']->addScript('browse.php?Frameworks/jquery/jquery.js');
50 50
 $GLOBALS['xoTheme']->addScript('browse.php?Frameworks/jquery/plugins/jquery.ui.js');
51
-$GLOBALS['xoTheme']->addScript(XOOPS_URL . '/modules/contact/assets/js/admin.js');
51
+$GLOBALS['xoTheme']->addScript(XOOPS_URL.'/modules/contact/assets/js/admin.js');
52 52
 // Add module stylesheet
53
-$GLOBALS['xoTheme']->addStylesheet(XOOPS_URL . '/modules/contact/assets/css/admin.css');
54
-$GLOBALS['xoTheme']->addStylesheet(XOOPS_URL . '/modules/system/css/ui/' . xoops_getModuleOption('jquery_theme', 'system') . '/ui.all.css');
55
-$GLOBALS['xoTheme']->addStylesheet(XOOPS_URL . '/modules/system/css/admin.css');
53
+$GLOBALS['xoTheme']->addStylesheet(XOOPS_URL.'/modules/contact/assets/css/admin.css');
54
+$GLOBALS['xoTheme']->addStylesheet(XOOPS_URL.'/modules/system/css/ui/'.xoops_getModuleOption('jquery_theme', 'system').'/ui.all.css');
55
+$GLOBALS['xoTheme']->addStylesheet(XOOPS_URL.'/modules/system/css/admin.css');
56 56
 
57 57
 switch ($op) {
58 58
     case 'list':
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
         $contacts        = $contactHandler->contactGetAdminList($contact, 'contact_cid');
72 72
 
73 73
         if ($contact_numrows > $contact['limit']) {
74
-            $contact_pagenav = new \XoopsPageNav($contact_numrows, $contact['limit'], $contact['start'], 'start', 'limit=' . $contact['limit']);
74
+            $contact_pagenav = new \XoopsPageNav($contact_numrows, $contact['limit'], $contact['start'], 'start', 'limit='.$contact['limit']);
75 75
             $contact_pagenav = $contact_pagenav->renderNav(4);
76 76
         } else {
77 77
             $contact_pagenav = '';
@@ -198,6 +198,6 @@  discard block
 block discarded – undo
198 198
 $GLOBALS['xoopsTpl']->assign('level', $level);
199 199
 
200 200
 // Call template file
201
-$GLOBALS['xoopsTpl']->display(XOOPS_ROOT_PATH . '/modules/contact/templates/admin/contact_main.tpl');
201
+$GLOBALS['xoopsTpl']->display(XOOPS_ROOT_PATH.'/modules/contact/templates/admin/contact_main.tpl');
202 202
 // Call footer
203
-require_once __DIR__ . '/admin_footer.php';
203
+require_once __DIR__.'/admin_footer.php';
Please login to merge, or discard this patch.
admin/index.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
 
22 22
 /** @var ContactHandler $contactHandler */
23 23
 // Call header
24
-require_once __DIR__ . '/admin_header.php';
24
+require_once __DIR__.'/admin_header.php';
25 25
 // Display Admin header
26 26
 xoops_cp_header();
27 27
 
@@ -33,6 +33,6 @@  discard block
 block discarded – undo
33 33
 $adminObject->displayIndex();
34 34
 
35 35
 // Call template file
36
-$GLOBALS['xoopsTpl']->display(XOOPS_ROOT_PATH . '/modules/contact/templates/admin/contact_index.tpl');
36
+$GLOBALS['xoopsTpl']->display(XOOPS_ROOT_PATH.'/modules/contact/templates/admin/contact_index.tpl');
37 37
 // Call footer
38
-require_once __DIR__ . '/admin_footer.php';
38
+require_once __DIR__.'/admin_footer.php';
Please login to merge, or discard this patch.
admin/log.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@  discard block
 block discarded – undo
24 24
 /** @var Admin $adminObject */
25 25
 
26 26
 // Call header
27
-require_once __DIR__ . '/admin_header.php';
27
+require_once __DIR__.'/admin_header.php';
28 28
 // Display Admin header
29 29
 xoops_cp_header();
30 30
 // Define default value
@@ -52,6 +52,6 @@  discard block
 block discarded – undo
52 52
 
53 53
 $GLOBALS['xoopsTpl']->assign('navigation', $adminObject->displayNavigation(basename(__FILE__)));
54 54
 // Call template file
55
-$GLOBALS['xoopsTpl']->display(XOOPS_ROOT_PATH . '/modules/contact/templates/admin/contact_logs.tpl');
55
+$GLOBALS['xoopsTpl']->display(XOOPS_ROOT_PATH.'/modules/contact/templates/admin/contact_logs.tpl');
56 56
 // Call footer
57
-require_once __DIR__ . '/admin_footer.php';
57
+require_once __DIR__.'/admin_footer.php';
Please login to merge, or discard this patch.
admin/tools.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@  discard block
 block discarded – undo
24 24
 /** @var Admin $adminObject */
25 25
 
26 26
 // Call header
27
-require_once __DIR__ . '/admin_header.php';
27
+require_once __DIR__.'/admin_header.php';
28 28
 // Display Admin header
29 29
 xoops_cp_header();
30 30
 // Define default value
@@ -56,6 +56,6 @@  discard block
 block discarded – undo
56 56
 
57 57
 $GLOBALS['xoopsTpl']->assign('navigation', $adminObject->displayNavigation(basename(__FILE__)));
58 58
 // Call template file
59
-$GLOBALS['xoopsTpl']->display(XOOPS_ROOT_PATH . '/modules/contact/templates/admin/contact_tools.tpl');
59
+$GLOBALS['xoopsTpl']->display(XOOPS_ROOT_PATH.'/modules/contact/templates/admin/contact_tools.tpl');
60 60
 // Call footer
61
-require_once __DIR__ . '/admin_footer.php';
61
+require_once __DIR__.'/admin_footer.php';
Please login to merge, or discard this patch.
send.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -26,10 +26,10 @@  discard block
 block discarded – undo
26 26
 };
27 27
 /** @var ContactHandler $contactHandler */
28 28
 
29
-require_once __DIR__ . '/header.php';
29
+require_once __DIR__.'/header.php';
30 30
 $GLOBALS['xoopsOption']['template_main'] = 'contact_index.tpl';
31 31
 //unset($_SESSION);
32
-require_once XOOPS_ROOT_PATH . '/header.php';
32
+require_once XOOPS_ROOT_PATH.'/header.php';
33 33
 
34 34
 /** @var Helper $helper */
35 35
 $helper = Helper::getInstance();
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
 if (!$captcha && $helper->getConfig('recaptchause')) {
48 48
     redirect_header('index.php', 2, _MD_CONTACT_MES_NOCAPTCHA);
49 49
 } else {
50
-    $response = file_get_contents('https://www.google.com/recaptcha/api/siteverify?secret=' . $helper->getConfig('recaptchakey') . '&response=' . $captcha . '&remoteip=' . $_SERVER['REMOTE_ADDR']);
50
+    $response = file_get_contents('https://www.google.com/recaptcha/api/siteverify?secret='.$helper->getConfig('recaptchakey').'&response='.$captcha.'&remoteip='.$_SERVER['REMOTE_ADDR']);
51 51
     if (false === $response && $helper->getConfig('recaptchause')) {
52 52
         redirect_header('index.php', 2, _MD_CONTACT_MES_CAPTCHAINCORRECT);
53 53
     } else {
@@ -93,4 +93,4 @@  discard block
 block discarded – undo
93 93
     }
94 94
 }
95 95
 
96
-require_once XOOPS_ROOT_PATH . '/footer.php';
96
+require_once XOOPS_ROOT_PATH.'/footer.php';
Please login to merge, or discard this patch.
class/Common/VersionChecks.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -40,13 +40,13 @@  discard block
 block discarded – undo
40 40
         //check for minimum XOOPS version
41 41
         $currentVer = mb_substr(\XOOPS_VERSION, 6); // get the numeric part of string
42 42
         if (null === $requiredVer) {
43
-            $requiredVer = '' . $module->getInfo('min_xoops'); //making sure it's a string
43
+            $requiredVer = ''.$module->getInfo('min_xoops'); //making sure it's a string
44 44
         }
45 45
         $success = true;
46 46
 
47 47
         if (\version_compare($currentVer, $requiredVer, '<')) {
48 48
             $success = false;
49
-            $module->setErrors(\sprintf(\constant('CO_' . $moduleDirNameUpper . '_ERROR_BAD_XOOPS'), $requiredVer, $currentVer));
49
+            $module->setErrors(\sprintf(\constant('CO_'.$moduleDirNameUpper.'_ERROR_BAD_XOOPS'), $requiredVer, $currentVer));
50 50
         }
51 51
 
52 52
         return $success;
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
 
78 78
         if (false !== $reqVer && '' !== $reqVer) {
79 79
             if (\version_compare($verNum, $reqVer, '<')) {
80
-                $module->setErrors(\sprintf(\constant('CO_' . $moduleDirNameUpper . '_ERROR_BAD_PHP'), $reqVer, $verNum));
80
+                $module->setErrors(\sprintf(\constant('CO_'.$moduleDirNameUpper.'_ERROR_BAD_PHP'), $reqVer, $verNum));
81 81
                 $success = false;
82 82
             }
83 83
         }
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
         $moduleDirName      = \basename(\dirname(__DIR__, 2));
102 102
         $moduleDirNameUpper = \mb_strtoupper($moduleDirName);
103 103
         $update             = '';
104
-        $repository         = 'XoopsModules25x/' . $moduleDirName;
104
+        $repository         = 'XoopsModules25x/'.$moduleDirName;
105 105
         //        $repository         = 'XoopsModules25x/publisher'; //for testing only
106 106
         $ret             = '';
107 107
         $infoReleasesUrl = "https://api.github.com/repos/$repository/releases";
@@ -115,14 +115,14 @@  discard block
 block discarded – undo
115 115
                 if (false === $curlReturn) {
116 116
                     \trigger_error(\curl_error($curlHandle));
117 117
                 } elseif (false !== \mb_strpos($curlReturn, 'Not Found')) {
118
-                    \trigger_error('Repository Not Found: ' . $infoReleasesUrl);
118
+                    \trigger_error('Repository Not Found: '.$infoReleasesUrl);
119 119
                 } else {
120 120
                     $file              = json_decode($curlReturn, false);
121 121
                     $latestVersionLink = \sprintf("https://github.com/$repository/archive/%s.zip", $file ? \reset($file)->tag_name : $default);
122 122
                     $latestVersion     = $file[0]->tag_name;
123 123
                     $prerelease        = $file[0]->prerelease;
124 124
                     if ('master' !== $latestVersionLink) {
125
-                        $update = \constant('CO_' . $moduleDirNameUpper . '_' . 'NEW_VERSION') . $latestVersion;
125
+                        $update = \constant('CO_'.$moduleDirNameUpper.'_'.'NEW_VERSION').$latestVersion;
126 126
                     }
127 127
                     //"PHP-standardized" version
128 128
                     $latestVersion = mb_strtolower($latestVersion);
@@ -130,7 +130,7 @@  discard block
 block discarded – undo
130 130
                         $latestVersion = \str_replace('_', '', mb_strtolower($latestVersion));
131 131
                         $latestVersion = \str_replace('final', '', mb_strtolower($latestVersion));
132 132
                     }
133
-                    $moduleVersion = ($helper->getModule()->getInfo('version') . '_' . $helper->getModule()->getInfo('module_status'));
133
+                    $moduleVersion = ($helper->getModule()->getInfo('version').'_'.$helper->getModule()->getInfo('module_status'));
134 134
                     //"PHP-standardized" version
135 135
                     $moduleVersion = \str_replace(' ', '', mb_strtolower($moduleVersion));
136 136
                     //                    $moduleVersion = '1.0'; //for testing only
Please login to merge, or discard this patch.
ajax.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@
 block discarded – undo
18 18
  * @author      Trabis <[email protected]>
19 19
  * @author      Hossein Azizabadi (AKA Voltan)
20 20
  */
21
-require_once __DIR__ . '/header.php';
21
+require_once __DIR__.'/header.php';
22 22
 /** @var ContactHandler $contactHandler */
23 23
 
24 24
 if (!empty($_POST)) {
Please login to merge, or discard this patch.